[Freeciv-Dev] [bug #21949] Server crash when ruleset has no pollution extra for some terrain

2014-04-25 Thread Marko Lindqvist 
Update of bug #21949 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21949] Server crash when ruleset has no pollution extra for some terrain

2014-04-25 Thread Marko Lindqvist 
Follow-up Comment #4, bug #21949 (project freeciv):

Obsoleting "No_Pollution" now in patch #4667

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21949] Server crash when ruleset has no pollution extra for some terrain

2014-04-21 Thread Emmet Hikory 
Follow-up Comment #3, bug #21949 (project freeciv):

My preference would be to drop engine support for TER_NO_POLLUTION: for sake
of clarity in reading rulesets, I believe it better as a userflag if used for
the described shorthand behaviour.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21949] Server crash when ruleset has no pollution extra for some terrain

2014-04-21 Thread Marko Lindqvist 
Follow-up Comment #2, bug #21949 (project freeciv):

> With this fix, is there still value to the No_Pollution flag,
> or can it be entirely migrated to the reqs vector for the
> various extras caused by Pollution or Fallout?

That's in my extras work TODO (at least to consider, the flag is sort of handy
shorthand for typical rulesets where all the pollution extras apply to all the
terrains without No_Pollution)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21949] Server crash when ruleset has no pollution extra for some terrain

2014-04-21 Thread Emmet Hikory 
Follow-up Comment #1, bug #21949 (project freeciv):

With this fix, is there still value to the No_Pollution flag, or can it be
entirely migrated to the reqs vector for the various extras caused by
Pollution or Fallout?

Entirely separately (this may be a different ticket), in the case where the
randomly selected extra is already present, should the code check to see if
there are multiple Pollution-caused extras available for the tile, and if so,
select a different one?  (this also applies for Fallout-caused extras,
although those already have the != NULL gate).


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21949] Server crash when ruleset has no pollution extra for some terrain

2014-04-21 Thread Marko Lindqvist 
URL:
  

 Summary: Server crash when ruleset has no pollution extra for
some terrain
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 21 Apr 2014 10:57:53 PM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0

___

Details:

Server can crash if ruleset has terrain type without "No_Pollution" flag but
for which no suitable pollution extra (EC_POLLUTION or EC_FALLOUT) is found
when game wants to place one.
This bug affects variant2 at the moment.

Fix attached.



___

File Attachments:


---
Date: Mon 21 Apr 2014 10:57:53 PM EEST  Name: NativePollution.patch  Size:
562B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21949] Server crash when ruleset has no pollution extra for some terrain

2014-04-21 Thread Marko Lindqvist 
Update of bug #21949 (project freeciv):

  Status:None => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev