[Freeciv-Dev] [bug #22189] Prefer to load units onto less nested transporters
Update of bug #22189 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22189 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22189] Prefer to load units onto less nested transporters
Follow-up Comment #3, bug #22189 (project freeciv): Do we really need to sort the full list of candidates. If I understand correctly, we only need to know the best candidate. Also, I suggest to test if the unit is better candidate than our previous one in the iteration. ___ Reply to this item at: http://gna.org/bugs/?22189 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22189] Prefer to load units onto less nested transporters
Update of bug #22189 (project freeciv): Status: Ready For Test = In Progress ___ Follow-up Comment #4: Do we really need to sort the full list of candidates. [...] I suggest to test if the unit is better candidate than our previous one in the iteration. You're right. Will rework. ___ Reply to this item at: http://gna.org/bugs/?22189 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22189] Prefer to load units onto less nested transporters
Update of bug #22189 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_5-prefer-unnested-transports-bis.patch Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?22189 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22189] Prefer to load units onto less nested transporters
Follow-up Comment #5, bug #22189 (project freeciv): (Note also that depth could be calculated using unit_transport_depth().) ___ Reply to this item at: http://gna.org/bugs/?22189 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22189] Prefer to load units onto less nested transporters
Follow-up Comment #6, bug #22189 (project freeciv): Note also that depth could be calculated using unit_transport_depth(). ...and clearly should, in case we ever decide to cache it. Third attempt attached. Sorry for being asleep. (file #21024) ___ Additional Item Attachment: File name: trunk-S2_5-prefer-unnested-transports-ter.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?22189 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22189] Prefer to load units onto less nested transporters
Follow-up Comment #7, bug #22189 (project freeciv): Sorry for being asleep. Do not worry, you don't! ___ Reply to this item at: http://gna.org/bugs/?22189 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22189] Prefer to load units onto less nested transporters
URL: http://gna.org/bugs/?22189 Summary: Prefer to load units onto less nested transporters Project: Freeciv Submitted by: jtn Submitted on: Sat 14 Jun 2014 17:18:04 BST Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: Any Planned Release: 2.5.0, 2.6.0 ___ Details: Now that it's possible to load onto transporters which are themselves transported (since bug #22050), since there is no UI to choose which transport is used (bug #13943 and friends), in some rulesets units may now randomly get loaded onto nested transports or not. Consider a ruleset with units: * Ferry: class Sea, transports Land and Small Land * Bus: class Land, transports Small Land * Spy: class Small Land If a Spy is given a load order on a tile with a Ferry carrying a Bus, I thin it's random which of the Ferry or Bus she'll end up on. This could be annoying, especially as it can't be undone. Obviously proper UI would be great, but in its absence (and in other cases where no target is specified) I think the default choice of transport should be made vaguely predictable. I propose that transporter_for_unit() ranks candidate transports by nesting depth, and a transport with the least nesting depth is chosen. This will restore the previous experience in these cases. ___ Reply to this item at: http://gna.org/bugs/?22189 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22189] Prefer to load units onto less nested transporters
Follow-up Comment #1, bug #22189 (project freeciv): I propose that transporter_for_unit() ranks candidate transports by nesting depth, and a transport with the least nesting depth is chosen. That's the most logical solution. In theory (I don't propose really doing it) we could even in the lack of complete loading UI to make Load and Unload to work one nesting level at the time. When you first Load diplomat, it enters Ferry. When it has already entered the ship, and you Load again, it enters Bus inside the Ferry or Helicopter on the deck. ___ Reply to this item at: http://gna.org/bugs/?22189 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22189] Prefer to load units onto less nested transporters
Update of bug #22189 (project freeciv): Status:None = Ready For Test Assigned to:None = jtn ___ Follow-up Comment #2: Since I couldn't think of anything more cunning than making a list of candidate transports and sorting it, I've used movement points as a tiebreaker -- units prefer to be loaded on the transport with more free MP. (file #21014) ___ Additional Item Attachment: File name: trunk-S2_5-prefer-unnested-transports.patch Size:3 KB ___ Reply to this item at: http://gna.org/bugs/?22189 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
