[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Update of patch #2152 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Follow-up Comment #18, patch #2152 (project freeciv): > I doubt we can consider "2.2.99" as a Freeciv version. It is > just a hack to don't duplicate any real version of Freeciv. > Maybe I am wrong. You are right. If development versions are not considered for the savegame versions, this should

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Follow-up Comment #17, patch #2152 (project freeciv): I doubt we can consider "2.2.99" as a Freeciv version. It is just a hack to don't duplicate any real version of Freeciv. Maybe I am wrong. ___ Reply to this item at:

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Follow-up Comment #16, patch #2152 (project freeciv): Here are two version - one for S2_3 and one for trunk. In S2_3 no changes are expected. Add a comment how to insert changes in trunk. (file #11066, file #11067) ___ Additional Item At

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Follow-up Comment #15, patch #2152 (project freeciv): Thank you, it was what I wanted to hear. :) But it is safe to keep them... ___ Reply to this item at: ___

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Follow-up Comment #14, patch #2152 (project freeciv): > I mean the savegame options "embassies2" and "vision". (lines > 245, 246). If 2.3 uses the new savegame format (savegame2.c) as default format, these options are not relevant as the entire format was updated/changed. The old file (savegame

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Follow-up Comment #13, patch #2152 (project freeciv): I mean the savegame options "embassies2" and "vision". (lines 245, 246). ___ Reply to this item at: ___ M

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Follow-up Comment #12, patch #2152 (project freeciv): > In dunno also if the options of the savegames added in 2.3 are > still correct, since the format as changed... Do you mean the scenarios? At the moment they load in 2.2 compatibility mode as they were not ported to th new format.

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Follow-up Comment #11, patch #2152 (project freeciv): In dunno also if the options of the savegames added in 2.3 are still correct, since the format as changed... ___ Reply to this item at: ___

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Follow-up Comment #10, patch #2152 (project freeciv): [from task #7225] > I didn't touch about "server/savegame.c" > and "server/savegame2.c" which seems have hard-coded > references to version 2.3. It will be handled in patch #2152. Do you mean the reference as 'can read/write old savefile'? I'

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Follow-up Comment #9, patch #2152 (project freeciv): > Yes, I agree. I made a such comment in the thread about > ruleset/tileset capability string. (I cannot find anymore, > could someone help me?) Do you mean patch #2061? ___ Reply to t

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Follow-up Comment #8, patch #2152 (project freeciv): > Yes, there should be no change. So only for major/minor versions > ... ;-) Yes, I agree. I made a such comment in the thread about ruleset/tileset capability string. (I cannot find anymore, could someone help me?) _

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Follow-up Comment #7, patch #2152 (project freeciv): > S2_3 is stable branch. You really should not be making changes > that require savegame format version bumps there. Yes, there should be no change. So only for major/minor versions ... ;-) In the past, the savegame.c file had a lot of condit

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Follow-up Comment #6, patch #2152 (project freeciv): > Could this patch please be applied before branching of 2.3 > tomorrow? Are we still on track to branch tomorrow? As Pepeto is one doing the branching, this question is directed mainly to him. It will still be possible to commit same patch to

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Follow-up Comment #5, patch #2152 (project freeciv): > 2.3.0 gets '3' with S_2_3 set to version '4' which is used when > 2.3.1 is released and so on S2_3 is *stable* branch. You really should not be making changes that require savegame format version bumps there. ___

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Follow-up Comment #4, patch #2152 (project freeciv): > However, if you are in hurry, I have no objection. We could > still discuss after that. No, I would like to discuss this before it is committed. My aim are savegame files which are compatible between freeciv versions and which are structur

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Follow-up Comment #3, patch #2152 (project freeciv): However, if you are in hurry, I have no objection. We could still discuss after that. ___ Reply to this item at: ___

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Follow-up Comment #2, patch #2152 (project freeciv): I don't really like the idea of having to increase the format every time something changed. Not release savegames shouldn't be listed anywhere (2.2.99 is not a valid savegame version). It will be just confusing, and make lot of noise, when chan

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

Follow-up Comment #1, patch #2152 (project freeciv): Could this patch please be applied before branching of 2.3 tomorrow? changes 20101101v2: * translate log_normal messages (file #11044) ___ Additional Item Attachment: File name: 2010

[Freeciv-Dev] [patch #2152] cleanup savegame version (compatibility)

URL: Summary: cleanup savegame version (compatibility) Project: Freeciv Submitted by: syntron Submitted on: Montag 01.11.2010 um 09:22 Category: general Priority: 5 - Normal