[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-13 Thread Marko Lindqvist
Update of patch #3377 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-11 Thread J. M. Gorbach
Follow-up Comment #17, patch #3377 (project freeciv):

- Huts were not added to generated map
- Set only those server settings that should have non-default value
- Removed specials from savegame.options as there's no map included at all
- Restored one changed string

I applied the patch and tutorial.sav started without errors. More lighter with
21.6 kb (22.5 kb old tutorial.sav) :)

___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-10 Thread J. M. Gorbach
Follow-up Comment #13, patch #3377 (project freeciv):

Savegame format does't run for scenario files (ie. earth 160x90, etc.).
Neither

mapsize, FULLSIZE, FULLSIZE ?
size, x measure, y measure ?

nor

+topology, ISO|WRAPX, ISO|WRAPX ?
+mapsize, XYSIZE, XYSIZE ?
+xsize, x measure, x measure ?
+ysize, y measure, y measure ?



___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-10 Thread Marko Lindqvist
Follow-up Comment #14, patch #3377 (project freeciv):

 earth 160x90

 topology, ISO|WRAPX, ISO|WRAPX ?
 mapsize, XYSIZE, XYSIZE ?
 xsize, x measure, x measure ?
 ysize, y measure, y measure ?

That scenario has map already, server settings for generating one should not
matter.

___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-10 Thread J. M. Gorbach
Follow-up Comment #15, patch #3377 (project freeciv):

That scenario has map already, server settings for generating one should not
matter.
Ok. Save and load tutorial.sav without errors.

___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-10 Thread Marko Lindqvist
Follow-up Comment #16, patch #3377 (project freeciv):

- Huts were not added to generated map
- Set only those server settings that should have non-default value
- Removed specials from savegame.options as there's no map included at all
- Restored one changed string

(file #16059)
___

Additional Item Attachment:

File name: TutorialUp-3.patch Size:7 KB


___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread J. M. Gorbach
Follow-up Comment #1, patch #3377 (project freeciv):

Any volunteers?
I applied the patch, but... tutorial.sav don't start

in map_init_topology() [map.c::332]: assertion 'MAP_WIDTH =
MAP_MIN_LINEAR_SIZE' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
in map_init_topology() [map.c::333]: assertion 'MAP_HEIGHT =
MAP_MIN_LINEAR_SIZE' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
in create_start_positions() [startpos.c::399]: assertion 'player_count() =
sum' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
The server couldn't allocate starting positions.
Failed to create suitable map, retrying with another mapseed
in map_init_topology() [map.c::332]: assertion 'MAP_WIDTH =
MAP_MIN_LINEAR_SIZE' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
in map_init_topology() [map.c::333]: assertion 'MAP_HEIGHT =
MAP_MIN_LINEAR_SIZE' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
in create_start_positions() [startpos.c::399]: assertion 'player_count() =
sum' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
The server couldn't allocate starting positions.
Cannot create suitable map with given settings.
Segnalare questo messaggio a http://gna.org/projects/freeciv/

I tried with british-isles-85x80-v2.80.sav (edit by hand) and start without
problem.


(file #16018)
___

Additional Item Attachment:

File name: british-isles-85x80-v2.80.sav.gz Size:3 KB


___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread Marko Lindqvist
Follow-up Comment #2, patch #3377 (project freeciv):

 I applied the patch, but... tutorial.sav don't start

Which branch you used? It should be compatible with current freeciv TRUNK.
(One would assume that freeciv would right-out refuse to load savegame in
newer format than what it understands)

___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread Jacob Nevins
Follow-up Comment #3, patch #3377 (project freeciv):

 (One would assume that freeciv would right-out refuse to load 
 savegame in newer format than what it understands)
Right now it doesn't (for savegame2), it emits a warning and ploughs on
regardless.

___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread J. M. Gorbach
Follow-up Comment #4, patch #3377 (project freeciv):

Which branch you used? It should be compatible with current freeciv TRUNK.
I use rev. 21469



___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread J. M. Gorbach
Follow-up Comment #5, patch #3377 (project freeciv):

I tried with british-isles-85x80-v2.80.sav (edit by hand) and start without
problem.
I made a mistake... British map doesn't start. Measure isn't 85x80, but
73x81.
I applied the patch, but... tutorial.sav doesn't start.
I added a minimap at the bottom of tutorial.sav

t000=
t001=gggg
t002=gggg
t003=
t004=
t005=
t006=
t007=
n000=
n001=
n002=
n003=
n004=
n005=
n006=
n007=

but same output.

___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread Marko Lindqvist
Follow-up Comment #6, patch #3377 (project freeciv):

By applying the patch I can reproduce myself. Will investigate.

___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread Marko Lindqvist
Follow-up Comment #7, patch #3377 (project freeciv):

- Fixed map size settings

(file #16022)
___

Additional Item Attachment:

File name: TutorialUp-2.patch Size:8 KB


___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread J. M. Gorbach
Follow-up Comment #8, patch #3377 (project freeciv):

Applied patch:

+mapsize, FULLSIZE, FULLSIZE
+size, 1, 1

I don't know, maybe it's my pc, but the same output. Now I use rev. 21471,
last change jtn (2012-07-08 11:26:08 +0200).

in map_init_topology() [map.c::332]: assertion 'MAP_WIDTH =
MAP_MIN_LINEAR_SIZE' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
in map_init_topology() [map.c::333]: assertion 'MAP_HEIGHT =
MAP_MIN_LINEAR_SIZE' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
in create_start_positions() [startpos.c::399]: assertion 'player_count() =
sum' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
The server couldn't allocate starting positions.
Failed to create suitable map, retrying with another mapseed
in map_init_topology() [map.c::332]: assertion 'MAP_WIDTH =
MAP_MIN_LINEAR_SIZE' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
in map_init_topology() [map.c::333]: assertion 'MAP_HEIGHT =
MAP_MIN_LINEAR_SIZE' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
in create_start_positions() [startpos.c::399]: assertion 'player_count() =
sum' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
The server couldn't allocate starting positions.
Cannot create suitable map with given settings.
Segnalare questo messaggio a http://gna.org/projects/freeciv/


___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread Marko Lindqvist
Follow-up Comment #9, patch #3377 (project freeciv):

 +mapsize, FULLSIZE, FULLSIZE
 +size, 1, 1

More importantly, below minimum xsize and ysize settings were removed.

___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread J. M. Gorbach
Follow-up Comment #10, patch #3377 (project freeciv):

More importantly, below minimum xsize and ysize settings were removed.
Exactly! Anyway new format is very interesting, great job!

___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread J. M. Gorbach
Follow-up Comment #11, patch #3377 (project freeciv):

See bug #18476: allow to load games without a map (i.e. tutorial)?

___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread J. M. Gorbach
Follow-up Comment #12, patch #3377 (project freeciv):

Now I use rev. 21480 and tutorial.sav start without errors :)

___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-07 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3377

 Summary: Update tutorial savegame format
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 07 Jul 2012 02:52:31 PM EEST
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

Update tutorial scenario to current savegame format.

We will eventually drop support for loading very old savegames (directly to
latest version) so better to make sure that such old formats are not used in
anything that is part of our distribution.

I simply loaded tutorial, saved it, and hand-edited. There was a lot to edit
by hand (we should improve load - save of scenarios), so please test.



___

File Attachments:


---
Date: Sat 07 Jul 2012 02:52:31 PM EEST  Name: TutorialUp.patch  Size: 9kB  
By: cazfi

http://gna.org/patch/download.php?file_id=16002

___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev