Re: [Freeciv-Dev] Continuous integration for Freeciv-Web on Travis CI

2014-03-07 Thread Marko Lindqvist
On 7 March 2014 22:26, Andreas Røsdal  wrote:
> On Fri, 7 Mar 2014, Marko Lindqvist wrote:
>>
>> I'm trying to add patch BoolCanAttack patch from bug #21767 to
>> freeciv-web, but any attempt to run it causes this in the server side:
>>
>> 1: ERROR: Unable to parse packet:
>>
>> {"type":4,"usern:"cazfi","capability":"+Freeciv.Web.Devel-2.l-2.6-2014.Mar.05b","version_label":"-dev"jor_version"minominor_versio,"pa,"patch_veh_vers:99,:99,"port":5556}
>
>
> It seems like the packet PACKET_SERVER_JOIN_REQ is sent incorrectly. This is
> the first network packet sent from Freeciv-web from Javascript in the
> browser as a WebSocket message to nginx. Nginx will then proxy this packet
> to freeciv-proxy, which will then send it to the Freeciv C server, which is
> reporting that it isn't able to parse the packet. So somewhere on this path
> the packet becomes broken, as you see that several characters are missing in
> the packet.
>
> I haven't seen this problem before. It doesn't seem to be related to the
> BoolCanAttack patch. As there are missing characters from the packet, I
> think that it is network related.
>
> Has Freeciv-web worked correctly at some point previously, then suddenly you
> got this packet problem?


 Even reverting back to the previous commit I've done myself does not
help, so this seems like something that's changed in my system rather
than in freeciv-web.

 It's not missing characters, but more like parts of the string get
written second time over the correct string. For example "Devel-2." +
"l-2.6-2014"


 Anyway, I recommend not going to production with current version
without BoolCanAttack.patch as the AI is crashing very often in
current HEAD.


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] Continuous integration for Freeciv-Web on Travis CI

2014-03-07 Thread Andreas Røsdal

On Fri, 7 Mar 2014, Marko Lindqvist wrote:

On 7 March 2014 22:06, Marko Lindqvist  wrote:

I'm trying to add patch BoolCanAttack patch from bug #21767 to
freeciv-web, but any attempt to run it causes this in the server side:

1: ERROR: Unable to parse packet:
{"type":4,"usern:"cazfi","capability":"+Freeciv.Web.Devel-2.l-2.6-2014.Mar.05b","version_label":"-dev"jor_version"minominor_versio,"pa,"patch_veh_vers:99,:99,"port":5556}


 - ML


It also seems that freeciv revision has been updated without updating
the ruleset (at least not in every respect). I should document the
procedure of freeciv server updates.


Yes, please document the procedure. Any things we can do to make this 
process easier I would appreciate. I have probably forgotten some things 
when doing the latest svn update. Thanks!


Regards,
Andreas

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] Continuous integration for Freeciv-Web on Travis CI

2014-03-07 Thread Andreas Røsdal

On Fri, 7 Mar 2014, Marko Lindqvist wrote:

I'm trying to add patch BoolCanAttack patch from bug #21767 to
freeciv-web, but any attempt to run it causes this in the server side:

1: ERROR: Unable to parse packet:
{"type":4,"usern:"cazfi","capability":"+Freeciv.Web.Devel-2.l-2.6-2014.Mar.05b","version_label":"-dev"jor_version"minominor_versio,"pa,"patch_veh_vers:99,:99,"port":5556}


It seems like the packet PACKET_SERVER_JOIN_REQ is sent incorrectly. This 
is the first network packet sent from Freeciv-web from Javascript in the 
browser as a WebSocket message to nginx. Nginx will then proxy this packet 
to freeciv-proxy, which will then send it to the Freeciv C server, which 
is reporting that it isn't able to parse the packet. So somewhere on this 
path the packet becomes broken, as you see that several characters are 
missing in the packet.


I haven't seen this problem before. It doesn't seem to be related to 
the BoolCanAttack patch. As there are missing characters from the packet, 
I think that it is network related.


Has Freeciv-web worked correctly at some point previously, then suddenly 
you got this packet problem?


I would think that the easiest way to setup a clean Freeciv-web 
environment is to setup a virtual image using Vagrant. It should be quite 
fast and work in a consistent way every time. I would be happy to help you 
set up Freeciv-web with Vagrant, as I don't think you will have this 
problem there.


The Vagrant setup is described here: 
https://github.com/freeciv/freeciv-web



Regards,
Andreas

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] Continuous integration for Freeciv-Web on Travis CI

2014-03-07 Thread Marko Lindqvist
On 7 March 2014 22:06, Marko Lindqvist  wrote:
> I'm trying to add patch BoolCanAttack patch from bug #21767 to
> freeciv-web, but any attempt to run it causes this in the server side:
>
> 1: ERROR: Unable to parse packet:
> {"type":4,"usern:"cazfi","capability":"+Freeciv.Web.Devel-2.l-2.6-2014.Mar.05b","version_label":"-dev"jor_version"minominor_versio,"pa,"patch_veh_vers:99,:99,"port":5556}
>
>
>  - ML

 It also seems that freeciv revision has been updated without updating
the ruleset (at least not in every respect). I should document the
procedure of freeciv server updates.


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] Continuous integration for Freeciv-Web on Travis CI

2014-03-07 Thread Marko Lindqvist
I'm trying to add patch BoolCanAttack patch from bug #21767 to
freeciv-web, but any attempt to run it causes this in the server side:

1: ERROR: Unable to parse packet:
{"type":4,"usern:"cazfi","capability":"+Freeciv.Web.Devel-2.l-2.6-2014.Mar.05b","version_label":"-dev"jor_version"minominor_versio,"pa,"patch_veh_vers:99,:99,"port":5556}


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] Continuous integration for Freeciv-Web on Travis CI

2014-03-07 Thread Andreas Røsdal

Hi!

Freeciv-Web is now build on Travis CI upon every commit to git.
I hope that Travis CI will make it easy to detect bugs early,
and make it easier to keep Freeciv and Freeciv-web in sync.

https://travis-ci.org/freeciv/freeciv-web

Travis CI could be something to consider for Freeciv as well,
as this is a free service for open source projects.

Regards,
Andreas

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev