Re: [Freeciv-Dev] Re: (PR#38552) resolution

2007-03-27 Thread Christopher Spiewak

URL: http://bugs.freeciv.org/Ticket/Display.html?id=38552 

Daniel Markstedt wrote:
 URL: http://bugs.freeciv.org/Ticket/Display.html?id=38552 

 On 3/26/07, Christopher Spiewak [EMAIL PROTECTED] wrote:
   
 URL: http://bugs.freeciv.org/Ticket/Display.html?id=38552 

 
 (...)
   
 I just tried re-downloading it and it works now. Although when I want
 full screen I had to cheek the full screen, and then hit the 1280 by
 800. Is it posible to make it so that when you turn on full screen that
 it auto fills to an ok resolution and then you can choose what
 resolution you want?

 Christopher


 

 I agree that the current UI solution is unintuitive. When you learn
 it, however, it's convenient. I would personally be annoyed if the SDL
 client autodefaulted to some random resolution. So I thought, by
 putting a small helptext between the checkbox and the resolution
 buttons, could we keep it the way it is. The helptext could say
 something like For fullscreen mode, first select this checkbox, then
 click on a resolution button below.

 Alternatively, how about having two columns of resolution buttons; one
 for windowed and one for fullscreen resolutions?

  ~Daniel



   
I think that the two columns would be a great idea. Currently the SDL 
feels like it needs a little bit of work. Which makes me wish that I 
know how to program even more. Well thank you guys once again and keep 
all this awesome coding.

Christopher



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] Re: (PR#38552) resolution

2007-03-26 Thread Christopher Spiewak

URL: http://bugs.freeciv.org/Ticket/Display.html?id=38552 

Christian Prochaska wrote:
 URL: http://bugs.freeciv.org/Ticket/Display.html?id=38552 

   
 [EMAIL PROTECTED] - Di 20. Mär 2007, 21:53:18]:

 Hello,
 Here I am once again with another problem. My problem is that I tried 
 the SDL client and I was having trouble with the resolution. I was 
 trying to set it to full-screen and 1280 by 800 resolution. It didn't 
 have a 1280 by 800 setting and I could not get it to stay in 
 full-screen. Could you please fix this or tell me how or what I need to 
 do to fix it.

 Christopher


 

 Does the 1280x800 resolution work when you set it manually in the
 .civclientrc file? (look for gui_sdl_screen_width and
 gui_sdl_screen_height)

 The attached patch fixes the could not get it to stay in full-screen
 problem.

   
 

 Index: client/gui-sdl/optiondlg.c
 ===
 --- client/gui-sdl/optiondlg.c(Revision 12860)
 +++ client/gui-sdl/optiondlg.c(Arbeitskopie)
 @@ -424,7 +424,7 @@

  set_wstate(pWidget, FC_WS_DISABLED);

 -if (gui_sdl_fullscreen != (Main.screen-flags  SDL_FULLSCREEN)) {
 +if (gui_sdl_fullscreen != BOOL_VAL(Main.screen-flags  SDL_FULLSCREEN)) 
 {
tmp_flags ^= SDL_FULLSCREEN;
tmp_flags ^= SDL_RESIZABLE;
  }
 @@ -440,7 +440,7 @@

  gui_sdl_screen_width = Main.screen-w;
  gui_sdl_screen_height = Main.screen-h;
 -
 +
  /* change setting label */
  if (Main.screen-flags  SDL_FULLSCREEN) {
my_snprintf(cBuf, sizeof(cBuf), _(Current Setup\nFullscreen %dx%d),
 @@ -665,8 +665,8 @@

  /* gui_sdl_fullscreen check box */
  pTmpGui = create_checkbox(pWindow-dst,
 -  ((Main.screen-flags  SDL_FULLSCREEN) == SDL_FULLSCREEN),
 -  WF_RESTORE_BACKGROUND);
 +  (Main.screen-flags  SDL_FULLSCREEN),
 +  WF_RESTORE_BACKGROUND);
  
  pTmpGui-action = toggle_fullscreen_callback;
  set_wstate(pTmpGui, FC_WS_NORMAL);
 @@ -2322,7 +2322,7 @@
  
SDL_Client_Flags |= (CF_OPTION_MAIN | CF_OPTION_OPEN);

 -  gui_sdl_fullscreen = Main.screen-flags  SDL_FULLSCREEN;
 +  gui_sdl_fullscreen = BOOL_VAL(Main.screen-flags  SDL_FULLSCREEN);

disable_main_widgets();

 @@ -2340,7 +2340,7 @@
   
  SDL_Client_Flags = ~(CF_OPTION_MAIN | CF_OPTION_OPEN);
 
 -gui_sdl_fullscreen = Main.screen-flags  SDL_FULLSCREEN;
 +gui_sdl_fullscreen = BOOL_VAL(Main.screen-flags  SDL_FULLSCREEN);
  
  FC_FREE(pOption_Dlg);
  enable_main_widgets();
   

I just tried re-downloading it and it works now. Although when I want 
full screen I had to cheek the full screen, and then hit the 1280 by 
800. Is it posible to make it so that when you turn on full screen that 
it auto fills to an ok resolution and then you can choose what 
resolution you want?

Christopher



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] Re: (PR#38552) resolution

2007-03-26 Thread Daniel Markstedt

URL: http://bugs.freeciv.org/Ticket/Display.html?id=38552 

On 3/26/07, Christopher Spiewak [EMAIL PROTECTED] wrote:

 URL: http://bugs.freeciv.org/Ticket/Display.html?id=38552 

(...)

 I just tried re-downloading it and it works now. Although when I want
 full screen I had to cheek the full screen, and then hit the 1280 by
 800. Is it posible to make it so that when you turn on full screen that
 it auto fills to an ok resolution and then you can choose what
 resolution you want?

 Christopher



I agree that the current UI solution is unintuitive. When you learn
it, however, it's convenient. I would personally be annoyed if the SDL
client autodefaulted to some random resolution. So I thought, by
putting a small helptext between the checkbox and the resolution
buttons, could we keep it the way it is. The helptext could say
something like For fullscreen mode, first select this checkbox, then
click on a resolution button below.

Alternatively, how about having two columns of resolution buttons; one
for windowed and one for fullscreen resolutions?

 ~Daniel



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev