Re: [Freeciv-Dev] (PR#36577) PNG flags and shields do not depend on SVG files
URL: http://bugs.freeciv.org/Ticket/Display.html?id=36577 On Thu, 15 Mar 2007 21:18:38 -0800 Daniil Ivanov wrote: I have finally made those changes :) It is not going to change any default behavior. It just will be useful for people, who are adding their own flags at a build stage. The rule is applied only in case there is no PNG files or they have an earlier modification date than SVG file. I would like these to be called non-automatically, but by something like 'make update-png' (inspired by 'make update-po'). And like 'make update-po' it can be called by 'make dist' rather than regular 'make'. Btw, what script do if there is no inkscape in system? -- Thanks, evyscr ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#36577) PNG flags and shields do not depend on SVG files
URL: http://bugs.freeciv.org/Ticket/Display.html?id=36577 On 16/03/07, Egor Vyscrebentsov [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=36577 On Thu, 15 Mar 2007 21:18:38 -0800 Daniil Ivanov wrote: I would like these to be called non-automatically, but by something like 'make update-png' (inspired by 'make update-po'). And like 'make update-po' it can be called by 'make dist' rather than regular 'make'. Btw, what script do if there is no inkscape in system? -- Thanks, evyscr It fails :) Well, this is the exact behavior before, when you add SVG, patch half of dozen of files and try to build, make says to you there is no rule to produce PNG files. In absence of Inkscape make will fail trying to execute convert_png. However, if we will keep adding PNG to SVN this rule will never be used during 'make' or 'make dist'. I feel update-po is very different from this use-case. BR, Daniil. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#36577) PNG flags and shields do not depend on SVG files
URL: http://bugs.freeciv.org/Ticket/Display.html?id=36577 On 3/16/07, Egor Vyscrebentsov [EMAIL PROTECTED] wrote: On Fri, 16 Mar 2007 Daniil Ivanov wrote: However, if we will keep adding PNG to SVN this rule will never be used during 'make' or 'make dist'. I feel update-po is very different from this use-case. Well, I thought about another case: .svg file is newer than .png. I don't want to regen new png, and regen it again after `svn revert`, and regen it again... ;) Agreed. You cannot guarantee that local timestamps of files got from svn are in correct order. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#36577) PNG flags and shields do not depend on SVG files
URL: http://bugs.freeciv.org/Ticket/Display.html?id=36577 Ping. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#36577) PNG flags and shields do not depend on SVG files
URL: http://bugs.freeciv.org/Ticket/Display.html?id=36577 On 2/24/07, Daniil Ivanov [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=36577 Hi, can anybody briefly describe the problems with Windows build? I'm total newbie in Windows. But I think, Windows has GNU make, GNU bash and Inkscape, so what is the actual problem? Thanks, Daniil. I'm against regenerating all flag PNGs during every build, as it would slow down the make process too much. Maybe you could devise a system where only flags whose SVG has been modified since the last make is targeted. ~Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#36577) PNG flags and shields do not depend on SVG files
URL: http://bugs.freeciv.org/Ticket/Display.html?id=36577 On 12/03/07, Daniel Markstedt [EMAIL PROTECTED] wrote: I'm against regenerating all flag PNGs during every build, as it would slow down the make process too much. Maybe you could devise a system where only flags whose SVG has been modified since the last make is targeted. ~Daniel There is no need in regenerating PNGs every build. GNU/Make checks dependencies and perform actions only if produced PNG is older than SVG. So that you will need this only during initial build and until you do make clean. But okay, now I have the opinions and the best solution is to keep the PNG in svn and just add a rule to produce lacking or outdated PNGs. Thanks, Daniil. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#36577) PNG flags and shields do not depend on SVG files
URL: http://bugs.freeciv.org/Ticket/Display.html?id=36577 Hi, can anybody briefly describe the problems with Windows build? I'm total newbie in Windows. But I think, Windows has GNU make, GNU bash and Inkscape, so what is the actual problem? Thanks, Daniil. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#36577) PNG flags and shields do not depend on SVG files
URL: http://bugs.freeciv.org/Ticket/Display.html?id=36577 On Thu, 22 Feb 2007 Jason Dorje Short wrote: Daniil Ivanov wrote: Hi, what is the actual reason that PNG flags and shields do not depend on SVG files and, thus, are not generated during build? Should I make a patch? Sure. Doesn't this mean that freeciv build will require something it doesn't require now? Couldn't this add problems for compilation on non-posix systems? -- Thanks, evyscr ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#36577) PNG flags and shields do not depend on SVG files
URL: http://bugs.freeciv.org/Ticket/Display.html?id=36577 On 23/02/07, Egor Vyscrebentsov [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=36577 On Thu, 22 Feb 2007 Jason Dorje Short wrote: Daniil Ivanov wrote: Hi, what is the actual reason that PNG flags and shields do not depend on SVG files and, thus, are not generated during build? Should I make a patch? Sure. Doesn't this mean that freeciv build will require something it doesn't require now? Couldn't this add problems for compilation on non-posix systems? -- Thanks, evyscr Hi, Egor, Build will require the Inkscape. What are non-posix systems? Thanks, Daniil. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#36577) PNG flags and shields do not depend on SVG files
URL: http://bugs.freeciv.org/Ticket/Display.html?id=36577 On Fri, 23 Feb 2007 Daniil Ivanov wrote: On 23/02/07, Egor Vyscrebentsov wrote: Doesn't this mean that freeciv build will require something it doesn't require now? Couldn't this add problems for compilation on non-posix systems? Build will require the Inkscape. Well, then I'm strongly against this change. This should be done other way (script, possibly) and generated files should be in svn repo. What are non-posix systems? One example of non-posix system is MS Win PS. Daniil, please, set your mail client to not insert mail address in quoting. PPS. S prazdnikom ;) -- Thanks, evyscr ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#36577) PNG flags and shields do not depend on SVG files
URL: http://bugs.freeciv.org/Ticket/Display.html?id=36577 On 2/23/07, Egor Vyscrebentsov [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=36577 On Fri, 23 Feb 2007 Daniil Ivanov wrote: On 23/02/07, Egor Vyscrebentsov wrote: Doesn't this mean that freeciv build will require something it doesn't require now? Couldn't this add problems for compilation on non-posix systems? Build will require the Inkscape. Well, then I'm strongly against this change. This should be done other way (script, possibly) and generated files should be in svn repo. This is exactly how it's done now. If you want to generate all flags, in the flags directory run ./convert_png *.svg once. All PNG flags in SVN are generated from the SVG images like this. ~Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
