Re: [Freeciv-Dev] (PR#40228) Lone "And, became more experienced!" -message
http://bugs.freeciv.org/Ticket/Display.html?id=40228 > 2008/5/4 Marko Lindqvist: > > S2_2 > > After successful attack, Messages tab shows: > "Start of turn 2" > "And, became more experienced!" > > > "And, became more experienced" has event type separate from the > 'parent' message. So it's possible that this message is displayed when > parent is not. This was fixed by Madeline's batch of translation fixes, right? - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40228) Lone "And, became more experienced!" -message
http://bugs.freeciv.org/Ticket/Display.html?id=40228 > cc to translators list. 2008/5/4 Madeline Book: > > How about keeping separate event type and making messages something > > like: > > "After successful attack %s became more experienced" > > "After defending successfully %s became more experienced" > > > > Of course, this repeats "successful attack" from the parent message > > when both are displayed. > > How about: > "Your %s became more experienced through combat" My mistake. This is actually used for any kind of experience gaining. Either we simply say that "Your %s became more experienced!", make each case completely separate string "Your %s became more experienced through combat!", "Your %s became more experienced by working hard!", or provide 'reason' to common "Your %s became more experienced %s". - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40228) Lone "And, became more experienced!" -message
http://bugs.freeciv.org/Ticket/Display.html?id=40228 > 2008/5/4 Jason Dorje Short: > > "And, became more experienced" has event type separate from the > > 'parent' message. So it's possible that this message is displayed when > > parent is not. > > I've seen this reported on IRC. It's broken english and should be > merged with the first half of the sentence into a single translatable > string. How about keeping separate event type and making messages something like: "After successful attack %s became more experienced" "After defending successfully %s became more experienced" Of course, this repeats "successful attack" from the parent message when both are displayed. I'm just mentioning alternative solution. I'm not against Jason's suggestion. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40228) Lone "And, became more experienced!" -message
http://bugs.freeciv.org/Ticket/Display.html?id=40228 > Marko Lindqvist wrote: > http://bugs.freeciv.org/Ticket/Display.html?id=40228 > > > S2_2 > > After successful attack, Messages tab shows: > "Start of turn 2" > "And, became more experienced!" > > > "And, became more experienced" has event type separate from the > 'parent' message. So it's possible that this message is displayed when > parent is not. > > Note that there is two parent event types; defending and attacking units. I've seen this reported on IRC. It's broken english and should be merged with the first half of the sentence into a single translatable string. -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40228) Lone "And, became more experienced!" -message
Marko Lindqvist wrote: > http://bugs.freeciv.org/Ticket/Display.html?id=40228 > > > S2_2 > > After successful attack, Messages tab shows: > "Start of turn 2" > "And, became more experienced!" > > > "And, became more experienced" has event type separate from the > 'parent' message. So it's possible that this message is displayed when > parent is not. > > Note that there is two parent event types; defending and attacking units. I can confirm seeing this regularly in games played in 2.2 and trunk. I almost never see any information about my units when I attack (either in same turn, or when attack is delayed until start of next turn). I usually do see information about enemy units as well as mine when being attacked. - John ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
