Re: [Freeciv-Dev] (PR#40389) [Patch] Avoid bogus max rate exceeded -messages

2008-07-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40389 2008/7/22 Jason Dorje Short: And what's the purpose of the return value anyway? Wouldn't the simplest fix be just to change the != to in the three comparisons? It would work, but I consider it very ugly. We would be looking in the

Re: [Freeciv-Dev] (PR#40389) [Patch] Avoid bogus max rate exceeded -messages

2008-07-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40389 2008/7/22 Marko Lindqvist: 2008/7/22 Jason Dorje Short: On the other hand changing the function to return the new value (a struct player_economic) so that it didn't have side effects, might be worthwhile. Yes, that would probably

Re: [Freeciv-Dev] (PR#40389) [Patch] Avoid bogus max rate exceeded -messages

2008-07-21 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40389 On Mon, Jul 21, 2008 at 10:40 AM, Marko Lindqvist [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40389 After rates are adjusted, message about rate exceeding is sent about all changed values - also