Re: [Freeciv-Dev] [bug #20111] generate_packets.py asserts against packet types above 255

[Marko Lindqvist]

On 17 September 2012 20:58, Gilles J. Seguin  wrote:
> why do i received comment that this a year ago
> changed/proposition/whatever ?
>
> please help stupid people
>
>> On Thu, 2012-08-30 at 03:29 +0200, Marko Lindqvist wrote:
>
> that looks like a week ago

 Let me repeat: This (week old ticket) was bugfix to actual protocol
change almost a year ago.

 Size of type field was increased to 16bit as one of the first commits
that went in when 2.5 development started (timed that way so it
wouldn't break compatibility in the middle of the cycle) Howeverf,
assert remained that prevented now-legal values from being accepted.

>>
>> When size of packet type field was increased, assert forcing maximum type
>> number of 255 was left to generate_packets.py.
>>
>> Fix attached.


 Also, what kind of connection you have if you have such problems with
freeciv bandwidth usage as you claim? Do you have any idea how much 1
byte/packet increase makes in percents? (maybe it's not totally
insignificant but you have not complained about feature changes that
have increased bandwidth usage in orders of magnitude more)


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] [bug #20111] generate_packets.py asserts against packet types above 255

[Gilles J. Seguin]

why do i received comment that this a year ago
changed/proposition/whatever ?

please help stupid people

> On Thu, 2012-08-30 at 03:29 +0200, Marko Lindqvist wrote:

that looks like a week ago

> URL:
>   

this url says Submitted: 30 Aug 2012

> 
>  Summary: generate_packets.py asserts against packet types
> above 255

is my english so bad
you have modify assert
message type greater than 255 are now allow

>  Project: Freeciv
> Submitted by: cazfi
> Submitted on: Thu 30 Aug 2012 04:29:55 AM EEST

time is at most two week ago

> Category: bootstrap
> Severity: 3 - Normal

severity is catastrophic

> Priority: 5 - Normal
>   Status: Ready For Test
>  Assigned to: None
> Originator Email: 
>  Open/Closed: Open
>  Release: 
>  Discussion Lock: Any
> Operating System: None
>  Planned Release: 2.5.0

that is not looking like 2.2 code to me

> 
> ___
> 
> Details:
> 
> When size of packet type field was increased, assert forcing maximum type
> number of 255 was left to generate_packets.py.
> 
> Fix attached.
> 
> 
> 
> ___
> 
> File Attachments:
> 
> 
> ---
> Date: Thu 30 Aug 2012 04:29:55 AM EEST  Name: Above255Packets.patch  Size:

i still see no 2011 date, what should be my encoding

> 512B   By: cazfi
> 
> 
> 
> ___
> 
> Reply to this item at:
> 
>   



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] [bug #20111] generate_packets.py asserts against packet types above 255

[Marko Lindqvist]

On 15 September 2012 20:58, Gilles J. Seguin  wrote:
> On Thu, 2012-08-30 at 03:29 +0200, Marko Lindqvist wrote:
>> Details:
>>
>> When size of packet type field was increased, assert forcing maximum type
>> number of 255 was left to generate_packets.py.
>
> wow
> stop everything
> what is this ?
>
> changing communication protocol

 No, you are commenting to bugfix to protocol change that went in
almost a year ago, originally proposed during 2.2 development.

> that should be put in BOLD RED

We have never been network compatible between major versions.
Development version protocol changes are very frequent. This change
was in more fundamental level than most, but compatibility breaks
often when new features require new information to be transmitted.

> you know that will break metaserver too ?

 No, it didn't. Metaserver communication is completely unrelated.


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] [bug #20111] generate_packets.py asserts against packet types above 255

[Gilles J. Seguin]

On Thu, 2012-08-30 at 03:29 +0200, Marko Lindqvist wrote:
> URL:
>   
> 
>  Summary: generate_packets.py asserts against packet types
> above 255
>  Project: Freeciv
> Submitted by: cazfi
> Submitted on: Thu 30 Aug 2012 04:29:55 AM EEST
> Category: bootstrap
> Severity: 3 - Normal
> Priority: 5 - Normal
>   Status: Ready For Test
>  Assigned to: None
> Originator Email: 
>  Open/Closed: Open
>  Release: 
>  Discussion Lock: Any
> Operating System: None
>  Planned Release: 2.5.0
> 
> ___
> 
> Details:
> 
> When size of packet type field was increased, assert forcing maximum type
> number of 255 was left to generate_packets.py.

wow
stop everything
what is this ?

changing communication protocol

that should be put in BOLD RED

you know that will break metaserver too ?
the answer should be yes.

you know that increasing load on a game
- that major limitation of this game is bandwidth communication
  is major design misunderstanding(bad thing).

please, justify need for increase in number of message type.

like with Walt Disney graphic

http://www.mcternan.me.uk/mscgen/

if you can not, which you should not, means do not be crazy.
revert as soon as possible.

even protocol similation should prove you wrong.

if you do not understand, do not think twice
think about alternative for keeping message type been a byte.

Gilles J. Seguin





___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev