Re: [Freedreno] [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-08 Thread Sebastian Wick
On Tue, Nov 8, 2022 at 7:51 PM Simon Ser wrote: > > cc'ing Pekka and wayland-devel for userspace devs feedback on the new uAPI. > > On Saturday, October 29th, 2022 at 14:08, Dmitry Baryshkov > wrote: > > > On 29/10/2022 01:59, Jessica Zhang wrote: > > > Add support for COLOR_FILL and

Re: [Freedreno] [PATCH v2 08/18] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis

2022-11-08 Thread Krzysztof Kozlowski
On 08/11/2022 00:56, Bryan O'Donoghue wrote: > Each compatible has a different set of clocks which are associated with it. > Add in the list of clocks for each compatible. > > Cc: Rob Clark > Cc: Abhinav Kumar > Cc: Dmitry Baryshkov > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter >

Re: [Freedreno] [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC

2022-11-08 Thread Krzysztof Kozlowski
On 08/11/2022 13:46, Dmitry Baryshkov wrote: > On 08/11/2022 02:56, Bryan O'Donoghue wrote: >> Currently we do not differentiate between the various users of the >> qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one >> compatible string but, the hardware does have some

Re: [Freedreno] [PATCH v2 06/18] dt-bindings: msm: dsi-controller-main: Alphanumerically sort compatible enum

2022-11-08 Thread Krzysztof Kozlowski
On 08/11/2022 00:56, Bryan O'Donoghue wrote: > Sort the order of the compatible strings alphanumerically. > > Cc: Rob Clark > Cc: Abhinav Kumar > Cc: Dmitry Baryshkov > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: Rob Herring > Cc: Krzysztof Kozlowski > Cc:

Re: [Freedreno] [PATCH v2 05/18] dt-bindings: msm: dsi-controller-main: Fix description of core clock

2022-11-08 Thread Krzysztof Kozlowski
On 08/11/2022 00:56, Bryan O'Donoghue wrote: > There's a typo in describing the core clock as an 'escape' clock. The > accurate description is 'core'. > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI > bindings") > Cc: Rob Clark Acked-by: Krzysztof Kozlowski Best

Re: [Freedreno] [PATCH v2 03/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in

2022-11-08 Thread Krzysztof Kozlowski
On 08/11/2022 00:56, Bryan O'Donoghue wrote: > When converting from .txt to .yaml we didn't include descriptions for the > existing regulator supplies. > > - vdd > - vdda > - vddio > > Add those descriptions into the yaml now as they were prior to the > conversion. Mark the supplies as required

Re: [Freedreno] [PATCH v2 02/18] dt-bindings: msm: dsi-controller-main: Fix power-domain constraint

2022-11-08 Thread Krzysztof Kozlowski
On 08/11/2022 00:56, Bryan O'Donoghue wrote: > power-domain is required for the sc7180 dispcc GDSC but not every qcom SoC > has a similar dependency for example the aqp8064. > > Most Qcom SoC's using mdss-dsi-ctrl seem to have the ability to > power-collapse the MDP without collapsing DSI. > >

Re: [Freedreno] [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-08 Thread Simon Ser
cc'ing Pekka and wayland-devel for userspace devs feedback on the new uAPI. On Saturday, October 29th, 2022 at 14:08, Dmitry Baryshkov wrote: > On 29/10/2022 01:59, Jessica Zhang wrote: > > Add support for COLOR_FILL and COLOR_FILL_FORMAT properties for > > drm_plane. In addition, add support

Re: [Freedreno] [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-08 Thread Simon Ser
On Saturday, October 29th, 2022 at 13:23, Dmitry Baryshkov wrote: > On 29/10/2022 01:59, Jessica Zhang wrote: > > > Add support for COLOR_FILL and COLOR_FILL_FORMAT properties for > > drm_plane. In addition, add support for setting and getting the values > > of these properties. > > > >

Re: [Freedreno] [PATCH v2 03/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in

2022-11-08 Thread Dmitry Baryshkov
On Tue, 8 Nov 2022 at 17:42, Bryan O'Donoghue wrote: > > On 08/11/2022 12:59, Dmitry Baryshkov wrote: > >> > >> Warnings about missing regulators can be resolved by updating the > >> relevant > >> dtsi files to point to fixed always-on regulators where appropriate. > > > > Ugh. Are they missing

Re: [Freedreno] [PATCH v2 03/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in

2022-11-08 Thread Bryan O'Donoghue
On 08/11/2022 12:59, Dmitry Baryshkov wrote: Warnings about missing regulators can be resolved by updating the relevant dtsi files to point to fixed always-on regulators where appropriate. Ugh. Are they missing or are they optional/not used on these platforms? Some platforms either don't

Re: [Freedreno] [PATCH v2 05/18] dt-bindings: msm: dsi-controller-main: Fix description of core clock

2022-11-08 Thread Dmitry Baryshkov
On 08/11/2022 02:56, Bryan O'Donoghue wrote: There's a typo in describing the core clock as an 'escape' clock. The accurate description is 'core'. Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") Cc: Rob Clark Cc: Abhinav Kumar Cc: Dmitry Baryshkov Cc: Sean

Re: [Freedreno] [PATCH v2 04/18] dt-bindings: msm: dsi-controller-main: Fix clock declarations

2022-11-08 Thread Dmitry Baryshkov
On 08/11/2022 02:56, Bryan O'Donoghue wrote: When converting from .txt to .yaml dt-binding descriptions we appear to have missed some of the previous detail on the number and names of permissible clocks. Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")

Re: [Freedreno] [PATCH v2 03/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in

2022-11-08 Thread Dmitry Baryshkov
On 08/11/2022 02:56, Bryan O'Donoghue wrote: When converting from .txt to .yaml we didn't include descriptions for the existing regulator supplies. - vdd - vdda - vddio Add those descriptions into the yaml now as they were prior to the conversion. Mark the supplies as required as was

Re: [Freedreno] [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC

2022-11-08 Thread Dmitry Baryshkov
On 08/11/2022 02:56, Bryan O'Donoghue wrote: Currently we do not differentiate between the various users of the qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one compatible string but, the hardware does have some significant differences in the number of clocks. To facilitate

Re: [Freedreno] [PATCH v2 08/18] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis

2022-11-08 Thread Bryan O'Donoghue
On 08/11/2022 12:43, Dmitry Baryshkov wrote: I'd prefer to have this part squashed into the previous patch. NP. Actually I'll add you as a suggested by here since you sent me a patch ~ similar to this. --- bod

Re: [Freedreno] [PATCH v2 08/18] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis

2022-11-08 Thread Dmitry Baryshkov
On 08/11/2022 02:56, Bryan O'Donoghue wrote: Each compatible has a different set of clocks which are associated with it. Add in the list of clocks for each compatible. Cc: Rob Clark Cc: Abhinav Kumar Cc: Dmitry Baryshkov Cc: Sean Paul Cc: David Airlie Cc: Daniel Vetter Cc: Rob Herring

Re: [Freedreno] [PATCH v9 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-11-08 Thread Krzysztof Kozlowski
On 24/10/2022 18:42, Dmitry Baryshkov wrote: > Move properties common to all MDSS DT nodes to the mdss-common.yaml. > > This extends qcom,msm8998-mdss schema to allow interconnect nodes, which > will be added later, once msm8998 gains interconnect support. (...) > +minItems: 1 > +

Re: [Freedreno] [PATCH v9 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-11-08 Thread Krzysztof Kozlowski
On 24/10/2022 18:42, Dmitry Baryshkov wrote: > Move properties common to all DPU DT nodes to the dpu-common.yaml. > > Note, this removes description of individual DPU port@ nodes. However > such definitions add no additional value. The reg values do not > correspond to hardware INTF indices. The

Re: [Freedreno] [PATCH v3 3/8] dt-bindings: display/msm: add support for the display on SM8450

2022-11-08 Thread Krzysztof Kozlowski
On 04/11/2022 14:03, Dmitry Baryshkov wrote: > Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm > SM8450 platform. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/qcom,sm8450-dpu.yaml | 132 +++ > .../display/msm/qcom,sm8450-mdss.yaml |

Re: [Freedreno] [RFC PATCH 0/3] Support for Solid Fill Planes

2022-11-08 Thread Ville Syrjälä
On Mon, Nov 07, 2022 at 07:34:43PM -0800, Rob Clark wrote: > On Mon, Nov 7, 2022 at 4:22 PM Jessica Zhang > wrote: > > > > > > > > On 11/7/2022 2:09 PM, Rob Clark wrote: > > > On Mon, Nov 7, 2022 at 1:32 PM Jessica Zhang > > > wrote: > > >> > > >> > > >> > > >> On 11/7/2022 11:37 AM, Ville