Re: [Freedreno] [PATCH v3 05/12] dt-bindings: display/msm: Add SM6375 MDSS

2023-05-07 Thread Krzysztof Kozlowski
On 05/05/2023 23:40, Konrad Dybcio wrote: > Document the SM6375 MDSS. > > Signed-off-by: Konrad Dybcio > --- > .../bindings/display/msm/qcom,sm6375-mdss.yaml | 216 > + > 1 file changed, 216 insertions(+) > Thank you for your patch. There is something to

Re: [Freedreno] [PATCH v3 03/12] dt-bindings: display/msm: sc7180-dpu: Describe SM6350 and SM6375

2023-05-07 Thread Krzysztof Kozlowski
On 05/05/2023 23:40, Konrad Dybcio wrote: > SC7180, SM6350 and SM6375 use a rather similar hw setup for DPU, with > the main exception being that the last one requires an additional > throttle clock. > > It is not well understood yet, but failing to toggle it on makes the > display hardware stall

Re: [Freedreno] [PATCH v3 04/12] dt-bindings: display/msm: Add SM6350 MDSS

2023-05-07 Thread Krzysztof Kozlowski
On 05/05/2023 23:40, Konrad Dybcio wrote: > Document the SM6350 MDSS. > > Signed-off-by: Konrad Dybcio > --- > .../bindings/display/msm/qcom,sm6350-mdss.yaml | 214 > + > 1 file changed, 214 insertions(+) > > diff --git >

Re: [Freedreno] [PATCH v6 6/7] drm/msm/dsi: update hdisplay calculation for dsi_timing_setup

2023-05-07 Thread Marijn Suijten
On 2023-05-04 15:05:15, Abhinav Kumar wrote: > > > On 5/4/2023 2:56 PM, Marijn Suijten wrote: > > On 2023-04-12 16:25:20, Jessica Zhang wrote: > >> hdisplay for compressed images should be calculated as bytes_per_slice * > >> slice_count. Thus, use MSM DSC helper to calculate hdisplay for > >>

Re: [Freedreno] [PATCH v6 6/7] drm/msm/dsi: update hdisplay calculation for dsi_timing_setup

2023-05-07 Thread Marijn Suijten
On 2023-05-04 15:34:08, Jessica Zhang wrote: > > > On 5/4/2023 2:56 PM, Marijn Suijten wrote: > > On 2023-04-12 16:25:20, Jessica Zhang wrote: > >> hdisplay for compressed images should be calculated as bytes_per_slice * > >> slice_count. Thus, use MSM DSC helper to calculate hdisplay for > >>

Re: [Freedreno] [PATCH v2 3/4] drm/msm/dpu: Add DPU_INTF_DATA_COMPRESS feature flag

2023-05-07 Thread Marijn Suijten
On 2023-05-05 14:23:50, Jessica Zhang wrote: > Add DATA_COMPRESS feature flag to DPU INTF block. > > In DPU 7.x and later, DSC/DCE enablement registers have been moved from > PINGPONG to INTF. > > As core_rev (and related macros) was removed from the dpu_kms struct, the > most straightforward

[Freedreno] [PATCH 31/53] drm/msm: Convert to platform remove callback returning void

2023-05-07 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[Freedreno] [PATCH 00/53] drm: Convert to platform remove callback returning void

2023-05-07 Thread Uwe Kleine-König
Hello, this patch series adapts the platform drivers below drivers/gpu/drm to use the .remove_new() callback. Compared to the traditional .remove() callback .remove_new() returns no value. This is a good thing because the driver core doesn't (and cannot) cope for errors during remove. The only

Re: [Freedreno] [PATCH v2 4/4] drm/msm/dpu: Set DATA_COMPRESS for command mode

2023-05-07 Thread Marijn Suijten
On 2023-05-05 14:23:51, Jessica Zhang wrote: > Add a DPU INTF op to set DATA_COMPRESS register for command mode panels if > the DPU_INTF_DATA_COMPRESS feature flag is set. This flag needs to be > enabled in order for DSC v1.2 to work. > > Note: These changes are for command mode only. Video mode

[Freedreno] [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

2023-05-07 Thread Leonard Lausen
This reverts commit e17af1c9d861dc177e5b56009bd4f71ace688d97. Removing the delay of 100 units broke hot plug detection for USB-C displays on qcom sc7180 lazor devices. Lazor uses mdss for hot plug detection and declares dp_hot_plug_det in the dts. Other sc7180 based devices like aspire1 were not

Re: [Freedreno] [PATCH v6 6/7] drm/msm/dsi: update hdisplay calculation for dsi_timing_setup

2023-05-07 Thread Marijn Suijten
On 2023-05-07 17:27:33, Marijn Suijten wrote: > On 2023-05-04 15:05:15, Abhinav Kumar wrote: > > > > > > On 5/4/2023 2:56 PM, Marijn Suijten wrote: > > > On 2023-04-12 16:25:20, Jessica Zhang wrote: > > >> hdisplay for compressed images should be calculated as bytes_per_slice * > > >>

Re: [Freedreno] [PATCH v2 3/4] drm/msm/dpu: Add DPU_INTF_DATA_COMPRESS feature flag

2023-05-07 Thread Dmitry Baryshkov
On 07/05/2023 19:00, Marijn Suijten wrote: On 2023-05-05 14:23:50, Jessica Zhang wrote: Add DATA_COMPRESS feature flag to DPU INTF block. In DPU 7.x and later, DSC/DCE enablement registers have been moved from PINGPONG to INTF. As core_rev (and related macros) was removed from the dpu_kms

[Freedreno] [RFC PATCH v1 1/3] drm/msm/hdmi: add msm8974 PLL support

2023-05-07 Thread Dmitry Baryshkov
From: Brian Masney Add msm8974 Phase-Locked Loop (PLL) support to the MSM HDMI so that an external display can be used on this SoC. Signed-off-by: Brian Masney Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/hdmi/hdmi.h | 6

[Freedreno] [RFC PATCH v1 0/3] drm/msm: add support for HDMI on msm8974

2023-05-07 Thread Dmitry Baryshkov
This series adds support for the HDMI output on the msm8974 platform. It was tested on the apq8074 dragonboard device. I'm sending this as an RFC for two reasons: - The series depends on the other patchset ([1]), which got no feedback yet. - I'm looking at refactoring the HDMI PHY support. I

[Freedreno] [RFC PATCH v1 2/3] ARM: dts: qcom: msm8974: add support for the HDMI output

2023-05-07 Thread Dmitry Baryshkov
Add HDMI and HDMI PHY device nodes for the Qualcomm MSM8974 SoC. Signed-off-by: Dmitry Baryshkov --- arch/arm/boot/dts/qcom-msm8974.dtsi | 90 - 1 file changed, 89 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi

[Freedreno] [RFC PATCH v1 3/3] ARM: dts: qcom: apq8074-dragonboard: enable HDMI output

2023-05-07 Thread Dmitry Baryshkov
Enable HDMI output on the APQ8074 dragonboard device. Signed-off-by: Dmitry Baryshkov --- .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 30 +++ 1 file changed, 30 insertions(+) diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts

[Freedreno] [PATCH 4/4] ARM: dts: qcom: apq8074-dragonboard: enable DSI panel

2023-05-07 Thread Dmitry Baryshkov
Enable MDSS, GPU and DSI panel output on the APQ8074 dragonboard. Signed-off-by: Dmitry Baryshkov --- .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 51 +++ 1 file changed, 51 insertions(+) diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts

[Freedreno] [PATCH 0/4] ARM: dts: qcom: apq8074-dragonboard enable DSI and remoteproc

2023-05-07 Thread Dmitry Baryshkov
Enable GPU, DSI panel and remoteprocs on the APQ8074 dragonboard device. Dmitry Baryshkov (4): ARM: dts: qcom: msm8974: add ocmem clock to GPU ARM: dts: qcom: apq8074-dragonboard: Set DMA as remotely controlled ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS ARM: dts: qcom:

[Freedreno] [PATCH 2/4] ARM: dts: qcom: apq8074-dragonboard: Set DMA as remotely controlled

2023-05-07 Thread Dmitry Baryshkov
Add the qcom,controlled-remotely property for the blsp2_bam controller node. This board requires this, otherwise the board stalls during the boot for some reason (most probably because TZ mishandles the protection error and keeps on looping somewhere inside). Fixes: 62bc81792223 dts: msm8974: Add

[Freedreno] [PATCH 3/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS

2023-05-07 Thread Dmitry Baryshkov
Enable ADSP and Modem DSPs on APQ8074 dragonboard. The MSS region differs from the one defined in the msm8974, so it overriden locally. The modem is specified use mba.mbn instead of mbn.b00 (for the sake of similarity with other platforms). This requires a patch for remoteproc to be applied [1].

[Freedreno] [PATCH 1/4] ARM: dts: qcom: msm8974: add ocmem clock to GPU

2023-05-07 Thread Dmitry Baryshkov
To get GPU working with the OCMEM, the oxili_ocmemgx_clk clock should be enabled. Pass it to the GPU to get it to work on apq8074/msm8974 boards. Fixes: fe079442db63 ("ARM: dts: qcom: msm8974: add gpu support") Signed-off-by: Dmitry Baryshkov --- arch/arm/boot/dts/qcom-msm8974.dtsi | 3 ++- 1

Re: [Freedreno] [PATCH v3 08/12] drm/msm/dpu: Add SM6375 support

2023-05-07 Thread Dmitry Baryshkov
On 06/05/2023 00:40, Konrad Dybcio wrote: Add basic SM6375 support to the DPU1 driver to enable display output. Signed-off-by: Konrad Dybcio --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h | 152 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 +

[Freedreno] [PATCH 0/3] drm/bridge: display-connector: add external supply support

2023-05-07 Thread Dmitry Baryshkov
On some devices the 5V pin of the HDMI connector and/or the ESD protection logic is powered on by a separate regulator. The dp-connector for such usecases provides dp-pwr supply support. Follow this example and make hdmi-connector support the hdmi-pwr supply. Dmitry Baryshkov (3): dt-bindings:

[Freedreno] [PATCH 1/3] dt-bindings: display: hdmi-connector: add hdmi-pwr supply

2023-05-07 Thread Dmitry Baryshkov
Follow the dp-connector example and add hdmi-pwr supply to drive the 5V pin of the HDMI connector (together with some simple glue logic possibly attached to the connector). Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/display/connector/hdmi-connector.yaml | 3 +++ 1 file

[Freedreno] [PATCH 2/3] drm/bridge: display-connector: rename dp_pwr to connector_pwr

2023-05-07 Thread Dmitry Baryshkov
In preparation to adding support for the hdmi_pwr supply, rename dp_pwr structure field to the generic connector_pwr. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/display-connector.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[Freedreno] [PATCH 3/3] drm/bridge: display-connector: handle hdmi-pwr supply

2023-05-07 Thread Dmitry Baryshkov
On some devices the 5V pin of the HDMI connector and/or the ESD protection logic is powered on by a separate regulator. Instead of declaring this regulator as always-on, make hdmi-connector support the additional hdmi-pwr supply. Signed-off-by: Dmitry Baryshkov ---

Re: [Freedreno] [PATCH 1/3] dt-bindings: display: hdmi-connector: add hdmi-pwr supply

2023-05-07 Thread Rob Herring
On Sun, 07 May 2023 23:12:16 +0300, Dmitry Baryshkov wrote: > Follow the dp-connector example and add hdmi-pwr supply to drive the 5V > pin of the HDMI connector (together with some simple glue logic possibly > attached to the connector). > > Signed-off-by: Dmitry Baryshkov > --- >

Re: [Freedreno] [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

2023-05-07 Thread Bjorn Andersson
On Mon, May 08, 2023 at 01:06:13AM +, Leonard Lausen wrote: > This reverts commit e17af1c9d861dc177e5b56009bd4f71ace688d97. > > Removing the delay of 100 units broke hot plug detection for USB-C displays on > qcom sc7180 lazor devices. Lazor uses mdss for hot plug detection and declares >

Re: [Freedreno] [PATCH 2/3] drm/bridge: display-connector: rename dp_pwr to connector_pwr

2023-05-07 Thread Laurent Pinchart
Hi Dmitry, Thank you for the patch. On Sun, May 07, 2023 at 11:12:17PM +0300, Dmitry Baryshkov wrote: > In preparation to adding support for the hdmi_pwr supply, rename dp_pwr > structure field to the generic connector_pwr. > > Signed-off-by: Dmitry Baryshkov > --- >

Re: [Freedreno] [PATCH 3/3] drm/bridge: display-connector: handle hdmi-pwr supply

2023-05-07 Thread Laurent Pinchart
Hi Dmitry, Thank you for the patch. On Sun, May 07, 2023 at 11:12:18PM +0300, Dmitry Baryshkov wrote: > On some devices the 5V pin of the HDMI connector and/or the ESD > protection logic is powered on by a separate regulator. Instead of > declaring this regulator as always-on, make

Re: [Freedreno] [PATCH 1/3] dt-bindings: display: hdmi-connector: add hdmi-pwr supply

2023-05-07 Thread Laurent Pinchart
Hi Rob, On Sun, May 07, 2023 at 04:25:44PM -0500, Rob Herring wrote: > On Sun, 07 May 2023 23:12:16 +0300, Dmitry Baryshkov wrote: > > Follow the dp-connector example and add hdmi-pwr supply to drive the 5V > > pin of the HDMI connector (together with some simple glue logic possibly > > attached

Re: [Freedreno] [PATCH 1/3] dt-bindings: display: hdmi-connector: add hdmi-pwr supply

2023-05-07 Thread Laurent Pinchart
Hi Dmitry, Thank you for the patch. On Sun, May 07, 2023 at 11:12:16PM +0300, Dmitry Baryshkov wrote: > Follow the dp-connector example and add hdmi-pwr supply to drive the 5V > pin of the HDMI connector (together with some simple glue logic possibly > attached to the connector). > >

Re: [Freedreno] [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

2023-05-07 Thread Abhinav Kumar
On 5/7/2023 7:15 PM, Bjorn Andersson wrote: On Mon, May 08, 2023 at 01:06:13AM +, Leonard Lausen wrote: This reverts commit e17af1c9d861dc177e5b56009bd4f71ace688d97. Removing the delay of 100 units broke hot plug detection for USB-C displays on qcom sc7180 lazor devices. Lazor uses mdss