Re: [Freedreno] [PATCH 2/4] drm/msm: drop qcom,chipid

2017-01-30 Thread Rob Clark
On Mon, Jan 30, 2017 at 2:54 PM, Eric Anholt wrote: > Rob Clark writes: > >> On Mon, Jan 30, 2017 at 1:09 PM, Eric Anholt wrote: >>> Rob Clark writes: >>> The original way we determined the gpu version was based on downstream bindings from android kernel. A cleaner way is to get the

Re: [Freedreno] [PATCH 1/4] drm/msm: remove qcom, gpu-pwrlevels bindings

2017-01-30 Thread Eric Anholt
Rob Clark writes: > On Mon, Jan 30, 2017 at 1:21 PM, Eric Anholt wrote: >> Rob Clark writes: >> >>> The plan is to use the OPP bindings. For now, remove the documentation >>> for qcom,gpu-pwrlevels, and make the driver fall back to a safe low >>> clock if the node is not present. >>> >>> Note

Re: [Freedreno] [PATCH 2/4] drm/msm: drop qcom,chipid

2017-01-30 Thread Eric Anholt
Rob Clark writes: > On Mon, Jan 30, 2017 at 1:09 PM, Eric Anholt wrote: >> Rob Clark writes: >> >>> The original way we determined the gpu version was based on downstream >>> bindings from android kernel. A cleaner way is to get the version from >>> the compatible string. >>> >>> Note that no

Re: [Freedreno] [PATCH 1/4] drm/msm: remove qcom, gpu-pwrlevels bindings

2017-01-30 Thread Rob Clark
On Mon, Jan 30, 2017 at 1:21 PM, Eric Anholt wrote: > Rob Clark writes: > >> The plan is to use the OPP bindings. For now, remove the documentation >> for qcom,gpu-pwrlevels, and make the driver fall back to a safe low >> clock if the node is not present. >> >> Note that no upstream dtb use this

Re: [Freedreno] [PATCH 4/4] drm/msm: drop _clk suffix from clk names

2017-01-30 Thread Rob Clark
On Mon, Jan 30, 2017 at 1:15 PM, Eric Anholt wrote: > Rob Clark writes: > >> Suggested by Rob Herring. We still support the old names for >> compatibility with downstream android dt files. >> >> Cc: Rob Herring >> Signed-off-by: Rob Clark > > Huh, I don't think I would have cleaned up DT bindi

Re: [Freedreno] [PATCH 1/4] drm/msm: remove qcom, gpu-pwrlevels bindings

2017-01-30 Thread Eric Anholt
Rob Clark writes: > The plan is to use the OPP bindings. For now, remove the documentation > for qcom,gpu-pwrlevels, and make the driver fall back to a safe low > clock if the node is not present. > > Note that no upstream dtb use this node. For now we keep compatibility > with this node to avo

Re: [Freedreno] [PATCH 2/4] drm/msm: drop qcom,chipid

2017-01-30 Thread Rob Clark
On Mon, Jan 30, 2017 at 1:09 PM, Eric Anholt wrote: > Rob Clark writes: > >> The original way we determined the gpu version was based on downstream >> bindings from android kernel. A cleaner way is to get the version from >> the compatible string. >> >> Note that no upstream dtb uses these bindi

Re: [Freedreno] [PATCH 4/4] drm/msm: drop _clk suffix from clk names

2017-01-30 Thread Eric Anholt
Rob Clark writes: > Suggested by Rob Herring. We still support the old names for > compatibility with downstream android dt files. > > Cc: Rob Herring > Signed-off-by: Rob Clark Huh, I don't think I would have cleaned up DT bindings in exchange for adding driver code like this. But the code

Re: [Freedreno] [PATCH 3/4] drm/msm: drop quirks binding

2017-01-30 Thread Eric Anholt
Rob Clark writes: > This was never documented or used in upstream dtb. It is used by > downstream bindings from android device kernels. But the quirks are > a property of the gpu revision, and as such are redundant to be listed > separately in dt. Instead, move the quirks to the device table.

Re: [Freedreno] [PATCH 2/4] drm/msm: drop qcom,chipid

2017-01-30 Thread Eric Anholt
Rob Clark writes: > The original way we determined the gpu version was based on downstream > bindings from android kernel. A cleaner way is to get the version from > the compatible string. > > Note that no upstream dtb uses these bindings. But the code still > supports falling back to the legac

[Freedreno] [PATCH 0/4] drm/msm: cleanup gpu bindings

2017-01-30 Thread Rob Clark
Existing bindings for the gpu are based on the downstream android kgsl driver (a subset of the downstream bindings). But that isn't really how we want the upstream bindings to look. For now we have held off on adding gpu nodes to upstream dt files, but now that all the dependencies are in place f

[Freedreno] [PATCH 3/4] drm/msm: drop quirks binding

2017-01-30 Thread Rob Clark
This was never documented or used in upstream dtb. It is used by downstream bindings from android device kernels. But the quirks are a property of the gpu revision, and as such are redundant to be listed separately in dt. Instead, move the quirks to the device table. Signed-off-by: Rob Clark -

[Freedreno] [PATCH 2/4] drm/msm: drop qcom,chipid

2017-01-30 Thread Rob Clark
The original way we determined the gpu version was based on downstream bindings from android kernel. A cleaner way is to get the version from the compatible string. Note that no upstream dtb uses these bindings. But the code still supports falling back to the legacy bindings (with a warning), so

[Freedreno] [PATCH 1/4] drm/msm: remove qcom, gpu-pwrlevels bindings

2017-01-30 Thread Rob Clark
The plan is to use the OPP bindings. For now, remove the documentation for qcom,gpu-pwrlevels, and make the driver fall back to a safe low clock if the node is not present. Note that no upstream dtb use this node. For now we keep compatibility with this node to avoid breaking compatibility with

[Freedreno] [PATCH 4/4] drm/msm: drop _clk suffix from clk names

2017-01-30 Thread Rob Clark
Suggested by Rob Herring. We still support the old names for compatibility with downstream android dt files. Cc: Rob Herring Signed-off-by: Rob Clark --- Documentation/devicetree/bindings/display/msm/gpu.txt | 12 ++-- drivers/gpu/drm/msm/msm_drv.c | 19