Re: [Freedreno] [RFC PATCH 03/13] drm/msm/disp/dpu1: Add support for DSC

2021-05-27 Thread Dmitry Baryshkov
On 21/05/2021 15:49, Vinod Koul wrote: Display Stream Compression (DSC) is one of the hw blocks in dpu, so add support by adding hw blocks for DSC Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/Makefile | 1 + .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 26 +++

Re: [Freedreno] [RFC PATCH 03/13] drm/msm/dsi: add support for dsc data

2021-05-27 Thread Dmitry Baryshkov
On 21/05/2021 15:49, Vinod Koul wrote: DSC needs some configuration from device tree, add support to read and store these params and add DSC structures in msm_drv Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi_host.c | 170 +

Re: [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support

2021-05-27 Thread Rob Clark
On Wed, May 26, 2021 at 8:00 AM Jeffrey Hugo wrote: > > On Tue, May 25, 2021 at 11:46 PM Vinod Koul wrote: > > > > Hello Jeff, > > > > On 21-05-21, 08:09, Jeffrey Hugo wrote: > > > On Fri, May 21, 2021 at 6:50 AM Vinod Koul wrote: > > > > > > > > Display Stream Compression (DSC) compresses the

Re: [Freedreno] [v1] drm/msm/disp/dpu1: avoid perf update in frame done event

2021-05-27 Thread Doug Anderson
Hi, On Wed, May 26, 2021 at 10:08 PM Krishna Manikandan wrote: > > Crtc perf update from frame event work can result in > wrong bandwidth and clock update from dpu if the work > is scheduled after the swap state has happened. > > Avoid such issues by moving perf update to complete > commit once

Re: [Freedreno] [PATCH] drm/msm: fix display snapshotting if DP or DSI is disabled

2021-05-27 Thread abhinavk
On 2021-05-27 15:03, Dmitry Baryshkov wrote: Fix following warnings generated when either DP or DSI support is disabled: drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c:141:3: error: implicit declaration of function 'msm_dp_snapshot'; did you mean 'msm_dsi_snapshot'?

[Freedreno] [PATCH] drm/msm: fix display snapshotting if DP or DSI is disabled

2021-05-27 Thread Dmitry Baryshkov
Fix following warnings generated when either DP or DSI support is disabled: drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c:141:3: error: implicit declaration of function 'msm_dp_snapshot'; did you mean 'msm_dsi_snapshot'? [-Werror=implicit-function-declaration]

Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-05-27 Thread Doug Anderson
Hi, On Thu, May 27, 2021 at 5:21 AM wrote: > > >> @@ -171,6 +172,19 @@ struct panel_desc { > >> > >> /** @connector_type: LVDS, eDP, DSI, DPI, etc. */ > >> int connector_type; > >> + > >> + /** > >> +* @uses_dpcd_backlight: Panel supports eDP dpcd backlight > >>

Re: [Freedreno] [PATCH] drm/msm/dp: keep aux channel up when power of dp phy

2021-05-27 Thread khsieh
On 2021-05-26 21:29, Stephen Boyd wrote: General note, please Cc dri-devel on freedreno driver patches. Quoting Kuogee Hsieh (2021-05-26 16:49:49) Aux channel is used to perform management function and should be running in parallel with main link. Therefore should only power down main link and

Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-05-27 Thread rajeevny
Hi, On 25-05-2021 22:48, Doug Anderson wrote: Hi, On Tue, May 25, 2021 at 12:31 AM Rajeev Nandan wrote: @@ -171,6 +172,19 @@ struct panel_desc { /** @connector_type: LVDS, eDP, DSI, DPI, etc. */ int connector_type; + + /** +* @uses_dpcd_backlight: Panel