Re: [Freedreno] [PATCH v6 3/5] arm64: dts: qcom: sm7180: remove assigned-clock-rate property for mdp clk

2022-03-17 Thread Doug Anderson
Hi, On Mon, Mar 14, 2022 at 7:47 AM Vinod Polimera wrote: > > Drop the assigned clock rate property and vote on the mdp clock as per > calculated value during the usecase. > > This patch is dependent on below patch > https://patchwork.kernel.org/patch/12774067/ > > Signed-off-by: Vinod Polimera

Re: [Freedreno] [PATCH v6 2/5] arm64: dts: qcom: sm7280: remove assigned-clock-rate property for mdp clk

2022-03-17 Thread Doug Anderson
Hi, On Mon, Mar 14, 2022 at 7:47 AM Vinod Polimera wrote: > > Drop the assigned clock rate property and vote on the mdp clock as per > calculated value during the usecase. > > This patch is dependent on below patch > https://patchwork.kernel.org/patch/12774067/ Some nits on how you're referring

Re: [Freedreno] [PATCH v6 1/5] drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table during probe

2022-03-17 Thread Doug Anderson
Hi, On Mon, Mar 14, 2022 at 7:47 AM Vinod Polimera wrote: > > use max clock during probe/bind sequence from the opp table. > The clock will be scaled down when framework sends an update. > > Fixes: 25fdd5933("drm/msm: Add SDM845 DPU support") The "Fixes:" format is a little wrong. Should have

Re: [Freedreno] [PATCH v5 4/9] drm/panel-edp: add LQ140M1JW46 edp panel entry

2022-03-17 Thread Doug Anderson
Hi, On Wed, Mar 16, 2022 at 10:37 AM Sankeerth Billakanti wrote: > > Add panel identification entry for the sharp LQ140M1JW46 eDP panel > with power sequencing delay information. > > Signed-off-by: Sankeerth Billakanti > --- > drivers/gpu/drm/panel/panel-edp.c | 1 + > 1 file changed, 1

Re: [Freedreno] [PATCH v5 1/5] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk

2022-03-14 Thread Doug Anderson
Hi, On Fri, Mar 11, 2022 at 1:22 AM Dmitry Baryshkov wrote: > > On Fri, 11 Mar 2022 at 11:06, Vinod Polimera > wrote: > > > > > > > > > -Original Message- > > > From: Stephen Boyd > > > Sent: Wednesday, March 9, 2022 1:36 AM > > > To: quic_vpolimer ; > > > devicet...@vger.kernel.org;

Re: [Freedreno] [PATCH v5 5/5] drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table during probe

2022-03-09 Thread Doug Anderson
Hi, On Tue, Mar 8, 2022 at 8:55 AM Vinod Polimera wrote: > > use max clock during probe/bind sequence from the opp table. > The clock will be scaled down when framework sends an update. > > Signed-off-by: Vinod Polimera > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 +++ > 1 file changed,

Re: [Freedreno] [PATCH v4 4/4] arm64/dts/qcom/sm8250: remove assigned-clock-rate property for mdp clk

2022-03-04 Thread Doug Anderson
Hi, On Thu, Mar 3, 2022 at 4:16 PM Dmitry Baryshkov wrote: > > On Fri, 4 Mar 2022 at 02:56, Stephen Boyd wrote: > > > > Quoting Dmitry Baryshkov (2022-03-03 15:50:50) > > > On Thu, 3 Mar 2022 at 12:40, Vinod Polimera > > > wrote: > > > > > > > > Kernel clock driver assumes that initial rate

Re: [Freedreno] [PATCH v4 1/4] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Doug Anderson
Hi, On Thu, Mar 3, 2022 at 1:40 AM Vinod Polimera wrote: > > Kernel clock driver assumes that initial rate is the > max rate for that clock and was not allowing it to scale > beyond the assigned clock value. > > Drop the assigned clock rate property and vote on the mdp clock as per > calculated

Re: [Freedreno] [v1] arm64/dts/qcom/sc7280: update mdp clk to max supported value to support higher refresh rates

2022-02-22 Thread Doug Anderson
Hi, On Tue, Feb 22, 2022 at 1:46 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2022-02-22 13:25:05) > > Hi, > > > > On Tue, Feb 22, 2022 at 12:58 PM Stephen Boyd wrote: > > > > > > Quoting Vinod Polimera (2022-02-21 05:12:06) > > > > P

Re: [Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-02-22 Thread Doug Anderson
Hi, On Tue, Feb 22, 2022 at 1:23 PM Dmitry Baryshkov wrote: > > On 22/02/2022 22:25, Doug Anderson wrote: > > Hi, > > > > On Mon, Feb 21, 2022 at 7:12 PM Dmitry Baryshkov > > wrote: > >> > >>> +static int dp_link_psr_status(struct dp_lin

Re: [Freedreno] [v1] arm64/dts/qcom/sc7280: update mdp clk to max supported value to support higher refresh rates

2022-02-22 Thread Doug Anderson
Hi, On Tue, Feb 22, 2022 at 12:58 PM Stephen Boyd wrote: > > Quoting Vinod Polimera (2022-02-21 05:12:06) > > Panels with higher refresh rate will need mdp clk above 300Mhz. > > Select max frequency for mdp clock during bootup, dpu driver will > > scale down the clock as per usecase when first

Re: [Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-02-22 Thread Doug Anderson
Hi, On Mon, Feb 21, 2022 at 7:12 PM Dmitry Baryshkov wrote: > > > +static int dp_link_psr_status(struct dp_link_private *link) > > +{ > > + u8 status[2]; > > + > > + drm_dp_dpcd_read(link->aux, DP_PSR_ERROR_STATUS, status, 2); > > + > > + if (status[0] & DP_PSR_LINK_CRC_ERROR)

Re: [Freedreno] [PATCH v4 5/5] drm/msm/dp: Add driver support to utilize drm panel

2022-02-18 Thread Doug Anderson
Hi, On Thu, Feb 10, 2022 at 3:58 AM Sankeerth Billakanti wrote: > > Add support in the DP driver to utilize the custom eDP panels > from drm/panels. > > An eDP panel is always connected to the platform. So, the eDP > connector can be reported as always connected. The display mode > will be

Re: [Freedreno] [PATCH v4 2/5] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-02-18 Thread Doug Anderson
Hi, On Thu, Feb 10, 2022 at 4:04 PM Bjorn Andersson wrote: > > > +_edp { > > + status = "okay"; > > + > > + vdda-1p2-supply = <_l6b_1p2>; > > + vdda-0p9-supply = <_l10c_0p8>; > > + /delete-property/ pinctrl-names; > > + /delete-property/ pinctrl-0; > > If the first device to

Re: [Freedreno] [PATCH v4 2/5] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-02-17 Thread Doug Anderson
Hi, On Thu, Feb 10, 2022 at 3:58 AM Sankeerth Billakanti wrote: > > + backlight_3v3_regulator: backlight-3v3-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "backlight_3v3_regulator"; > + > + regulator-min-microvolt =

Re: [Freedreno] [PATCH v4 2/5] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-02-17 Thread Doug Anderson
Hi, On Thu, Feb 10, 2022 at 3:58 AM Sankeerth Billakanti wrote: > > +_gpios { > + edp_bl_power: edp-bl-power { > + pins = "gpio7"; > + function = "normal"; > + qcom,drive-strength = ; As far as I can tell you're lacking: #include ...which is

Re: [Freedreno] [PATCH v4 4/5] drm/panel-edp: Add eDP sharp panel support

2022-02-16 Thread Doug Anderson
Hi, On Wed, Feb 16, 2022 at 11:29 AM Doug Anderson wrote: > > Hi, > > On Thu, Feb 10, 2022 at 3:58 AM Sankeerth Billakanti > wrote: > > > > Add support for the 14" sharp,lq140m1jw46 eDP panel. > > > > Signed-off-by: Sankeerth Billakanti > > --

Re: [Freedreno] [PATCH v4 1/5] dt-bindings: display: simple: Add sharp LQ140M1JW46 panel

2022-02-16 Thread Doug Anderson
Hi, On Wed, Feb 16, 2022 at 11:26 AM Doug Anderson wrote: > > Hi, > > On Thu, Feb 10, 2022 at 3:58 AM Sankeerth Billakanti > wrote: > > > > Add support for sharp LQ140M1JW46 display panel. It is a 14" eDP panel > > with 1920x1080 display resolution. >

Re: [Freedreno] [PATCH v4 4/5] drm/panel-edp: Add eDP sharp panel support

2022-02-16 Thread Doug Anderson
Hi, On Thu, Feb 10, 2022 at 3:58 AM Sankeerth Billakanti wrote: > > Add support for the 14" sharp,lq140m1jw46 eDP panel. > > Signed-off-by: Sankeerth Billakanti > --- > 00 ff ff ff ff ff ff 00 4d 10 23 15 00 00 00 00 > 35 1e 01 04 a5 1f 11 78 07 de 50 a3 54 4c 99 26 > 0f 50 54 00 00 00 01 01 01

Re: [Freedreno] [PATCH v4 1/5] dt-bindings: display: simple: Add sharp LQ140M1JW46 panel

2022-02-16 Thread Doug Anderson
Hi, On Thu, Feb 10, 2022 at 3:58 AM Sankeerth Billakanti wrote: > > Add support for sharp LQ140M1JW46 display panel. It is a 14" eDP panel > with 1920x1080 display resolution. > > Signed-off-by: Sankeerth Billakanti > Acked-by: Rob Herring > Reviewed-by: Stephen Boyd > --- > > Changes in v4:

Re: [Freedreno] [PATCH v1 0/3] Add support for eDP PHY on SC7280 platform

2022-02-07 Thread Doug Anderson
Hi, On Wed, Feb 2, 2022 at 1:54 PM Stephen Boyd wrote: > > Quoting Sankeerth Billakanti (2021-11-15 23:07:35) > > This series adds support for the eDP PHY on Qualcomm SC7280 platform. > > The changes are dependent on v4 of the new eDP PHY driver introduced by > > Bjorn: > >

Re: [Freedreno] [PATCH v1 1/2] ARM64: dts: qcom: enable eDP panel support for sc7280

2022-02-02 Thread Doug Anderson
Hi, On Mon, Jan 24, 2022 at 11:04 AM Doug Anderson wrote: > > > +_edp { > > + status = "okay"; > > + > > + vdda-1p2-supply = <_l6b_1p2>; > > + vdda-0p9-supply = <_l10c_0p8>; > > + > > + ports

Re: [Freedreno] [PATCH v1 2/2] drm/panel-edp: Add sharp panel support for sc7280

2022-01-24 Thread Doug Anderson
Hi, On Mon, Jan 24, 2022 at 10:16 AM Sankeerth Billakanti wrote: > > Add eDP panel support for sc7280 CRD platform. > > Signed-off-by: Sankeerth Billakanti > --- > drivers/gpu/drm/panel/panel-edp.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git

Re: [Freedreno] [PATCH v1 1/2] ARM64: dts: qcom: enable eDP panel support for sc7280

2022-01-24 Thread Doug Anderson
Hi, On Mon, Jan 24, 2022 at 10:15 AM Sankeerth Billakanti wrote: > > Enable the eDP display panel support with backlight on sc7280 platform. > > Signed-off-by: Sankeerth Billakanti > --- > arch/arm64/boot/dts/qcom/sc7280-crd.dts | 127 > > 1 file changed, 127

Re: [Freedreno] [PATCH 2/2] drm/msm/gpu: Respect PM QoS constraints

2021-11-19 Thread Doug Anderson
Hi, On Fri, Nov 19, 2021 at 2:47 PM Rob Clark wrote: > > +void msm_devfreq_boost(struct msm_gpu *gpu, unsigned factor) > +{ > + struct msm_gpu_devfreq *df = >devfreq; > + unsigned long freq; > + > + freq = get_freq(gpu); > + freq *= factor; > + freq /= HZ_PER_KHZ;

Re: [Freedreno] [PATCH 1/2] drm/msm/gpu: Fix idle_work time

2021-11-19 Thread Doug Anderson
Hi, On Fri, Nov 19, 2021 at 2:47 PM Rob Clark wrote: > > From: Rob Clark > > This was supposed to be a relative timer, not absolute. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gpu_devfreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Douglas

Re: [Freedreno] [PATCH 2/2] drm/msm/gpu: Respect PM QoS constraints

2021-11-05 Thread Doug Anderson
Hi, On Wed, Nov 3, 2021 at 1:59 PM Rob Clark wrote: > > From: Rob Clark > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gpu_devfreq.c | 31 +-- > 1 file changed, 29 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c >

Re: [Freedreno] [PATCH v2] drm/msm/devfreq: Fix OPP refcnt leak

2021-11-05 Thread Doug Anderson
Hi, On Fri, Nov 5, 2021 at 1:15 PM Rob Clark wrote: > > From: Rob Clark > > Reported-by: Douglas Anderson > Fixes: 9bc95570175a ("drm/msm: Devfreq tuning") > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gpu_devfreq.c | 5 + > 1 file changed, 5 insertions(+) Reviewed-by:

Re: [Freedreno] [PATCH] drm/msm/devfreq: Fix OPP refcnt leak

2021-11-05 Thread Doug Anderson
Hi, On Thu, Nov 4, 2021 at 9:32 PM Steev Klimaszewski wrote: > > > On 11/4/21 5:28 PM, Rob Clark wrote: > > From: Rob Clark > > > > Reported-by: Douglas Anderson > > Fixes: 9bc95570175a ("drm/msm: Devfreq tuning") > > Signed-off-by: Rob Clark > > --- > >

Re: [Freedreno] [PATCH] drm/msm/devfreq: Fix OPP refcnt leak

2021-11-04 Thread Doug Anderson
Hi, On Thu, Nov 4, 2021 at 3:23 PM Rob Clark wrote: > > From: Rob Clark > > Reported-by: Douglas Anderson > Fixes: 9bc95570175a ("drm/msm: Devfreq tuning") > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gpu_devfreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [Freedreno] [PATCH] drm/msm/dsi: set default num_data_lanes

2021-11-01 Thread Doug Anderson
Hi, On Sat, Oct 30, 2021 at 10:08 AM Philip Chen wrote: > > If "data_lanes" property of the dsi output endpoint is missing in > the DT, num_data_lanes would be 0 by default, which could cause > dsi_host_attach() to fail if dsi->lanes is set to a non-zero value > by the bridge driver. > >

Re: [Freedreno] [PATCH v2 2/2] dt-bindings: Add SC7280 compatible string

2021-10-20 Thread Doug Anderson
Hi, On Wed, Oct 20, 2021 at 5:14 AM Sankeerth Billakanti wrote: > > From: Sankeerth Billakanti > > The Qualcomm SC7280 platform supports an eDP controller, add > compatible string for it to dp-controller. > > Signed-off-by: Sankeerth Billakanti > --- >

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-06 Thread Doug Anderson
Hi, On Tue, Oct 5, 2021 at 7:27 PM Bjorn Andersson wrote: > > > > For reference, this is how I thought one is supposed to tie the Type-C > > > controller to the display driver: > > > https://lore.kernel.org/all/20211005022451.2037405-1-bjorn.anders...@linaro.org/ > > > > OK, so I looked at that

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-05 Thread Doug Anderson
Hi, On Tue, Oct 5, 2021 at 10:33 AM Bjorn Andersson wrote: > > On Tue 05 Oct 08:39 PDT 2021, Doug Anderson wrote: > > > Hi, > > > > On Mon, Oct 4, 2021 at 6:09 PM Bjorn Andersson > > wrote: > > > > > > On Mon 04 Oct 17:36 PDT 2021, Doug Ander

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-05 Thread Doug Anderson
Hi, On Mon, Oct 4, 2021 at 6:09 PM Bjorn Andersson wrote: > > On Mon 04 Oct 17:36 PDT 2021, Doug Anderson wrote: > > > Hi, > > > > On Fri, Oct 1, 2021 at 2:00 PM Bjorn Andersson > > wrote: > > > > > > On Fri 27 Aug 13:52 PDT 2021, Doug Ander

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-04 Thread Doug Anderson
Hi, On Fri, Oct 1, 2021 at 2:00 PM Bjorn Andersson wrote: > > On Fri 27 Aug 13:52 PDT 2021, Doug Anderson wrote: > > > Hi, > > > > On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson > > wrote: > > > > > > +static int dp_parser_find_panel(stru

Re: [Freedreno] [PATCH v2 2/3] drm/bridge: ti-sn65dsi86: Implement bridge->mode_valid()

2021-10-01 Thread Doug Anderson
Hi, On Wed, Sep 22, 2021 at 5:31 PM Laurent Pinchart wrote: > > Hi Rob, > > Thank you for the patch. > > On Mon, Sep 20, 2021 at 03:57:59PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > For the brave new world of bridges not creating their own connectors, we > > need to implement the max

Re: [Freedreno] [PATCH v2 3/3] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support

2021-10-01 Thread Doug Anderson
Hi, On Thu, Sep 23, 2021 at 7:26 PM Laurent Pinchart wrote: > > > > > err_conn_init: > > > > drm_dp_aux_unregister(>aux); > > > > return ret; > > > > @@ -792,9 +790,30 @@ static void ti_sn_bridge_set_dsi_rate(struct > > > > ti_sn65dsi86 *pdata) > > > >

Re: [Freedreno] [PATCH v2 3/5] drm/msm/dp: Support up to 3 DP controllers

2021-10-01 Thread Doug Anderson
Hi, On Thu, Aug 26, 2021 at 10:20 PM Stephen Boyd wrote: > > Quoting Bjorn Andersson (2021-08-25 16:42:31) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > > b/drivers/gpu/drm/msm/dp/dp_display.c > > index 2c7de43f655a..4a6132c18e57 100644 > > --- a/drivers/gpu/drm/msm/dp/dp_display.c > >

Re: [Freedreno] [PATCH v2 3/3] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support

2021-09-21 Thread Doug Anderson
Hi, On Mon, Sep 20, 2021 at 3:53 PM Rob Clark wrote: > > From: Rob Clark > > Slightly awkward to fish out the display_info when we aren't creating > own connector. But I don't see an obvious better way. > > v2: Remove error return with NO_CONNECTOR flag > > Signed-off-by: Rob Clark > --- >

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-08-30 Thread Doug Anderson
Hi, On Sat, Aug 28, 2021 at 7:40 AM Bjorn Andersson wrote: > > On Fri 27 Aug 15:52 CDT 2021, Doug Anderson wrote: > > > Hi, > > > > On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson > > wrote: > > > > > > +static int dp_parser_find_panel(stru

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-08-27 Thread Doug Anderson
Hi, On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson wrote: > > +static int dp_parser_find_panel(struct dp_parser *parser) > +{ > + struct device_node *np = parser->pdev->dev.of_node; > + int rc; > + > + rc = drm_of_find_panel_or_bridge(np, 2, 0, >drm_panel, NULL); Why port 2?

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-08-26 Thread Doug Anderson
Hi, On Wed, Aug 25, 2021 at 6:31 PM Stephen Boyd wrote: > > Quoting Bjorn Andersson (2021-07-26 16:13:51) > > eDP panels might need some power sequencing and backlight management, > > so make it possible to associate a drm_panel with a DP instance and > > prepare and enable the panel

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-08-26 Thread Doug Anderson
Hi, On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson wrote: > > +static int dp_parser_find_panel(struct dp_parser *parser) > +{ > + struct device_node *np = parser->pdev->dev.of_node; > + int rc; > + > + rc = drm_of_find_panel_or_bridge(np, 2, 0, >drm_panel, NULL); > + if

Re: [Freedreno] [PATCH v1 2/2] dt-bindings: Add SC7280 compatible string

2021-08-24 Thread Doug Anderson
Hi, On Wed, Aug 11, 2021 at 5:08 PM Sankeerth Billakanti wrote: > > The Qualcomm SC7280 platform supports an eDP controller, add > compatible string for it to msm/binding. > > Signed-off-by: Sankeerth Billakanti > --- > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 3 +++ >

Re: [Freedreno] [PATCH 4/4] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support

2021-08-12 Thread Doug Anderson
Laurent, On Thu, Aug 12, 2021 at 12:26 PM Laurent Pinchart wrote: > > Hi Rob, > > Thank you for the patch. > > On Wed, Aug 11, 2021 at 04:52:50PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > Slightly awkward to fish out the display_info when we aren't creating > > own connector. But I

Re: [Freedreno] [PATCH 4/4] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support

2021-08-12 Thread Doug Anderson
Hi, On Wed, Aug 11, 2021 at 4:51 PM Rob Clark wrote: > > From: Rob Clark > > Slightly awkward to fish out the display_info when we aren't creating > own connector. But I don't see an obvious better way. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 34

Re: [Freedreno] [PATCH 3/4] drm/bridge: ti-sn65dsi86: Implement bridge->mode_valid()

2021-08-12 Thread Doug Anderson
Hi, On Wed, Aug 11, 2021 at 4:51 PM Rob Clark wrote: > > From: Rob Clark > > For the brave new world of bridges not creating their own connectors, we > need to implement the max clock limitation via bridge->mode_valid() > instead of connector->mode_valid(). > > Signed-off-by: Rob Clark > --- >

Re: [Freedreno] [PATCH 1/4] drm/bridge: ti-sn65dsi86: Avoid creating multiple connectors

2021-08-12 Thread Doug Anderson
Hi, On Wed, Aug 11, 2021 at 4:51 PM Rob Clark wrote: > > From: Rob Clark > > If we created our own connector because the driver does not support the > NO_CONNECTOR flag, we don't want the downstream bridge to *also* create > a connector. And if this driver did pass the NO_CONNECTOR flag (and

Re: [Freedreno] [v8 1/6] drm/panel: add basic DP AUX backlight support

2021-07-12 Thread Doug Anderson
Hi, On Mon, Jul 12, 2021 at 6:39 AM Doug Anderson wrote: > > Hi, > > On Mon, Jul 12, 2021 at 2:41 AM Thomas Zimmermann wrote: > > > > > + ret = drm_dp_dpcd_read(aux, DP_EDP_DPCD_REV, edp_dpcd, > > > +EDP_DISPLAY_CTL_CAP_

Re: [Freedreno] [v8 1/6] drm/panel: add basic DP AUX backlight support

2021-07-12 Thread Doug Anderson
Hi, On Mon, Jul 12, 2021 at 2:41 AM Thomas Zimmermann wrote: > > > + ret = drm_dp_dpcd_read(aux, DP_EDP_DPCD_REV, edp_dpcd, > > +EDP_DISPLAY_CTL_CAP_SIZE); > > This creates a cyclic dependency between drm_kms_helper-ko and drm.ko. > drm_panel.c is in the latter,

Re: [Freedreno] [v8 0/6] drm: Support basic DPCD backlight in panel-simple and add a new panel ATNA33XC20

2021-07-09 Thread Doug Anderson
Hi, On Fri, Jul 9, 2021 at 1:41 PM Ville Syrjälä wrote: > > On Fri, Jul 09, 2021 at 06:54:05AM -0700, Doug Anderson wrote: > > Hi, > > > > On Sat, Jun 26, 2021 at 9:52 AM Rajeev Nandan > > wrote: > > > > > > This series adds the su

Re: [Freedreno] [v8 0/6] drm: Support basic DPCD backlight in panel-simple and add a new panel ATNA33XC20

2021-07-09 Thread Doug Anderson
Hi, On Sat, Jun 26, 2021 at 9:52 AM Rajeev Nandan wrote: > > This series adds the support for the eDP panel that needs the backlight > controlling over the DP AUX channel using DPCD registers of the panel > as per the VESA's standard. > > This series also adds support for the Samsung eDP AMOLED

Re: [Freedreno] [v8 4/6] drm/panel-simple: Update validation warnings for eDP panel description

2021-06-28 Thread Doug Anderson
Hi, On Mon, Jun 28, 2021 at 6:33 AM Laurent Pinchart wrote: > > Hi Rajeev, > > On Mon, Jun 28, 2021 at 05:46:24PM +0530, rajee...@codeaurora.org wrote: > > On 27-06-2021 23:48, Laurent Pinchart wrote: > > > On Sat, Jun 26, 2021 at 10:21:06PM +0530, Rajeev Nandan wrote: > > >> Do not give a

Re: [Freedreno] [v7 1/5] drm/panel: add basic DP AUX backlight support

2021-06-22 Thread Doug Anderson
Hi, On Mon, Jun 21, 2021 at 11:38 AM Sam Ravnborg wrote: > > > > I cannot see why you need the extra check on ->enabled? > > > Would it be sufficient to check backlight_is_blank() only? > > > > This extra check on bl->enabled flag is added to avoid enabling/disabling > > backlight again if it is

Re: [Freedreno] [v7 5/5] drm/panel-simple: Add Samsung ATNA33XC20

2021-06-22 Thread Doug Anderson
Hi, On Mon, Jun 21, 2021 at 11:42 AM Sam Ravnborg wrote: > > Hi Doug, > > On Mon, Jun 21, 2021 at 08:34:51AM -0700, Doug Anderson wrote: > > Hi, > > > > On Sun, Jun 20, 2021 at 3:01 AM Sam Ravnborg wrote: > > > > > > Hi Rajeev > > > On S

Re: [Freedreno] [v7 5/5] drm/panel-simple: Add Samsung ATNA33XC20

2021-06-21 Thread Doug Anderson
Hi, On Sun, Jun 20, 2021 at 3:01 AM Sam Ravnborg wrote: > > Hi Rajeev > On Sat, Jun 19, 2021 at 04:10:30PM +0530, Rajeev Nandan wrote: > > Add Samsung 13.3" FHD eDP AMOLED panel. > > > > Signed-off-by: Rajeev Nandan > > Reviewed-by: Douglas Anderson > > --- > > > > Changes in v4: > > - New > >

Re: [Freedreno] [v6 5/5] drm/panel-simple: Add Samsung ATNA33XC20

2021-06-16 Thread Doug Anderson
Hi, On Sat, Jun 12, 2021 at 5:09 AM Rajeev Nandan wrote: > > +static const struct panel_desc samsung_atna33xc20 = { > + .modes = _atna33xc20_mode, > + .num_modes = 1, > + .bpc = 10, > + .size = { > + .width = 294, > + .height = 165, > +

Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-06-08 Thread Doug Anderson
Lyude, On Tue, Jun 1, 2021 at 3:20 PM Lyude Paul wrote: > > oh-looks like my patches just got reviewed, so hopefully I should get a chance > to get a look at this in the next day or two :) I'm going to assume that means that you don't need extra eyes on your backlight patches. If you do, please

Re: [Freedreno] [v5 2/5] drm/panel-simple: Support DP AUX backlight

2021-06-02 Thread Doug Anderson
Hi, On Sun, May 30, 2021 at 8:57 AM Rajeev Nandan wrote: > > If there is no backlight specified in the device tree and the panel > has access to the DP AUX channel then create a DP AUX backlight if > supported by the panel. > > Signed-off-by: Rajeev Nandan > --- > > This patch depends on [1]

Re: [Freedreno] [v5 3/5] drm/panel-simple: Support for delays between GPIO & regulator

2021-06-02 Thread Doug Anderson
Hi, On Sun, May 30, 2021 at 8:57 AM Rajeev Nandan wrote: > > Some panels datasheets may specify a delay between the enable GPIO and > the regulator. Support this in panel-simple. > > Signed-off-by: Rajeev Nandan > --- > > Changes in v4: > - New > > Changes in v5: > - Update description

Re: [Freedreno] [v5 1/5] drm/panel: add basic DP AUX backlight support

2021-06-02 Thread Doug Anderson
Hi, On Sun, May 30, 2021 at 8:57 AM Rajeev Nandan wrote: > > +static int dp_aux_backlight_update_status(struct backlight_device *bd) > +{ > + struct dp_aux_backlight *bl = bl_get_data(bd); > + u16 brightness = backlight_get_brightness(bd); > + int ret = 0; > + > + if

Re: [Freedreno] [v1] drm/msm/disp/dpu1: avoid perf update in frame done event

2021-05-27 Thread Doug Anderson
Hi, On Wed, May 26, 2021 at 10:08 PM Krishna Manikandan wrote: > > Crtc perf update from frame event work can result in > wrong bandwidth and clock update from dpu if the work > is scheduled after the swap state has happened. > > Avoid such issues by moving perf update to complete > commit once

Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-05-27 Thread Doug Anderson
Hi, On Thu, May 27, 2021 at 5:21 AM wrote: > > >> @@ -171,6 +172,19 @@ struct panel_desc { > >> > >> /** @connector_type: LVDS, eDP, DSI, DPI, etc. */ > >> int connector_type; > >> + > >> + /** > >> +* @uses_dpcd_backlight: Panel supports eDP dpcd backlight > >>

Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-05-25 Thread Doug Anderson
Hi, On Tue, May 25, 2021 at 12:31 AM Rajeev Nandan wrote: > > @@ -171,6 +172,19 @@ struct panel_desc { > > /** @connector_type: LVDS, eDP, DSI, DPI, etc. */ > int connector_type; > + > + /** > +* @uses_dpcd_backlight: Panel supports eDP dpcd backlight control. > +

Re: [Freedreno] [v4 3/4] dt-bindings: display: simple: Add Samsung ATNA33XC20

2021-05-25 Thread Doug Anderson
Hi, On Tue, May 25, 2021 at 12:31 AM Rajeev Nandan wrote: > > Add Samsung 13.3" FHD eDP AMOLED panel. > > Signed-off-by: Rajeev Nandan > --- > > Changes in v4: > - New > > Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [Freedreno] [v4 4/4] drm/panel-simple: Add Samsung ATNA33XC20

2021-05-25 Thread Doug Anderson
Hi, On Tue, May 25, 2021 at 12:31 AM Rajeev Nandan wrote: > > Add Samsung 13.3" FHD eDP AMOLED panel. > > Signed-off-by: Rajeev Nandan > --- > > Changes in v4: > - New > > drivers/gpu/drm/panel/panel-simple.c | 34 ++ > 1 file changed, 34 insertions(+) > > diff

Re: [Freedreno] [v4 2/4] drm/panel-simple: Support for delays between GPIO & regulator

2021-05-25 Thread Doug Anderson
Hi, On Tue, May 25, 2021 at 12:31 AM Rajeev Nandan wrote: > > Some panels datasheets may specify a delay between the enable GPIO and > the regulator. Support this in panel-simple. > > Signed-off-by: Rajeev Nandan > --- > > Changes in v4: > - New > > drivers/gpu/drm/panel/panel-simple.c | 23

Re: [Freedreno] [PATCH v2] drm/msm: Use nvmem_cell_read_variable_le_u32() to read speed bin

2021-05-21 Thread Doug Anderson
Hi, On Fri, May 21, 2021 at 3:02 PM Stephen Boyd wrote: > > Quoting Douglas Anderson (2021-05-21 13:45:50) > > Let's use the newly-added nvmem_cell_read_variable_le_u32() to future > > proof ourselves a little bit. > > > > Signed-off-by: Douglas Anderson > > --- > > The patch that this depends

Re: [Freedreno] [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight

2021-05-17 Thread Doug Anderson
Hi, On Tue, May 11, 2021 at 4:17 PM Doug Anderson wrote: > > Hi, > > On Tue, May 11, 2021 at 11:12 AM wrote: > > > > On 01-05-2021 03:08, Doug Anderson wrote: > > > Hi, > > > > > > On Fri, Apr 30, 2021 at 8:10 AM wrote: > > >&g

Re: [Freedreno] [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight

2021-05-11 Thread Doug Anderson
Hi, On Tue, May 11, 2021 at 11:12 AM wrote: > > On 01-05-2021 03:08, Doug Anderson wrote: > > Hi, > > > > On Fri, Apr 30, 2021 at 8:10 AM wrote: > >> > >> On 30-04-2021 02:33, Doug Anderson wrote: > >> > Hi, > >&g

Re: [Freedreno] [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight

2021-04-30 Thread Doug Anderson
Hi, On Fri, Apr 30, 2021 at 8:10 AM wrote: > > On 30-04-2021 02:33, Doug Anderson wrote: > > Hi, > > > > On Thu, Apr 29, 2021 at 11:04 AM Rob Herring wrote: > >> > >> On Mon, Apr 26, 2021 at 11:29:15AM +0530, Rajeev Nandan wrote: > >>

Re: [Freedreno] [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight

2021-04-29 Thread Doug Anderson
Hi, On Thu, Apr 29, 2021 at 11:04 AM Rob Herring wrote: > > On Mon, Apr 26, 2021 at 11:29:15AM +0530, Rajeev Nandan wrote: > > Add bindings for DisplayPort aux backlight driver. > > > > Changes in v2: > > - New > > > > Signed-off-by: Rajeev Nandan > > --- > >

Re: [Freedreno] [v1 0/3] drm: Add support for backlight control of eDP panel on ti-sn65dsi86 bridge

2021-04-16 Thread Doug Anderson
Hi, On Wed, Apr 14, 2021 at 9:41 AM Rajeev Nandan wrote: > > The backlight level of an eDP panel can be controlled through the AUX > channel using DPCD registers of the panel. > > The capability for the Source device to adjust backlight characteristics > within the panel, using the Sink device

Re: [Freedreno] [PATCH v2] drm/msm: Drop mm_lock in scan loop

2021-04-02 Thread Doug Anderson
Hi, On Fri, Apr 2, 2021 at 2:08 PM Rob Clark wrote: > > From: Rob Clark > > lock_stat + mmm_donut[1] say that this reduces contention on mm_lock > significantly (~350x lower waittime-max, and ~100x lower waittime-avg) > > [1] >

Re: [Freedreno] [PATCH v2 3/4] drm/msm: Fix debugfs deadlock

2021-04-01 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 6:24 PM Rob Clark wrote: > > From: Rob Clark > > In normal cases the gem obj lock is acquired first before mm_lock. The > exception is iterating the various object lists. In the shrinker path, > deadlock is avoided by using msm_gem_trylock() and skipping over

Re: [Freedreno] [PATCH v2 2/4] drm/msm: Avoid mutex in shrinker_count()

2021-04-01 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 6:24 PM Rob Clark wrote: > > @@ -45,6 +30,9 @@ msm_gem_shrinker_scan(struct shrinker *shrinker, struct > shrink_control *sc) > list_for_each_entry(msm_obj, >inactive_dontneed, mm_list) { > if (freed >= sc->nr_to_scan) >

Re: [Freedreno] [PATCH v2 1/4] drm/msm: Remove unused freed llist node

2021-04-01 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 6:23 PM Rob Clark wrote: > > From: Rob Clark > > Unused since commit c951a9b284b9 ("drm/msm: Remove msm_gem_free_work") > > Signed-off-by: Rob Clark > Tested-by: Douglas Anderson > --- > drivers/gpu/drm/msm/msm_gem.h | 2 -- > 1 file changed, 2 deletions(-)

Re: [Freedreno] [PATCH 1/4] drm/msm: Remove unused freed llist node

2021-03-31 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote: > > From: Rob Clark > > Unused since c951a9b284b907604759628d273901064c60d09f Not terribly important, but checkpatch always yells at me when I don't reference commits by saying: commit c951a9b284b9 ("drm/msm: Remove msm_gem_free_work") >

Re: [Freedreno] [PATCH 0/4] drm/msm: Shrinker (and related) fixes

2021-03-31 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote: > > From: Rob Clark > > I've been spending some time looking into how things behave under high > memory pressure. The first patch is a random cleanup I noticed along > the way. The second improves the situation significantly when we are >

Re: [Freedreno] [PATCH 2/4] drm/msm: Avoid mutex in shrinker_count()

2021-03-31 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 4:23 PM Rob Clark wrote: > > On Wed, Mar 31, 2021 at 3:44 PM Doug Anderson wrote: > > > > Hi, > > > > On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote: > > > > > > @@ -818,11 +820,19 @@ static void updat

Re: [Freedreno] [PATCH 4/4] drm/msm: Improved debugfs gem stats

2021-03-31 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote: > > From: Rob Clark > > The last patch lost the breakdown of active vs inactive GEM objects in > $debugfs/gem. But we can add some better stats to summarize not just > active vs inactive, but also purgable/purged to make up for that. > >

Re: [Freedreno] [PATCH 3/4] drm/msm: Fix debugfs deadlock

2021-03-31 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote: > > @@ -111,23 +111,15 @@ static const struct file_operations msm_gpu_fops = { > static int msm_gem_show(struct drm_device *dev, struct seq_file *m) > { > struct msm_drm_private *priv = dev->dev_private; > - struct msm_gpu *gpu

Re: [Freedreno] [PATCH 2/4] drm/msm: Avoid mutex in shrinker_count()

2021-03-31 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote: > > @@ -818,11 +820,19 @@ static void update_inactive(struct msm_gem_object > *msm_obj) > mutex_lock(>mm_lock); > WARN_ON(msm_obj->active_count != 0); > > + if (msm_obj->dontneed) > +

Re: [Freedreno] [v1] drm/msm/disp/dpu1: fix warn stack reported during dpu resume

2021-03-31 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 4:27 AM Kalyan Thota wrote: > > @@ -294,6 +294,9 @@ static int dpu_kms_parse_data_bus_icc_path(struct dpu_kms > *dpu_kms) > struct icc_path *path1; > struct drm_device *dev = dpu_kms->dev; > > + if (!dpu_supports_bw_scaling(dev)) > +

Re: [Freedreno] [PATCH] drm/msm: Fix removal of valid error case when checking speed_bin

2021-03-30 Thread Doug Anderson
Hi, On Mon, Mar 29, 2021 at 6:34 PM John Stultz wrote: > > Commit 7bf168c8fe8c ("drm/msm: Fix speed-bin support not to > access outside valid memory"), reworked the nvmem reading of > "speed_bin", but in doing so dropped handling of the -ENOENT > case which was previously documented as "fine".

Re: [Freedreno] [v1] drm/msm/disp/dpu1: fix display underruns during modeset.

2021-03-19 Thread Doug Anderson
Hi, On Fri, Mar 19, 2021 at 5:54 AM Kalyan Thota wrote: > > During crtc disable, display perf structures are reset to 0 > which includes state varibles which are immutable. On crtc > enable, we use the same structures and they don't refelect > the actual values > > 1) Fix is to avoid updating

Re: [Freedreno] [PATCH] drm/msm: Ratelimit invalid-fence message

2021-03-17 Thread Doug Anderson
Hi, On Wed, Mar 17, 2021 at 9:40 AM Rob Clark wrote: > > From: Rob Clark > > We have seen a couple cases where low memory situations cause something > bad to happen, followed by a flood of these messages obscuring the root > cause. Lets ratelimit the dmesg spam so that next time it happens we

Re: [Freedreno] [PATCH 1/3] drm/msm: Fix speed-bin support not to access outside valid memory

2021-03-05 Thread Doug Anderson
Hi, On Fri, Mar 5, 2021 at 2:28 AM Srinivas Kandagatla wrote: > > > > On 27/02/2021 00:26, Douglas Anderson wrote: > > When running the latest kernel on an sc7180 with KASAN I got this > > splat: > >BUG: KASAN: slab-out-of-bounds in a6xx_gpu_init+0x618/0x644 > >Read of size 4 at addr

Re: [Freedreno] [PATCH 1/2] arm64: dts: qcom: sc7180: Add gpu cooling support

2020-10-09 Thread Doug Anderson
Hi, On Thu, Oct 8, 2020 at 10:10 AM Akhil P Oommen wrote: > > Add cooling-cells property and the cooling maps for the gpu tzones > to support GPU cooling. > > Signed-off-by: Akhil P Oommen > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 29 ++--- > 1 file changed, 22

Re: [Freedreno] [PATCH 10/20] dt-bindings: arm-smmu: Add compatible string for Adreno GPU SMMU

2020-08-19 Thread Doug Anderson
Hi, On Wed, Aug 19, 2020 at 10:36 AM Rob Clark wrote: > > On Wed, Aug 19, 2020 at 10:03 AM Doug Anderson wrote: > > > > Hi, > > > > On Mon, Aug 17, 2020 at 3:03 PM Rob Clark wrote: > > > > > > From: Jordan Crouse > > > > &g

Re: [Freedreno] [PATCH 10/20] dt-bindings: arm-smmu: Add compatible string for Adreno GPU SMMU

2020-08-19 Thread Doug Anderson
Hi, On Mon, Aug 17, 2020 at 3:03 PM Rob Clark wrote: > > From: Jordan Crouse > > Every Qcom Adreno GPU has an embedded SMMU for its own use. These > devices depend on unique features such as split pagetables, > different stall/halt requirements and other settings. Identify them > with a

Re: [Freedreno] [PATCH v2] drm: msm: a6xx: fix gpu failure after system resume

2020-07-17 Thread Doug Anderson
Hi, On Fri, Jul 17, 2020 at 1:24 PM Rob Clark wrote: > > On Fri, Jul 17, 2020 at 10:39 AM Doug Anderson wrote: > > > > Hi, > > > > On Fri, Jul 17, 2020 at 7:46 AM Jordan Crouse > > wrote: > > > > > > On Fri, Jul 17, 2020 at 08:04:18PM +05

Re: [Freedreno] [PATCH v2] drm: msm: a6xx: fix gpu failure after system resume

2020-07-17 Thread Doug Anderson
Hi, On Fri, Jul 17, 2020 at 7:46 AM Jordan Crouse wrote: > > On Fri, Jul 17, 2020 at 08:04:18PM +0530, Akhil P Oommen wrote: > > On targets where GMU is available, GMU takes over the ownership of GX GDSC > > during its initialization. So, move the refcount-get on GX PD before we > > initialize

Re: [Freedreno] [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-13 Thread Doug Anderson
Hi, On Mon, Jul 13, 2020 at 1:25 PM Rob Herring wrote: > > On Mon, Jul 13, 2020 at 9:08 AM Doug Anderson wrote: > > > > Hi, > > > > On Mon, Jul 13, 2020 at 7:11 AM Rob Herring wrote: > > > > > > On Fri, Jul 10, 2020 at 5:02 PM Douglas Anderson

Re: [Freedreno] [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-13 Thread Doug Anderson
Hi, On Mon, Jul 13, 2020 at 7:11 AM Rob Herring wrote: > > On Fri, Jul 10, 2020 at 5:02 PM Douglas Anderson > wrote: > > > > I found that if I ever had a little mistake in my kernel config, > > or device tree, or graphics driver that my system would sit in a loop > > at bootup trying again and

Re: [Freedreno] [v2] drm/msm/dpu: add support for dither block in display

2020-06-25 Thread Doug Anderson
Hi, On Thu, Jun 25, 2020 at 5:17 AM Kalyan Thota wrote: > > This change enables dither block for primary interface > in display. > > Enabled for 6bpc in the current version. > > Changes in v1: > - Remove redundant error checks (Rob). > > Signed-off-by: Kalyan Thota > --- >

Re: [Freedreno] [v3] drm/bridge: ti-sn65dsi86: ensure bridge suspend happens during PM sleep

2020-06-18 Thread Doug Anderson
Hi, On Tue, Jun 9, 2020 at 5:05 AM Harigovindan P wrote: > > ti-sn65dsi86 bridge is enumerated as a runtime device. When > suspend is triggered, PM core adds a refcount on all the > devices and calls device suspend, since usage count is > already incremented, runtime suspend will not be called >

Re: [Freedreno] [v3] drm/bridge: ti-sn65dsi86: ensure bridge suspend happens during PM sleep

2020-06-10 Thread Doug Anderson
Hi, On Tue, Jun 9, 2020 at 5:05 AM Harigovindan P wrote: > > ti-sn65dsi86 bridge is enumerated as a runtime device. When > suspend is triggered, PM core adds a refcount on all the > devices and calls device suspend, since usage count is > already incremented, runtime suspend will not be called >

Re: [Freedreno] [PATCH v6] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-06-04 Thread Doug Anderson
Hi, On Thu, Jun 4, 2020 at 6:20 AM Kalyan Thota wrote: > > -#ifdef CONFIG_PM > -static int msm_runtime_suspend(struct device *dev) > +#ifdef CONFIG_PM_SLEEP > +static int msm_pm_suspend(struct device *dev) > { > - struct drm_device *ddev = dev_get_drvdata(dev); > - struct

<    1   2   3   4   >