Re: [Freedreno] [v5 1/5] drm/panel: add basic DP AUX backlight support

2021-06-03 Thread rajeevny
On 03-06-2021 05:35, Doug Anderson wrote: Hi, On Sun, May 30, 2021 at 8:57 AM Rajeev Nandan wrote: Other than the two nits (ordering of memory allocation and word wrapping in a comment), this looks good to me. Feel free to add my Reviewed-by tag when you fix the nits. NOTE: Even though

Re: [Freedreno] [v5 1/5] drm/panel: add basic DP AUX backlight support

2021-06-02 Thread Doug Anderson
Hi, On Sun, May 30, 2021 at 8:57 AM Rajeev Nandan wrote: > > +static int dp_aux_backlight_update_status(struct backlight_device *bd) > +{ > + struct dp_aux_backlight *bl = bl_get_data(bd); > + u16 brightness = backlight_get_brightness(bd); > + int ret = 0; > + > + if

Re: [Freedreno] [v5 1/5] drm/panel: add basic DP AUX backlight support

2021-05-30 Thread kernel test robot
Hi Rajeev, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.13-rc3 next-20210528] [cannot apply to drm/drm-next] [If your patch

Re: [Freedreno] [v5 1/5] drm/panel: add basic DP AUX backlight support

2021-05-30 Thread kernel test robot
Hi Rajeev, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.13-rc3 next-20210528] [cannot apply to drm/drm-next] [If your patch

[Freedreno] [v5 1/5] drm/panel: add basic DP AUX backlight support

2021-05-30 Thread Rajeev Nandan
Some panels support backlight control over DP AUX channel using VESA's standard backlight control interface. Using new DRM eDP backlight helpers, add support to create and register a backlight for those panels in drm_panel to simplify the panel drivers. The panel driver with access to "struct