Re: [PATCH] drm/msm: Drop msm_read/writel

2024-04-11 Thread Bjorn Andersson
On Thu, Apr 11, 2024 at 04:31:41AM +0300, Dmitry Baryshkov wrote: > On Wed, Apr 10, 2024 at 11:52:52PM +0200, Konrad Dybcio wrote: [..] > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > > b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > > index e4275d3ad581..5a5dc3faa971 100644 > > ---

[pull] drm/msm: drm-msm-next-2024-04-11 for v6.9-rc4

2024-04-11 Thread Rob Clark
Hi Dave, Fixes for v6.9, description below The following changes since commit 4be445f5b6b6810baf397b2d159bd07c3573fd75: drm/msm/dpu: capture snapshot on the first commit_done timeout (2024-03-04 11:44:03 +0200) are available in the Git repository at:

Re: [PATCH 10/12] drm/msm: convert msm_format::alpha_enable to the flag

2024-04-11 Thread Dmitry Baryshkov
On Fri, 12 Apr 2024 at 00:20, Abhinav Kumar wrote: > > > > On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: > > Instead of having a bool field alpha_enable, convert it to the > > flag, this save space in the tables and allows us to handle all booleans > > in the same way. > > > > Signed-off-by:

Re: [PATCH 4/6] drm/msm/adreno: Implement SMEM-based speed bin

2024-04-11 Thread Konrad Dybcio
On 4/11/24 23:46, Dmitry Baryshkov wrote: On Fri, 12 Apr 2024 at 00:35, Konrad Dybcio wrote: On 4/10/24 21:26, Dmitry Baryshkov wrote: On Wed, Apr 10, 2024 at 01:42:33PM +0200, Konrad Dybcio wrote: On 4/6/24 05:23, Dmitry Baryshkov wrote: On Fri, Apr 05, 2024 at 10:41:32AM +0200,

Re: [PATCH 1/6] soc: qcom: Move some socinfo defines to the header, expand them

2024-04-11 Thread Elliot Berman
On Thu, Apr 11, 2024 at 10:24:08PM +0200, Konrad Dybcio wrote: > > > On 4/11/24 22:09, Elliot Berman wrote: > > On Thu, Apr 11, 2024 at 10:05:30PM +0200, Konrad Dybcio wrote: > > > > > > > > > On 4/11/24 20:55, Elliot Berman wrote: > > > > On Fri, Apr 05, 2024 at 10:41:29AM +0200, Konrad

Re: [PATCH 1/6] soc: qcom: Move some socinfo defines to the header, expand them

2024-04-11 Thread Konrad Dybcio
On 4/12/24 01:49, Elliot Berman wrote: On Thu, Apr 11, 2024 at 10:24:08PM +0200, Konrad Dybcio wrote: On 4/11/24 22:09, Elliot Berman wrote: On Thu, Apr 11, 2024 at 10:05:30PM +0200, Konrad Dybcio wrote: On 4/11/24 20:55, Elliot Berman wrote: On Fri, Apr 05, 2024 at 10:41:29AM +0200,

Re: [PATCH 1/6] soc: qcom: Move some socinfo defines to the header, expand them

2024-04-11 Thread Elliot Berman
On Fri, Apr 12, 2024 at 02:10:30AM +0200, Konrad Dybcio wrote: > > > On 4/12/24 01:49, Elliot Berman wrote: > > On Thu, Apr 11, 2024 at 10:24:08PM +0200, Konrad Dybcio wrote: > > > > > > > > > On 4/11/24 22:09, Elliot Berman wrote: > > > > On Thu, Apr 11, 2024 at 10:05:30PM +0200, Konrad

Re: [PATCH 2/6] soc: qcom: smem: Add pcode/fcode getters

2024-04-11 Thread Elliot Berman
On Fri, Apr 05, 2024 at 10:41:30AM +0200, Konrad Dybcio wrote: > Introduce getters for SoC product and feature codes and export them. > > Signed-off-by: Konrad Dybcio > --- > drivers/soc/qcom/smem.c | 66 > +++ > include/linux/soc/qcom/smem.h | 2

Re: [PATCH 07/12] drm/msm: merge dpu_format and mdp_format in struct msm_format

2024-04-11 Thread Dmitry Baryshkov
On Thu, 11 Apr 2024 at 22:15, Abhinav Kumar wrote: > > > > On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: > > Structures dpu_format and mdp_format are largely the same structures. > > In order to remove duplication between format databases, merge these two > > stucture definitions into the global

Re: [PATCH 06/12] drm/msm/dpu: pull format flag definitions to msm_drv.h

2024-04-11 Thread Abhinav Kumar
On 4/11/2024 11:41 AM, Abhinav Kumar wrote: On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: In preparation to merger of formats databases, pull format flag definitions to msm_drv.h header, so that they are visibile to both dpu and mdp drivers. Signed-off-by: Dmitry Baryshkov ---  

Re: [PATCH 07/12] drm/msm: merge dpu_format and mdp_format in struct msm_format

2024-04-11 Thread Abhinav Kumar
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: Structures dpu_format and mdp_format are largely the same structures. In order to remove duplication between format databases, merge these two stucture definitions into the global struct msm_format. Signed-off-by: Dmitry Baryshkov ---

Re: [PATCH 1/6] soc: qcom: Move some socinfo defines to the header, expand them

2024-04-11 Thread Elliot Berman
On Thu, Apr 11, 2024 at 10:05:30PM +0200, Konrad Dybcio wrote: > > > On 4/11/24 20:55, Elliot Berman wrote: > > On Fri, Apr 05, 2024 at 10:41:29AM +0200, Konrad Dybcio wrote: > > > In preparation for parsing the chip "feature code" (FC) and "product > > > code" (PC) (essentially the parameters

Re: [PATCH 1/6] soc: qcom: Move some socinfo defines to the header, expand them

2024-04-11 Thread Elliot Berman
On Fri, Apr 05, 2024 at 10:41:29AM +0200, Konrad Dybcio wrote: > In preparation for parsing the chip "feature code" (FC) and "product > code" (PC) (essentially the parameters that let us conclusively > characterize the sillicon we're running on, including various speed > bins), move the socinfo

Re: [PATCH 4/6] drm/msm/adreno: Implement SMEM-based speed bin

2024-04-11 Thread Dmitry Baryshkov
On Fri, 12 Apr 2024 at 00:35, Konrad Dybcio wrote: > > > > On 4/10/24 21:26, Dmitry Baryshkov wrote: > > On Wed, Apr 10, 2024 at 01:42:33PM +0200, Konrad Dybcio wrote: > >> > >> > >> On 4/6/24 05:23, Dmitry Baryshkov wrote: > >>> On Fri, Apr 05, 2024 at 10:41:32AM +0200, Konrad Dybcio wrote: >

Re: [PATCH] drm/msm: Drop msm_read/writel

2024-04-11 Thread Dmitry Baryshkov
On Thu, Apr 11, 2024 at 08:27:22AM -0700, Bjorn Andersson wrote: > On Thu, Apr 11, 2024 at 04:31:41AM +0300, Dmitry Baryshkov wrote: > > On Wed, Apr 10, 2024 at 11:52:52PM +0200, Konrad Dybcio wrote: > [..] > > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > > >

Re: [PATCH 1/6] soc: qcom: Move some socinfo defines to the header, expand them

2024-04-11 Thread Konrad Dybcio
On 4/11/24 22:09, Elliot Berman wrote: On Thu, Apr 11, 2024 at 10:05:30PM +0200, Konrad Dybcio wrote: On 4/11/24 20:55, Elliot Berman wrote: On Fri, Apr 05, 2024 at 10:41:29AM +0200, Konrad Dybcio wrote: In preparation for parsing the chip "feature code" (FC) and "product code" (PC)

Re: [PATCH 08/12] drm/msm: convert msm_format::unpack_tight to the flag

2024-04-11 Thread Abhinav Kumar
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: Instead of having a u8 or bool field unpack_tight, convert it to the flag, this save space in the tables and allows us to handle all booleans in the same way. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 22

Re: [PATCH 09/12] drm/msm: convert msm_format::unpack_align_msb to the flag

2024-04-11 Thread Abhinav Kumar
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: Instead of having a u8 or bool field unpack_align_msb, convert it to the flag, this save space in the tables and allows us to handle all booleans in the same way. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c

Re: [PATCH 10/12] drm/msm: convert msm_format::alpha_enable to the flag

2024-04-11 Thread Abhinav Kumar
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: Instead of having a bool field alpha_enable, convert it to the flag, this save space in the tables and allows us to handle all booleans in the same way. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 12

Re: [PATCH 06/12] drm/msm/dpu: pull format flag definitions to msm_drv.h

2024-04-11 Thread Abhinav Kumar
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: In preparation to merger of formats databases, pull format flag definitions to msm_drv.h header, so that they are visibile to both dpu and mdp drivers. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 98

Re: [PATCH 1/6] soc: qcom: Move some socinfo defines to the header, expand them

2024-04-11 Thread Konrad Dybcio
On 4/11/24 20:55, Elliot Berman wrote: On Fri, Apr 05, 2024 at 10:41:29AM +0200, Konrad Dybcio wrote: In preparation for parsing the chip "feature code" (FC) and "product code" (PC) (essentially the parameters that let us conclusively characterize the sillicon we're running on, including

Re: [PATCH 4/6] drm/msm/adreno: Implement SMEM-based speed bin

2024-04-11 Thread Konrad Dybcio
On 4/10/24 21:26, Dmitry Baryshkov wrote: On Wed, Apr 10, 2024 at 01:42:33PM +0200, Konrad Dybcio wrote: On 4/6/24 05:23, Dmitry Baryshkov wrote: On Fri, Apr 05, 2024 at 10:41:32AM +0200, Konrad Dybcio wrote: On recent (SM8550+) Snapdragon platforms, the GPU speed bin data is abstracted