Re: [Freedreno] Whether A200 driver is supported by Linux Mainline Kernel

2017-08-10 Thread Wladimir J. van der Laan
Hello Abhijit, On Thu, Aug 10, 2017 at 07:45:03PM +0530, abhijit wrote: > Hi Wladimir, > > Thank you very much for the reply. > > I am able to build the kernel, drm and mesa components. > > After loading the kernel, I am getting following entries, > /dev/gsl_kmod > /dev/dri/card0 >

Re: [Freedreno] Whether A200 driver is supported by Linux Mainline Kernel

2017-08-17 Thread Wladimir J. van der Laan
Hello abhijit, > Now I am trying to run some 2D application from freedreno. I saw that these > applications use libC2D2. > > I was able to get this library for UNIX, but I am not able to get libstlport > for UNIX which is one of dependencies. I am concluding libC2D2 is specific > to Andriod You

Re: [Freedreno] [PATCH] a2xx: add support for a few 16-bit color rendering formats

2017-08-25 Thread Wladimir J. van der Laan
On Fri, Aug 25, 2017 at 12:48:22AM -0400, Ilia Mirkin wrote: > The rest should be possible too, just needs some additional > investigation. Passes fbo-*-formats piglit tests. Reviewed-by: Wladimir J. van der Laan > Signed-off-by: Ilia Mirkin > --- > src/gallium/drivers

Re: [Freedreno] Whether A200 driver is supported by Linux Mainline Kernel

2017-11-16 Thread Wladimir J. van der Laan
Hello abhijit, On Thu, Nov 16, 2017 at 01:02:21PM +0530, abhijit wrote: > Hi Wladimir, > > Thank you very much for you response. > > I am using the kernel which is provided by you and I was able to > successfully get the GPU driver on to imx53 based QSRB board. > > I am using the same kernel fo

[Freedreno] [PATCH 0/7] freedreno: a2xx improvements

2018-01-25 Thread Wladimir J. van der Laan
the patch stack. Wladimir J. van der Laan (7): freedreno: a2xx: Update rnndb header freedreno: a2xx: Fix fd2_tex_swiz freedreno: a2xx: Prevent crash in emit_texture if view is not set freedreno: a2xx: Support TEXTURE_RECT freedreno: a2xx: Compressed textures support freedreno: a2xx: imp

[Freedreno] [PATCH 2/7] freedreno: a2xx: Fix fd2_tex_swiz

2018-01-25 Thread Wladimir J. van der Laan
Compose swizzles using util_format_compose_swizzles instead of the custom code (which somehow had a bug). This makes the GL_ALPHA internal format work. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_util.c | 18 +- 1 file changed, 9

[Freedreno] [PATCH 6/7] freedreno: a2xx: implement SEQ/SNE instructions

2018-01-25 Thread Wladimir J. van der Laan
Extend translate_sge_slt to emit these, in analogous fashion but using CNDEv. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/freedreno

[Freedreno] [PATCH 4/7] freedreno: a2xx: Support TEXTURE_RECT

2018-01-25 Thread Wladimir J. van der Laan
Denormalized texture coordinates are required for text rendering in GALLIUM_HUD. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 3 ++- src/gallium/drivers/freedreno/a2xx/ir-a2xx.c | 1 + src/gallium/drivers/freedreno/a2xx/ir-a2xx.h | 1

[Freedreno] [PATCH 7/7] freedreno: a2xx: Implement DP2 instruction

2018-01-25 Thread Wladimir J. van der Laan
Use DOT2ADDv instruction with 0.0f constant add. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_compiler.c b/src/gallium/drivers

[Freedreno] [PATCH 5/7] freedreno: a2xx: Compressed textures support

2018-01-25 Thread Wladimir J. van der Laan
Add support for: - PIPE_FORMAT_ETC1_RGB8 - PIPE_FORMAT_DXT1_RGB - PIPE_FORMAT_DXT1_RGBA - PIPE_FORMAT_DXT3_RGBA - PIPE_FORMAT_DXT5_RGBA Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_util.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src

[Freedreno] [PATCH 1/7] freedreno: a2xx: Update rnndb header

2018-01-25 Thread Wladimir J. van der Laan
Also update BLEND_ to BLEND2_ opcodes to accomodate. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/a2xx.xml.h | 33 +++ src/gallium/drivers/freedreno/a2xx/fd2_gmem.c | 4 ++-- 2 files changed, 15 insertions(+), 22 deletions(-) diff

[Freedreno] [PATCH 3/7] freedreno: a2xx: Prevent crash in emit_texture if view is not set

2018-01-25 Thread Wladimir J. van der Laan
Textures will sometimes be updated if texture view state was un-set, without this change that causes an assertion crash or segfault. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_emit.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff

Re: [Freedreno] [PATCH 1/7] freedreno: a2xx: Update rnndb header

2018-01-25 Thread Wladimir J. van der Laan
On Thu, Jan 25, 2018 at 08:40:00AM -0500, Ilia Mirkin wrote: > On Thu, Jan 25, 2018 at 8:29 AM, Wladimir J. van der Laan > wrote: > > Also update BLEND_ to BLEND2_ opcodes to accomodate. > > Are you saying this doesn't compile right now? I would have expected >

Re: [Freedreno] [PATCH 4/7] freedreno: a2xx: Support TEXTURE_RECT

2018-01-25 Thread Wladimir J. van der Laan
On Thu, Jan 25, 2018 at 08:41:11AM -0500, Ilia Mirkin wrote: > Should you also expose PIPE_CAP_TEXTURE_RECTANGLE? (Or whatever it's > called... I forget.) Yes, good point, will add that. Wladimir ___ Freedreno mailing list Freedreno@lists.freedesktop.or

Re: [Freedreno] [PATCH 4/7] freedreno: a2xx: Support TEXTURE_RECT

2018-03-22 Thread Wladimir J. van der Laan
Hello Ilia, On Thu, Jan 25, 2018 at 08:41:11AM -0500, Ilia Mirkin wrote: > Should you also expose PIPE_CAP_TEXTURE_RECTANGLE? (Or whatever it's > called... I forget.) I checked and I don't think a capability exists for this (anymore?). Everywhere, the assumption is meant that all Gallium drivers

[Freedreno] [PATCH v2 1/8] freedreno: a2xx: Update rnndb header for formats enumeration

2018-03-22 Thread Wladimir J. van der Laan
The format enumeration comes comes from the yamoto register headers that are part of the amd-gpu kernel driver. (see freedreno envytools commit 1b32c444f82cd7144d71602106462f59f146c1d0) Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/a2xx.xml.h | 33

[Freedreno] [PATCH v2 0/8] freedreno: a2xx improvements

2018-03-22 Thread Wladimir J. van der Laan
the patch stack. Changes since first post: - Split up rnndb patch into a patch that changes formate numeration and one that changed BLEND->BLEND2. - fd2_emit emit_texture const correctness. I checked that there is no Gallium capability to be set for TEXTURE_RECT. Wladimir J. van der Laan (8)

[Freedreno] [PATCH v2 5/8] freedreno: a2xx: Support TEXTURE_RECT

2018-03-22 Thread Wladimir J. van der Laan
Denormalized texture coordinates are required for text rendering in GALLIUM_HUD. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 3 ++- src/gallium/drivers/freedreno/a2xx/ir-a2xx.c | 1 + src/gallium/drivers/freedreno/a2xx/ir-a2xx.h | 1

[Freedreno] [PATCH v2 2/8] freedreno: a2xx: Change use of BLEND_ to BLEND2_

2018-03-22 Thread Wladimir J. van der Laan
Change use of BLEND_ to BLEND2_, BLEND_* a3xx_rb_blend_opcode BLEND2_* is a2xx_rb_blend_opcode This makes no effective difference as the used enumerant has the same value (0), but the other enumerants do not match 1-to-1 so this will avoid future problems. Signed-off-by: Wladimir J. van

[Freedreno] [PATCH v2 3/8] freedreno: a2xx: Fix fd2_tex_swiz

2018-03-22 Thread Wladimir J. van der Laan
Compose swizzles using util_format_compose_swizzles instead of the custom code (which somehow had a bug). This makes the GL_ALPHA internal format work. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_util.c | 18 +- 1 file changed, 9

[Freedreno] [PATCH v2 7/8] freedreno: a2xx: implement SEQ/SNE instructions

2018-03-22 Thread Wladimir J. van der Laan
Extend translate_sge_slt to emit these, in analogous fashion but using CNDEv. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/freedreno

[Freedreno] [PATCH v2 6/8] freedreno: a2xx: Compressed textures support

2018-03-22 Thread Wladimir J. van der Laan
Add support for: - PIPE_FORMAT_ETC1_RGB8 - PIPE_FORMAT_DXT1_RGB - PIPE_FORMAT_DXT1_RGBA - PIPE_FORMAT_DXT3_RGBA - PIPE_FORMAT_DXT5_RGBA Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_util.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src

[Freedreno] [PATCH v2 8/8] freedreno: a2xx: Implement DP2 instruction

2018-03-22 Thread Wladimir J. van der Laan
Use DOT2ADDv instruction with 0.0f constant add. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_compiler.c b/src/gallium/drivers

[Freedreno] [PATCH v2 4/8] freedreno: a2xx: Prevent crash in emit_texture if view is not set

2018-03-22 Thread Wladimir J. van der Laan
Textures will sometimes be updated if texture view state was un-set, without this change that causes an assertion crash or segfault. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_emit.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions

Re: [Freedreno] [PATCH v2 0/8] freedreno: a2xx improvements

2018-03-22 Thread Wladimir J. van der Laan
On Thu, Mar 22, 2018 at 11:46:57AM -0400, Ilia Mirkin wrote: > With the minor whitespace issue I pointed out (which might also apply > to 8/8, couldn't tell), this is Looks like there is also a case in 5/8, will go over them and resubmit the ones with wacky spacing. (I think the issue here is that

[Freedreno] [PATCH v3 3/8] freedreno: a2xx: Fix fd2_tex_swiz

2018-03-23 Thread Wladimir J. van der Laan
Compose swizzles using util_format_compose_swizzles instead of the custom code (which somehow had a bug). This makes the GL_ALPHA internal format work. Signed-off-by: Wladimir J. van der Laan Reviewed-by: Ilia Mirkin --- src/gallium/drivers/freedreno/a2xx/fd2_util.c | 18 +- 1

[Freedreno] [PATCH v3 2/8] freedreno: a2xx: Change use of BLEND_ to BLEND2_

2018-03-23 Thread Wladimir J. van der Laan
Change use of BLEND_ to BLEND2_, BLEND_* a3xx_rb_blend_opcode BLEND2_* is a2xx_rb_blend_opcode This makes no effective difference as the used enumerant has the same value (0), but the other enumerants do not match 1-to-1 so this will avoid future problems. Signed-off-by: Wladimir J. van

[Freedreno] [PATCH v3 4/8] freedreno: a2xx: Prevent crash in emit_texture if view is not set

2018-03-23 Thread Wladimir J. van der Laan
Textures will sometimes be updated if texture view state was un-set, without this change that causes an assertion crash or segfault. Signed-off-by: Wladimir J. van der Laan Reviewed-by: Ilia Mirkin --- src/gallium/drivers/freedreno/a2xx/fd2_emit.c | 13 ++--- 1 file changed, 10

[Freedreno] [PATCH v3 5/8] freedreno: a2xx: Support TEXTURE_RECT

2018-03-23 Thread Wladimir J. van der Laan
Denormalized texture coordinates are required for text rendering in GALLIUM_HUD. Signed-off-by: Wladimir J. van der Laan Reviewed-by: Ilia Mirkin --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 3 ++- src/gallium/drivers/freedreno/a2xx/ir-a2xx.c | 1 + src/gallium/drivers

[Freedreno] [PATCH v3 0/8] freedreno: a2xx improvements

2018-03-23 Thread Wladimir J. van der Laan
p patch 6,7,8 Wladimir J. van der Laan (8): freedreno: a2xx: Update rnndb header for formats enumeration freedreno: a2xx: Change use of BLEND_ to BLEND2_ freedreno: a2xx: Fix fd2_tex_swiz freedreno: a2xx: Prevent crash in emit_texture if view is not set freedreno: a2xx: Support

[Freedreno] [PATCH v3 8/8] freedreno: a2xx: Implement DP2 instruction

2018-03-23 Thread Wladimir J. van der Laan
Use DOT2ADDv instruction with 0.0f constant add. Signed-off-by: Wladimir J. van der Laan Reviewed-by: Ilia Mirkin --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 21 + 1 file changed, 21 insertions(+) Change since v2: spaces->tabs diff --git a/src/gallium/driv

[Freedreno] [PATCH v3 7/8] freedreno: a2xx: implement SEQ/SNE instructions

2018-03-23 Thread Wladimir J. van der Laan
Extend translate_sge_slt to emit these, in analogous fashion but using CNDEv. Signed-off-by: Wladimir J. van der Laan Reviewed-by: Ilia Mirkin --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) Change since v2

[Freedreno] [PATCH v3 6/8] freedreno: a2xx: Compressed textures support

2018-03-23 Thread Wladimir J. van der Laan
Add support for: - PIPE_FORMAT_ETC1_RGB8 - PIPE_FORMAT_DXT1_RGB - PIPE_FORMAT_DXT1_RGBA - PIPE_FORMAT_DXT3_RGBA - PIPE_FORMAT_DXT5_RGBA Signed-off-by: Wladimir J. van der Laan Reviewed-by: Ilia Mirkin --- src/gallium/drivers/freedreno/a2xx/fd2_util.c | 11 +++ 1 file changed, 11

[Freedreno] [PATCH v3 1/8] freedreno: a2xx: Update rnndb header for formats enumeration

2018-03-23 Thread Wladimir J. van der Laan
The format enumeration comes comes from the yamoto register headers that are part of the amd-gpu kernel driver. (see freedreno envytools commit 1b32c444f82cd7144d71602106462f59f146c1d0) Signed-off-by: Wladimir J. van der Laan Reviewed-by: Ilia Mirkin --- src/gallium/drivers/freedreno/a2xx

Re: [Freedreno] [PATCH v3 0/8] freedreno: a2xx improvements

2018-03-27 Thread Wladimir J. van der Laan
> Patchset looks reasonable to me, from a quick look. Testing a22x > isn't so easy without resurrecting an ancient downstream kernel for > old snadragon devices, so I think it is ok to ignore that. If the Do you mean: - try to keep supporting a22x on best-effort basis by providing fallback b