Re: [Freeipa-devel] [PATCH] 075 Add ignore lists to migrate-ds command

2011-06-15 Thread Martin Kosek
On Tue, 2011-06-14 at 13:43 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Thu, 2011-06-09 at 15:14 -0400, Rob Crittenden wrote: Martin Kosek wrote: How to test: 1) Create a custom DS instance with for example 60radius.ldif schema present (as in the original report in ticket #1266)

Re: [Freeipa-devel] [PATCH] 078 Improve DNS zone creation

2011-06-15 Thread Martin Kosek
On Tue, 2011-06-14 at 13:58 -0400, Rob Crittenden wrote: Simo Sorce wrote: On Thu, 2011-06-09 at 11:31 +0200, Martin Kosek wrote: When a new DNS zone is being created a local hostname is set as a nameserver of the new zone. However, when the zone is created during ipa-replica-prepare, the

Re: [Freeipa-devel] [PATCH] admiyo-0127-add-missing-files-in-rpm

2011-06-15 Thread Martin Kosek
On Fri, 2011-01-14 at 14:20 -0500, Adam Young wrote: On 01/06/2011 04:13 AM, Pavel Zůna wrote: On 2011-01-05 20:57, Adam Young wrote: Had to move some files around, and added to both Makefile.am and ipa.spec ACK. Pavel ___

Re: [Freeipa-devel] [PATCH] admiyo-0127-add-missing-files-in-rpm

2011-06-15 Thread Martin Kosek
On Wed, 2011-06-15 at 09:47 +0200, Martin Kosek wrote: On Fri, 2011-01-14 at 14:20 -0500, Adam Young wrote: On 01/06/2011 04:13 AM, Pavel Zůna wrote: On 2011-01-05 20:57, Adam Young wrote: Had to move some files around, and added to both Makefile.am and ipa.spec ACK.

Re: [Freeipa-devel] [PATCH] 080 Add a list of managed hosts

2011-06-15 Thread Martin Kosek
On Tue, 2011-06-14 at 14:12 -0400, Rob Crittenden wrote: Martin Kosek wrote: Enhance Host plugin to provide not only Managed By list but also a list of managed hosts. The new list is generated only when --all option is passed. https://fedorahosted.org/freeipa/ticket/993 ack Pushed

[Freeipa-devel] [PATCH] 081 Missing krbprincipalname when uid is not set

2011-06-15 Thread Martin Kosek
When user_add command is executed without uid parameter filled, user account is created without 'krbprincipalname' attribute. This renders the user account unusable. https://fedorahosted.org/freeipa/ticket/1279 From 8bc3777e72590c665029e0d1e3698490b7a7dacd Mon Sep 17 00:00:00 2001 From: Martin

[Freeipa-devel] [PATCH] 082 Add port 9443 to replica port checking

2011-06-15 Thread Martin Kosek
Port 9443 (Agent secure port on PKI-CA) was missing. Additionaly, checked port descriptions case consistency fixed. https://fedorahosted.org/freeipa/ticket/1321 From 6d2ae60382588f77b79265558bd3d895e970c854 Mon Sep 17 00:00:00 2001 From: Martin Kosek mko...@redhat.com Date: Wed, 15 Jun 2011

Re: [Freeipa-devel] [PATCH] 079 DNS installation fails when domain and host domain mismatch

2011-06-15 Thread Martin Kosek
On Tue, 2011-06-14 at 13:53 -0400, Rob Crittenden wrote: Martin Kosek wrote: This patch depends on my patch 078. A special patch for stable branch attached. --- Create DNS domain for IPA server hostname first so that it's forward record can be added. This results in 2 forward DNS

Re: [Freeipa-devel] [PATCH] 802 add message summary to sudorule

2011-06-15 Thread Martin Kosek
On Tue, 2011-06-14 at 21:36 -0400, Rob Crittenden wrote: Some of the sudorule commands were missing a message summary. ticket https://fedorahosted.org/freeipa/ticket/1255 rob ACK. I checked if any unit test is broken because of newly returned summary field, but its OK. Pushed to master,

Re: [Freeipa-devel] [PATCH] 803 disallow revocation reason 7

2011-06-15 Thread Martin Kosek
On Tue, 2011-06-14 at 22:05 -0400, Rob Crittenden wrote: Revocation reason 7 is undefined in the RFCs, disallow it. https://fedorahosted.org/freeipa/ticket/1318 ACK. Works fine. Pushed to master, ipa-2-0. Martin ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 29 Raise DuplicateEntry Error when adding a duplicate sudo option

2011-06-15 Thread Rob Crittenden
JR Aquino wrote: On Jun 14, 2011, at 11:06 AM, Rob Crittenden wrote: JR Aquino wrote: On Jun 10, 2011, at 3:11 PM, JR Aquino wrote: On Jun 9, 2011, at 10:24 AM, Rob Crittenden wrote: JR Aquino wrote: https://fedorahosted.org/freeipa/ticket/1277 Raise DuplicateEntry Error when adding a

Re: [Freeipa-devel] [PATCH] 792 Update translations

2011-06-15 Thread Martin Kosek
On Tue, 2011-06-14 at 17:41 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2011-06-06 at 13:47 -0400, Rob Crittenden wrote: Our translation files haven't been updated for a few months, this brings things up to date. It is intended for master only. All I did to generate this

Re: [Freeipa-devel] [PATCH] 081 Missing krbprincipalname when uid is not set

2011-06-15 Thread Rob Crittenden
Martin Kosek wrote: When user_add command is executed without uid parameter filled, user account is created without 'krbprincipalname' attribute. This renders the user account unusable. https://fedorahosted.org/freeipa/ticket/1279 ack ___

Re: [Freeipa-devel] [PATCH] 082 Add port 9443 to replica port checking

2011-06-15 Thread Rob Crittenden
Martin Kosek wrote: Port 9443 (Agent secure port on PKI-CA) was missing. Additionaly, checked port descriptions case consistency fixed. https://fedorahosted.org/freeipa/ticket/1321 ack ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH] 0236-no-redirect-on-search

2011-06-15 Thread Adam Young
From 9a49b4f23609e6a57775c0107de47b44b99a674f Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Wed, 15 Jun 2011 11:18:25 -0400 Subject: [PATCH] no redirect on search https://fedorahosted.org/freeipa/ticket/1281 --- install/ui/entity.js |6 +- 1 files changed, 5

Re: [Freeipa-devel] [PATCH] 0236-no-redirect-on-search

2011-06-15 Thread Adam Young
On 06/15/2011 11:24 AM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Removed extra whitespace From f53183f649aebe4f85a904639c21236a80c1eb32 Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH] 081 Missing krbprincipalname when uid is not set

2011-06-15 Thread Martin Kosek
On Wed, 2011-06-15 at 11:19 -0400, Rob Crittenden wrote: Martin Kosek wrote: When user_add command is executed without uid parameter filled, user account is created without 'krbprincipalname' attribute. This renders the user account unusable. https://fedorahosted.org/freeipa/ticket/1279

Re: [Freeipa-devel] [PATCH] 082 Add port 9443 to replica port checking

2011-06-15 Thread Martin Kosek
On Wed, 2011-06-15 at 11:19 -0400, Rob Crittenden wrote: Martin Kosek wrote: Port 9443 (Agent secure port on PKI-CA) was missing. Additionaly, checked port descriptions case consistency fixed. https://fedorahosted.org/freeipa/ticket/1321 ack Pushed to master. Martin

[Freeipa-devel] [PATCH 25/25] assert_deepequal supports callback for equality

2011-06-15 Thread John Dennis
The unit test framework recursively checks for equality between the expected and got. When it finds a non-container object it checks for equality between the expected and got objects. However sometimes a simple equality test is insufficient. This can happen when two values are equivalent but not

Re: [Freeipa-devel] [PATCH] 177 Fixed build break.

2011-06-15 Thread Martin Kosek
On Wed, 2011-06-15 at 10:23 -0500, Endi Sukma Dewata wrote: The Makefile.am freeipa.spec.in have been updated according to the recent file changes. ACK. Works fine. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 177 Fixed build break.

2011-06-15 Thread Endi Sukma Dewata
On 6/15/2011 10:51 AM, Martin Kosek wrote: On Wed, 2011-06-15 at 10:23 -0500, Endi Sukma Dewata wrote: The Makefile.am freeipa.spec.in have been updated according to the recent file changes. ACK. Works fine. Pushed to master. Thanks! -- Endi S. Dewata

[Freeipa-devel] [PATCH] 178 Removed FreeWay font files.

2011-06-15 Thread Endi Sukma Dewata
The CSS files in install/html and install/migration have been modified to use the Overpass font. The changes can be verified here: http://edewata.fedorapeople.org/freeipa/install/html/unauthorized.html http://edewata.fedorapeople.org/freeipa/install/migration/index.html -- Endi S. Dewata

Re: [Freeipa-devel] [PATCH] 0236-no-redirect-on-search

2011-06-15 Thread Adam Young
On 06/15/2011 11:28 AM, Adam Young wrote: On 06/15/2011 11:24 AM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Removed extra whitespace

Re: [Freeipa-devel] [PATCH] 802 add message summary to sudorule

2011-06-15 Thread JR Aquino
On Jun 14, 2011, at 6:36 PM, Rob Crittenden wrote: Some of the sudorule commands were missing a message summary. ticket https://fedorahosted.org/freeipa/ticket/1255 rob freeipa-rcrit-802-sudo.patch___ Freeipa-devel mailing list

[Freeipa-devel] [PATCH 26/26] Add backslash escape support for csv reader

2011-06-15 Thread John Dennis
The csv reader is used to break comma separated lists into individual items. However what if you want one of those items to have an embedded comma? The answer is to escape it by preceding the comma with a backslash. This patch adds support for escaping in the csv reader. -- John Dennis

Re: [Freeipa-devel] [PATCH] 0236-no-redirect-on-search

2011-06-15 Thread Endi Sukma Dewata
On 6/15/2011 11:37 AM, Adam Young wrote: Removed extra whitespace Facet can override what to do on error There's a jslint warning, but other than that it can be pushed. This patch fixes the first item in ticket #1281. The second item is still a problem. Steps to reproduce: 1. Open a

Re: [Freeipa-devel] [PATCH] 0236-no-redirect-on-search

2011-06-15 Thread Adam Young
On 06/15/2011 01:50 PM, Endi Sukma Dewata wrote: On 6/15/2011 11:37 AM, Adam Young wrote: Removed extra whitespace Facet can override what to do on error There's a jslint warning, but other than that it can be pushed. This patch fixes the first item in ticket #1281. The second item is

Re: [Freeipa-devel] [PATCH] 799 The IP address provided to ipa-server-install must be local

2011-06-15 Thread Rob Crittenden
Rob Crittenden wrote: Martin Kosek wrote: On Tue, 2011-06-14 at 08:56 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2011-06-13 at 16:41 -0400, Rob Crittenden wrote: Compare the configured interfaces with the supplied IP address and optional netmask to determine if the interface is

[Freeipa-devel] [PATCH] 0237-no-redirect-on-unknown-error

2011-06-15 Thread Adam Young
Part 2 https://fedorahosted.org/freeipa/ticket/1281 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0237-no-redirect-on-unknown-error

2011-06-15 Thread Adam Young
On 06/15/2011 02:37 PM, Adam Young wrote: Part 2 https://fedorahosted.org/freeipa/ticket/1281 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel From

Re: [Freeipa-devel] [PATCH] 29 Raise DuplicateEntry Error when adding a duplicate sudo option

2011-06-15 Thread JR Aquino
On Jun 15, 2011, at 8:03 AM, Rob Crittenden wrote: A minor issue and a question. The minor issue is you changed a couple of options from optional to mandatory, which is fine, but we need to bump up the minor version in VERSION (older clients otherwise could not send the string and blow

[Freeipa-devel] [PATCH 27/27] get_primary_key_from_dn returns decoded value

2011-06-15 Thread John Dennis
DN's may be encoded. If we're going to return the value from one of the RDN's in the DN then we must decode the DN first, otherwise the returned value won't be what we're expecting. Specifically the value getting passed back through the RPC interface was not the value set because it included

[Freeipa-devel] [PATCH 28/28] Update test_role_plugin test to include a comma in a, privilege

2011-06-15 Thread John Dennis
Update test_role_plugin test to include a comma in a privilege Introduce a comma into a privilege name to assure we can handle commas. Commas must be escaped for some parameters, add escape_comma() utility and invoke it for the necessary parameters. Utilize a DN object to properly construct a

[Freeipa-devel] [PATCH] 179 Fixed paging for indirect members.

2011-06-15 Thread Endi Sukma Dewata
Since ticket #1273 has been fixed, the indirect members can be shown using the regular association facet which supports paging. -- Endi S. Dewata From eae218c660109479c6a5f355f5ad184cbfe10c63 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Mon, 13 Jun 2011 16:18:48 -0500

[Freeipa-devel] [PATCH] 180 Renamed associate.js to association.js.

2011-06-15 Thread Endi Sukma Dewata
-- Endi S. Dewata From a84e4ad9d6327d3f0a17ba860ca53a7d883ad7d4 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Tue, 14 Jun 2011 00:02:54 -0500 Subject: [PATCH] Renamed associate.js to association.js. --- install/ui/Makefile.am |2 +-

Re: [Freeipa-devel] [PATCH] 0237-no-redirect-on-unknown-error

2011-06-15 Thread Adam Young
On 06/15/2011 02:37 PM, Adam Young wrote: Part 2 https://fedorahosted.org/freeipa/ticket/1281 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Now iterates through a list of known error

Re: [Freeipa-devel] [PATCH] 0237-no-redirect-on-unknown-error

2011-06-15 Thread Endi Sukma Dewata
On 6/15/2011 6:44 PM, Adam Young wrote: On 06/15/2011 02:37 PM, Adam Young wrote: Part 2 https://fedorahosted.org/freeipa/ticket/1281 Now iterates through a list of known error types. If the server is down (service ipa stop) it throws an error with name 'NS_ERROR_NOT_AVAILABLE' which is