[Freeipa-devel] [PATCH] 159 Fix ipa-replica-conncheck port labels

2011-11-04 Thread Martin Kosek
Pushed under the one-liner (two-liner in this case) rule to master, ipa-2-1. Quick self-verification after the change: # ipa-replica-conncheck -m vm-050.idm.lab.bos.redhat.com Check connection from replica to remote master 'vm-050.idm.lab.bos.redhat.com': Directory Service: Unsecure port

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Alexander Bokovoy
On Thu, 03 Nov 2011, Simo Sorce wrote: As stated in the bug in order to attain better interoperability with Windows clients we need to change the way we generate the random salt. ACK. -- / Alexander Bokovoy ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Martin Kosek
On Fri, 2011-11-04 at 10:04 +0200, Alexander Bokovoy wrote: On Thu, 03 Nov 2011, Simo Sorce wrote: As stated in the bug in order to attain better interoperability with Windows clients we need to change the way we generate the random salt. ACK. Pushed to master. Martin

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Simo Sorce
On Fri, 2011-11-04 at 11:14 +0100, Martin Kosek wrote: On Fri, 2011-11-04 at 10:04 +0200, Alexander Bokovoy wrote: On Thu, 03 Nov 2011, Simo Sorce wrote: As stated in the bug in order to attain better interoperability with Windows clients we need to change the way we generate the random

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Martin Kosek
On Fri, 2011-11-04 at 07:41 -0400, Simo Sorce wrote: On Fri, 2011-11-04 at 11:14 +0100, Martin Kosek wrote: On Fri, 2011-11-04 at 10:04 +0200, Alexander Bokovoy wrote: On Thu, 03 Nov 2011, Simo Sorce wrote: As stated in the bug in order to attain better interoperability with Windows

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Simo Sorce
On Fri, 2011-11-04 at 12:55 +0100, Martin Kosek wrote: On Fri, 2011-11-04 at 07:41 -0400, Simo Sorce wrote: On Fri, 2011-11-04 at 11:14 +0100, Martin Kosek wrote: On Fri, 2011-11-04 at 10:04 +0200, Alexander Bokovoy wrote: On Thu, 03 Nov 2011, Simo Sorce wrote: As stated in the bug

Re: [Freeipa-devel] [PATCH] 157 Add --delattr option to complement --setattr/--addattr

2011-11-04 Thread Rob Crittenden
Martin Kosek wrote: Add a --delattr option to round out multi-valued attribute manipulation. The new option is be available for all LDAPUpdate based commands. --delattr is evaluated last, it can remove any value present either in --addattr/--setattr options or stored in LDAP.

[Freeipa-devel] [PATCHES] #1791 Tust Effort: Add support for generating MS-PAC

2011-11-04 Thread Simo Sorce
The attached patches are for master and concern the effort of creating trust relationships between IPA and AD domains. With these patches if you have run ipa-adtrust-install the IPA kdc will be able to create a MS-PAC if the user has the right attributes ipaNTSecurityIdentifier on the user entry

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Simo Sorce
On Fri, 2011-11-04 at 08:03 -0400, Simo Sorce wrote: On Fri, 2011-11-04 at 12:55 +0100, Martin Kosek wrote: On Fri, 2011-11-04 at 07:41 -0400, Simo Sorce wrote: On Fri, 2011-11-04 at 11:14 +0100, Martin Kosek wrote: On Fri, 2011-11-04 at 10:04 +0200, Alexander Bokovoy wrote: On Thu,

Re: [Freeipa-devel] [PATCH] 306 Moved facet code into facet.js.

2011-11-04 Thread Petr Vobornik
On 11/04/2011 04:35 AM, Endi Sukma Dewata wrote: Facet-related code has been moved from entity.js into a new facet.js because the file is getting too big. ACK and pushed to master -- Petr Vobornik ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 029 Page is cleared before it is visible

2011-11-04 Thread Petr Vobornik
On 11/03/2011 10:22 PM, Endi Sukma Dewata wrote: On 11/2/2011 11:01 AM, Petr Vobornik wrote: Regardless, ACK and pushed to master. Found another problem, the krbtpolicy config need to be forced to update. See the attached patch. ACK and pushed to master. -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 307 Added extensible UI framework.

2011-11-04 Thread Petr Vobornik
On 11/04/2011 04:37 AM, Endi Sukma Dewata wrote: The entity definitions have been converted into classes. The entity init() method will use the builder to construct the facets and dialogs. The UI can be customized by creating a subclass of the original entity in extension.js and then overriding

Re: [Freeipa-devel] [PATCH] 307 Added extensible UI framework.

2011-11-04 Thread Adam Young
On 11/04/2011 12:10 PM, Petr Vobornik wrote: On 11/04/2011 04:37 AM, Endi Sukma Dewata wrote: The entity definitions have been converted into classes. The entity init() method will use the builder to construct the facets and dialogs. The UI can be customized by creating a subclass of the

Re: [Freeipa-devel] [PATCH] 030 Extending facet's mechanism of gathering changes

2011-11-04 Thread Endi Sukma Dewata
Rebased, ACK, and pushed to master. Some comments below. On 11/4/2011 7:21 AM, Petr Vobornik wrote: I'm considering command builder more as an utility class, than proper builder. If it would gather more functionality it would be better to changed it that way. I think in general a utility

Re: [Freeipa-devel] [PATCH] 307 Added extensible UI framework.

2011-11-04 Thread Endi Sukma Dewata
On 11/4/2011 12:11 PM, Adam Young wrote: There is a warning/error in browser when there is no extension.js present. This doesn't affect functionality, but I think we should try to eliminate this kinds of error. Same problem is for develop.js on production machines. This can be fixed separately.

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Nalin Dahyabhai
On Thu, Nov 03, 2011 at 06:26:15PM -0400, Simo Sorce wrote: As stated in the bug in order to attain better interoperability with Windows clients we need to change the way we generate the random salt. Nack. The data in a krb5_data is of type 'char', and if it's signed, the math used here

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Simo Sorce
On Fri, 2011-11-04 at 15:15 -0400, Nalin Dahyabhai wrote: On Thu, Nov 03, 2011 at 06:26:15PM -0400, Simo Sorce wrote: As stated in the bug in order to attain better interoperability with Windows clients we need to change the way we generate the random salt. Nack. The data in a krb5_data

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Simo Sorce
On Fri, 2011-11-04 at 15:59 -0400, Simo Sorce wrote: On Fri, 2011-11-04 at 15:15 -0400, Nalin Dahyabhai wrote: On Thu, Nov 03, 2011 at 06:26:15PM -0400, Simo Sorce wrote: As stated in the bug in order to attain better interoperability with Windows clients we need to change the way we

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Simo Sorce
On Fri, 2011-11-04 at 16:14 -0400, Simo Sorce wrote: On Fri, 2011-11-04 at 15:59 -0400, Simo Sorce wrote: On Fri, 2011-11-04 at 15:15 -0400, Nalin Dahyabhai wrote: On Thu, Nov 03, 2011 at 06:26:15PM -0400, Simo Sorce wrote: As stated in the bug in order to attain better interoperability

Re: [Freeipa-devel] [PATCH] 120 Improve DNS record data validation

2011-11-04 Thread Rob Crittenden
Martin Kosek wrote: On Wed, 2011-10-19 at 15:38 -0400, Adam Young wrote: On 10/19/2011 08:15 AM, Martin Kosek wrote: On Wed, 2011-09-07 at 15:18 +0200, Martin Kosek wrote: On Wed, 2011-09-07 at 15:05 +0200, Martin Kosek wrote: This is 3.0 Core Effort Backlog patch. The changes to API may

Re: [Freeipa-devel] [PATCH] #2038 modify salt creation

2011-11-04 Thread Nalin Dahyabhai
On Fri, Nov 04, 2011 at 04:45:02PM -0400, Simo Sorce wrote: After a quick review with nalin offline I decided for a different approach that properly covers the range of values we want and is more similar to the initial code. New patches attached. Looks good to me. Please bump up

Re: [Freeipa-devel] [PATCH] 152 Enable automember for upgraded servers

2011-11-04 Thread Rob Crittenden
Martin Kosek wrote: automember functionality is depends on predefined data is in LDAP. Since we add it for fresh installs only, automember cannot be used for upgraded servers. Make sure that automember LDAP data is added during upgrade too. https://fedorahosted.org/freeipa/ticket/1992 I think

Re: [Freeipa-devel] [PATCH] 152 Enable automember for upgraded servers

2011-11-04 Thread Nathan Kinder
On 11/04/2011 02:02 PM, Rob Crittenden wrote: Martin Kosek wrote: automember functionality is depends on predefined data is in LDAP. Since we add it for fresh installs only, automember cannot be used for upgraded servers. Make sure that automember LDAP data is added during upgrade too.

Re: [Freeipa-devel] [PATCH] 55 Parse comma-separated lists of values in all parameter types

2011-11-04 Thread Rob Crittenden
Jan Cholasta wrote: Dne 24.10.2011 17:42, Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 20.10.2011 13:20, Jan Cholasta napsal(a): Parse comma-separated lists of values in all parameter types. This can enabled for a specific parameter by setting the csvlist option to True. Remove List

Re: [Freeipa-devel] [PATCH] 152 Enable automember for upgraded servers

2011-11-04 Thread Martin Kosek
On Fri, 2011-11-04 at 14:04 -0700, Nathan Kinder wrote: On 11/04/2011 02:02 PM, Rob Crittenden wrote: Martin Kosek wrote: automember functionality is depends on predefined data is in LDAP. Since we add it for fresh installs only, automember cannot be used for upgraded servers. Make sure

Re: [Freeipa-devel] [PATCH] 152 Enable automember for upgraded servers

2011-11-04 Thread Nathan Kinder
On 11/04/2011 02:26 PM, Martin Kosek wrote: On Fri, 2011-11-04 at 14:04 -0700, Nathan Kinder wrote: On 11/04/2011 02:02 PM, Rob Crittenden wrote: Martin Kosek wrote: automember functionality is depends on predefined data is in LDAP. Since we add it for fresh installs only, automember cannot

Re: [Freeipa-devel] [PATCH] 152 Enable automember for upgraded servers

2011-11-04 Thread Nathan Kinder
On 11/04/2011 02:35 PM, Nathan Kinder wrote: On 11/04/2011 02:26 PM, Martin Kosek wrote: On Fri, 2011-11-04 at 14:04 -0700, Nathan Kinder wrote: On 11/04/2011 02:02 PM, Rob Crittenden wrote: Martin Kosek wrote: automember functionality is depends on predefined data is in LDAP. Since we add

[Freeipa-devel] [PATCH] 308 Added current password field.

2011-11-04 Thread Endi Sukma Dewata
The reset password dialog for user has been modified to provide a field to specify the current password when changing the user's own password. Ticket #2065 -- Endi S. Dewata From 004bd7f1676255508fe11cf87e059607978f7593 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Fri,

Re: [Freeipa-devel] [PATCHES] #1791 Tust Effort: Add support for generating MS-PAC

2011-11-04 Thread Sumit Bose
On Fri, Nov 04, 2011 at 10:49:40AM -0400, Simo Sorce wrote: The attached patches are for master and concern the effort of creating trust relationships between IPA and AD domains. With these patches if you have run ipa-adtrust-install the IPA kdc will be able to create a MS-PAC if the user

Re: [Freeipa-devel] [PATCH] 029 Page is cleared before it is visible

2011-11-04 Thread Endi Sukma Dewata
On 11/4/2011 11:02 AM, Petr Vobornik wrote: ACK and pushed to master. Found another problem, changing page in the association facet didn't work because pkey is still the same. See the attached patch. -- Endi S. Dewata From 291626e4f4e464b907fae33291b430f8ead95055 Mon Sep 17 00:00:00 2001