[Freeipa-devel] [PATCH 502] schema: do not derive ipaVaultPublicKey from ipaPublicKey

2015-10-12 Thread Jan Cholasta
Hi, the attached patch fixes . Honza -- Jan Cholasta From d92d4c6c2d3f2aa7d879157325fa30c383ea6f45 Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Mon, 12 Oct 2015 08:04:38 +0200 Subject: [PATCH] schema: do not derive

Re: [Freeipa-devel] [PATCH 502] schema: do not derive ipaVaultPublicKey from ipaPublicKey

2015-10-12 Thread Alexander Bokovoy
On Mon, 12 Oct 2015, Jan Cholasta wrote: Hi, the attached patch fixes . ACK, given Thierry's comment #32 in the bug https://bugzilla.redhat.com/show_bug.cgi?id=1267782 -- / Alexander Bokovoy -- Manage your subscription for the Freeipa-devel

Re: [Freeipa-devel] [PATCH 0057] Warn in no installation found when running ipa-server-install --uninstall

2015-10-12 Thread Petr Spacek
Hello Gabe, thank you for your patch! Please note that there might be a case where detection is_ipa_configured() is broken but the user still needs to run the uninstall process to clean it up. Could you amend the patch to respect --force option? In that case the detection should be skipped.

Re: [Freeipa-devel] [PATCH 0078-0081] ipa-client-install autodiscovery code improvements

2015-10-12 Thread Petr Spacek
On 9.10.2015 12:47, Martin Babinsky wrote: > On 10/09/2015 11:47 AM, Petr Spacek wrote: >> On 9.10.2015 09:14, Petr Spacek wrote: >>> On 8.10.2015 19:09, Martin Babinsky wrote: These patches fix https://fedorahosted.org/freeipa/ticket/4305 Actually only the last patch does the work

Re: [Freeipa-devel] [PATCHES 0318 - 0320] installer: allow to modify dse.ldif during installation

2015-10-12 Thread Martin Basti
On 12.10.2015 12:30, Martin Babinsky wrote: On 10/08/2015 05:58 PM, Martin Basti wrote: The attached patches fix following tickets: https://fedorahosted.org/freeipa/ticket/4949 https://fedorahosted.org/freeipa/ticket/4048 https://fedorahosted.org/freeipa/ticket/1930 With these

Re: [Freeipa-devel] [PATCH 0019] handle cleanRUV in the topology plugin

2015-10-12 Thread Ludwig Krispenz
On 10/12/2015 12:44 PM, Martin Basti wrote: On 23.07.2015 10:46, Ludwig Krispenz wrote: The attached patch moves the cleaning of the RUV into the topology plugin. I encountered a problem when removing a replica, which disconnects the topology, but it was fixed with my WIP for #5072. I

Re: [Freeipa-devel] [PATCHES 362-366] Realmdomains handling improvements

2015-10-12 Thread Martin Basti
On 09.10.2015 19:11, Tomas Babej wrote: On 09/23/2015 02:40 PM, Martin Basti wrote: On 09/22/2015 02:23 PM, Tomas Babej wrote: On 09/03/2015 04:34 PM, Alexander Bokovoy wrote: On Thu, 03 Sep 2015, Tomas Babej wrote: Hi, this couple of patches fix

Re: [Freeipa-devel] [PATCHES 362-366] Realmdomains handling improvements

2015-10-12 Thread Tomas Babej
- Original Message - From: "Martin Basti" To: "Tomas Babej" Cc: "freeipa-devel" Sent: Monday, October 12, 2015 12:41:13 PM Subject: Re: [Freeipa-devel] [PATCHES 362-366] Realmdomains handling improvements >On

Re: [Freeipa-devel] [PATCHES 0318 - 0320] installer: allow to modify dse.ldif during installation

2015-10-12 Thread Martin Babinsky
On 10/08/2015 05:58 PM, Martin Basti wrote: The attached patches fix following tickets: https://fedorahosted.org/freeipa/ticket/4949 https://fedorahosted.org/freeipa/ticket/4048 https://fedorahosted.org/freeipa/ticket/1930 With these patches, an administrator can specify LDIF

Re: [Freeipa-devel] [PATCH 0019] handle cleanRUV in the topology plugin

2015-10-12 Thread Martin Basti
On 23.07.2015 10:46, Ludwig Krispenz wrote: The attached patch moves the cleaning of the RUV into the topology plugin. I encountered a problem when removing a replica, which disconnects the topology, but it was fixed with my WIP for #5072. I want to keep these issues separate, so please

Re: [Freeipa-devel] [PATCHES 0321 - 0322] CI: vault CI test

2015-10-12 Thread Martin Basti
On 12.10.2015 15:18, Martin Basti wrote: On 12.10.2015 13:37, Milan Kubík wrote: On 10/08/2015 06:53 PM, Martin Basti wrote: Patches attached. Tests for https://fedorahosted.org/freeipa/ticket/5302 LGTM, ACK. -- Milan Kubik Pushed to: ipa-4-2: ad345b4e2572cbc5ce26501f4a73fc4eb02bfaf0

[Freeipa-devel] [PATCH 0084] hide topology segment direction in topology command CLI and webui interface

2015-10-12 Thread Martin Babinsky
https://fedorahosted.org/freeipa/ticket/5222 -- Martin^3 Babinsky From 42911d656a7d9e3f3113bada8d146893e880f21d Mon Sep 17 00:00:00 2001 From: Martin Babinsky Date: Mon, 12 Oct 2015 17:49:50 +0200 Subject: [PATCH] hide topology segment direction in topology command CLI and

Re: [Freeipa-devel] [PATCH] 0001 cert-show: Remove check if hostname != CN

2015-10-12 Thread Rob Crittenden
Jan Orel wrote: >> Agreed. The corresponding checks for certificate issuance via >> cert-request, where the bind principal is a host, check that the >> subject host (and SAN dNSNames) is "managed by" the bind host. >> This is checked via `ldap.can_write(dn_of_subject_principal)'. >> >> 1.

Re: [Freeipa-devel] [PATCHES 362-366] Realmdomains handling improvements

2015-10-12 Thread Tomas Babej
>On 12.10.2015 12:50, Tomas Babej wrote: >> >> - Original Message - >> From: "Martin Basti" >> To: "Tomas Babej" >> Cc: "freeipa-devel" >> Sent: Monday, October 12, 2015 12:41:13 PM >> Subject: Re: [Freeipa-devel] [PATCHES

Re: [Freeipa-devel] [PATCHES 362-366] Realmdomains handling improvements

2015-10-12 Thread Martin Basti
On 12.10.2015 12:50, Tomas Babej wrote: - Original Message - From: "Martin Basti" To: "Tomas Babej" Cc: "freeipa-devel" Sent: Monday, October 12, 2015 12:41:13 PM Subject: Re: [Freeipa-devel] [PATCHES 362-366]

Re: [Freeipa-devel] [PATCHES 0321 - 0322] CI: vault CI test

2015-10-12 Thread Martin Basti
On 12.10.2015 13:37, Milan Kubík wrote: On 10/08/2015 06:53 PM, Martin Basti wrote: Patches attached. Tests for https://fedorahosted.org/freeipa/ticket/5302 LGTM, ACK. -- Milan Kubik Pushed to: ipa-4-2: ad345b4e2572cbc5ce26501f4a73fc4eb02bfaf0 master:

Re: [Freeipa-devel] [PATCH 503] upgrade: make sure ldap2 is connected in export_kra_agent_pem

2015-10-12 Thread Aleš Mareček
Hello, the patch looks good but pep8 cries: # pep8 ipaserver/install/server/upgrade.py ipaserver/install/server/upgrade.py:53:1: E302 expected 2 blank lines, found 1 ipaserver/install/server/upgrade.py:68:1: E302 expected 2 blank lines, found 1 ipaserver/install/server/upgrade.py:83:25: E261 at

Re: [Freeipa-devel] [PATCHES 362-366] Realmdomains handling improvements

2015-10-12 Thread Martin Basti
On 12.10.2015 14:02, Tomas Babej wrote: On 12.10.2015 12:50, Tomas Babej wrote: - Original Message - From: "Martin Basti" To: "Tomas Babej" Cc: "freeipa-devel" Sent: Monday, October 12, 2015 12:41:13 PM Subject: Re:

Re: [Freeipa-devel] [PATCHES 0321 - 0322] CI: vault CI test

2015-10-12 Thread Milan Kubík
On 10/08/2015 06:53 PM, Martin Basti wrote: Patches attached. Tests for https://fedorahosted.org/freeipa/ticket/5302 LGTM, ACK. -- Milan Kubik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [PATCH 0082] remove Kerberos authenticators after service uninstall

2015-10-12 Thread Martin Babinsky
Fixes https://fedorahosted.org/freeipa/ticket/5243 -- Martin^3 Babinsky From fa66bd0a5277e04b231982dabad61614ec9eddec Mon Sep 17 00:00:00 2001 From: Martin Babinsky Date: Fri, 9 Oct 2015 18:08:38 +0200 Subject: [PATCH] remove Kerberos authenticators after service uninstall

Re: [Freeipa-devel] [PATCH 503] upgrade: make sure ldap2 is connected in export_kra_agent_pem

2015-10-12 Thread Aleš Mareček
ok, it's not fault of patch itself, ACK - Original Message - > From: "Aleš Mareček" > To: "Jan Cholasta" > Cc: "freeipa-devel" > Sent: Monday, October 12, 2015 3:45:51 PM > Subject: Re: [Freeipa-devel] [PATCH 503]

Re: [Freeipa-devel] [PATCH 503] upgrade: make sure ldap2 is connected in export_kra_agent_pem

2015-10-12 Thread Jan Cholasta
Thanks. Pushed to: master: 61bdbd6e47b2cd2a62f7e50a6a6cbd2e272470d9 ipa-4-2: 9182f40ac549fc0104878a5599c9effe4f80c3ec On 12.10.2015 15:47, Aleš Mareček wrote: ok, it's not fault of patch itself, ACK - Original Message - From: "Aleš Mareček" To: "Jan Cholasta"