URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with parse_ipa_version()
mbasti-rh commented:
"""
Thank you for PY3 fix, it actually belongs to this ticket
https://fedorahosted.org/freeipa/ticket/6473
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with parse_ipa_version()
mbasti-rh commented:
"""
> > I was thinking about this a bit, and was wondering whether the
> > platform-specific idiosyncracies of the version handling could be safely
> > confined to
URL: https://github.com/freeipa/freeipa/pull/255
Author: tiran
Title: #255: Adjustments for setup requirements
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/255/head:pr255
git checkout pr255
From
URL: https://github.com/freeipa/freeipa/pull/254
Author: tiran
Title: #254: Replace LooseVersion with parse_ipa_version()
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/254/head:pr254
git checkout pr254
URL: https://github.com/freeipa/freeipa/pull/182
Author: tiran
Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/182/head:pr182
git
URL: https://github.com/freeipa/freeipa/pull/231
Title: #231: Do not log DM password in ca/kra installation logs
stlaz commented:
"""
I must have misclicked "close" when viewing this PR on my phone. I believe we
may rather add admin and DM passwords to the nolog_list at the point where the
URL: https://github.com/freeipa/freeipa/pull/231
Author: stlaz
Title: #231: Do not log DM password in ca/kra installation logs
Action: reopened
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/231/head:pr231
git checkout pr231
URL: https://github.com/freeipa/freeipa/pull/258
Author: tiran
Title: #258: Break ipaplatform / ipalib import cycle of hell
Action: opened
PR body:
"""
Here is an attempt to break the import cycle of hell between ipaplatform
and ipalib. All services now pass an ipalib.api object to
URL: https://github.com/freeipa/freeipa/pull/247
Title: #247: Add 'ipa local-env' subcommand
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/247
Title: #247: Add 'ipa local-env' subcommand
martbab commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/1166fbc4946596fcc2ed51a1ec6990fc7dae8964
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/247
Author: tiran
Title: #247: Add 'ipa local-env' subcommand
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/247/head:pr247
git checkout pr247
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/247
Title: #247: Add 'ipa local-env' subcommand
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with parse_ipa_version()
martbab commented:
"""
Oh right, ok. My code reading skills are sub-par today.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/254#issuecomment-261534814
--
Manage
URL: https://github.com/freeipa/freeipa/pull/254
Author: tiran
Title: #254: Replace LooseVersion with parse_ipa_version()
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/254/head:pr254
git checkout pr254
URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with parse_ipa_version()
tiran commented:
"""
> I was thinking about this a bit, and was wondering whether the
> platform-specific idiosyncracies of the version handling could be safely
> confined to the
URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with parse_ipa_version()
martbab commented:
"""
Upon closer inspection of the affected code it seems that all the code in
ipalib/ipaclient/ipapython actually parses and compares API versions, which are
sane and
URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with parse_ipa_version()
martbab commented:
"""
I was thinking about this a bit, and was wondering whether the
platform-specific idiosyncracies of the version handling could be safely
confined to the
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
lslebodn commented:
"""
>Your patch adds `config.rpath`. Is it necessary to include the file in source
>control? certmonger and sssd use the file but don't have it in git.
URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with parse_ipa_version()
tiran commented:
"""
I reworked my PR to use ```tasks.parse_ipa_version()``` for all version number
checks. Of course I ran into the import cycle of death. I broke the cycle with
a
URL: https://github.com/freeipa/freeipa/pull/254
Author: tiran
Title: #254: Replace LooseVersion with pkg_resources.parse_version
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/254/head:pr254
git checkout
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
tiran commented:
"""
Your patch adds ```config.rpath```. Is it necessary to include the file in
source control? certmonger and sssd use the file but don't have it in git.
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/1
Title: #1: Port bind-dyndb-ldap to BIND 9.11
pspacek commented:
"""
@stutiredboy There is probably a issue in path overriding logic. I will take
care of this in separate PR because it works when you have BIND 9.11 installed
in default
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/1
Title: #1: Port bind-dyndb-ldap to BIND 9.11
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/245
Title: #245: Allow full customisability of IPA CA subject DN
tiran commented:
"""
flake8 violation: ```./ipaserver/plugins/migration.py:750:80: E501 line too
long (83 > 79 characters)```
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/257
Author: tiran
Title: #257: Don't ship install subpackages with wheels
Action: opened
PR body:
"""
The install subpackages of ipaclient, ipalib and ipapython contain
helper code for installers such as ipa-client-install. They also depend
on
URL: https://github.com/freeipa/freeipa/pull/256
Author: tiran
Title: #256: Pylint: whitelist packages with extension modules
Action: opened
PR body:
"""
Pylint refuses to load extension modules from unsafe places. This
triggers import-error failures for pylint runs inside a tox virtualenv.
URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with pkg_resources.parse_version
martbab commented:
"""
Yes that's why we resorted to a direct CFFI call to RPM libs during server
version check in upgrade. We simply could not win aside from re-implementing
URL: https://github.com/freeipa/freeipa/pull/253
Title: #253: Add .eggs to Gitignore
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/253
Author: pspacek
Title: #253: Add .eggs to Gitignore
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/253/head:pr253
git checkout pr253
--
Manage your subscription
URL: https://github.com/freeipa/freeipa/pull/253
Title: #253: Add .eggs to Gitignore
tiran commented:
"""
#255 takes care of .eggs and some other minor issues in setup.py.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/253#issuecomment-261496632
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/255
Author: tiran
Title: #255: Adjustments for setup requirements
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/255/head:pr255
git checkout pr255
From
URL: https://github.com/freeipa/freeipa/pull/255
Author: tiran
Title: #255: Adjustments for setup requirements
Action: opened
PR body:
"""
Fix some typos, missing or surplus dependencies. ipatests is now
installable. Tests need further changes to be runable.
URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with pkg_resources.parse_version
tiran commented:
"""
sigh, you are right, parse_version does not handle one version comparison as we
expect: ```4.2.0-15.el7 < 4.2.0-15.el7_2.3```
```
from __future__ import
URL: https://github.com/freeipa/freeipa/pull/253
Title: #253: Add .eggs to Gitignore
tiran commented:
"""
Ah, you don't have python-wheel installed. The package download is triggered by
```setup_requires=["wheel"]```. I assumed that Fedora installs the wheel
package with pip. Apparently it
URL: https://github.com/freeipa/freeipa/pull/251
Title: #251: Add rebuild rule for template files
tiran commented:
"""
I created a ticket for you, https://fedorahosted.org/freeipa/ticket/6498 .
This **exact (!)** AC_SUBST works for me. Additional newlines cause
CONFIG_STATUS_DEPENDENCIES to
URL: https://github.com/freeipa/freeipa/pull/253
Title: #253: Add .eggs to Gitignore
pspacek commented:
"""
I'm using this script to build IPA:
~~~
rm -rvf ~/rpmbuild/{BUILD,BUILDROOT,SPECS,SOURCES,RPMS,SRPMS}
mkdir -pv ~/rpmbuild/{BUILD,BUILDROOT,SPECS,SOURCES,RPMS,SRPMS}
autoreconf -i
URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with pkg_resources.parse_version
martbab commented:
"""
I have a sneaky suspicion that the parse_version couldn't cope correctly with
some of the downstream versioning schemes like RHEL z-stream releases and
URL: https://github.com/freeipa/freeipa/pull/253
Title: #253: Add .eggs to Gitignore
tiran commented:
"""
I can't reproduce the issue locally. What's inside your .eggs directory? It's
used by setuptools.dist to cache install, build and test dependencies. It
should not be generated in the
URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with pkg_resources.parse_version
tiran commented:
"""
The PR is related to integration improvements and pip-installable effort,
https://fedorahosted.org/freeipa/ticket/6468.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/254
Author: tiran
Title: #254: Replace LooseVersion with pkg_resources.parse_version
Action: opened
PR body:
"""
pylint is having a hard time with distutils.version in tox's virtual
envs. virtualenv uses some tricks to provide a virtual distutils
40 matches
Mail list logo
