URL: https://github.com/freeipa/freeipa/pull/593
Author: tiran
Title: #593: WIP: Add make patchcheck for developers
Action: edited
Changed field: title
Original value:
"""
WIP: Add make patchcheck for developers
"""
--
Manage your subscription for the Freeipa-devel mailing list:
URL: https://github.com/freeipa/freeipa/pull/593
Author: tiran
Title: #593: WIP: Add make patchcheck for developers
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/593/head:pr593
git checkout pr593
From
Release date: 2017-03-15
The FreeIPA team would like to announce FreeIPA 4.5.0 release!
It can be downloaded from http://www.freeipa.org/page/Downloads. Builds for
Fedora 25 and Fedora 26 will be available soon in the official COPR
repository:
URL: https://github.com/freeipa/freeipa/pull/593
Author: tiran
Title: #593: WIP: Add make patchcheck for developers
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/593/head:pr593
git checkout pr593
From
URL: https://github.com/freeipa/freeipa/pull/587
Title: #587: Python 3: Fix session storage
MartinBasti commented:
"""
master:
* 42bc778c0c1de91f0d8dc695dfee4e5aea4cc1f0 Python 3: Fix session storage
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/587
Author: tiran
Title: #587: Python 3: Fix session storage
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/587/head:pr587
git checkout pr587
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/587
Title: #587: Python 3: Fix session storage
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/594
Title: #594: Fix Python 3 pylint errors
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/594
Title: #594: Fix Python 3 pylint errors
MartinBasti commented:
"""
master:
* 602b395cf19b0ae0b8ade1c13ddaf09175ed7291 Fix Python 3 pylint errors
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/594#issuecomment-286831708
--
URL: https://github.com/freeipa/freeipa/pull/594
Author: tiran
Title: #594: Fix Python 3 pylint errors
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/594/head:pr594
git checkout pr594
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/542
Title: #542: Implementation independent interface for CSR generation
MartinBasti commented:
"""
I meant this:
```diff
-Str(
-'helper',
-label=_('Name of CSR generation tool'),
-doc=_('Name of tool (e.g.
URL: https://github.com/freeipa/freeipa/pull/605
Author: MartinBasti
Title: #605: Set development version to 4.5.90
Action: opened
PR body:
"""
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/605/head:pr605
git checkout
URL: https://github.com/freeipa/freeipa/pull/604
Author: MartinBasti
Title: #604: [4.5] Set zanata version to ipa-4-5
Action: opened
PR body:
"""
Regular after-releas update, zanata branch has been created
https://fedora.zanata.org/iteration/view/freeipa/ipa-4-5
"""
To pull the PR as Git
URL: https://github.com/freeipa/freeipa/pull/542
Title: #542: Implementation independent interface for CSR generation
LiptonB commented:
"""
Regarding this comment from @MartinBasti in #590:
> > For the record, #542 removes the helper parameter of cert-get-requestdata,
> > and will be
URL: https://github.com/freeipa/freeipa/pull/433
Title: #433: csrgen: Allow some certificate fields to be specified by the user
LiptonB commented:
"""
Rebased, thanks.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/433#issuecomment-286816039
--
Manage your subscription
URL: https://github.com/freeipa/freeipa/pull/590
Title: #590: Validate user input for cert-get-requestdata
Akasurde commented:
"""
@MartinBasti Should I wait for #542 to get merged?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/590#issuecomment-286808634
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/603
Title: #603: Update 4.5 translations
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/603
Author: MartinBasti
Title: #603: Update 4.5 translations
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/603/head:pr603
git checkout pr603
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/603
Title: #603: Update 4.5 translations
MartinBasti commented:
"""
master:
* 474e6a7a71a9e51db80367018927c078f0bf1296 Update 4.5 translations
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/603#issuecomment-286803729
--
URL: https://github.com/freeipa/freeipa/pull/602
Author: tjaalton
Title: #602: configure: Use ODS_USER and NAMED_GROUP in
daemons/dnssec/*.service.in
Action: edited
Changed field: body
Original value:
"""
These are platform specific, add values for Debian and default values
for Fedora/RHEL.
URL: https://github.com/freeipa/freeipa/pull/590
Title: #590: Validate user input for cert-get-requestdata
MartinBasti commented:
"""
> For the record, #542 removes the helper parameter of cert-get-requestdata,
> and will be modified to remove the concept of different helpers entirely,
>
URL: https://github.com/freeipa/freeipa/pull/590
Title: #590: Validate user input for cert-get-requestdata
LiptonB commented:
"""
I don't think one could really add a new helper without modifying the code, so
there's probably no need to allow arbitrary strings. Given that, StrEnum seems
URL: https://github.com/freeipa/freeipa/pull/433
Author: LiptonB
Title: #433: csrgen: Allow some certificate fields to be specified by the user
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa
URL: https://github.com/freeipa/freeipa/pull/590
Title: #590: Validate user input for cert-get-requestdata
LiptonB commented:
"""
I don't think one could really add a new helper without modifying the code, so
there's probably no need to allow arbitrary strings. Given that, StrEnum seems
URL: https://github.com/freeipa/freeipa/pull/603
Title: #603: Update 4.5 translations
MartinBasti commented:
"""
selfACK when travis build pass
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/603#issuecomment-286786463
--
Manage your subscription for the Freeipa-devel
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags
lslebodn commented:
"""
On (15/03/17 08:14), MartinBasti wrote:
>Commit message amended before pushed
>
Thank you; I was busy with other tasks.
LS
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/584
Author: martbab
Title: #584: Improve the implementation of PKINIT certificate retrieval
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/584/head:pr584
git
URL: https://github.com/freeipa/freeipa/pull/584
Title: #584: Improve the implementation of PKINIT certificate retrieval
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/584
Title: #584: Improve the implementation of PKINIT certificate retrieval
MartinBasti commented:
"""
master:
* 95768de06fbef78169329af12b29e4d65e4bf157 Make PKINIT certificate request
logic consistent with other installers
*
URL: https://github.com/freeipa/freeipa/pull/584
Title: #584: Improve the implementation of PKINIT certificate retrieval
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/584
Title: #584: Improve the implementation of PKINIT certificate retrieval
MartinBasti commented:
"""
Works for me and code looks OK
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/584#issuecomment-286781521
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/582
Title: #582: Remove pkinit from ipa-replica-prepare
MartinBasti commented:
"""
master:
* 46d4d534c08d14756b989e157e87a078d174ad5c Remove pkinit from
ipa-replica-prepare
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/582
Title: #582: Remove pkinit from ipa-replica-prepare
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/582
Author: stlaz
Title: #582: Remove pkinit from ipa-replica-prepare
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/582/head:pr582
git checkout pr582
--
Manage
URL: https://github.com/freeipa/freeipa/pull/600
Author: lslebodn
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/600/head:pr600
git checkout pr600
--
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags
MartinBasti commented:
"""
Commit message amended before pushed
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/600#issuecomment-286773684
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags
MartinBasti commented:
"""
master:
* 2a4f7f2cfaf6ac5ffaf4cc2b43fa0e9b5fa3ebe4 CONFIGURE: Improve detection of
xmlrpc_c flags
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/582
Title: #582: Remove pkinit from ipa-replica-prepare
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/602
Author: tjaalton
Title: #602: configure: Use ODS_USER and NAMED_GROUP in
daemons/dnssec/*.service.in
Action: opened
PR body:
"""
These are platform specific, add values for Debian and default values
for Fedora/RHEL.
Also, use prettier output
URL: https://github.com/freeipa/freeipa/pull/567
Author: simo5
Title: #567: Configure KDC to use certs after they are deployed
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/567/head:pr567
git checkout pr567
--
URL: https://github.com/freeipa/freeipa/pull/567
Title: #567: Configure KDC to use certs after they are deployed
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/567
Title: #567: Configure KDC to use certs after they are deployed
martbab commented:
"""
Superseded by https://github.com/freeipa/freeipa/pull/584
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/567#issuecomment-286765122
--
URL: https://github.com/freeipa/freeipa/pull/584
Title: #584: Improve the implementation of PKINIT certificate retrieval
martbab commented:
"""
I have reworked the PR quite a bit and added/changed a few checks due to
replication race conditions affecting PKINIT requests from replica to master.
URL: https://github.com/freeipa/freeipa/pull/584
Author: martbab
Title: #584: Improve the implementation of PKINIT certificate retrieval
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/584/head:pr584
git
URL: https://github.com/freeipa/freeipa/pull/601
Title: #601: spec file: always provide python package aliases
HonzaCholasta commented:
"""
master:
* 990ce9eef314622440b2036742bbf34f57ba2699 spec file: always provide python
package aliases
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
tjaalton commented:
"""
sorry, I just saw PR#600 which is a subset of this
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/494#issuecomment-286758047
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/601
Title: #601: spec file: always provide python package aliases
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/601
Author: HonzaCholasta
Title: #601: spec file: always provide python package aliases
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/601/head:pr601
git checkout
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
tjaalton commented:
"""
+ack on the xmlrpc-c detection patch at least, I need that on Debian
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/494#issuecomment-286756541
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags
MartinBasti commented:
"""
Could you add ticket to commit message please
https://fedorahosted.org/freeipa/ticket/6418
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/590
Title: #590: Validate user input for cert-get-requestdata
MartinBasti commented:
"""
I have no context about how exactly certrequest is supposed to work, but IMO it
was done in that way to allow dynamically adding more helpers as plugins,
URL: https://github.com/freeipa/freeipa/pull/601
Title: #601: spec file: always provide python package aliases
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/590
Title: #590: Validate user input for cert-get-requestdata
Akasurde commented:
"""
@rcritten I don't know about backward compatibility of changing helper to
StrEnum. @MartinBasti @HonzaCholasta Can you please comment on this?
"""
See the full
URL: https://github.com/freeipa/freeipa/pull/594
Title: #594: Fix Python 3 pylint errors
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/597
Author: HonzaCholasta
Title: #597: spec file: support build without ipatests
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/597/head:pr597
git checkout pr597
--
URL: https://github.com/freeipa/freeipa/pull/601
Author: HonzaCholasta
Title: #601: spec file: always provide python package aliases
Action: opened
PR body:
"""
Provide python-ipa* aliases for python2-ipa* subpackages when the
python_provide RPM macro is not available.
"""
To pull the PR as
URL: https://github.com/freeipa/freeipa/pull/596
Author: HonzaCholasta
Title: #596: spec file: support client-only build
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/596/head:pr596
git checkout pr596
--
URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build
HonzaCholasta commented:
"""
master:
* 417f1926c48b426b34b18edb28869f4f06824873 spec file: support client-only build
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/596
Author: HonzaCholasta
Title: #596: spec file: support client-only build
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/596/head:pr596
git checkout pr596
URL: https://github.com/freeipa/freeipa/pull/597
Title: #597: spec file: support build without ipatests
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/597
Title: #597: spec file: support build without ipatests
HonzaCholasta commented:
"""
master:
* e42a846506ee7ad5e8a395da154bec64f6be3654 spec file: support build without
ipatests
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/597
Title: #597: spec file: support build without ipatests
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/590
Title: #590: Validate user input for cert-get-requestdata
rcritten commented:
"""
You are duplicating the list of helpers. It would have been better to have
helper defined as a StrEnum. If it isn't too late to change (e.g. no release
has
URL: https://github.com/freeipa/freeipa/pull/599
Title: #599: CONFIGURE: Improve error messages for optional dependencies
lslebodn commented:
"""
@tiran one more time:
The approach in PR #502 was not accepted in upstream discussion
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags
abbra commented:
"""
LGTM. Falling back to a standard check is fine.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/600#issuecomment-286735880
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/599
Title: #599: CONFIGURE: Improve error messages for optional dependencies
lslebodn commented:
"""
>NACK, you are changing the spirit of the accepted PR #502.
The approach PR #502 was not accepted in upstream discussion
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags
lslebodn commented:
"""
@tjaalton It should simplify you work on debian
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/600#issuecomment-286733233
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/600
Author: lslebodn
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags
Action: opened
PR body:
"""
The pkg-config files for xmlrpc_c libraries are shipped just
in fedora/rhel due to downstream patch. Debian does not have
pkg-config files
URL: https://github.com/freeipa/freeipa/pull/599
Author: lslebodn
Title: #599: CONFIGURE: Improve error messages for optional dependencies
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/599/head:pr599
git
URL: https://github.com/freeipa/freeipa/pull/599
Title: #599: CONFIGURE: Improve error messages for optional dependencies
tiran commented:
"""
NACK, you are changing the spirit of the accepted PR #502.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/598
Author: tiran
Title: #598: Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/598/head:pr598
git checkout
URL: https://github.com/freeipa/freeipa/pull/598
Title: #598: Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb
MartinBasti commented:
"""
master:
* b280c7bb0192485dfb622c731e31deb89d517b6f Add PYTHON_INSTALL_EXTRA_OPTIONS and
--install-layout=deb
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/598
Title: #598: Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/599
Author: lslebodn
Title: #599: CONFIGURE: Improve error messages for optional dependencies
Action: opened
PR body:
"""
https://www.redhat.com/archives/freeipa-devel/2017-March/msg00307.html
"""
To pull the PR as Git branch:
git remote add
URL: https://github.com/freeipa/freeipa/pull/594
Title: #594: Fix Python 3 pylint errors
tiran commented:
"""
@stlaz I fixed the problem with shadowed builtin type ```type```.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/594#issuecomment-286729958
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/596
Author: HonzaCholasta
Title: #596: spec file: support client-only build
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/596/head:pr596
git checkout pr596
URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build
HonzaCholasta commented:
"""
Now that PR #502 was pushed this should finally work.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/596#issuecomment-286729368
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
pvoborni commented:
"""
If it improves messages then I assume so provided that in won't be
controversial in other aspects.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/502
Author: tiran
Title: #502: Make pylint and jsl optional
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/502/head:pr502
git checkout pr502
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
HonzaCholasta commented:
"""
master:
* f1f63506caf88e4d86ea2bfdc7d25eceaf689bc5 Make pylint and jsl optional
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
On (15/03/17 05:32), Petr Vobornik wrote:
>In any case spending so much time discussing so minor change is a waste of
>time. I'd push it.
>
Will you accept patch whith improves
URL: https://github.com/freeipa/freeipa/pull/598
Title: #598: Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
tiran commented:
"""
@pvoborni For the use case "easy for developers" the ```make lint``` target is
not sufficient. It tests only a small subset and doesn't check Python 3 issues.
PR #593 provides a
URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build
pvomacka commented:
"""
ipa server build without tests does not work, so NACK
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/596#issuecomment-286728170
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
pvoborni commented:
"""
There was no result in the upstream discussion. My personal opinion is that one
way or the other can work. They are for different use cases. I tend to prefer
the "be easier for
URL: https://github.com/freeipa/freeipa/pull/598
Title: #598: Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb
tjaalton commented:
"""
Yep, works great, thanks!
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/598#issuecomment-286727748
--
Manage your subscription
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
HonzaCholasta commented:
"""
4.5.1 will be an official release too.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/502#issuecomment-286727609
--
Manage your subscription for the
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
On (15/03/17 05:17), Jan Cholasta wrote:
>@lslebodn, nobody said that this has to be the last lint build related patch
>ever, we can change the behavior later, even on top of this
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
HonzaCholasta commented:
"""
@lslebodn, nobody said that this has to be the last lint build related patch
ever, we can change the behavior later, even on top of this PR. I would rather
push this now and
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
On (14/03/17 16:05), Christian Heimes wrote:
>https://github.com/freeipa/freeipa/pull/502#issue-209980292
>
>two thumbs up, one heart, no thumbs down
>
My naive assumption was
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
>PR #593 is not related to default yes; It is about something else.
Current version does not fix concerns; because default should be yes as it was
discussed in
URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build
pvomacka commented:
"""
@HonzaCholasta Thank you for update - only client build on Fedora now works. So
ACK once the travis pass.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
>PR #593 is not related to default yes; It is about something else.
Current version does not fix concerns; because default should be yes as it was
discussed in
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
> This PR makes packaging IPA 4.5 on RHEL 7 easier for me, so thumbs up from me.
I understand it is more convenient to have less extra configure options in rhel;
But it was
URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional
lslebodn commented:
"""
> This PR makes packaging IPA 4.5 on RHEL 7 easier for me, so thumbs up from me.
I understand it is more convenient to have less extra configure options in rhel;
But it was
URL: https://github.com/freeipa/freeipa/pull/598
Title: #598: Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb
MartinBasti commented:
"""
@tjaalton could you please check this PR?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/598#issuecomment-286719071
--
1 - 100 of 175 matches
Mail list logo
