Re: [Freeipa-devel] [PATCH 0405] idviews: Add user certificate attribute to user ID overrides

On 04/19/2016 08:20 AM, Jan Cholasta wrote: > On 13.4.2016 14:13, Tomas Babej wrote: >> On 04/13/2016 09:55 AM, Tomas Babej wrote: >>> On 04/07/2016 01:53 PM, Sumit Bose wrote: >>>> On Mon, Apr 04, 2016 at 04:27:02PM +0200, Jan Cholasta wrote: >>>>> H

Re: [Freeipa-devel] [PATCH 0405] idviews: Add user certificate attribute to user ID overrides

On 04/13/2016 09:55 AM, Tomas Babej wrote: > On 04/07/2016 01:53 PM, Sumit Bose wrote: >> On Mon, Apr 04, 2016 at 04:27:02PM +0200, Jan Cholasta wrote: >>> Hi, >>> >>> On 1.4.2016 16:53, Tomas Babej wrote: >>>> Hi, >>>> >>>&

Re: [Freeipa-devel] [PATCH 0405] idviews: Add user certificate attribute to user ID overrides

On 04/07/2016 01:53 PM, Sumit Bose wrote: > On Mon, Apr 04, 2016 at 04:27:02PM +0200, Jan Cholasta wrote: >> Hi, >> >> On 1.4.2016 16:53, Tomas Babej wrote: >>> Hi, >>> >>> this extends the user ID overrides with capability to store the user &

[Freeipa-devel] [PATCH 0406] admintool: Remove the option to override the log file

Hi, This option has been rarely used, and can be replaced by proper shell output redirection. https://fedorahosted.org/freeipa/ticket/5385 Tomas From ee3b3d295e696488bef9abd16eb3108255afd0b0 Mon Sep 17 00:00:00 2001 From: Tomas Babej <tba...@redhat.com> Date: Tue, 10 Nov 2015 14:20:45

[Freeipa-devel] [PATCH 0405] idviews: Add user certificate attribute to user ID overrides

Hi, this extends the user ID overrides with capability to store the user certificate. https://fedorahosted.org/freeipa/ticket/4955 Tomas From 4ab4ac5871f14d164544298fc5763321b8ef7558 Mon Sep 17 00:00:00 2001 From: Tomas Babej <tba...@redhat.com> Date: Thu, 3 Mar 2016 15:14:10 +0100 S

Re: [Freeipa-devel] [MAN] [PATCH] 0004 Fix phrasing in man page for stageuser.py

On 07/07/2015 08:44 AM, Tomas Babej wrote: > > > On 07/04/2015 02:03 PM, Jérôme Fenal wrote: >> Hi all, >> >> A quick patch to the man page part of stageuser to avoid ambiguity in >> the phrasing, spotted while translating the page. >> >> Regard

Re: [Freeipa-devel] [PATCH 0087] Pylint: enable parallelism

On 03/07/2016 10:58 AM, Petr Spacek wrote: > On 4.3.2016 14:13, Tomas Babej wrote: >> On 03/01/2016 03:46 PM, Petr Spacek wrote: >>> Hello, >>> >>> Pylint: enable parallelism >>> >>> The config file specifies 8 cores but Pylint very

Re: [Freeipa-devel] [PATCH 0404] ipalib: Fix user certificate docstrings

On 03/07/2016 05:50 AM, Fraser Tweedale wrote: > On Fri, Mar 04, 2016 at 12:49:46PM +0100, Tomas Babej wrote: >> Hi, >> >> this fixes incorrect usercertificate attribute docstrings in several IPA >> objects. >> >> Tomas >> > ACK. > Pushed

Re: [Freeipa-devel] [PATCH 0087] Pylint: enable parallelism

On 03/01/2016 03:46 PM, Petr Spacek wrote: > Hello, > > Pylint: enable parallelism > > The config file specifies 8 cores but Pylint very quickly > ends up with 3 cores so do not worry about overwhelming your system. I like the idea of the patch, however, on my single-CPU VM this causes

Re: [Freeipa-devel] [PATCH 0429] fix suspicious except statement

On 03/02/2016 06:23 PM, Martin Basti wrote: > > > On 02.03.2016 17:17, Martin Basti wrote: >> Patch attached, read commit message for more info. >> >> > https://fedorahosted.org/freeipa/ticket/5718 > > Updated patch attached. > > Good catch, ACK. Issue is present both in master and

[Freeipa-devel] [PATCH 0404] ipalib: Fix user certificate docstrings

Hi, this fixes incorrect usercertificate attribute docstrings in several IPA objects. Tomas From a056b839c48363721d0c27a196e9b47bdd28f12a Mon Sep 17 00:00:00 2001 From: Tomas Babej <tba...@redhat.com> Date: Fri, 4 Mar 2016 12:45:39 +0100 Subject: [PATCH] ipalib: Fix user certificate docs

Re: [Freeipa-devel] [PATCH] 951 webui: fail nicely if cookies are disabled

On 01/28/2016 04:25 PM, Petr Vobornik wrote: > On 01/28/2016 04:23 PM, Tomas Babej wrote: >> >> >> On 01/28/2016 04:15 PM, Petr Vobornik wrote: >>> Reworks also sessionStorage test because disablement of cookies might be >>> connected with sessionStora

Re: [Freeipa-devel] [PATCH 0425] pylint: suppress false positive no-member errors

On 03/02/2016 01:35 PM, David Kupka wrote: > Tested with pylint-1.5.4-2, works for me, ACK. > > - Original Message - > From: "Martin Basti" > To: "freeipa-devel" > Sent: Tuesday, March 1, 2016 5:55:54 PM > Subject: Re: [Freeipa-devel]

Re: [Freeipa-devel] [PATCH] 954 fix incorrect name of ipa-winsync-migrate command in help

On 03/02/2016 12:42 PM, Petr Vobornik wrote: > Help and status text used incorrect name "ipa-migrate-winsync" > > https://fedorahosted.org/freeipa/ticket/5713 > > ACK, Pushed to: ipa-4-2: 7151ea394aac00ca596a8d7460a2fcefd258b36e ipa-4-3: 57e02c7140fe2ad6fe6a6bc9823f84500bb78732 master:

Re: [Freeipa-devel] [PATCH 0086] Fix URL for reporting bugs in string

On 03/01/2016 03:23 PM, Petr Spacek wrote: > Hello, > > Fix URL for reporting bugs in strings. > ACK, good catch. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [PATCH 0086] Fix URL for reporting bugs in string

On 03/01/2016 03:25 PM, Tomas Babej wrote: > > > On 03/01/2016 03:23 PM, Petr Spacek wrote: >> Hello, >> >> Fix URL for reporting bugs in strings. >> > > ACK, good catch. > Pushed to master: e9922c36b15476f99426d0e85fde857887fb5c7d -- Manage your

Re: [Freeipa-devel] [PATCH] 0007 Refactor test_sudocmd_plugin

On 03/01/2016 01:27 PM, Aleš Mareček wrote: > ACK. > Thank you! > - alich - > > - Original Message - >> From: "Filip Skola" >> To: "Aleš Mareček" >> Cc: freeipa-devel@redhat.com, "Milan Kubík" >> Sent: Wednesday, February

Re: [Freeipa-devel] [PATCH] 0008 Refactor test_sudocmdgroup_plugin, create SudoCmdGroupTracker

On 03/01/2016 01:29 PM, Aleš Mareček wrote: > ACK. > Thank you! > > Master push: Make sure it will go *after or together with* the previous patch > from Filip, #0007, thanks! > > - alich - > > - Original Message - >> From: "Filip Skola" >> To: "Aleš Mareček"

Re: [Freeipa-devel] [PATCH 00136] use LDAPS during standalone CA/KRA subsystem deployment

On 02/26/2016 06:03 PM, Martin Babinsky wrote: > This patch fixes https://fedorahosted.org/freeipa/ticket/5570 and also > enables CA installation on CA-less master with hardened dirsrv > configuration. > > When testing I ran into the issue with Dogtag restart during KRA > installation [1] which

Re: [Freeipa-devel] [PATCH] 953 advise: configure TLS in redhat_nss_pam_ldapd and redhat_nss_ldap plugins

On 03/01/2016 10:36 AM, Petr Vobornik wrote: > On 02/26/2016 03:29 PM, Petr Spacek wrote: >> On 25.2.2016 18:01, Petr Vobornik wrote: >>> I did not add --enableldapstarttls to config_redhat_nss_ldap because >>> I'm not >>> sure if it is present on el5 (IMO it is not). >>> >>> authconfig in: >>>

Re: [Freeipa-devel] [PATCH 200] slapi-nis: update configuration to allow external members

On 02/29/2016 01:07 PM, Tomas Babej wrote: > > > On 02/29/2016 07:19 AM, Jan Cholasta wrote: >> On 26.2.2016 21:38, Lukas Slebodnik wrote: >>> On (26/02/16 12:37), Tomas Babej wrote: >>>> >>>> >>>> On 02/26/2016 07:30 AM, Jan

Re: [Freeipa-devel] [PATCH 0401] ipa-adtrust-install: Allow dash in the NETBIOS name

On 02/29/2016 03:20 PM, Martin Babinsky wrote: > On 02/29/2016 02:59 PM, Tomas Babej wrote: >> >> >> On 02/29/2016 02:04 PM, Martin Babinsky wrote: >>> On 02/25/2016 02:13 PM, Tomas Babej wrote: >>>> Hi, >>>> >>>> Dash should be

Re: [Freeipa-devel] [PATCH 0401] ipa-adtrust-install: Allow dash in the NETBIOS name

On 02/29/2016 02:04 PM, Martin Babinsky wrote: > On 02/25/2016 02:13 PM, Tomas Babej wrote: >> Hi, >> >> Dash should be one of the allowed characters in the netbios names, >> so relax the too strict validation. >> >> Note: the set of allowed characters

Re: [Freeipa-devel] [PATCH 0421] Make PTR records check optional for IPA installation

On 02/29/2016 01:20 PM, Tomas Babej wrote: > > > On 02/26/2016 10:01 AM, Oleg Fayans wrote: >> >> >> On 02/25/2016 12:06 PM, Petr Spacek wrote: >>> On 24.2.2016 15:13, Martin Basti wrote: >>>> https://fedorahosted.org/freeipa/ticket/5686 >>

Re: [Freeipa-devel] [PATCH 0421] Make PTR records check optional for IPA installation

On 02/26/2016 10:01 AM, Oleg Fayans wrote: > > > On 02/25/2016 12:06 PM, Petr Spacek wrote: >> On 24.2.2016 15:13, Martin Basti wrote: >>> https://fedorahosted.org/freeipa/ticket/5686 >>> >>> Patch attached. >> >> LGTM, ACK if it passes QE testing. >> > That did it. Works with both

Re: [Freeipa-devel] [PATCH 200] slapi-nis: update configuration to allow external members

On 02/29/2016 07:19 AM, Jan Cholasta wrote: > On 26.2.2016 21:38, Lukas Slebodnik wrote: >> On (26/02/16 12:37), Tomas Babej wrote: >>> >>> >>> On 02/26/2016 07:30 AM, Jan Cholasta wrote: >>>> On 22.2.2016 19:56, Tomas Babej wrote: >>>

[Freeipa-devel] [PATCH 0403] adtrustinstance: Make sure smb.conf exists

point me to it? I referenced the IPA ticket for now. https://fedorahosted.org/freeipa/ticket/5687 From 4fd714beec5c95e079028836168e0188ed27ff0c Mon Sep 17 00:00:00 2001 From: Tomas Babej <tba...@redhat.com> Date: Fri, 26 Feb 2016 14:28:26 +0100 Subject: [PATCH] adtrustinstance: Make sure sm

Re: [Freeipa-devel] [PATCH 200] slapi-nis: update configuration to allow external members

On 02/26/2016 07:30 AM, Jan Cholasta wrote: > On 22.2.2016 19:56, Tomas Babej wrote: >> >> >> On 02/22/2016 06:14 PM, Alexander Bokovoy wrote: >>> On Mon, 22 Feb 2016, Tomas Babej wrote: >>>> >>>> >>>> On 02/22/2016 11:48 AM, Al

[Freeipa-devel] [PATCH 0401] ipa-adtrust-install: Allow dash in the NETBIOS name

From: Tomas Babej <tba...@redhat.com> Date: Thu, 25 Feb 2016 14:02:08 +0100 Subject: [PATCH] ipa-adtrust-install: Allow dash in the NETBIOS name Dash should be one of the allowed characters in the netbios names, so relax the too strict validation. Note: the set of allowed characters might

Re: [Freeipa-devel] [PATCH 0134] CI tests: use old schema when testing hostmask-based sudo rules

On 02/18/2016 10:32 AM, Martin Babinsky wrote: > https://fedorahosted.org/freeipa/ticket/5625 ACK, works fine for me. Thanks for the patch. Pushed to master: 94a836dd46e5e041443b7da03e4ce8a7a7aaa7e3 Pushed to ipa-4-2: 61475631f64206d771e3fd243220be242f4bdd38 Tomas -- Manage your subscription

[Freeipa-devel] [PATCH 0400] l10n: Remove Transifex configuration

Hi, We're not using Transifex to manage our translations anymore. Tomas From 89b2da7d936b6c8aad115e05375c4dcdf8af11c5 Mon Sep 17 00:00:00 2001 From: Tomas Babej <tba...@redhat.com> Date: Wed, 20 Jan 2016 19:44:25 +0100 Subject: [PATCH] l10n: Remove Transifex configuration We're not

Re: [Freeipa-devel] [PATCH 0416-0419] fix broken configuration of sidgen and extdom plugins

On 02/23/2016 01:25 PM, Martin Basti wrote: > > > On 23.02.2016 13:02, Alexander Bokovoy wrote: >> On Tue, 23 Feb 2016, Martin Basti wrote: >>> From f2ae1bd129a1741500d2f3dcb86a0da553604d15 Mon Sep 17 00:00:00 2001 >>> From: Martin Basti >>> Date: Tue, 23 Feb 2016 10:37:47

Re: [Freeipa-devel] [PATCH 0416-0417] fix broken configuration of sidgen and extdom plugins

On 02/22/2016 07:15 PM, Martin Basti wrote: > > > On 22.02.2016 17:05, Martin Basti wrote: >> >> >> On 19.02.2016 15:02, Alexander Bokovoy wrote: >>> On Fri, 19 Feb 2016, Petr Vobornik wrote: On 02/19/2016 11:12 AM, Alexander Bokovoy wrote: > On Fri, 19 Feb 2016, Martin Basti wrote:

Re: [Freeipa-devel] [PATCH 200] slapi-nis: update configuration to allow external members

On 02/22/2016 06:14 PM, Alexander Bokovoy wrote: > On Mon, 22 Feb 2016, Tomas Babej wrote: >> >> >> On 02/22/2016 11:48 AM, Alexander Bokovoy wrote: >>> Hi, >>> >>> attached patch should update compat tree configuration if it exist to >>

Re: [Freeipa-devel] [PATCH 200] slapi-nis: update configuration to allow external members

On 02/22/2016 11:48 AM, Alexander Bokovoy wrote: > Hi, > > attached patch should update compat tree configuration if it exist to > follow slapi-nis 0.55 which has support for external members of IPA > groups. > > However, the real work is done in SSSD. These patches are not upstreamed > yet.

Re: [Freeipa-devel] [PATCH 0128] ipalib/cli.py: pythonify Collector class

On 01/28/2016 04:44 PM, Martin Babinsky wrote: > On 01/28/2016 03:20 PM, Tomas Babej wrote: >> >> >> On 01/27/2016 03:58 PM, Martin Babinsky wrote: >>> On 01/18/2016 06:43 PM, Martin Babinsky wrote: >>>> A little patch that shoul

Re: [Freeipa-devel] [PATCH] 951 webui: fail nicely if cookies are disabled

On 01/28/2016 04:15 PM, Petr Vobornik wrote: > Reworks also sessionStorage test because disablement of cookies might be > connected with sessionStorage and localStorage. E.g. Chrome raises > exception when *Storage is accessed with "Block sites from setting any > data" settings set in "Content

Re: [Freeipa-devel] [PATCH 0128] ipalib/cli.py: pythonify Collector class

On 01/27/2016 03:58 PM, Martin Babinsky wrote: > On 01/18/2016 06:43 PM, Martin Babinsky wrote: >> A little patch that should make some future pylint errors disappear. >> >> >> > Attaching updated patch that does not promote direct molestation of > instance dictionaries. > > > Patch looks

Re: [Freeipa-devel] [PATCH 0399] ipa-getkeytab: Handle the possibility of not obtaining a result

On 01/27/2016 05:03 PM, Martin Babinsky wrote: > On 01/26/2016 05:48 PM, Tomas Babej wrote: >> Hi, >> >> The ldap_result operation can time out, returning a NULL result, >> which in turn causes the parsing operation to crash. >> >> https://fedorahos

Re: [Freeipa-devel] [PATCH 540] cert renewal: import all external CA certs on IPA CA cert renewal

On 01/27/2016 08:06 AM, Martin Babinsky wrote: > On 01/25/2016 08:19 AM, Jan Cholasta wrote: >> On 22.1.2016 12:28, Jan Cholasta wrote: >>> On 22.1.2016 10:34, Martin Babinsky wrote: On 01/21/2016 10:27 AM, Jan Cholasta wrote: > Hi, > > the attached patch fixes >

Re: [Freeipa-devel] [PATCH 543] CA install: explicitly set dogtag_version to 10

On 01/27/2016 12:10 PM, Martin Babinsky wrote: > On 01/27/2016 09:27 AM, Jan Cholasta wrote: >> On 26.1.2016 10:23, Martin Babinsky wrote: >>> On 01/26/2016 10:14 AM, Martin Babinsky wrote: On 01/25/2016 08:56 AM, Alexander Bokovoy wrote: > On Mon, 25 Jan 2016, Jan Cholasta wrote:

Re: [Freeipa-devel] [PATCH 540] cert renewal: import all external CA certs on IPA CA cert renewal

On 01/27/2016 02:53 PM, Jan Cholasta wrote: > On 27.1.2016 14:41, Tomas Babej wrote: >> >> >> On 01/27/2016 08:06 AM, Martin Babinsky wrote: >>> On 01/25/2016 08:19 AM, Jan Cholasta wrote: >>>> On 22.1.2016 12:28, Jan Cholasta wrote: >>>>>

Re: [Freeipa-devel] [PATCH] webui: 949 crash nicely if sessionStorage is not available

On 01/26/2016 06:59 PM, Tomas Babej wrote: > ACK > > On 01/26/2016 06:57 PM, Petr Vobornik wrote: >> https://fedorahosted.org/freeipa/ticket/5643 >> >> > Pushed to master: 6e1eb5bc8f83faa38203bd308896d0b15f359b24 -- Manage your subscription for the Fre

Re: [Freeipa-devel] [PATCH 155] ipa-kdb: get_authz_data_types() make sure entry can be NULL

On 01/06/2016 12:15 PM, Sumit Bose wrote: > Hi, > > this patch fixes and issue found by Simo when he called > get_authz_data_types() with the second argument being NULL. > This function determines which type of authorization data should be > added to the Kerberos ticket. There are global

Re: [Freeipa-devel] [PATCH 155] ipa-kdb: get_authz_data_types() make sure entry can be NULL

On 01/27/2016 04:04 PM, Tomas Babej wrote: > > > On 01/06/2016 12:15 PM, Sumit Bose wrote: >> Hi, >> >> this patch fixes and issue found by Simo when he called >> get_authz_data_types() with the second argument being NULL. >> This function determines

[Freeipa-devel] [PATCH 0399] ipa-getkeytab: Handle the possibility of not obtaining a result

Hi, The ldap_result operation can time out, returning a NULL result, which in turn causes the parsing operation to crash. https://fedorahosted.org/freeipa/ticket/5642 Tomas From 3b4482cdd5494890a220bfd935874fa84677524c Mon Sep 17 00:00:00 2001 From: Tomas Babej <tba...@redhat.com> Date: T

Re: [Freeipa-devel] [PATCH] webui: 949 crash nicely if sessionStorage is not available

ACK On 01/26/2016 06:57 PM, Petr Vobornik wrote: > https://fedorahosted.org/freeipa/ticket/5643 > > -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH 0397] ipapython: Use custom datetime to LDAP generalized time

/freeipa/ticket/5579 Tomas From d746dd233c07b0dc81f539f502844a16e5cc97e2 Mon Sep 17 00:00:00 2001 From: Tomas Babej <tba...@redhat.com> Date: Fri, 15 Jan 2016 12:20:12 +0100 Subject: [PATCH] ipapython: Use custom datetime to LDAP generalized time converter For the dates older than 1900,

Re: [Freeipa-devel] [PATCH 536] ipapython: remove default_encoding_utf8

On 01/12/2016 10:24 AM, Jan Cholasta wrote: > On 6.1.2016 12:33, Christian Heimes wrote: >> On 2016-01-05 11:30, Tomas Babej wrote: >>> >>> >>> On 01/05/2016 08:54 AM, Jan Cholasta wrote: >>>> Hi, >>>> >>>> the attached

[Freeipa-devel] [PATCH 0398] logger: Use warning instead of warn

Hi, this should build up to another pylint-related patch Martin^2 has in works. Tomas From b5e445c1dfdd469a7b85ba418b910f2a85fa470f Mon Sep 17 00:00:00 2001 From: Tomas Babej <tba...@redhat.com> Date: Fri, 15 Jan 2016 16:25:33 +0100 Subject: [PATCH] logger: Use warning instead o

Re: [Freeipa-devel] [PATCH 0398] logger: Use warning instead of warn

On 01/15/2016 05:12 PM, Martin Basti wrote: > > > On 15.01.2016 16:27, Tomas Babej wrote: >> Hi, >> >> this should build up to another pylint-related patch Martin^2 has in works. >> >> Tomas >> >> >> > NACK :) > > **

Re: [Freeipa-devel] import rpm causes failure during IPA caless install

On 01/08/2016 01:45 PM, Martin Basti wrote: > Hello all, > > fix for ticket https://fedorahosted.org/freeipa/ticket/5535 > requires to import rpm module > > This import somehow breaks nsslib in IPA > https://fedorahosted.org/freeipa/ticket/5572 > > > We have 2 ways how to fix it: > > 1)

Re: [Freeipa-devel] import rpm causes failure during IPA caless install

On 01/08/2016 03:31 PM, Lukas Slebodnik wrote: > On (08/01/16 14:14), Jan Cholasta wrote: >> On 8.1.2016 14:09, Martin Basti wrote: >>> >>> >>> On 08.01.2016 14:00, Martin Kosek wrote: On 01/08/2016 01:45 PM, Martin Basti wrote: > Hello all, > > fix for ticket

Re: [Freeipa-devel] [PATCH 0118] fix Py3 incompatible exception instantiation in replica install code

wever, there are additional occurrences in the code base, attaching a patch. Tomas From 7475c1650e5cc5478a65166d853822b93419cd5e Mon Sep 17 00:00:00 2001 From: Tomas Babej <tba...@redhat.com> Date: Fri, 8 Jan 2016 18:23:35 +0100 Subject: [PATCH] py3: Remove py3 incompatible exception handling

Re: [Freeipa-devel] [PATCH 536] ipapython: remove default_encoding_utf8

On 01/05/2016 08:54 AM, Jan Cholasta wrote: > Hi, > > the attached patch replaces the default_encoding_utf8 binary module with > 2 lines of equivalent Python code. > > Honza > > > This looks fine to me, however, I wonder, why this approach was ever taken? The sys.setdefaultencoding is

Re: [Freeipa-devel] [PATCHES 531-532] server install: redirect ipa-client-install output to standard output

On 12/14/2015 12:52 PM, Jan Cholasta wrote: > Hi, > > the attached patches fix . > > Honza > > > Shouldn't skip_output be also marked as incompatible with redirect_output? Tomas -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH] 0047 dogtaginstance: remove unused function 'check_inst'

On 12/14/2015 06:56 AM, Fraser Tweedale wrote: > Just some drive-by cleanup of an unused function. > > Cheers, > Fraser > ACK, thanks for the cleanup! Pushed to master: 38861428e76c19107a03f07530e3724aee60a270 -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 534] replica promotion: let ipa-client-install validate enrollment options

On 12/14/2015 03:37 PM, Jan Cholasta wrote: > Hi, > > the attached patch fixes . > > Honza > > > ACK, Pushed to master: 110e3dfc5401899ae0a54cc979ca0820e53cfa02 -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCHES 531-532] server install: redirect ipa-client-install output to standard output

On 12/14/2015 12:57 PM, Jan Cholasta wrote: > On 14.12.2015 12:54, Tomas Babej wrote: >> >> >> On 12/14/2015 12:52 PM, Jan Cholasta wrote: >>> Hi, >>> >>> the attached patches fix <https://fedorahosted.org/freeipa/ticket/5527>. >>> &

Re: [Freeipa-devel] [PATCH 533] replica promotion: notify user about ignoring client enrollment options

On 12/14/2015 02:02 PM, Jan Cholasta wrote: > On 14.12.2015 13:41, Jan Cholasta wrote: >> Hi, >> >> the attached patch fixes . > > Self-NACK, updated patch attached. > > > ACK, works fine. -- Manage your subscription for the Freeipa-devel

Re: [Freeipa-devel] [PATCH 0373] Upgrade: Fix IPA version comparison

On 12/14/2015 10:21 AM, Martin Basti wrote: > > > On 14.12.2015 09:24, Martin Kosek wrote: >> On 12/14/2015 07:21 AM, Jan Cholasta wrote: >>> On 11.12.2015 19:01, Tomas Babej wrote: >>>> >>>> On 12/11/2015 09:36 AM, Martin Kosek wrote:

Re: [Freeipa-devel] [PATCH 0378] Tests: fix always true assertion

On 12/14/2015 12:24 PM, Martin Basti wrote: > Fixes: > /usr/lib/python2.7/site-packages/ipatests/test_cmdline/test_ipagetkeytab.py:116: > SyntaxWarning: assertion is always true, perhaps remove parentheses? > > Patch attached. > > Nice catch. ACK. Pushed to master:

Re: [Freeipa-devel] [PATCHES 531-532] server install: redirect ipa-client-install output to standard output

On 12/14/2015 02:41 PM, Jan Cholasta wrote: > On 14.12.2015 14:20, Tomas Babej wrote: >> >> >> On 12/14/2015 12:57 PM, Jan Cholasta wrote: >>> On 14.12.2015 12:54, Tomas Babej wrote: >>>> >>>> >>>> On 12/14/2015 12:52 PM,

Re: [Freeipa-devel] [PATCH 0374-0375] Fix permissions on newly created directories

On 12/11/2015 07:19 PM, Martin Basti wrote: > > > On 10.12.2015 15:18, Martin Basti wrote: >> Hello, >> >> patch 0374 fixes the ticket, but I found more issues with directory >> permission, I fixed them in 0375 >> >> https://fedorahosted.org/freeipa/ticket/5520 >> >> Patches attached. > >

Re: [Freeipa-devel] [PATCH 533] replica promotion: notify user about ignoring client enrollment options

On 12/14/2015 02:19 PM, Tomas Babej wrote: > > > On 12/14/2015 02:02 PM, Jan Cholasta wrote: >> On 14.12.2015 13:41, Jan Cholasta wrote: >>> Hi, >>> >>> the attached patch fixes <https://fedorahosted.org/freeipa/ticket/5530>. >> >>

Re: [Freeipa-devel] [PATCH 0070] Makefile: disable parallel build

On 12/11/2015 09:35 AM, Petr Spacek wrote: > Hello, > > Makefile: disable parallel build > > IPA build system cannot cope with parallel build anyway, so this patch > disables parallel build explicitly so it does not blow up when user > has -j specified in default MAKEOPTS. > > > ACK.

Re: [Freeipa-devel] [PATCH 0117] ipa-client-install: create a temporary directory for ccache files

On 12/14/2015 05:31 PM, Martin Babinsky wrote: > fixes https://fedorahosted.org/freeipa/ticket/5528 Works as expected, code-wise looks good. Thanks for looking into this, ACK! Pushed to master: 5886f87f974fa508047a21350c2e6e75a3001da6 -- Manage your subscription for the Freeipa-devel

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

On 12/10/2015 09:05 AM, Lukas Slebodnik wrote: > On (08/12/15 14:47), Tomas Babej wrote: >> >> >> On 12/03/2015 04:33 PM, Tomas Babej wrote: >>> >>> >>> On 12/03/2015 04:26 PM, Aleš Mareček wrote: >>>> Hello, >>>> >>&g

Re: [Freeipa-devel] [PATCH 0071] replica: Fix ipa-replica-install with replica file (domain, level 0).

On 12/09/2015 08:31 AM, David Kupka wrote: > On 08/12/15 16:33, Tomas Babej wrote: >> >> >> On 12/08/2015 04:20 PM, Oleg Fayans wrote: >>> ACK. The initial issue is fixed. >>> >>> On 12/08/2015 03:03 PM, David Kupka wrote: >>>> https://

Re: [Freeipa-devel] [PATCH 0395] replicainstall: Make sure the enrollment state is preserved

On 12/11/2015 06:05 PM, Martin Basti wrote: > > > On 11.12.2015 14:03, Tomas Babej wrote: >> >> On 12/10/2015 02:22 PM, Tomas Babej wrote: >>> >>> On 12/10/2015 02:18 PM, Tomas Babej wrote: >>>> Hi, >>>> >>>&

Re: [Freeipa-devel] [PATCHES 523-525] replica install: add remote connection check over API

On 12/11/2015 05:37 PM, Martin Basti wrote: > > > On 11.12.2015 15:40, Jan Cholasta wrote: >> On 11.12.2015 08:03, Jan Cholasta wrote: >>> On 11.12.2015 07:08, Jan Cholasta wrote: On 10.12.2015 15:56, Martin Babinsky wrote: > On 12/10/2015 09:48 AM, Jan Cholasta wrote: >> On

Re: [Freeipa-devel] [PATCH 0113] properly add ACIs to custodia container during IPA upgrade

On 12/11/2015 10:37 AM, David Kupka wrote: > On 10/12/15 10:14, Martin Babinsky wrote: >> On 12/08/2015 10:45 AM, Martin Babinsky wrote: >>> fixes https://fedorahosted.org/freeipa/ticket/5524 >>> >>> >>> >> >> Attaching updated patch with simpler fix suggested by Jan. >> >> >> > Thanks for the

Re: [Freeipa-devel] [PATCH 0113] properly add ACIs to custodia container during IPA upgrade

On 12/11/2015 12:50 PM, Tomas Babej wrote: > > > On 12/11/2015 10:37 AM, David Kupka wrote: >> On 10/12/15 10:14, Martin Babinsky wrote: >>> On 12/08/2015 10:45 AM, Martin Babinsky wrote: >>>> fixes https://fedorahosted.org/freeipa/ticket/5524 >>&g

Re: [Freeipa-devel] [PATCH 0395] replicainstall: Make sure the enrollment state is preserved

On 12/10/2015 02:22 PM, Tomas Babej wrote: > > > On 12/10/2015 02:18 PM, Tomas Babej wrote: >> Hi, >> >> During the promote_check phase, the subsequent checks after the machine >> is enrolled may cause the installation to abort, hence leaving it >> enro

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

On 12/11/2015 02:01 PM, Lukas Slebodnik wrote: > On (10/12/15 11:40), Tomas Babej wrote: >> On 12/10/2015 09:05 AM, Lukas Slebodnik wrote: >>> On (08/12/15 14:47), Tomas Babej wrote: >>>> >>>> >>>> On 12/03/2015 04:33 PM, Tomas Babej wrote:

Re: [Freeipa-devel] [PATCHES 523-525] replica install: add remote connection check over API

On 12/11/2015 03:40 PM, Jan Cholasta wrote: > On 11.12.2015 08:03, Jan Cholasta wrote: >> On 11.12.2015 07:08, Jan Cholasta wrote: >>> On 10.12.2015 15:56, Martin Babinsky wrote: On 12/10/2015 09:48 AM, Jan Cholasta wrote: > On 9.12.2015 16:38, Jan Cholasta wrote: >> On 9.12.2015

Re: [Freeipa-devel] [PATCH 0373] Upgrade: Fix IPA version comparison

On 12/11/2015 09:36 AM, Martin Kosek wrote: > On 12/10/2015 05:09 PM, Martin Basti wrote: >> >> >> On 10.12.2015 15:49, Tomas Babej wrote: >>> >>> On 12/10/2015 11:23 AM, Martin Basti wrote: >>>> >>>> On 10.12.2015 09:13, Lukas

Re: [Freeipa-devel] [PATCH 0395] replicainstall: Make sure the enrollment state is preserved

On 12/10/2015 02:18 PM, Tomas Babej wrote: > Hi, > > During the promote_check phase, the subsequent checks after the machine > is enrolled may cause the installation to abort, hence leaving it > enrolled even though it might not have been prior to the execution of > the i

[Freeipa-devel] [PATCH 0395] replicainstall: Make sure the enrollment state is preserved

is called on the machine that has not been enrolled before in case of failure during the promote_check phase. https://fedorahosted.org/freeipa/ticket/5529 From 183cea1e3a7efd8574d6b74b9181485e6cf7d19b Mon Sep 17 00:00:00 2001 From: Tomas Babej <tba...@redhat.com> Date: Thu, 10 Dec 2015 14:10:18

Re: [Freeipa-devel] [PATCH 0373] Upgrade: Fix IPA version comparison

On 12/10/2015 11:23 AM, Martin Basti wrote: > > > On 10.12.2015 09:13, Lukas Slebodnik wrote: >> On (09/12/15 19:22), Martin Basti wrote: >>> https://fedorahosted.org/freeipa/ticket/5535 >>> >>> Patch attached. >> >From 8ef93485d61e8732166fb0c5b6c4559209740f3e Mon Sep 17 00:00:00 2001 >>>

Re: [Freeipa-devel] [PATCH 0068] add missing /ipaplatform/constants.py to .gitignore

On 12/08/2015 01:26 PM, Tomas Babej wrote: > > > On 12/08/2015 01:26 PM, Petr Spacek wrote: >> Hello, >> >> add missing /ipaplatform/constants.py to .gitignore >> > > ACK. > Pushed to master: 848912ae31d1549d5f6bed874cc6c4541bada6f4 -- Mana

Re: [Freeipa-devel] [PATCH 0068] add missing /ipaplatform/constants.py to .gitignore

On 12/08/2015 01:26 PM, Petr Spacek wrote: > Hello, > > add missing /ipaplatform/constants.py to .gitignore > ACK. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [PATCH 0394] topology: Make sure the old 'realm' topology suffix is not

From 4c60de6009140f389bc45a5649868f1fde938421 Mon Sep 17 00:00:00 2001 From: Tomas Babej <tba...@redhat.com> Date: Tue, 8 Dec 2015 13:34:15 +0100 Subject: [PATCH] topology: Make sure the old 'realm' topology suffix is not used The old 'realm' topology suffix is no longer used, however, it was

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

On 12/03/2015 04:33 PM, Tomas Babej wrote: > > > On 12/03/2015 04:26 PM, Aleš Mareček wrote: >> Hello, >> >> ACK for code >> NACK for the placing "get_client_ip_with_hostmask" function to test_sudo.py >> (this function should be in some more g

Re: [Freeipa-devel] [PATCH 0394] topology: Make sure the old 'realm' topology suffix is not

On 12/08/2015 02:28 PM, Tomas Babej wrote: > Hi, > > The old 'realm' topology suffix is no longer used, however, it was being > created on masters with version 4.2.3 and later. Make sure it's properly > removed. > > Note that this is not the case for the 'ipaca' su

Re: [Freeipa-devel] [PATCH 0071] replica: Fix ipa-replica-install with replica file (domain, level 0).

On 12/08/2015 04:20 PM, Oleg Fayans wrote: > ACK. The initial issue is fixed. > > On 12/08/2015 03:03 PM, David Kupka wrote: >> https://fedorahosted.org/freeipa/ticket/5531 >> >> > Can we get some more love for the patch and provide at least a sentence worth of commit message before pushing?

Re: [Freeipa-devel] You cannot specify '--admin-password' option(s) with replica file

On 12/07/2015 10:36 AM, Oleg Fayans wrote: > This is an error message that I received at the attempt to install > replica with the following command: > > ipa-replica-install --setup-ca -p -w > /var/lib/ipa/replica-info-replica2.justfor.test.gpg > > However, if I remove the '-w ', then I get

Re: [Freeipa-devel] [PATCH 0393] replicainstall: Admin password should not conflict with

On 12/07/2015 02:33 PM, Tomas Babej wrote: > Hi, > > The --admin-password (-w) has its use both in domain level 0 and 1. > > https://fedorahosted.org/freeipa/ticket/5517 > > > ACK. Pushed to master: dcb6626e870bcededb62d801720721d5d6c9795f -- Manage your subs

[Freeipa-devel] [PATCH 0393] replicainstall: Admin password should not conflict with

Hi, The --admin-password (-w) has its use both in domain level 0 and 1. https://fedorahosted.org/freeipa/ticket/5517 From 9f5a6c6b257955ccad03840090d1b8fd2463bf6d Mon Sep 17 00:00:00 2001 From: Tomas Babej <tba...@redhat.com> Date: Mon, 7 Dec 2015 14:32:11 +0100 Subject: [PATCH] replicai

Re: [Freeipa-devel] [PATCH 0392] tests: Fix incorrect uninstall method invocation

On 12/07/2015 10:58 AM, Tomas Babej wrote: > Hi, > > this fixes: https://fedorahosted.org/freeipa/ticket/5516 > > Tomas > Pushed under oneliner rule: master: 5cb003f0b4b85dce47499f594c410b34b5c961e2 ipa-4-2: e5189ef6e23e4691f6c74541da5bc1a0b0f2e73f -- Manage your subscripti

[Freeipa-devel] [PATCH 0392] tests: Fix incorrect uninstall method invocation

Hi, this fixes: https://fedorahosted.org/freeipa/ticket/5516 Tomas From efd1304be61c792c23c8e8560db6508c63fdd5e6 Mon Sep 17 00:00:00 2001 From: Tomas Babej <tba...@redhat.com> Date: Sat, 5 Dec 2015 16:54:04 +0100 Subject: [PATCH] tests: Fix incorrect uninstall method invocation

Re: [Freeipa-devel] [PATCH 0391] replicainstall: Add check for domain if server is specified

On 12/04/2015 08:22 PM, Rob Crittenden wrote: > Martin Kosek wrote: >> On 12/04/2015 07:17 PM, Tomas Babej wrote: >>> Hi, >>> >>> Avoids failing in the later stages during the ipa-client-install >>> command. >>> >>> Tomas >> &g

Re: [Freeipa-devel] [PATCH] 940 Update ipa-(cs)replica-manage man pages

On 12/04/2015 12:09 PM, Petr Vobornik wrote: > On 12/03/2015 04:58 PM, Petr Vobornik wrote: >> SSIA >> > > Updated patch attached. > > ACK, Pushed to master: 95d659b634b2ea13d18d26cacbd73e19972145f2 -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 0390] man: Update the ipa-replica-install manpage with promotion

On 12/04/2015 12:08 PM, Petr Vobornik wrote: > On 12/03/2015 12:54 PM, Petr Vobornik wrote: >> On 12/03/2015 12:06 PM, Tomas Babej wrote: >>> Hi, >>> >>> this patch updates the man page for the ipa-replica-install given the >>> latest changes (

[Freeipa-devel] [PATCH 0391] replicainstall: Add check for domain if server is specified

Hi, Avoids failing in the later stages during the ipa-client-install command. Tomas From 477a9a197524ff39373f5e58cf7c7ee173657c91 Mon Sep 17 00:00:00 2001 From: Tomas Babej <tba...@redhat.com> Date: Fri, 4 Dec 2015 19:13:07 +0100 Subject: [PATCH] replicainstall: Add check for domain if

Re: [Freeipa-devel] [PATCH] 941 Extend topology help

On 12/04/2015 06:58 PM, Tomas Babej wrote: > > > On 12/03/2015 04:58 PM, Petr Vobornik wrote: >> `ipa help topology` is improved. >> >> > > Looks good. I changed one part of the documentation for more clarity, > see the attached patch. > > Otherwi

Re: [Freeipa-devel] [PATCH] 941 Extend topology help

On 12/03/2015 04:58 PM, Petr Vobornik wrote: > `ipa help topology` is improved. > > Looks good. I changed one part of the documentation for more clarity, see the attached patch. Otherwise ACK from me. Tomas From b460994c2a0f454ffcfdc8345d58c0c963155c7d Mon Sep 17 00:00:00 2001 From: Petr

[Freeipa-devel] [PATCH 0390] man: Update the ipa-replica-install manpage with promotion

Hi, this patch updates the man page for the ipa-replica-install given the latest changes (including the Jan's OTP patch). Tomas From 454e091bc29a536452094ecbf6fe72c100d46f30 Mon Sep 17 00:00:00 2001 From: Tomas Babej <tba...@redhat.com> Date: Thu, 3 Dec 2015 11:42:03 +0100 Subject: [PATC

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

On 12/02/2015 05:25 PM, Lukas Slebodnik wrote: > On (02/12/15 15:41), Tomas Babej wrote: >> >> >> On 12/02/2015 09:24 AM, Tomas Babej wrote: >>> >>> >>> On 12/01/2015 06:27 PM, Tomas Babej wrote: >>>> >>>> >>>> O

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

On 12/03/2015 04:26 PM, Aleš Mareček wrote: > Hello, > > ACK for code > NACK for the placing "get_client_ip_with_hostmask" function to test_sudo.py > (this function should be in some more general file) > What place would you propose? The task.py is not a good place, as this is not really a

  1   2   3   4   5   6   7   8   9   10   >