Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-24 Thread Petr Vobornik
On 08/23/2011 11:09 PM, Endi Sukma Dewata wrote: On 8/23/2011 6:34 AM, Petr Vobornik wrote: Please take a look at the attached patch. This should be applied on top of your patch. It does several things: 1. As mentioned over IRC, we should be treating these partial failure as a success (the

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-24 Thread Endi Sukma Dewata
On 8/24/2011 3:40 AM, Petr Vobornik wrote: It's good enough for #1628 so we can push both patches. Pushed to master and ipa-2-1. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-23 Thread Petr Vobornik
On 08/22/2011 07:05 PM, Endi Sukma Dewata wrote: On 8/22/2011 10:06 AM, Petr Vobornik wrote: 'Failed' moved to command. On 'failed' success is transformed to error - can be change behaviour of serial associator in some commands (previously some commands were executed even after 'failed' of

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-23 Thread Endi Sukma Dewata
On 8/23/2011 6:34 AM, Petr Vobornik wrote: On 08/22/2011 07:05 PM, Endi Sukma Dewata wrote: One more issue, a command could return multiple error messages in each failure, but right now the get_failed() only reads the first message in each failure. Try adding several users into a group, but

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-22 Thread Petr Vobornik
On 08/18/2011 06:25 PM, Endi Sukma Dewata wrote: On 8/17/2011 10:38 AM, Petr Vobornik wrote: Ticket #1628 - https://fedorahosted.org/freeipa/ticket/1628 Unreported insufficient access error This patch is dependant on freeipa-pvoborni-0004-1-error-dialog-for-batch-command.patch. This may be

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-22 Thread Endi Sukma Dewata
On 8/22/2011 10:06 AM, Petr Vobornik wrote: 'Failed' moved to command. On 'failed' success is transformed to error - can be change behaviour of serial associator in some commands (previously some commands were executed even after 'failed' of previous). It isn't probably big issue because they

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-18 Thread Petr Vobornik
On 08/17/2011 05:38 PM, Petr Vobornik wrote: Ticket #1628 - https://fedorahosted.org/freeipa/ticket/1628 Unreported insufficient access error This patch is dependant on freeipa-pvoborni-0004-1-error-dialog-for-batch-command.patch. This may be only a checking if approach of this patch is good.

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-18 Thread Petr Vobornik
On 08/18/2011 10:28 AM, Petr Vobornik wrote: On 08/17/2011 05:38 PM, Petr Vobornik wrote: Ticket #1628 - https://fedorahosted.org/freeipa/ticket/1628 Unreported insufficient access error This patch is dependant on freeipa-pvoborni-0004-1-error-dialog-for-batch-command.patch. This may be only

[Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-17 Thread Petr Vobornik
Ticket #1628 - https://fedorahosted.org/freeipa/ticket/1628 Unreported insufficient access error This patch is dependant on freeipa-pvoborni-0004-1-error-dialog-for-batch-command.patch. This may be only a checking if approach of this patch is good. I was not sure if this type of error