Re: [Freeipa-devel] [PATCH 0372] CI: installation tests

2015-12-08 Thread Oleg Fayans
ACK On 12/07/2015 10:44 PM, Martin Basti wrote: > > > On 07.12.2015 15:51, Oleg Fayans wrote: >> >> On 12/07/2015 03:51 PM, Martin Basti wrote: >>> >>> On 07.12.2015 15:49, Oleg Fayans wrote: Hi, On 12/07/2015 02:37 PM, Martin Basti wrote: > On 07.12.2015 14:32, Martin Basti

Re: [Freeipa-devel] [PATCH 0372] CI: installation tests

2015-12-08 Thread Oleg Fayans
On 12/08/2015 10:09 AM, Martin Basti wrote: > > > On 08.12.2015 10:04, Oleg Fayans wrote: >> ACK > Pushed to master: a11cddd75b4e887998ad6fd52a05f87e0354ea30 > > How about patch mbasti-371, this will not work without it. Looks safe. Could be pushed too :) >> >> On 12/07/2015 10:44 PM,

Re: [Freeipa-devel] [PATCH 0372] CI: installation tests

2015-12-08 Thread Martin Basti
On 08.12.2015 10:04, Oleg Fayans wrote: ACK Pushed to master: a11cddd75b4e887998ad6fd52a05f87e0354ea30 How about patch mbasti-371, this will not work without it. On 12/07/2015 10:44 PM, Martin Basti wrote: On 07.12.2015 15:51, Oleg Fayans wrote: On 12/07/2015 03:51 PM, Martin Basti

Re: [Freeipa-devel] [PATCH 0372] CI: installation tests

2015-12-07 Thread Oleg Fayans
Hi, On 12/07/2015 02:37 PM, Martin Basti wrote: > > > On 07.12.2015 14:32, Martin Basti wrote: >> >> >> On 07.12.2015 13:24, Oleg Fayans wrote: >>> Hi Martin, >>> >>> I would prefer both install_kra and install_ca methods to have >>> raiseonerr parameter set to True by default. We need a way to

Re: [Freeipa-devel] [PATCH 0372] CI: installation tests

2015-12-07 Thread Oleg Fayans
On 12/07/2015 03:51 PM, Martin Basti wrote: > > > On 07.12.2015 15:49, Oleg Fayans wrote: >> Hi, >> >> On 12/07/2015 02:37 PM, Martin Basti wrote: >>> >>> On 07.12.2015 14:32, Martin Basti wrote: On 07.12.2015 13:24, Oleg Fayans wrote: > Hi Martin, > > I would prefer both

Re: [Freeipa-devel] [PATCH 0372] CI: installation tests

2015-12-07 Thread Martin Basti
On 07.12.2015 14:32, Martin Basti wrote: On 07.12.2015 13:24, Oleg Fayans wrote: Hi Martin, I would prefer both install_kra and install_ca methods to have raiseonerr parameter set to True by default. We need a way to test negatives and analyze results. Mine looks like this: def

Re: [Freeipa-devel] [PATCH 0372] CI: installation tests

2015-12-07 Thread Martin Basti
On 07.12.2015 15:49, Oleg Fayans wrote: Hi, On 12/07/2015 02:37 PM, Martin Basti wrote: On 07.12.2015 14:32, Martin Basti wrote: On 07.12.2015 13:24, Oleg Fayans wrote: Hi Martin, I would prefer both install_kra and install_ca methods to have raiseonerr parameter set to True by default.

Re: [Freeipa-devel] [PATCH 0372] CI: installation tests

2015-12-07 Thread Martin Basti
On 07.12.2015 13:24, Oleg Fayans wrote: Hi Martin, I would prefer both install_kra and install_ca methods to have raiseonerr parameter set to True by default. We need a way to test negatives and analyze results. Mine looks like this: def install_kra(host, domain_level=None,

Re: [Freeipa-devel] [PATCH 0372] CI: installation tests

2015-12-07 Thread Oleg Fayans
Hi Martin, I would prefer both install_kra and install_ca methods to have raiseonerr parameter set to True by default. We need a way to test negatives and analyze results. Mine looks like this: def install_kra(host, domain_level=None, first_instance=False, raiseonerr=True):

Re: [Freeipa-devel] [PATCH 0372] CI: installation tests

2015-12-07 Thread Martin Basti
On 07.12.2015 15:51, Oleg Fayans wrote: On 12/07/2015 03:51 PM, Martin Basti wrote: On 07.12.2015 15:49, Oleg Fayans wrote: Hi, On 12/07/2015 02:37 PM, Martin Basti wrote: On 07.12.2015 14:32, Martin Basti wrote: On 07.12.2015 13:24, Oleg Fayans wrote: Hi Martin, I would prefer both

[Freeipa-devel] [PATCH 0372] CI: installation tests

2015-12-06 Thread Martin Basti
My favorite today \o/ --> 67 <-- \o/ test cases, no more manual testing of installers \o/. Test suite contains: 6 combination how to install components on replica X 4 combinations of server installation + 3 extra server tests To save time tests install 1 master and 3 replicas per test class