URL: https://github.com/freeipa/freeipa/pull/416
Title: #416: replica install: relax domain level check for promotion
MartinBasti commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/f51869bf5214e2d2322f85bf72b7ae86b6893974
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/416
Title: #416: replica install: relax domain level check for promotion
MartinBasti commented:
"""
ACK and I found a new bug: https://fedorahosted.org/freeipa/ticket/6654
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/416
Title: #416: replica install: relax domain level check for promotion
frasertweedale commented:
"""
Any other changes requested? What's preventing ack on this?
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/416
Title: #416: replica install: relax domain level check for promotion
stlaz commented:
"""
@frasertweedale Alright. I am definitely not against having it separated since
we came to the realization that replica install checks can not be merged in
URL: https://github.com/freeipa/freeipa/pull/416
Title: #416: replica install: relax domain level check for promotion
frasertweedale commented:
"""
@stlaz there are three considerations when "checking the DL":
1. Retrieving the current DL.
2. Checking that current DL is supported by server
URL: https://github.com/freeipa/freeipa/pull/416
Title: #416: replica install: relax domain level check for promotion
stlaz commented:
"""
The purpose of `check_domain_level()` was to have a unified means of checking
whether the domain level in the rest of the domain corresponds to the
URL: https://github.com/freeipa/freeipa/pull/416
Title: #416: replica install: relax domain level check for promotion
frasertweedale commented:
"""
@HonzaCholasta @MartinBasti PR updated. I extracted the specific (== 0) and
(>= 1) checks to the relevant call sites. Also separated DL
URL: https://github.com/freeipa/freeipa/pull/416
Title: #416: replica install: relax domain level check for promotion
frasertweedale commented:
"""
So, what do we want the behaviour of `check_domain_level` to be? I just want
to make a small change so that replica install does not break if DL
URL: https://github.com/freeipa/freeipa/pull/416
Title: #416: replica install: relax domain level check for promotion
MartinBasti commented:
"""
IMO the whole `check_domain_level` is somehow broken, AFAIK the main purpose of
it is to print correct error message related to replica file option,
URL: https://github.com/freeipa/freeipa/pull/416
Title: #416: replica install: relax domain level check for promotion
HonzaCholasta commented:
"""
I see. The point is, `check_domain_level()` is supposed to check whether
replica promotion is possible or not in the current domain level, so it's
URL: https://github.com/freeipa/freeipa/pull/416
Title: #416: replica install: relax domain level check for promotion
MartinBasti commented:
"""
expected is for domain level 0, because there are different expectations about
replica file, it must exactly match domain level 0, you cannot have
URL: https://github.com/freeipa/freeipa/pull/416
Title: #416: replica install: relax domain level check for promotion
HonzaCholasta commented:
"""
Excuse me, but what is the point of checking for an exact domain level?
Shouldn't `check_domain_level()` rather always check for a minimum domain
URL: https://github.com/freeipa/freeipa/pull/416
Title: #416: replica install: relax domain level check for promotion
frasertweedale commented:
"""
Build failure is unrelated to patch.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/416#issuecomment-275988778
--
Manage
13 matches
Mail list logo
