Re: [Freeipa-devel] [PATCH] 52 Disallow deletion of global password policy

2011-10-12 Thread Jan Cholasta
Dne 11.10.2011 15:19, Rob Crittenden napsal(a): Jan Cholasta wrote: Don't allow ipa pwpolicy-del global_policy. https://fedorahosted.org/freeipa/ticket/1936 Can you add a unit test case for this? Then ack. Questions: Is it possible to disallow deletion of specific objects on LDAP level

[Freeipa-devel] [PATCH] 145 Optimize member/memberof searches in LDAP

2011-10-12 Thread Martin Kosek
How to test: 1) Add some nested membership relationships: $ ipa group-add --desc=foo group1 $ ipa group-add --desc=foo group2 $ ipa user-add --first=Foo --last=Bar foobar $ ipa role-add-member helpdesk --groups=group2 $ ipa group-add-member group2 --groups=group1 $ ipa group-add-member group1

Re: [Freeipa-devel] [PATCH] 26 Remove redundant configuration values from krb5.conf

2011-10-12 Thread Jan Cholasta
Dne 28.6.2011 22:19, Rob Crittenden napsal(a): Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/1358 Honza ack, pushed to master and ipa-2-0 Don't configure [appdefaults], as per Nalin's suggestion (https://fedorahosted.org/freeipa/ticket/1358#comment:5) Honza -- Jan

Re: [Freeipa-devel] [PATCH] 52 Disallow deletion of global password policy

2011-10-12 Thread Martin Kosek
On Wed, 2011-10-12 at 09:28 +0200, Jan Cholasta wrote: Dne 11.10.2011 15:19, Rob Crittenden napsal(a): Jan Cholasta wrote: Don't allow ipa pwpolicy-del global_policy. https://fedorahosted.org/freeipa/ticket/1936 Can you add a unit test case for this? Then ack. Questions: Is

[Freeipa-devel] [PATCH] 146 ipa-client-install hangs if the discovered server is

2011-10-12 Thread Martin Kosek
For starters I added a 15 second timeout and 2 tries. These numbers are arbitrary, I am open to suggestions. Martin --- Add a timeout to the wget call to cover a case when autodiscovered server does not response to our attempt to download ca.crt. Let user specify a different IPA server in that

[Freeipa-devel] [PATCH] 0025/0026 ipa-client-install --hostname not setting HOSTNAME if it is missing from the configuration file

2011-10-12 Thread Alexander Bokovoy
Hi, attached is a small refactoring that is pursuing two goals: - fix https://fedorahosted.org/freeipa/ticket/1871 and - prepare grounds for systemd integration As ticket 1871 is about cases when HOSTNAME is missing from /etc/sysconfig/network, this patch adds support to append

Re: [Freeipa-devel] [PATCH] 146 ipa-client-install hangs if the discovered server is

2011-10-12 Thread Rob Crittenden
Martin Kosek wrote: For starters I added a 15 second timeout and 2 tries. These numbers are arbitrary, I am open to suggestions. Martin --- Add a timeout to the wget call to cover a case when autodiscovered server does not response to our attempt to download ca.crt. Let user specify a

Re: [Freeipa-devel] [PATCH] 889 fix selfsign upgrades

2011-10-12 Thread Jan Cholasta
Dne 10.10.2011 16:21, Rob Crittenden napsal(a): Upgrading an installation that was installed with selfsign CA will fail in ipa-upgradeconfig because it doesn't handle the case where dogtag isn't installed. rob ACK. Honza -- Jan Cholasta ___

Re: [Freeipa-devel] [PATCH] 146 ipa-client-install hangs if the discovered server is

2011-10-12 Thread Martin Kosek
On Wed, 2011-10-12 at 08:52 -0400, Rob Crittenden wrote: Martin Kosek wrote: For starters I added a 15 second timeout and 2 tries. These numbers are arbitrary, I am open to suggestions. Martin --- Add a timeout to the wget call to cover a case when autodiscovered server does not

[Freeipa-devel] [PATCH] 147 Hostname used by IPA must be a system hostname

2011-10-12 Thread Martin Kosek
This patch depends on my patch 140 (attached just to be sure). Do I understand it correctly that new proposed bind-dyndb-ldap option ldap_hostname won't be needed? Martin From 21b8bea688b03e6c4d13da2dbcdebed8ff0fa09d Mon Sep 17 00:00:00 2001 From: Martin Kosek mko...@redhat.com Date: Wed, 12 Oct

Re: [Freeipa-devel] [PATCH] 146 ipa-client-install hangs if the discovered server is

2011-10-12 Thread Simo Sorce
On Wed, 2011-10-12 at 15:03 +0200, Martin Kosek wrote: On Wed, 2011-10-12 at 08:52 -0400, Rob Crittenden wrote: Martin Kosek wrote: For starters I added a 15 second timeout and 2 tries. These numbers are arbitrary, I am open to suggestions. Martin --- Add a timeout to the

Re: [Freeipa-devel] [PATCH] 0025/0026 ipa-client-install --hostname not setting HOSTNAME if it is missing from the configuration file

2011-10-12 Thread Rob Crittenden
Alexander Bokovoy wrote: Hi, attached is a small refactoring that is pursuing two goals: - fix https://fedorahosted.org/freeipa/ticket/1871 and - prepare grounds for systemd integration As ticket 1871 is about cases when HOSTNAME is missing from /etc/sysconfig/network, this patch adds

Re: [Freeipa-devel] [PATCH] 0025/0026 ipa-client-install --hostname not setting HOSTNAME if it is missing from the configuration file

2011-10-12 Thread Alexander Bokovoy
On Wed, 12 Oct 2011, Rob Crittenden wrote: Also, all keys totally missing from the config will be added. Values from replacevars and appendvars are merged before doing it so there is only single key=value pair afterwards. Obviously, it is the caller responsibility to not allow

[Freeipa-devel] ipa-client-install sudoers + automount

2011-10-12 Thread William Brown
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Is there a reason that ipa-client-install does not configure nsswitch for ldap sudoers and automount by default? I would see such a modification as a feature for this, rather than a negative. Alternately, this could be added as a module to ipa

Re: [Freeipa-devel] ipa-client-install sudoers + automount

2011-10-12 Thread Rob Crittenden
William Brown wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Is there a reason that ipa-client-install does not configure nsswitch for ldap sudoers and automount by default? I would see such a modification as a feature for this, rather than a negative. Alternately, this could be added as

Re: [Freeipa-devel] [PATCH] 889 fix selfsign upgrades

2011-10-12 Thread Rob Crittenden
Jan Cholasta wrote: Dne 10.10.2011 16:21, Rob Crittenden napsal(a): Upgrading an installation that was installed with selfsign CA will fail in ipa-upgradeconfig because it doesn't handle the case where dogtag isn't installed. rob ACK. Honza pushed to master and ipa-2-1

Re: [Freeipa-devel] ipa-client-install sudoers + automount

2011-10-12 Thread William Brown
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 These are both on our roadmap, we just haven't gotten to them yet: https://fedorahosted.org/freeipa/ticket/1233 http://freeipa.org/page/SUDO_integration_plans Okay, I did not find these two pages while searching. It appears to be what I have

Re: [Freeipa-devel] [PATCH] 890 OTP client enrollment with anonymous disabled

2011-10-12 Thread Martin Kosek
On Tue, 2011-10-11 at 17:40 -0400, Rob Crittenden wrote: Fix OTP client enrollment when anonymous searches are disabled in 389-ds. This is fixed mostly by passing in the basedn to ipa-join so we don't have to hunt for it. I did modify that routine so it will look through all naming

Re: [Freeipa-devel] [PATCH] 890 OTP client enrollment with anonymous disabled

2011-10-12 Thread Rob Crittenden
Martin Kosek wrote: On Tue, 2011-10-11 at 17:40 -0400, Rob Crittenden wrote: Fix OTP client enrollment when anonymous searches are disabled in 389-ds. This is fixed mostly by passing in the basedn to ipa-join so we don't have to hunt for it. I did modify that routine so it will look through

Re: [Freeipa-devel] [PATCH] 0025/0026 ipa-client-install --hostname not setting HOSTNAME if it is missing from the configuration file

2011-10-12 Thread Rob Crittenden
Alexander Bokovoy wrote: On Wed, 12 Oct 2011, Rob Crittenden wrote: Also, all keys totally missing from the config will be added. Values from replacevars and appendvars are merged before doing it so there is only single key=value pair afterwards. Obviously, it is the caller responsibility to

Re: [Freeipa-devel] ipa-client-install sudoers + automount

2011-10-12 Thread Rob Crittenden
William Brown wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 These are both on our roadmap, we just haven't gotten to them yet: https://fedorahosted.org/freeipa/ticket/1233 http://freeipa.org/page/SUDO_integration_plans Okay, I did not find these two pages while searching. It

Re: [Freeipa-devel] [PATCH 50/50] Ticket 1718 - Fix Spanish po translation file

2011-10-12 Thread John Dennis
On 10/11/2011 06:06 PM, Rob Crittenden wrote: John Dennis wrote: There were quite errors in es.po, it was difficult or impossible to track down where they came from, Transifex does not have good revision history. I fixed about 20% of the msgstr's in the file that had obvious problems which

Re: [Freeipa-devel] [PATCH 50/50] Ticket 1718 - Fix Spanish po translation file

2011-10-12 Thread Rob Crittenden
John Dennis wrote: On 10/11/2011 06:06 PM, Rob Crittenden wrote: John Dennis wrote: There were quite errors in es.po, it was difficult or impossible to track down where they came from, Transifex does not have good revision history. I fixed about 20% of the msgstr's in the file that had

Re: [Freeipa-devel] [PATCH 50/50] Ticket 1718 - Fix Spanish po translation file

2011-10-12 Thread John Dennis
On 10/12/2011 11:57 AM, Rob Crittenden wrote: #: ipalib/plugins/config.py:76 msgid searchtimelimit must be -1 or 1. -msgstr searchtimelimit debe ser -1 ogt; 1. +msgstr Why? This isn't where things are formatted for HTML. This string might be output on the command line. None of the other

Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-10-12 Thread Alexander Bokovoy
On Tue, 13 Sep 2011, Stephen Gallagher wrote: On Tue, 2011-09-13 at 16:33 +0300, Alexander Bokovoy wrote: On Tue, 13 Sep 2011, Stephen Gallagher wrote: File /usr/lib/python2.7/site-packages/SSSDConfig.py, line 1207, in import_config fd = open(configfile, 'r')

Re: [Freeipa-devel] ipa-client-install sudoers + automount

2011-10-12 Thread Simo Sorce
On Wed, 2011-10-12 at 11:42 -0400, Rob Crittenden wrote: Has any work started on the SSSD sudo provider? Yes, I believe it has. I don't know the full state of it, maybe one of the sssd dev lurkers will chime in :-) In progress, see sssd-devel@ or join #sssd on Freenode and ask there :)

Re: [Freeipa-devel] ipa-client-install sudoers + automount

2011-10-12 Thread Jakub Hrozek
On Wed, Oct 12, 2011 at 12:25:58PM -0400, Simo Sorce wrote: On Wed, 2011-10-12 at 11:42 -0400, Rob Crittenden wrote: Has any work started on the SSSD sudo provider? Yes, I believe it has. I don't know the full state of it, maybe one of the sssd dev lurkers will chime in :-) The work

Re: [Freeipa-devel] [PATCH] bind-dyndb-ldap: Add new ldap_hostname option (ticket #1931)

2011-10-12 Thread Rob Crittenden
Adam Tkac wrote: Hello all, please see attached patch for bind-dyndb-ldap, it should solve (at least from bind-dyndb-ldap side) ticket #1931. It adds new ldap_hostname option and ipa-server-install utility should set this option when /bin/hostname is different from --hostname parameter.

Re: [Freeipa-devel] [PATCH] 53 Don't leak passwords through kdb5_ldap_util command line arguments

2011-10-12 Thread Rob Crittenden
Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/1948 Honza Very nice, ACK, Rebased patch pushed to master, pushed to ipa-2-1 rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 26 Remove redundant configuration values from krb5.conf

2011-10-12 Thread Rob Crittenden
Jan Cholasta wrote: Dne 28.6.2011 22:19, Rob Crittenden napsal(a): Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/1358 Honza ack, pushed to master and ipa-2-0 Don't configure [appdefaults], as per Nalin's suggestion (https://fedorahosted.org/freeipa/ticket/1358#comment:5)

Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-10-12 Thread Rob Crittenden
Alexander Bokovoy wrote: On Tue, 13 Sep 2011, Stephen Gallagher wrote: On Tue, 2011-09-13 at 16:33 +0300, Alexander Bokovoy wrote: On Tue, 13 Sep 2011, Stephen Gallagher wrote: File /usr/lib/python2.7/site-packages/SSSDConfig.py, line 1207, in import_config fd = open(configfile,

Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-10-12 Thread Alexander Bokovoy
On Wed, 12 Oct 2011, Rob Crittenden wrote: 2) Be restrictive on ParseError and throw an error telling them to fix their config file. Pros: we don't break an existing setup. Cons: FreeIPA installation has been broken. 3) Default to one of the above but provide a command-line flag to behave

Re: [Freeipa-devel] [PATCH 50/50] Ticket 1718 - Fix Spanish po translation file

2011-10-12 Thread Rob Crittenden
John Dennis wrote: On 10/12/2011 12:11 PM, John Dennis wrote: I thought what I had done was replace thegt; with but I obviously didn't read the diff as closely as you did, good catch Rob , let me go back and check to make sure I didn't another similar mistake. Also I forgot to update the

Re: [Freeipa-devel] [PATCH] 134 Improve handling of GIDs when migrating groups

2011-10-12 Thread Rob Crittenden
Martin Kosek wrote: On Thu, 2011-10-06 at 21:31 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2011-10-05 at 13:44 -0400, Rob Crittenden wrote: Martin Kosek wrote: Since IPA v2 server already contain predefined groups that may collide with groups in migrated (IPA v1) server (for

Re: [Freeipa-devel] [PATCH] 146 ipa-client-install hangs if the discovered server is

2011-10-12 Thread Rob Crittenden
Martin Kosek wrote: On Wed, 2011-10-12 at 09:31 -0400, Simo Sorce wrote: On Wed, 2011-10-12 at 15:03 +0200, Martin Kosek wrote: On Wed, 2011-10-12 at 08:52 -0400, Rob Crittenden wrote: Martin Kosek wrote: For starters I added a 15 second timeout and 2 tries. These numbers are arbitrary, I am

Re: [Freeipa-devel] [PATCH] 147 Hostname used by IPA must be a system hostname

2011-10-12 Thread Rob Crittenden
Martin Kosek wrote: This patch depends on my patch 140 (attached just to be sure). Do I understand it correctly that new proposed bind-dyndb-ldap option ldap_hostname won't be needed? Martin I think it would be a good idea to add it when it becomes available in bind-dyndb-ldap. NACK on

Re: [Freeipa-devel] [PATCH] 145 Optimize member/memberof searches in LDAP

2011-10-12 Thread Rob Crittenden
Martin Kosek wrote: How to test: 1) Add some nested membership relationships: $ ipa group-add --desc=foo group1 $ ipa group-add --desc=foo group2 $ ipa user-add --first=Foo --last=Bar foobar $ ipa role-add-member helpdesk --groups=group2 $ ipa group-add-member group2 --groups=group1 $ ipa

[Freeipa-devel] [PATCH] 891 drop has_upg() check

2011-10-12 Thread Rob Crittenden
The has_upg() check was created during a transition period for 389-ds. It is no longer needed and is actually breaking things. The location of UPG template moved so it thinks the feature is not available. This is making the primary user's group ipausers instead of the UPG. rob From