Re: [Freeipa-devel] What is Changelog on wiki for?
On 24.1.2014 18:46, Dmitri Pal wrote: On 01/24/2014 10:39 AM, Rob Crittenden wrote: Martin Kosek wrote: When working on release, this question comes to my mind every time - what is the following page good for? :) http://www.freeipa.org/page/Changelog To me, it is usually just an annoyance of the release process. You can simply get all the data with git log derivatives, so I do not see a point of maintaining this page. I see benefits of having shortlog in Release pages like [1], but not with this one. I am thus proposing to deprecate it. [1] http://www.freeipa.org/page/Releases/3.3.3 Thanks. I used to just cherry-pick the big things then figured that some people care about everything so switched to that instead. Yes, the data is in git, but if one doesn't know git well then it can be hard to tell where something was fixed. I won't yell if it's dropped, but it's just a cut-n-paste after all. It is internet search-able and can be easily pointed to in different follow up materials. I would rather keep it, but a wiki formatting script might be a good idea. Our git repo has nice and responsive web interface: https://git.fedorahosted.org/cgit/freeipa.git/ The advantage is that you can read full commit messages so you can see links to tickets in Trac which are not present in shortlog. Given that I think that Changelog wiki page is mostly annoyance, it could simply redirect to repo web interface (may be to listings for specific branches). -- Petr^2 Spacek ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCHES] 0455-0459 Add support for managed permissions
On 01/27/2014 09:17 AM, Petr Spacek wrote: On 27.1.2014 08:07, Martin Kosek wrote: On 01/24/2014 05:23 PM, Simo Sorce wrote: On Fri, 2014-01-24 at 17:17 +0100, Petr Viktorin wrote: On 01/24/2014 04:57 PM, Simo Sorce wrote: On Fri, 2014-01-24 at 16:48 +0100, Petr Viktorin wrote: ... Technically we could alias the name so the attribute can be called either way, but that is not necessarily a good option either. If breaking master is unacceptable, we can use the old name instead. ipaPermIncludedAttr is more consistent but ipaPermAllowedAttr isn't downright wrong. Ok, let's hear other opinions, I see a lot f value in consistent naming, and not breaking a developer build is not that strong of a reason to have substandard naming I guess. What do others think ? Simo. Hmm, I obviously see things differently here. I would rather break the master and let developers running on the git version to reinstall the servers (including myself) than to have to live with suboptimal attribute name for ever or by adding unnecessary cruft to the code... I think you got lost in the nots. You and Simo agree. (Speaking as lab admin:) Please, break it! It will force people to finally reinstall years old VMs! :-) -- Petr³ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCHES] 0455-0459 Add support for managed permissions
On 01/27/2014 09:50 AM, Petr Viktorin wrote: On 01/27/2014 09:17 AM, Petr Spacek wrote: On 27.1.2014 08:07, Martin Kosek wrote: On 01/24/2014 05:23 PM, Simo Sorce wrote: On Fri, 2014-01-24 at 17:17 +0100, Petr Viktorin wrote: On 01/24/2014 04:57 PM, Simo Sorce wrote: On Fri, 2014-01-24 at 16:48 +0100, Petr Viktorin wrote: ... Technically we could alias the name so the attribute can be called either way, but that is not necessarily a good option either. If breaking master is unacceptable, we can use the old name instead. ipaPermIncludedAttr is more consistent but ipaPermAllowedAttr isn't downright wrong. Ok, let's hear other opinions, I see a lot f value in consistent naming, and not breaking a developer build is not that strong of a reason to have substandard naming I guess. What do others think ? Simo. Hmm, I obviously see things differently here. I would rather break the master and let developers running on the git version to reinstall the servers (including myself) than to have to live with suboptimal attribute name for ever or by adding unnecessary cruft to the code... I think you got lost in the nots. You and Simo agree. Ah, I see - you are right (indeed to many nots). Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] What is Changelog on wiki for?
On 01/27/2014 09:08 AM, Petr Spacek wrote: On 24.1.2014 18:46, Dmitri Pal wrote: On 01/24/2014 10:39 AM, Rob Crittenden wrote: Martin Kosek wrote: When working on release, this question comes to my mind every time - what is the following page good for? :) http://www.freeipa.org/page/Changelog To me, it is usually just an annoyance of the release process. You can simply get all the data with git log derivatives, so I do not see a point of maintaining this page. I see benefits of having shortlog in Release pages like [1], but not with this one. I am thus proposing to deprecate it. [1] http://www.freeipa.org/page/Releases/3.3.3 Thanks. I used to just cherry-pick the big things then figured that some people care about everything so switched to that instead. Yes, the data is in git, but if one doesn't know git well then it can be hard to tell where something was fixed. I won't yell if it's dropped, but it's just a cut-n-paste after all. It is internet search-able and can be easily pointed to in different follow up materials. I would rather keep it, but a wiki formatting script might be a good idea. Our git repo has nice and responsive web interface: https://git.fedorahosted.org/cgit/freeipa.git/ The advantage is that you can read full commit messages so you can see links to tickets in Trac which are not present in shortlog. Given that I think that Changelog wiki page is mostly annoyance, it could simply redirect to repo web interface (may be to listings for specific branches). Right, that was my thinking as well. The Changelog just duplicates information that is already internet-searchable in: * cgit * Mails and patches on freeipa-devel mailing list archive * Release specific Changelog excerpt in Release page Thus, I still do not see a reason in maintaining the huge Changelog page. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Debian client support
On 28.11.2013 22:26, Lukas Slebodnik wrote: On (05/09/13 23:25), Lukas Slebodnik wrote: On (03/09/13 00:43), Timo Aaltonen wrote: This fixes https://fedorahosted.org/freeipa/ticket/1887 and https://fedorahosted.org/freeipa/ticket/2455 the first three patches fix some bugs in how python is used fourth patch checks if dbus is already running before trying to start it fifth fixes some compilation warnings sixth finally adds the Debian platform module there are also distro patches that aren't upstreamable as-is, that do stuff like - give--install-layout=deb to setup.py - disable make-testcert since it needs a server running - fix hardcoded NFS related paths and a variable in ipa-client-automount - fix ldap.conf path in ipa-client-install - fix ntpdate options in ntpconf.py (Debian doesn't patch ntpdate like Fedora) - change nss includes in ipa_pwd.c (nss/.. not nss3/..) Solution is simple. Use pkg-config generated NSS_CFLAGS bash$ pkg-config --cflags nss -I/usr/include/nss -I/usr/include/nspr bash$ uname -a Linux positron 3.10-2-686-pae #1 SMP Debian 3.10.5-1 (2013-08-07) i686 GNU/Linux bash$pkg-config --cflags nss -I/usr/include/nss3 -I/usr/include/nspr4 bash$uname -a Linux unused-4-233.brq.redhat.com 3.10.10-200.fc19.x86_64 #1 SMP Thu Aug 29 19:05:45 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux It works in sssd. I can send a patch. LS Attached patch should fix problem with compilation on different distros. debian: http://anonscm.debian.org/gitweb/?p=pkg-freeipa/freeipa.git;a=blob;f=debian/patches/fix-nss-include.diff;h=1dac0709ed7344c7546c55225365c9434e6a930a;hb=HEAD arch: https://github.com/chenxiaolong/ArchLinux-Packages/blob/master/freeipa/0006_Fix_nss_includes.patch Timo can you test patch on debian/ubuntu? finally did last week, so Tested-by: Timo Aaltonen tjaal...@ubuntu.com ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH] 454 Migration does not add users to default group
When users with missing default group were searched, IPA suffix was
not passed so these users were searched in a wrong base DN. Thus,
no user was detected and added to default group.
https://fedorahosted.org/freeipa/ticket/4141
--
Martin Kosek mko...@redhat.com
Supervisor, Software Engineering - Identity Management Team
Red Hat Inc.
From 4ecb5f85e44f2f591504bb7f0d7f9ad64ccf6115 Mon Sep 17 00:00:00 2001
From: Martin Kosek mko...@redhat.com
Date: Mon, 27 Jan 2014 12:28:12 +0100
Subject: [PATCH] Migration does not add users to default group
When users with missing default group were searched, IPA suffix was
not passed so these users were searched in a wrong base DN. Thus,
no user was detected and added to default group.
https://fedorahosted.org/freeipa/ticket/4141
---
ipalib/plugins/migration.py | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/ipalib/plugins/migration.py b/ipalib/plugins/migration.py
index 83bf40dbfa4cf2310b2501c28cf095299711331d..19032248b559be48ca08d8b1a14874df4cd0988a 100644
--- a/ipalib/plugins/migration.py
+++ b/ipalib/plugins/migration.py
@@ -286,16 +286,19 @@ def _update_default_group(ldap, pkey, config, ctx, force):
searchfilter = ((objectclass=posixAccount)(!(memberof=%s))) % group_dn
try:
(result, truncated) = ldap.find_entries(searchfilter,
-[''], api.env.container_user, scope=ldap.SCOPE_SUBTREE,
-time_limit = -1)
+[''], DN(api.env.container_user, api.env.basedn),
+scope=ldap.SCOPE_SUBTREE, time_limit = -1)
except errors.NotFound:
+api.log.debug('All users have default group set')
return
new_members = []
(group_dn, group_entry_attrs) = ldap.get_entry(group_dn, ['member'])
for m in result:
if m[0] not in group_entry_attrs.get('member', []):
new_members.append(m[0])
-if len(new_members) 0:
+
+new_members_cnt = len(new_members)
+if new_members_cnt 0:
members = group_entry_attrs.get('member', [])
members.extend(new_members)
group_entry_attrs['member'] = members
@@ -308,7 +311,8 @@ def _update_default_group(ldap, pkey, config, ctx, force):
e = datetime.datetime.now()
d = e - s
mode = (forced) if force else
-api.log.debug('Adding %d users to group%s duration %s' % (len(new_members), mode, d))
+api.log.debug('Adding %d users to group%s duration %s',
+new_members_cnt, mode, d)
# GROUP MIGRATION CALLBACKS AND VARS
--
1.8.4.2
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0007] Limit memberOf and refInt DS plugins to main IPA suffix
Hi, On 23.1.2014 12:32, Petr Spacek wrote: Hello, this patch solves performance problems with retro change log trimming. It has to go to the same branches as Ana's patch 0079 Enable Retro Changelog and Content Synchronization DS plugins. Nitpicks: -Requires: 389-ds-base = 1.3.1.3 +Requires: 389-ds-base = 1.3.2.10 Why 1.3.2.10? According to 389-ds-base changelog, all the required enhancements should be available in 1.3.2.9: https://fedorahosted.org/389/ticket/47526 https://fedorahosted.org/389/ticket/47527 https://fedorahosted.org/389/ticket/47621 -# Enable Retro changelog +# Enable Retro changelog - is is necessary for SyncRepl s/is is/it is/ Otherwise ACK. Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0007] Limit memberOf and refInt DS plugins to main IPA suffix
On 01/27/2014 01:06 PM, Jan Cholasta wrote: Hi, On 23.1.2014 12:32, Petr Spacek wrote: Hello, this patch solves performance problems with retro change log trimming. It has to go to the same branches as Ana's patch 0079 Enable Retro Changelog and Content Synchronization DS plugins. Nitpicks: -Requires: 389-ds-base = 1.3.1.3 +Requires: 389-ds-base = 1.3.2.10 Why 1.3.2.10? According to 389-ds-base changelog, all the required enhancements should be available in 1.3.2.9: https://fedorahosted.org/389/ticket/47526 https://fedorahosted.org/389/ticket/47527 https://fedorahosted.org/389/ticket/47621 According to Petr Špaček things were broken in .9 so we do need the .10 -# Enable Retro changelog +# Enable Retro changelog - is is necessary for SyncRepl s/is is/it is/ Otherwise ACK. Fixed the typo and pushed to master: 04627b72d6d6cbf3a9dadc614a532505e31957f5 -- Petr³ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH 0008] Remove working directory for bind-dyndb-ldap plugin
Hello,
The working directory will be provided directly
by bind-dyndb-ldap package.
I'm testing the patch right now but I don't expect any problems. Please review
this as soon as possible so we can release 3.3.4 ...
--
Petr^2 Spacek
From 2909bfd21af0501230f6fb7e2ed9f2129ca48c12 Mon Sep 17 00:00:00 2001
From: Petr Spacek pspa...@redhat.com
Date: Mon, 27 Jan 2014 14:47:10 +0100
Subject: [PATCH] Remove working directory for bind-dyndb-ldap plugin.
The working directory will be provided directly
by bind-dyndb-ldap package.
This partially reverts commit 689382dc833e687d30349b10a8fd7dc740d54d08.
https://fedorahosted.org/freeipa/ticket/3967
---
freeipa.spec.in | 1 -
install/tools/ipa-upgradeconfig | 5 +
ipaserver/install/bindinstance.py | 13 -
3 files changed, 1 insertion(+), 18 deletions(-)
diff --git a/freeipa.spec.in b/freeipa.spec.in
index f4e22831d579166f850a2e307b207942d4cbe296..c28928c1c5c2d20e2dfe6112750c70bfb0b55894 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -767,7 +767,6 @@ fi
%{_mandir}/man1/ipa-backup.1.gz
%{_mandir}/man1/ipa-restore.1.gz
%{_mandir}/man1/ipa-advise.1.gz
-%ghost %{_localstatedir}/named/ipa
%files server-trust-ad
%{_sbindir}/ipa-adtrust-install
diff --git a/install/tools/ipa-upgradeconfig b/install/tools/ipa-upgradeconfig
index b281eb4eaf31a3d97cb4668cf7d38ab1f3e0f815..de50299715641a9a0b1fb37bf7ee50e946a5f144 100644
--- a/install/tools/ipa-upgradeconfig
+++ b/install/tools/ipa-upgradeconfig
@@ -1084,10 +1084,6 @@ def main():
setup_firefox_extension(fstore)
add_ca_dns_records()
-bind = bindinstance.BindInstance(fstore)
-if bind.is_configured():
-bind.create_dir('/var/named/ipa', 0700)
-
# Any of the following functions returns True iff the named.conf file
# has been altered
named_conf_changes = (
@@ -1101,6 +1097,7 @@ def main():
if any(named_conf_changes):
# configuration has changed, restart the name server
root_logger.info('Changes to named.conf have been made, restart named')
+bind = bindinstance.BindInstance(fstore)
try:
bind.restart()
except ipautil.CalledProcessError, e:
diff --git a/ipaserver/install/bindinstance.py b/ipaserver/install/bindinstance.py
index beeb39de6c29fa0635a26250d2517a554fe65a42..7c0085c6bf512e5d6491416e64f761bfe8815a6f 100644
--- a/ipaserver/install/bindinstance.py
+++ b/ipaserver/install/bindinstance.py
@@ -22,7 +22,6 @@ import os
import pwd
import netaddr
import re
-import errno
import ldap
@@ -510,16 +509,6 @@ class BindInstance(service.Service):
os.close(bind_fd)
print Sample zone file for bind has been created in +bind_name
-def create_dir(self, path, mode):
-try:
-os.makedirs(path, mode)
-except OSError as e:
-if e.errno != errno.EEXIST:
-raise e
-
-pent = pwd.getpwnam(self.named_user or 'named')
-os.chown(path, pent.pw_uid, pent.pw_gid)
-
def create_instance(self):
try:
@@ -530,8 +519,6 @@ class BindInstance(service.Service):
# get a connection to the DS
self.ldap_connect()
-self.create_dir('/var/named/ipa', 0700)
-
if installutils.record_in_hosts(self.ip_address, self.fqdn) is None:
installutils.add_record_to_hosts(self.ip_address, self.fqdn)
--
1.8.3.1
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] What is Changelog on wiki for?
On 01/27/2014 04:02 PM, Petr Viktorin wrote: On 01/27/2014 03:32 PM, Rob Crittenden wrote: [...] It is useful because you can more easily see what made it into the particular dot release rather than finding the patch you want then knowing to search backwards for the Become xx.yy commit. I saw it as a poor-man's way of finding changes. I think a poor man can open up the individual Release notes and look there. And a rich man (who has the repo cloned) can just use Git. $ git log -i --grep 'drop selinux' commit ad6abdb576b2ebeb941eb99fd141bf78918143c1 Author: Martin Kosek mko...@redhat.com Date: Thu Jun 13 14:40:52 2013 +0200 Drop SELinux subpackage All SELinux policy needed by FreeIPA server is now part of the global system SELinux policy which makes the subpackage redundant and slowing down the installation. This patch drops it. https://fedorahosted.org/freeipa/ticket/3683 https://fedorahosted.org/freeipa/ticket/3684 $ git tag --contains ad6abdb576b2ebeb941eb99fd141bf78918143c1 beta_1-3-3-0 beta_2-3-3-0 release-3-3-0 release-3-3-1 release-3-3-2 release-3-3-3 I couldn't say it better. Let's drop the manual changelog and use some modern way to do it - case is closed. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0008] Remove working directory for bind-dyndb-ldap plugin
On 01/27/2014 02:52 PM, Petr Spacek wrote: Hello, The working directory will be provided directly by bind-dyndb-ldap package. I'm testing the patch right now but I don't expect any problems. Please review this as soon as possible so we can release 3.3.4 ... ACK, pushed to master: c91936353865ecb03b06e2a558c370e6a50fa0dc -- Petr³ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] What is Changelog on wiki for?
Petr Spacek wrote: On 24.1.2014 18:46, Dmitri Pal wrote: On 01/24/2014 10:39 AM, Rob Crittenden wrote: Martin Kosek wrote: When working on release, this question comes to my mind every time - what is the following page good for? :) http://www.freeipa.org/page/Changelog To me, it is usually just an annoyance of the release process. You can simply get all the data with git log derivatives, so I do not see a point of maintaining this page. I see benefits of having shortlog in Release pages like [1], but not with this one. I am thus proposing to deprecate it. [1] http://www.freeipa.org/page/Releases/3.3.3 Thanks. I used to just cherry-pick the big things then figured that some people care about everything so switched to that instead. Yes, the data is in git, but if one doesn't know git well then it can be hard to tell where something was fixed. I won't yell if it's dropped, but it's just a cut-n-paste after all. It is internet search-able and can be easily pointed to in different follow up materials. I would rather keep it, but a wiki formatting script might be a good idea. Our git repo has nice and responsive web interface: https://git.fedorahosted.org/cgit/freeipa.git/ The advantage is that you can read full commit messages so you can see links to tickets in Trac which are not present in shortlog. Given that I think that Changelog wiki page is mostly annoyance, it could simply redirect to repo web interface (may be to listings for specific branches). It is useful because you can more easily see what made it into the particular dot release rather than finding the patch you want then knowing to search backwards for the Become xx.yy commit. I saw it as a poor-man's way of finding changes. It gets updated 3 or 4 times a year, so it is hardly a burden. It is certainly duplicated information and I won't fight any further for it. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] What is Changelog on wiki for?
On 01/27/2014 03:32 PM, Rob Crittenden wrote: Petr Spacek wrote: On 24.1.2014 18:46, Dmitri Pal wrote: On 01/24/2014 10:39 AM, Rob Crittenden wrote: Martin Kosek wrote: When working on release, this question comes to my mind every time - what is the following page good for? :) http://www.freeipa.org/page/Changelog To me, it is usually just an annoyance of the release process. You can simply get all the data with git log derivatives, so I do not see a point of maintaining this page. I see benefits of having shortlog in Release pages like [1], but not with this one. I am thus proposing to deprecate it. [1] http://www.freeipa.org/page/Releases/3.3.3 Thanks. I used to just cherry-pick the big things then figured that some people care about everything so switched to that instead. Yes, the data is in git, but if one doesn't know git well then it can be hard to tell where something was fixed. I won't yell if it's dropped, but it's just a cut-n-paste after all. It is internet search-able and can be easily pointed to in different follow up materials. I would rather keep it, but a wiki formatting script might be a good idea. Our git repo has nice and responsive web interface: https://git.fedorahosted.org/cgit/freeipa.git/ The advantage is that you can read full commit messages so you can see links to tickets in Trac which are not present in shortlog. Given that I think that Changelog wiki page is mostly annoyance, it could simply redirect to repo web interface (may be to listings for specific branches). It is useful because you can more easily see what made it into the particular dot release rather than finding the patch you want then knowing to search backwards for the Become xx.yy commit. I saw it as a poor-man's way of finding changes. Ok, though I still think that git and cgit should be the authoritative source of searches like this... It gets updated 3 or 4 times a year, so it is hardly a burden. 3-4 times? I see 19 updates happening in 2013 in this page. With each release (even a minor one) we do, we need to do prepare shortlog, apply wiki and the specific date format and paste it here. It is certainly duplicated information and I won't fight any further for it. rob Noted :) Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] What is Changelog on wiki for?
On 01/27/2014 03:32 PM, Rob Crittenden wrote: [...] It is useful because you can more easily see what made it into the particular dot release rather than finding the patch you want then knowing to search backwards for the Become xx.yy commit. I saw it as a poor-man's way of finding changes. I think a poor man can open up the individual Release notes and look there. And a rich man (who has the repo cloned) can just use Git. $ git log -i --grep 'drop selinux' commit ad6abdb576b2ebeb941eb99fd141bf78918143c1 Author: Martin Kosek mko...@redhat.com Date: Thu Jun 13 14:40:52 2013 +0200 Drop SELinux subpackage All SELinux policy needed by FreeIPA server is now part of the global system SELinux policy which makes the subpackage redundant and slowing down the installation. This patch drops it. https://fedorahosted.org/freeipa/ticket/3683 https://fedorahosted.org/freeipa/ticket/3684 $ git tag --contains ad6abdb576b2ebeb941eb99fd141bf78918143c1 beta_1-3-3-0 beta_2-3-3-0 release-3-3-0 release-3-3-1 release-3-3-2 release-3-3-3 -- Petr³ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] What is Changelog on wiki for?
On 01/27/2014 05:23 PM, Simo Sorce wrote: On Mon, 2014-01-27 at 16:53 +0100, Martin Kosek wrote: On 01/27/2014 04:02 PM, Petr Viktorin wrote: On 01/27/2014 03:32 PM, Rob Crittenden wrote: [...] It is useful because you can more easily see what made it into the particular dot release rather than finding the patch you want then knowing to search backwards for the Become xx.yy commit. I saw it as a poor-man's way of finding changes. I think a poor man can open up the individual Release notes and look there. And a rich man (who has the repo cloned) can just use Git. $ git log -i --grep 'drop selinux' commit ad6abdb576b2ebeb941eb99fd141bf78918143c1 Author: Martin Kosek mko...@redhat.com Date: Thu Jun 13 14:40:52 2013 +0200 Drop SELinux subpackage All SELinux policy needed by FreeIPA server is now part of the global system SELinux policy which makes the subpackage redundant and slowing down the installation. This patch drops it. https://fedorahosted.org/freeipa/ticket/3683 https://fedorahosted.org/freeipa/ticket/3684 $ git tag --contains ad6abdb576b2ebeb941eb99fd141bf78918143c1 beta_1-3-3-0 beta_2-3-3-0 release-3-3-0 release-3-3-1 release-3-3-2 release-3-3-3 I couldn't say it better. Let's drop the manual changelog and use some modern way to do it - case is closed. May be you can stick into the Release notes page the actual query that gives you the changelog from cgit ? It should probably be https://git.fedorahosted.org/cgit/freeipa.git/log/?qt=rangeq=release-3.3.2..release-3.3.3 But at the moment it returns an internal server error, I will ask on fedora-admin Simo. I can do that. Just note that the between-versions diff changelog in Release notes stays, we are just discussing removing the global one [1]. Martin [1] http://www.freeipa.org/page/Changelog ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] What is Changelog on wiki for?
On Mon, 2014-01-27 at 16:53 +0100, Martin Kosek wrote: On 01/27/2014 04:02 PM, Petr Viktorin wrote: On 01/27/2014 03:32 PM, Rob Crittenden wrote: [...] It is useful because you can more easily see what made it into the particular dot release rather than finding the patch you want then knowing to search backwards for the Become xx.yy commit. I saw it as a poor-man's way of finding changes. I think a poor man can open up the individual Release notes and look there. And a rich man (who has the repo cloned) can just use Git. $ git log -i --grep 'drop selinux' commit ad6abdb576b2ebeb941eb99fd141bf78918143c1 Author: Martin Kosek mko...@redhat.com Date: Thu Jun 13 14:40:52 2013 +0200 Drop SELinux subpackage All SELinux policy needed by FreeIPA server is now part of the global system SELinux policy which makes the subpackage redundant and slowing down the installation. This patch drops it. https://fedorahosted.org/freeipa/ticket/3683 https://fedorahosted.org/freeipa/ticket/3684 $ git tag --contains ad6abdb576b2ebeb941eb99fd141bf78918143c1 beta_1-3-3-0 beta_2-3-3-0 release-3-3-0 release-3-3-1 release-3-3-2 release-3-3-3 I couldn't say it better. Let's drop the manual changelog and use some modern way to do it - case is closed. May be you can stick into the Release notes page the actual query that gives you the changelog from cgit ? It should probably be https://git.fedorahosted.org/cgit/freeipa.git/log/?qt=rangeq=release-3.3.2..release-3.3.3 But at the moment it returns an internal server error, I will ask on fedora-admin Simo. -- Simo Sorce * Red Hat, Inc * New York ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
