Re: [Freeipa-devel] [PATCH] 364 base64-encode binary data for outputting to cli

2010-02-02 Thread Rob Crittenden
John Dennis wrote: On 02/01/2010 02:03 PM, Rob Crittenden wrote: The python type (str or unicode) tells us whether a variable is binary or text. Use this knowledge to base64-encode binary data so we stop hosing up terminals, especially when displaying certificates. rob ACK pushed to

Re: [Freeipa-devel] [PATCH] 365 be smarter about base64 decoding

2010-02-02 Thread Rob Crittenden
John Dennis wrote: On 02/01/2010 02:05 PM, Rob Crittenden wrote: Try to be a little smarter about base64 decoding certificates. For the most part certificates are handled as DER blobs internally. When loading certs from files or an NSS database they may come in as base64-endoded blobs but they

Re: [Freeipa-devel] [PATCH] add l10n support

2010-02-02 Thread Rob Crittenden
John Dennis wrote: There are 2 patches attached which add internationalized message catalog support (l10n, i.e. localization). The patch was split into 2 pieces for easier review. The first patch contains only the modifications to build components and the new framework. The second patch adds all

[Freeipa-devel] [PATCH] 367 fix some encoding issues

2010-02-02 Thread Rob Crittenden
I forgot the 'make test' step before submitting my base64 encoding in the cli patch. This fixes a few minor embedded documentation test failures and a limitation that it only accepted string types. rob freeipa-367-cli.patch Description: application/mbox

Re: [Freeipa-devel] [PATCH] 367 fix some encoding issues

2010-02-02 Thread John Dennis
On 02/02/2010 05:23 PM, Rob Crittenden wrote: I forgot the 'make test' step before submitting my base64 encoding in the cli patch. This fixes a few minor embedded documentation test failures and a limitation that it only accepted string types. rob ACK -- John Dennis jden...@redhat.com

[Freeipa-devel] [PATCH] 368 remove some duplicate code

2010-02-02 Thread Rob Crittenden
Move the dogtag HTTP and HTTPS request functions to a common library to remove duplication. I'm next planning on moving the XML parsing code into ipapython/dogtag because that is needed by the installer as well to identify errors. This is going to be quite a bit messier I think. rob