[Freeipa-devel] [PATCH] 249 Return correct record name in DNS plugin

2012-04-12 Thread Martin Kosek
When dnsrecord-add or dnsrecord-mod commands are used on a root zone record (it has a special name @), a zone name is returned instead of a special name @. This confuses DNS part of Web UI which is then not able to manipulate records in the root zone when these commands are used. This patch fixes

Re: [Freeipa-devel] [PATCH 72] Validate DN RDN parameters for migrate command

2012-04-12 Thread Martin Kosek
On Wed, 2012-04-11 at 22:05 -0400, John Dennis wrote: Revised patch attached. We'll leave the DN parameter changes till later. This is essentially the same as the original patch with the addition of the fixes necessary to support passing an empty container arg, an issue Martin discovered in

Re: [Freeipa-devel] [RANT] --setattr validation is a minefield.

2012-04-12 Thread Petr Viktorin
On 04/11/2012 09:42 AM, Jan Cholasta wrote: On 11.4.2012 09:27, Martin Kosek wrote: On Wed, 2012-04-11 at 09:18 +0200, Jan Cholasta wrote: On 10.4.2012 19:56, Dmitri Pal wrote: ... The use case I would see is the extensibility. Say a customer wants to extend a schema and add an attribute X

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-12 Thread Petr Viktorin
On 04/10/2012 10:41 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 03/30/2012 11:00 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 03/26/2012 05:35 PM, Petr Viktorin wrote: On 03/26/2012 04:54 PM, Rob Crittenden wrote: Some minor compliants. Ideally, there would be a routine that

[Freeipa-devel] [PATCH] 75 Fix internal error when renaming user with an empty string

2012-04-12 Thread Jan Cholasta
https://fedorahosted.org/freeipa/ticket/2629 Honza -- Jan Cholasta From da5f23b9d85a5b1725e2204758faa4bac90f0a58 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Thu, 12 Apr 2012 07:29:21 -0400 Subject: [PATCH] Fix internal error when renaming user with an empty string.

Re: [Freeipa-devel] param type issues

2012-04-12 Thread Petr Viktorin
On 04/11/2012 07:44 PM, Rob Crittenden wrote: John Dennis wrote: ... 3) The class name cannot contain an underscore. The find_name() function in makeapi uses a regexp that does not permit an underscore in the name of the class. I presume this was an oversight and not a requirement that

Re: [Freeipa-devel] [PATCH] 75 Fix internal error when renaming user with an empty string

2012-04-12 Thread Martin Kosek
On Thu, 2012-04-12 at 13:34 +0200, Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/2629 Honza ACK. I will wait with push until the ticket is triaged. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 249 Return correct record name in DNS plugin

2012-04-12 Thread Jan Cholasta
On 12.4.2012 09:51, Martin Kosek wrote: When dnsrecord-add or dnsrecord-mod commands are used on a root zone record (it has a special name @), a zone name is returned instead of a special name @. This confuses DNS part of Web UI which is then not able to manipulate records in the root zone when

Re: [Freeipa-devel] [PATCH] 0036 Remove pattern_errmsg from API.txt

2012-04-12 Thread Martin Kosek
On Thu, 2012-04-12 at 14:50 +0200, Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2619 ACK. Pushed to master, ipa-2-2. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 248 Raise proper exception when LDAP limits are exceeded

2012-04-12 Thread Jan Cholasta
On 10.4.2012 10:57, Martin Kosek wrote: Few test hints are attached to the ticket. --- ldap2 plugin returns NotFound error for find_entries/get_entry queries when the server did not manage to return an entry due to time limits. This may be confusing for user when the entry he searches actually

Re: [Freeipa-devel] [PATCH] 248 Raise proper exception when LDAP limits are exceeded

2012-04-12 Thread Rob Crittenden
Jan Cholasta wrote: On 10.4.2012 10:57, Martin Kosek wrote: Few test hints are attached to the ticket. --- ldap2 plugin returns NotFound error for find_entries/get_entry queries when the server did not manage to return an entry due to time limits. This may be confusing for user when the entry

[Freeipa-devel] [PATCH] 22 Always set ipa_hostname for sssd.conf

2012-04-12 Thread Ondrej Hamada
https://fedorahosted.org/freeipa/ticket/2527 ipa-client-install will always set ipa_hostname for sssd.conf in order to prevent the client from getting into weird state. -- Regards, Ondrej Hamada FreeIPA team jabber:oh...@jabbim.cz IRC: ohamada From 4f471211d6e0ab33e17bc1cda5d7c89045e2b3d5 Mon

Re: [Freeipa-devel] [PATCH 72] Validate DN RDN parameters for migrate command

2012-04-12 Thread John Dennis
On 04/12/2012 04:17 AM, Martin Kosek wrote: On Wed, 2012-04-11 at 22:05 -0400, John Dennis wrote: Revised patch attached. We'll leave the DN parameter changes till later. This is essentially the same as the original patch with the addition of the fixes necessary to support passing an empty

Re: [Freeipa-devel] [PATCH] 0042-0048 AD trusts support (master)

2012-04-12 Thread Martin Kosek
On Tue, 2012-04-03 at 16:57 +0200, Sumit Bose wrote: On Tue, Apr 03, 2012 at 01:41:35PM +0300, Alexander Bokovoy wrote: Hi! Attached are the current patches for adding support for Active Directory trusts for FreeIPA v3 (master). These are tested and working with samba4 build

Re: [Freeipa-devel] [PATCH] 0042-0048 AD trusts support (master)

2012-04-12 Thread Alexander Bokovoy
Hi Martin! On Thu, 12 Apr 2012, Martin Kosek wrote: Hello Alexander, I read the patches with focus on Python parts, please check my comments. freeipa-abbra-0042-ticket-2192.patch: 1) s4u2proxy records that you add for new replicas should also be removed during replica uninstall. Otherwise you

Re: [Freeipa-devel] [PATCH] 0042-0048 AD trusts support (master)

2012-04-12 Thread Martin Kosek
On Thu, 2012-04-12 at 18:08 +0300, Alexander Bokovoy wrote: Hi Martin! On Thu, 12 Apr 2012, Martin Kosek wrote: ... 3) I would not try to import ipaserver.dcerpc every time the command is executed: +try: +import ipaserver.dcerpc +except Exception, e: +

Re: [Freeipa-devel] [PATCH] 0033 Pass make-test arguments through to Nose + Test coverage

2012-04-12 Thread John Dennis
On 04/11/2012 05:26 PM, Rob Crittenden wrote: Petr Viktorin wrote: Currently, our test script forwards a select few command line arguments to nosetests. This patch removes the filtering, passing all arguments through. This allows things like disabling output redirection (--nocapture), dropping

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-12 Thread John Dennis
On 03/30/2012 06:21 AM, Petr Viktorin wrote: Updated patch: only log if logging has been configured (detected by looking at the root logger's handlers), and changed the message to “The ipa-server-install command has succeeded/failed”. Actually the log_manager has an attribute called

Re: [Freeipa-devel] [PATCH] 0033 Pass make-test arguments through to Nose + Test coverage

2012-04-12 Thread Rob Crittenden
John Dennis wrote: On 04/11/2012 05:26 PM, Rob Crittenden wrote: Petr Viktorin wrote: Currently, our test script forwards a select few command line arguments to nosetests. This patch removes the filtering, passing all arguments through. This allows things like disabling output redirection

Re: [Freeipa-devel] [PATCH] 21 Unable to rename permission object

2012-04-12 Thread Rob Crittenden
Ondrej Hamada wrote: On 04/10/2012 09:35 PM, Rob Crittenden wrote: Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2571 The update was failing because of the case insensitivity of permission object DN. Can you wrap the error in _() and add a couple of test cases for this, say