Re: [Freeipa-devel] [PATCH] 0005 Add list of domains associated to our realm to cn=etc

2013-02-19 Thread Alexander Bokovoy
On Wed, 13 Feb 2013, Alexander Bokovoy wrote: On Tue, 12 Feb 2013, Ana Krivokapic wrote: Add new LDAP container to store the list of domains associated with IPA realm. Add two new ipa commands (ipa realmdomains-show and ipa realmdomains-mod) to allow manipulation of the list of realm domains.

Re: [Freeipa-devel] [PATCH] 255 Added Web UI support for service PAC type option: NONE

2013-02-19 Thread Sumit Bose
On Thu, Feb 14, 2013 at 09:56:44AM -0600, Endi Sukma Dewata wrote: On 2/14/2013 6:30 AM, Petr Vobornik wrote: If they are mutually exclusive, they probably should be separated using radio buttons like this: PAC: ( ) None (o) Type: [x] MS-PAC [ ] PAD

Re: [Freeipa-devel] [PATCH] 1085 cert-find command

2013-02-19 Thread Petr Viktorin
On 02/18/2013 08:39 PM, Rob Crittenden wrote: Rob Crittenden wrote: Petr Viktorin wrote: On 02/15/2013 10:43 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/06/2013 07:23 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/06/2013 12:44 AM, Rob Crittenden wrote: This adds a

Re: [Freeipa-devel] [PATCHES] 0177-0179 Add missing dict methods to CIDict

2013-02-19 Thread Jan Cholasta
Hi, On 5.2.2013 18:02, Petr Viktorin wrote: CIDict, our case-insensitive dictionary, inherits from dict but did not reimplement the full dict interface. Calling the missing methods silently invoked case-sensitive behavior. Our code seems to avoid that, but it's a bit of a minefield for new

Re: [Freeipa-devel] [PATCH] 90 Run interactive_prompt callbacks after CSV values are split

2013-02-19 Thread Jan Cholasta
On 14.2.2013 10:45, Petr Viktorin wrote: This needs a test; here one I used to check it. Otherwise it works well, ACK if the test is added. Thank you, test added. Honza -- Jan Cholasta From d845724362507c662e45f21396b46ce520f25a45 Mon Sep 17 00:00:00 2001 From: Jan Cholasta

Re: [Freeipa-devel] [PATCH] 255 Added Web UI support for service PAC type option: NONE

2013-02-19 Thread Petr Vobornik
On 02/19/2013 01:40 PM, Sumit Bose wrote: On Thu, Feb 14, 2013 at 09:56:44AM -0600, Endi Sukma Dewata wrote: On 2/14/2013 6:30 AM, Petr Vobornik wrote: If they are mutually exclusive, they probably should be separated using radio buttons like this: PAC: ( ) None (o) Type:

Re: [Freeipa-devel] [PATCH] 255 Added Web UI support for service PAC type option: NONE

2013-02-19 Thread Sumit Bose
On Tue, Feb 19, 2013 at 02:01:24PM +0100, Petr Vobornik wrote: On 02/19/2013 01:40 PM, Sumit Bose wrote: On Thu, Feb 14, 2013 at 09:56:44AM -0600, Endi Sukma Dewata wrote: On 2/14/2013 6:30 AM, Petr Vobornik wrote: If they are mutually exclusive, they probably should be separated using radio

Re: [Freeipa-devel] [PATCH] 255 Added Web UI support for service PAC type option: NONE

2013-02-19 Thread Petr Vobornik
On 02/19/2013 02:08 PM, Sumit Bose wrote: On Tue, Feb 19, 2013 at 02:01:24PM +0100, Petr Vobornik wrote: On 02/19/2013 01:40 PM, Sumit Bose wrote: On Thu, Feb 14, 2013 at 09:56:44AM -0600, Endi Sukma Dewata wrote: On 2/14/2013 6:30 AM, Petr Vobornik wrote: If they are mutually exclusive,

Re: [Freeipa-devel] [PATCHES] 137-144 LDAP code refactoring (Part 3)

2013-02-19 Thread Jan Cholasta
On 29.1.2013 10:21, Jan Cholasta wrote: A patch from this patchset (part 3) causes some of the dns plugin tests to fail (idnsallowdynupdate is missing in dnszone_add output). Honza Patch 143: +assert isinstance(entry_or_dn, DN) +if normalize is None or normalize: +

Re: [Freeipa-devel] [PATCH] 255 Added Web UI support for service PAC type option: NONE

2013-02-19 Thread Sumit Bose
On Tue, Feb 19, 2013 at 02:12:24PM +0100, Petr Vobornik wrote: On 02/19/2013 02:08 PM, Sumit Bose wrote: On Tue, Feb 19, 2013 at 02:01:24PM +0100, Petr Vobornik wrote: On 02/19/2013 01:40 PM, Sumit Bose wrote: On Thu, Feb 14, 2013 at 09:56:44AM -0600, Endi Sukma Dewata wrote: On 2/14/2013

Re: [Freeipa-devel] [PATCHES] 146-164 LDAP code refactoring (Part 4)

2013-02-19 Thread Jan Cholasta
On 1.2.2013 15:38, Petr Viktorin wrote: Alright, I renamed get_single to single_value(). I also rebased to current master. Patch 152: +def single_value(self, name, default=_missing): +values = self.get(name, [default]) +if len(values) != 1: +raise ValueError(

Re: [Freeipa-devel] [PATCH] 90 Run interactive_prompt callbacks after CSV values are split

2013-02-19 Thread Petr Viktorin
On 02/19/2013 01:57 PM, Jan Cholasta wrote: On 14.2.2013 10:45, Petr Viktorin wrote: This needs a test; here one I used to check it. Otherwise it works well, ACK if the test is added. Thank you, test added. Honza ACK -- PetrĀ³ ___

Re: [Freeipa-devel] [PATCHES] 137-144 LDAP code refactoring (Part 3)

2013-02-19 Thread Petr Viktorin
On 02/19/2013 02:17 PM, Jan Cholasta wrote: On 29.1.2013 10:21, Jan Cholasta wrote: A patch from this patchset (part 3) causes some of the dns plugin tests to fail (idnsallowdynupdate is missing in dnszone_add output). Honza Patch 143: +assert isinstance(entry_or_dn, DN) +

Re: [Freeipa-devel] [PATCH] 90 Run interactive_prompt callbacks after CSV values are split

2013-02-19 Thread Rob Crittenden
Petr Viktorin wrote: On 02/19/2013 01:57 PM, Jan Cholasta wrote: On 14.2.2013 10:45, Petr Viktorin wrote: This needs a test; here one I used to check it. Otherwise it works well, ACK if the test is added. Thank you, test added. Honza ACK Pushed to master and ipa-3-1 rob

Re: [Freeipa-devel] [PATCH] 360 Add autodiscovery section in ipa-client-install man pages

2013-02-19 Thread Rob Crittenden
Martin Kosek wrote: On 01/31/2013 04:41 PM, Martin Kosek wrote: On 01/31/2013 02:44 PM, Petr Spacek wrote: On 31.1.2013 13:18, Martin Kosek wrote: Explain how autodiscovery and failover works and which options are important for these elements. https://fedorahosted.org/freeipa/ticket/3383

Re: [Freeipa-devel] [PATCH] 1087 Some missing v3 schema on upgrades

2013-02-19 Thread Jan Cholasta
Hi, On 18.2.2013 22:00, Rob Crittenden wrote: An objectclass and attribute are not being added on upgrades. Missing these causes the UI to not work. I also noticed a typo in the ordering of a number of the trust attributes so fix those as well. rob The patch looks good, but I think errors

Re: [Freeipa-devel] [PATCHES] 98-101 Preserve case of LDAP attribute names

2013-02-19 Thread Rob Crittenden
Petr Viktorin wrote: On 02/06/2013 10:55 AM, Jan Cholasta wrote: On 5.2.2013 15:45, Petr Viktorin wrote: On 02/05/2013 01:38 PM, Jan Cholasta wrote: On 4.2.2013 15:49, Petr Viktorin wrote: [...] I see one of the changes is using has_key instead of `in` for a CIDict. Given that

Re: [Freeipa-devel] [PATCH] 1085 cert-find command

2013-02-19 Thread Rob Crittenden
Petr Viktorin wrote: On 02/18/2013 08:39 PM, Rob Crittenden wrote: Rob Crittenden wrote: Petr Viktorin wrote: On 02/15/2013 10:43 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/06/2013 07:23 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/06/2013 12:44 AM, Rob Crittenden wrote:

Re: [Freeipa-devel] [PATCH] 0005 Add list of domains associated to our realm to cn=etc

2013-02-19 Thread Rob Crittenden
Alexander Bokovoy wrote: On Wed, 13 Feb 2013, Alexander Bokovoy wrote: On Tue, 12 Feb 2013, Ana Krivokapic wrote: Add new LDAP container to store the list of domains associated with IPA realm. Add two new ipa commands (ipa realmdomains-show and ipa realmdomains-mod) to allow manipulation of

Re: [Freeipa-devel] [PATCH] 1087 Some missing v3 schema on upgrades

2013-02-19 Thread Rob Crittenden
Jan Cholasta wrote: Hi, On 18.2.2013 22:00, Rob Crittenden wrote: An objectclass and attribute are not being added on upgrades. Missing these causes the UI to not work. I also noticed a typo in the ordering of a number of the trust attributes so fix those as well. rob The patch looks

Re: [Freeipa-devel] [PATCH] 1087 Some missing v3 schema on upgrades

2013-02-19 Thread Simo Sorce
On Tue, 2013-02-19 at 13:32 -0500, Rob Crittenden wrote: Jan Cholasta wrote: Hi, On 18.2.2013 22:00, Rob Crittenden wrote: An objectclass and attribute are not being added on upgrades. Missing these causes the UI to not work. I also noticed a typo in the ordering of a number of the

Re: [Freeipa-devel] [PATCH 0027] Add checks for SELinux in install scripts

2013-02-19 Thread Rob Crittenden
Tomas Babej wrote: On 02/04/2013 04:21 PM, Rob Crittenden wrote: Tomas Babej wrote: On 01/30/2013 05:12 PM, Tomas Babej wrote: Hi, The checks make sure that SELinux is: - installed and enabled (on server install) - installed and enabled OR not installed (on client install) Please note

Re: [Freeipa-devel] [PATCH] 0002 Add missing error message when adding duplicate external member to group

2013-02-19 Thread Rob Crittenden
Ana Krivokapic wrote: When adding a duplicate member to a group, an error message is issued, informing the user that the entry is already a member of the group. This message was missing in case of an external member. Ticket: https://fedorahosted.org/freeipa/ticket/3254 This works ok but the

Re: [Freeipa-devel] [PATCH] 355 Avoid internal error when user is not Trust admin

2013-02-19 Thread Rob Crittenden
Martin Kosek wrote: On 01/24/2013 12:01 PM, Martin Kosek wrote: When user tries to perform any action requiring communication with trusted domain, IPA server tries to retrieve a trust secret on his behalf to be able to establish the connection. This happens for example during group-add-member

Re: [Freeipa-devel] [PATCHES 0031-0032] Improve HBAC rule handling in selinuxusermap-add/mod/find

2013-02-19 Thread Rob Crittenden
Tomas Babej wrote: On 02/06/2013 07:57 PM, Rob Crittenden wrote: Tomas Babej wrote: Hi, this pair of patches improves HBAC rule handling in selinuxusermap commands. Patch 0031 deals with: https://fedorahosted.org/freeipa/ticket/3349 Patch 0032 takes care of:

Re: [Freeipa-devel] [PATCH 0033] Prevent changing protected group's name using --setattr

2013-02-19 Thread Rob Crittenden
Petr Viktorin wrote: On 02/11/2013 11:17 AM, Tomas Babej wrote: Hi, The name of any protected group now cannot be changed by modifing the cn attribute using --setattr. Unit tests have been added to make sure there is no regression. https://fedorahosted.org/freeipa/ticket/3354 Tomas We

Re: [Freeipa-devel] [PATCH] 0180 Check SSH connection in ipa-replica-conncheck

2013-02-19 Thread Rob Crittenden
Petr Viktorin wrote: On 02/15/2013 08:18 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/15/2013 04:38 PM, Rob Crittenden wrote: Petr Viktorin wrote: ipa-replica-conncheck ran SSH in quiet mode, probably to suppress a message about connecting to an unknown host. This made it hard to

[Freeipa-devel] Backup and Restore design

2013-02-19 Thread Rob Crittenden
I've looked into some basic backup and restore procedures for IPA. My findings are here: http://freeipa.org/page/V3/Backup_and_Restore This is in support of ticket https://fedorahosted.org/freeipa/ticket/3128 rob ___ Freeipa-devel mailing list

Re: [Freeipa-devel] Backup and Restore design

2013-02-19 Thread John Dennis
On 02/19/2013 10:43 PM, Rob Crittenden wrote: I've looked into some basic backup and restore procedures for IPA. My findings are here: http://freeipa.org/page/V3/Backup_and_Restore Good write up Rob! It seems to me there are two critical sub-issues to solve first that could benefit us in the