Re: [Freeipa-devel] Why do we require DNS record when service is being added?

2015-07-13 Thread Petr Spacek
On 13.7.2015 19:37, Jan Pazdziora wrote: > > Hello, > > we got a nack > > https://www.redhat.com/archives/freeipa-devel/2015-July/msg00259.html > > when attempting to address ticket > > https://fedorahosted.org/freeipa/ticket/3959 > > Basically, when service is being added with ip

[Freeipa-devel] Why do we require DNS record when service is being added?

2015-07-13 Thread Jan Pazdziora
Hello, we got a nack https://www.redhat.com/archives/freeipa-devel/2015-July/msg00259.html when attempting to address ticket https://fedorahosted.org/freeipa/ticket/3959 Basically, when service is being added with ipa service-add, you have to use --force to add it if the under

Re: [Freeipa-devel] [PATCH 0050] Fix client ca.crt to match the server's cert

2015-07-13 Thread Martin Basti
On 08/07/15 16:09, Gabe Alford wrote: Thanks, Martin. Update patch attached. I was getting an 'No newline at the end of file' in my environment hence an extra '\n' at the end. Please let me know if you see the same thing. Thanks, Gabe On Wed, Jul 1, 2015 at 2:54 AM, Martin Basti

Re: [Freeipa-devel] [PATCH] 0001 Enhance the DNSNotARecordError message

2015-07-13 Thread Petr Spacek
On 13.7.2015 16:32, Alexander Bokovoy wrote: > On Mon, 13 Jul 2015, Jan Pazdziora wrote: >> On Mon, Jul 13, 2015 at 03:12:13PM +0200, Petr Spacek wrote: >>> >>> Personally-opinionated-NACK. >>> >>> I would like to avoid advertising --force options when possible. --force >>> should not be necessary

Re: [Freeipa-devel] [PATCH] 0001 Enhance the DNSNotARecordError message

2015-07-13 Thread Alexander Bokovoy
On Mon, 13 Jul 2015, Jan Pazdziora wrote: On Mon, Jul 13, 2015 at 03:12:13PM +0200, Petr Spacek wrote: Personally-opinionated-NACK. I would like to avoid advertising --force options when possible. --force should not be necessary in proper setups and advertising it will make people to use it in

Re: [Freeipa-devel] [PATCH 0006] Start dirsrv for kdcproxy upgrade

2015-07-13 Thread Martin Basti
On 10/07/15 18:29, Christian Heimes wrote: Hi, this patch ensures that DS is running before HTTPInstance attempts to connect to LDAP. https://fedorahosted.org/freeipa/ticket/5113 While I was testing the patch I ran into trouble with DS. The upgrade script couldn't connect to 389/TCP, although

Re: [Freeipa-devel] [PATCH 007] Remove tuple unpacking from except clause

2015-07-13 Thread Alexander Bokovoy
On Mon, 13 Jul 2015, Tomas Babej wrote: On 07/13/2015 02:59 PM, Rob Crittenden wrote: Christian Heimes wrote: The patch replaces implicit tuple unpacking from except clauses with explicit unpacking of the exception objects' args attribute. Example: e = RuntimeError('num', 'messages') num,

Re: [Freeipa-devel] [PATCH] 0001 Enhance the DNSNotARecordError message

2015-07-13 Thread Jan Pazdziora
On Mon, Jul 13, 2015 at 03:12:13PM +0200, Petr Spacek wrote: > > Personally-opinionated-NACK. > > I would like to avoid advertising --force options when possible. --force > should not be necessary in proper setups and advertising it will make people > to use it instead of fixing underlying proble

Re: [Freeipa-devel] [PATCH 007] Remove tuple unpacking from except clause

2015-07-13 Thread Christian Heimes
On 2015-07-13 15:21, Tomas Babej wrote: > > > On 07/13/2015 02:59 PM, Rob Crittenden wrote: >> Christian Heimes wrote: >>> The patch replaces implicit tuple unpacking from except clauses with >>> explicit unpacking of the exception objects' args attribute. >>> >>> Example: >>> >> e = RuntimeE

Re: [Freeipa-devel] [PATCH 007] Remove tuple unpacking from except clause

2015-07-13 Thread Tomas Babej
On 07/13/2015 02:59 PM, Rob Crittenden wrote: > Christian Heimes wrote: >> The patch replaces implicit tuple unpacking from except clauses with >> explicit unpacking of the exception objects' args attribute. >> >> Example: >> > e = RuntimeError('num', 'messages') > num, message = e >

Re: [Freeipa-devel] [PATCH] 886-890 webui: API browser

2015-07-13 Thread Petr Spacek
On 3.7.2015 10:45, Tomas Babej wrote: > > > On 07/03/2015 10:06 AM, Tomas Babej wrote: >> >> >> On 07/02/2015 04:55 PM, Martin Kosek wrote: >>> On 07/01/2015 04:51 PM, Petr Vobornik wrote: For those of you who don't want to try the patches: * https://pvoborni.fedorapeople.org/images/api

Re: [Freeipa-devel] [PATCH] 0001 Enhance the DNSNotARecordError message

2015-07-13 Thread Petr Spacek
On 10.7.2015 20:06, Veronika Kabatova wrote: > - Original Message - >> From: "Tomas Babej" >> To: "Veronika Kabatova" , freeipa-devel@redhat.com >> Sent: Friday, July 10, 2015 2:56:58 PM >> Subject: Re: [Freeipa-devel] [PATCH] 0001 Enhance the DNSNotARecordError >> message >> >> >> >> On

Re: [Freeipa-devel] [PATCH 529] Fix DNS record installation for replicas

2015-07-13 Thread Martin Basti
On 10/07/15 19:57, Simo Sorce wrote: On Fri, 2015-07-10 at 13:03 -0400, Simo Sorce wrote: This bug affects 4.2, we should backport the fix there too. See ticket: https://fedorahosted.org/freeipa/ticket/5116 For what is worth I tested this change in my replica install code and it fixes the issu

Re: [Freeipa-devel] [PATCH 0284] stageuser-activate: show user name in error message instead of DN

2015-07-13 Thread David Kupka
On 10/07/15 14:51, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5038 I reworded the error message to keep the same format as stageuser-add and user-add. Patch attached. Works for me, ACK. -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https:/

Re: [Freeipa-devel] [PATCH 007] Remove tuple unpacking from except clause

2015-07-13 Thread Rob Crittenden
Christian Heimes wrote: The patch replaces implicit tuple unpacking from except clauses with explicit unpacking of the exception objects' args attribute. Example: e = RuntimeError('num', 'messages') num, message = e num, message ('num', 'messages') e.args ('num', 'messages') num, message =

[Freeipa-devel] [PATCH 007] Remove tuple unpacking from except clause

2015-07-13 Thread Christian Heimes
The patch replaces implicit tuple unpacking from except clauses with explicit unpacking of the exception objects' args attribute. Example: >>> e = RuntimeError('num', 'messages') >>> num, message = e >>> num, message ('num', 'messages') >>> e.args ('num', 'messages') >>> num, message = e.args >>>