[Freeipa-devel] [PATCH 0090] show optionally configured components in server-find/show command output

2015-10-22 Thread Martin Babinsky
https://fedorahosted.org/freeipa/ticket/5181 -- Martin^3 Babinsky From 118d0755142b7e801e87439ef1c84f476fd8f825 Mon Sep 17 00:00:00 2001 From: Martin Babinsky Date: Thu, 22 Oct 2015 10:26:41 +0200 Subject: [PATCH] show optionally configured components in server-find/show

Re: [Freeipa-devel] terminology: "main/primary/? DNS domain" for FreeIPA

2015-10-22 Thread Petr Spacek
On 8.10.2015 20:55, Simo Sorce wrote: > On 08/10/15 09:34, Petr Spacek wrote: >> Hello list, >> >> I'm in process of reviewing and fixing some of our docs and it seems that we >> do not have established term for The Domain user specified during >> ipa-server-install. >> >> Term "DNS domain" is not

Re: [Freeipa-devel] [PATCHSET] Replica promotion patches

2015-10-22 Thread Martin Basti
On 22.10.2015 13:30, Martin Babinsky wrote: On 10/21/2015 09:27 PM, Simo Sorce wrote: On 21/10/15 15:24, Simo Sorce wrote: On 21/10/15 11:46, Martin Babinsky wrote: On 10/20/2015 07:24 PM, Simo Sorce wrote: On 20/10/15 06:32, Martin Babinsky wrote: On 10/15/2015 08:14 PM, Simo Sorce

[Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

2015-10-22 Thread Oleg Fayans
-- Oleg Fayans Quality Engineer FreeIPA team RedHat. From c0a41ec0fbfb70ac33fd97beb1641ecfa126a87d Mon Sep 17 00:00:00 2001 From: Oleg Fayans Date: Thu, 22 Oct 2015 14:05:24 +0200 Subject: [PATCH] Updated the tests according to the new replica installation workflow As of

Re: [Freeipa-devel] [0089] fix class teardown in user plugin tests

2015-10-22 Thread Martin Basti
On 20.10.2015 13:25, Martin Babinsky wrote: fixes https://fedorahosted.org/freeipa/ticket/5368 Pushed to: master: af1f6721e1941af2012d38e1e8f628eef7ec014f ipa-4-2: 1573d3a81ecd55547bbc1f9b59fd84b0095e3565 -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCHSET] Replica promotion patches

2015-10-22 Thread Petr Vobornik
On 10/22/2015 01:30 PM, Martin Babinsky wrote: On 10/21/2015 09:27 PM, Simo Sorce wrote: snip Thanks, ACK for patch 551-6. I will continue the review of patch 552 when we'll have a dogtag build with fix for https://fedorahosted.org/pki/ticket/1580 in copr repo. Martin, could you try

Re: [Freeipa-devel] [PATCHSET] Replica promotion patches

2015-10-22 Thread Petr Vobornik
On 10/16/2015 06:41 PM, Endi Sukma Dewata wrote: On 10/15/2015 9:54 AM, Simo Sorce wrote: 3) ipa-ca-install fails with: Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/ipaserver/install/service.py", line 445, in start_creation run_step(full_msg, method)

Re: [Freeipa-devel] [PATCHSET] Replica promotion patches

2015-10-22 Thread Martin Babinsky
On 10/22/2015 02:01 PM, Petr Vobornik wrote: On 10/22/2015 01:30 PM, Martin Babinsky wrote: On 10/21/2015 09:27 PM, Simo Sorce wrote: snip Thanks, ACK for patch 551-6. I will continue the review of patch 552 when we'll have a dogtag build with fix for

Re: [Freeipa-devel] [PATCH 0057] Warn in no installation found when running ipa-server-install --uninstall

2015-10-22 Thread Martin Basti
On 22.10.2015 01:28, Gabe Alford wrote: Thanks Martin^2. Updated patched attached. On Wed, Oct 21, 2015 at 2:46 AM, Martin Basti > wrote: On 20.10.2015 05:17, Gabe Alford wrote: Bump for re-review. Hello, thank your for

Re: [Freeipa-devel] [PATCHES] 737-742 More Python3 porting

2015-10-22 Thread Tomas Babej
On 10/20/2015 06:30 PM, Petr Viktorin wrote: > Yet another batch of py3 patches. > > We're getting closer: if this was merged, my WIP branch that passes > ipapython & ipalib tests under py3 would currently be down to: > 8 files changed, 73 insertions(+), 23 deletions(-) ACK. This looks good to

Re: [Freeipa-devel] [PATCH 0090] show optionally configured components in server-find/show command output

2015-10-22 Thread Martin Basti
On 22.10.2015 16:35, Petr Spacek wrote: On 22.10.2015 16:13, Martin Basti wrote: On 22.10.2015 10:44, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5181 Thank you for the patch. 1) +OPTIONAL_SERVICES = { +'DNS', +'CA', +'KRA', +'ADTRUST', +'EXTID', +

Re: [Freeipa-devel] [PATCH 0083] perform an unlimited search for reverse zones when adding DNS records

2015-10-22 Thread Petr Spacek
On 16.10.2015 12:13, Martin Babinsky wrote: > On 10/14/2015 04:05 PM, Petr Spacek wrote: >> On 14.10.2015 14:13, Martin Babinsky wrote: >>> On 10/13/2015 04:00 PM, Petr Spacek wrote: On 13.10.2015 13:37, Martin Babinsky wrote: > On 10/13/2015 09:36 AM, Petr Spacek wrote: >> On

Re: [Freeipa-devel] [PATCH 0086] disable ipa-replica prepare in non-zero domain levels

2015-10-22 Thread Martin Basti
On 22.10.2015 14:29, Petr Spacek wrote: On 22.10.2015 14:24, Tomas Babej wrote: On 10/22/2015 02:15 PM, Petr Spacek wrote: On 20.10.2015 17:47, Martin Babinsky wrote: +def check_domainlevel(self, api): +domain_level = dsinstance.get_domain_level(api) +if domain_level >

Re: [Freeipa-devel] [PATCH 0090] show optionally configured components in server-find/show command output

2015-10-22 Thread Martin Basti
On 22.10.2015 10:44, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5181 Thank you for the patch. 1) +OPTIONAL_SERVICES = { +'DNS', +'CA', +'KRA', +'ADTRUST', +'EXTID', +'DNSKeyExporter', +'DNSSEC', +'DNSKeySync', +} This did not scale

Re: [Freeipa-devel] [PATCHES 0324 - 0325] DNSSEC: warn user if DNSSEC key master is not installed on any replica

2015-10-22 Thread Petr Spacek
On 13.10.2015 18:49, Martin Basti wrote: > https://fedorahosted.org/freeipa/ticket/5290 > > Patches attached. ACK, thank you! -- Petr^2 Spacek -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [PATCH 0090] show optionally configured components in server-find/show command output

2015-10-22 Thread Petr Spacek
On 22.10.2015 16:51, Martin Basti wrote: > > > On 22.10.2015 16:35, Petr Spacek wrote: >> On 22.10.2015 16:13, Martin Basti wrote: >>> On 22.10.2015 10:44, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5181 >>> Thank you for the patch. >>> >>> 1) >>>

Re: [Freeipa-devel] [PATCH 0086] disable ipa-replica prepare in non-zero domain levels

2015-10-22 Thread Petr Spacek
On 20.10.2015 17:47, Martin Babinsky wrote: > +def check_domainlevel(self, api): > +domain_level = dsinstance.get_domain_level(api) > +if domain_level > MIN_DOMAIN_LEVEL: > +raise RuntimeError( > +UNSUPPORTED_DOMAIN_LEVEL_TEMPLATE.format( > +

Re: [Freeipa-devel] [PATCH 0086] disable ipa-replica prepare in non-zero domain levels

2015-10-22 Thread Petr Spacek
On 22.10.2015 14:24, Tomas Babej wrote: > > > On 10/22/2015 02:15 PM, Petr Spacek wrote: >> On 20.10.2015 17:47, Martin Babinsky wrote: >>> +def check_domainlevel(self, api): >>> +domain_level = dsinstance.get_domain_level(api) >>> +if domain_level > MIN_DOMAIN_LEVEL: >>> +

Re: [Freeipa-devel] [PATCH 0086] disable ipa-replica prepare in non-zero domain levels

2015-10-22 Thread Tomas Babej
On 10/22/2015 02:15 PM, Petr Spacek wrote: > On 20.10.2015 17:47, Martin Babinsky wrote: >> +def check_domainlevel(self, api): >> +domain_level = dsinstance.get_domain_level(api) >> +if domain_level > MIN_DOMAIN_LEVEL: >> +raise RuntimeError( >> +

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

2015-10-22 Thread Martin Basti
On 22.10.2015 14:13, Oleg Fayans wrote: Hello, thank you for the patch. 1) please remove the added empty lines, they are unrelated to this ticket 2) -def install_master(host, setup_dns=True, setup_kra=False): +def install_master(host, setup_dns=True, setup_kra=False, domainlevel=1): I

Re: [Freeipa-devel] [PATCH 0328] DNSSEC CI: Wait until DS records are replicated

2015-10-22 Thread Petr Spacek
On 16.10.2015 16:51, Martin Basti wrote: > Drill command sometimes fail on replica due to long replication time, this > patch adding check that waits until record is replicated. > > Patch attached. ACK -- Petr^2 Spacek -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] Freeipa domain levels naming

2015-10-22 Thread Petr Spacek
On 22.10.2015 17:29, Martin Basti wrote: > Hello all, > > in current master branch we have mixed usage of literals 0, 1 and constants > MIN_DOMAIN_LEVEL, MAX_DOMAIN_LEVEL, and it is quite mess. > > I suggest to use names for domain levels: > > COMPAT_DOMAIN_LEVEL = 0 > PROMOTION_DOMAIN_LEVEL =

Re: [Freeipa-devel] [PATCHSET] Replica promotion patches

2015-10-22 Thread Martin Babinsky
On 10/15/2015 08:14 PM, Simo Sorce wrote: On 15/10/15 11:39, Martin Basti wrote: Without this patch the ipa-ca-install is broken in current master. Unexpected error - see /var/log/ipareplica-ca-install.log for details: AttributeError: Values instance has no attribute 'promote' Should be fixed

Re: [Freeipa-devel] [PATCH 0090] show optionally configured components in server-find/show command output

2015-10-22 Thread Martin Basti
On 22.10.2015 16:56, Petr Spacek wrote: On 22.10.2015 16:51, Martin Basti wrote: On 22.10.2015 16:35, Petr Spacek wrote: On 22.10.2015 16:13, Martin Basti wrote: On 22.10.2015 10:44, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5181 Thank you for the patch. 1)

[Freeipa-devel] [PATCH 0333] DNSSEC installer: store status of services only for first time

2015-10-22 Thread Martin Basti
After reinstall the wrong status has been saved, we do care only about service status before first installation. Patch attached. From f3f8605cdebdcc67f9cc5b8d7195b76b17794442 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Thu, 22 Oct 2015 17:05:27 +0200 Subject: [PATCH]

[Freeipa-devel] Freeipa domain levels naming

2015-10-22 Thread Martin Basti
Hello all, in current master branch we have mixed usage of literals 0, 1 and constants MIN_DOMAIN_LEVEL, MAX_DOMAIN_LEVEL, and it is quite mess. I suggest to use names for domain levels: COMPAT_DOMAIN_LEVEL = 0 PROMOTION_DOMAIN_LEVEL = 1 UBER_NEW_FEATURE_DOMAIN_LEVEL = 2 MIN_DOMAIN_LEVEL =

Re: [Freeipa-devel] Freeipa domain levels naming

2015-10-22 Thread Simo Sorce
On 22/10/15 11:29, Martin Basti wrote: Hello all, in current master branch we have mixed usage of literals 0, 1 and constants MIN_DOMAIN_LEVEL, MAX_DOMAIN_LEVEL, and it is quite mess. I suggest to use names for domain levels: COMPAT_DOMAIN_LEVEL = 0 PROMOTION_DOMAIN_LEVEL = 1

Re: [Freeipa-devel] [PATCH 0333] DNSSEC installer: store status of services only for first time

2015-10-22 Thread Petr Spacek
On 22.10.2015 17:42, Martin Basti wrote: > After reinstall the wrong status has been saved, we do care only about service > status before first installation. > > Patch attached. ACK -- Petr^2 Spacek -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCHES 0324 - 0325] DNSSEC: warn user if DNSSEC key master is not installed on any replica

2015-10-22 Thread Martin Basti
On 22.10.2015 16:45, Petr Spacek wrote: On 13.10.2015 18:49, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5290 Patches attached. ACK, thank you! Pushed to: master: 92a4b18fc282ab7b40899c4885617fc080e9e955 ipa-4-2: 1c173749872193b8c9234137a77f3c5400f33d2a -- Manage your

Re: [Freeipa-devel] [PATCHES] 737-742 More Python3 porting

2015-10-22 Thread Martin Basti
On 22.10.2015 16:06, Tomas Babej wrote: On 10/20/2015 06:30 PM, Petr Viktorin wrote: Yet another batch of py3 patches. We're getting closer: if this was merged, my WIP branch that passes ipapython & ipalib tests under py3 would currently be down to: 8 files changed, 73 insertions(+), 23

Re: [Freeipa-devel] [PATCH 0083] perform an unlimited search for reverse zones when adding DNS records

2015-10-22 Thread Martin Basti
On 22.10.2015 16:59, Petr Spacek wrote: On 16.10.2015 12:13, Martin Babinsky wrote: On 10/14/2015 04:05 PM, Petr Spacek wrote: On 14.10.2015 14:13, Martin Babinsky wrote: On 10/13/2015 04:00 PM, Petr Spacek wrote: On 13.10.2015 13:37, Martin Babinsky wrote: On 10/13/2015 09:36 AM, Petr

Re: [Freeipa-devel] [PATCHES] from Debian

2015-10-22 Thread Martin Basti
On 05.10.2015 15:08, Timo Aaltonen wrote: Hi Here are a few prep patches to get off the list before getting to discuss how to add Debian platform support.. ACK for patches 2, 3, 4 Pushed to master: ccae42bedae09d7380e38a67cc33f776ff9a953a -- Manage your subscription for the

Re: [Freeipa-devel] [PATCHSET] Replica promotion patches

2015-10-22 Thread Martin Basti
On 22.10.2015 17:51, Martin Babinsky wrote: On 10/15/2015 08:14 PM, Simo Sorce wrote: On 15/10/15 11:39, Martin Basti wrote: Without this patch the ipa-ca-install is broken in current master. Unexpected error - see /var/log/ipareplica-ca-install.log for details: AttributeError: Values

Re: [Freeipa-devel] Freeipa domain levels naming

2015-10-22 Thread Petr Vobornik
On 10/22/2015 05:49 PM, Simo Sorce wrote: On 22/10/15 11:29, Martin Basti wrote: Hello all, in current master branch we have mixed usage of literals 0, 1 and constants MIN_DOMAIN_LEVEL, MAX_DOMAIN_LEVEL, and it is quite mess. I suggest to use names for domain levels: COMPAT_DOMAIN_LEVEL = 0

Re: [Freeipa-devel] [PATCHSET] Replica promotion patches

2015-10-22 Thread Simo Sorce
On 22/10/15 11:54, Martin Basti wrote: On 22.10.2015 17:51, Martin Babinsky wrote: On 10/15/2015 08:14 PM, Simo Sorce wrote: On 15/10/15 11:39, Martin Basti wrote: Without this patch the ipa-ca-install is broken in current master. Unexpected error - see /var/log/ipareplica-ca-install.log

Re: [Freeipa-devel] [PATCH 0328] DNSSEC CI: Wait until DS records are replicated

2015-10-22 Thread Martin Basti
On 22.10.2015 17:36, Petr Spacek wrote: On 16.10.2015 16:51, Martin Basti wrote: Drill command sometimes fail on replica due to long replication time, this patch adding check that waits until record is replicated. Patch attached. ACK Pushed to: master:

Re: [Freeipa-devel] [PATCH 0333] DNSSEC installer: store status of services only for first time

2015-10-22 Thread Martin Basti
On 22.10.2015 17:48, Petr Spacek wrote: On 22.10.2015 17:42, Martin Basti wrote: After reinstall the wrong status has been saved, we do care only about service status before first installation. Patch attached. ACK Pushed to master: 2b01f71bef71229e5b10fa839a1844a6342b36bd -- Manage your