[Freeipa-devel] Testing FreeIPA 4.3 for GA

Blocking patches for FreeIPA 4.3 were pushed, ipa-4-3 branch was created. Master branch is ready for 4.4 development. A build is available for testing in my pvoborni/freeipa-4-3 COPR repo [1] until the official 4.3 repo is created. The repo contains only this build. The build is not pure

Re: [Freeipa-devel] [PATCHES 529-530] ca install: use host credentials in domain level 1

On 14.12.2015 07:53, Jan Cholasta wrote: On 11.12.2015 17:24, Martin Basti wrote: On 11.12.2015 15:00, Jan Cholasta wrote: On 10.12.2015 09:51, Jan Cholasta wrote: Hi, the attached patches fix . My patches 523-525 are required for this:

Re: [Freeipa-devel] [PATCHES 531-532] server install: redirect ipa-client-install output to standard output

On 14.12.2015 12:54, Tomas Babej wrote: On 12/14/2015 12:52 PM, Jan Cholasta wrote: Hi, the attached patches fix . Honza Shouldn't skip_output be also marked as incompatible with redirect_output? Yes, it should. -- Jan Cholasta --

Re: [Freeipa-devel] [PATCH 0074] spec file: Add dbus-python to BuildRequires

On 14.12.2015 13:26, David Kupka wrote: During work on ticket #5497 [0] the need for dbus-python in build time was introduced but it was not added in spec file. [0] https://fedorahosted.org/freeipa/ticket/5497 Thanks. Pushed to master under the one-liner rule:

Re: [Freeipa-devel] [PATCHES 523-525] replica install: add remote connection check over API

On 14.12.2015 07:23, Jan Cholasta wrote: On 11.12.2015 18:49, Tomas Babej wrote: On 12/11/2015 05:37 PM, Martin Basti wrote: On 11.12.2015 15:40, Jan Cholasta wrote: On 11.12.2015 08:03, Jan Cholasta wrote: On 11.12.2015 07:08, Jan Cholasta wrote: On 10.12.2015 15:56, Martin Babinsky

Re: [Freeipa-devel] [PATCH 0376] KRA: add RA cert during replica promotion

On 14.12.2015 11:46, David Kupka wrote: On 14/12/15 11:00, David Kupka wrote: On 10/12/15 19:40, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5512 patch attached. Hi, thanks for the patch. It works but only when WAIT_AFTER_ARCHIVE is raised. Patch attached. IOW, your

[Freeipa-devel] [PATCH 0378] Tests: fix always true assertion

Fixes: /usr/lib/python2.7/site-packages/ipatests/test_cmdline/test_ipagetkeytab.py:116: SyntaxWarning: assertion is always true, perhaps remove parentheses? Patch attached. From 27fa8fb58e2163836e0e5784fee422af248a158c Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Mon,

[Freeipa-devel] [PATCH 0074] spec file: Add dbus-python to BuildRequires

During work on ticket #5497 [0] the need for dbus-python in build time was introduced but it was not added in spec file. [0] https://fedorahosted.org/freeipa/ticket/5497 -- David Kupka From 6d1f5532de420efbe5c5f251681b8e7496ecb065 Mon Sep 17 00:00:00 2001 From: David Kupka

Re: [Freeipa-devel] [PATCH] 0748 Handle encoding for ipautil.run

On 14.12.2015 10:49, Petr Viktorin wrote: On 12/14/2015 10:29 AM, Jan Cholasta wrote: On 9.12.2015 12:04, Petr Viktorin wrote: On 12/04/2015 12:49 PM, Jan Cholasta wrote: On 4.12.2015 12:43, Petr Viktorin wrote: On 12/04/2015 12:15 PM, Jan Cholasta wrote: On 4.12.2015 10:53, Petr Viktorin

[Freeipa-devel] [PATCHES 531-532] server install: redirect ipa-client-install output to standard output

Hi, the attached patches fix . Honza -- Jan Cholasta From 8ee7ad0e87b1df062fbf253170bfffcb7b3bfb85 Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Mon, 14 Dec 2015 12:45:45 +0100 Subject: [PATCH 1/2] ipautil: allow

Re: [Freeipa-devel] [PATCH] 0748 Handle encoding for ipautil.run

On 9.12.2015 12:04, Petr Viktorin wrote: On 12/04/2015 12:49 PM, Jan Cholasta wrote: On 4.12.2015 12:43, Petr Viktorin wrote: On 12/04/2015 12:15 PM, Jan Cholasta wrote: On 4.12.2015 10:53, Petr Viktorin wrote: On 12/04/2015 08:51 AM, Jan Cholasta wrote: On 3.12.2015 15:42, Petr Viktorin

[Freeipa-devel] [PATCH 533] replica promotion: notify user about ignoring client enrollment options

Hi, the attached patch fixes . Honza -- Jan Cholasta From 484f68304bd4748313c50be35b1667694e07f00b Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Mon, 14 Dec 2015 13:30:33 +0100 Subject: [PATCH] replica promotion: notify

Re: [Freeipa-devel] [PATCHES 523-525] replica install: add remote connection check over API

On 14.12.2015 10:27, Martin Basti wrote: On 14.12.2015 07:23, Jan Cholasta wrote: On 11.12.2015 18:49, Tomas Babej wrote: On 12/11/2015 05:37 PM, Martin Basti wrote: On 11.12.2015 15:40, Jan Cholasta wrote: On 11.12.2015 08:03, Jan Cholasta wrote: On 11.12.2015 07:08, Jan Cholasta

Re: [Freeipa-devel] [PATCH] 0748 Handle encoding for ipautil.run

On 12/14/2015 10:29 AM, Jan Cholasta wrote: > On 9.12.2015 12:04, Petr Viktorin wrote: >> On 12/04/2015 12:49 PM, Jan Cholasta wrote: >>> On 4.12.2015 12:43, Petr Viktorin wrote: On 12/04/2015 12:15 PM, Jan Cholasta wrote: > On 4.12.2015 10:53, Petr Viktorin wrote: >> On 12/04/2015

Re: [Freeipa-devel] [PATCH 0376] KRA: add RA cert during replica promotion

On 10/12/15 19:40, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5512 patch attached. Hi, thanks for the patch. It works but only when WAIT_AFTER_ARCHIVE is raised. Patch attached. -- David Kupka From a209343652b8bedfcbca83c7eafc699e72c0a261 Mon Sep 17 00:00:00 2001 From: David

Re: [Freeipa-devel] [PATCHES 531-532] server install: redirect ipa-client-install output to standard output

On 12/14/2015 12:52 PM, Jan Cholasta wrote: > Hi, > > the attached patches fix . > > Honza > > > Shouldn't skip_output be also marked as incompatible with redirect_output? Tomas -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 0117] ipa-client-install: create a temporary directory for ccache files

On 14.12.2015 18:51, Tomas Babej wrote: On 12/14/2015 05:31 PM, Martin Babinsky wrote: fixes https://fedorahosted.org/freeipa/ticket/5528 Works as expected, code-wise looks good. Thanks for looking into this, ACK! Pushed to master: 5886f87f974fa508047a21350c2e6e75a3001da6 It would

Re: [Freeipa-devel] Testing FreeIPA 4.3 for GA

On 15.12.2015 07:24, Lukas Slebodnik wrote: On (15/12/15 01:05), Petr Vobornik wrote: Blocking patches for FreeIPA 4.3 were pushed, ipa-4-3 branch was created. Master branch is ready for 4.4 development. A build is available for testing in my pvoborni/freeipa-4-3 COPR repo [1] until the

Re: [Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

On 14/12/15 16:54, Alexander Bokovoy wrote: On Mon, 14 Dec 2015, David Kupka wrote: On 14/12/15 15:05, Alexander Bokovoy wrote: On Mon, 14 Dec 2015, David Kupka wrote: On 30/11/15 16:31, Martin Basti wrote: First instance of KRA should be installed only by ipa-kra-install Patch attached.

Re: [Freeipa-devel] [PATCH 0373] Upgrade: Fix IPA version comparison

On 14.12.2015 09:24, Martin Kosek wrote: On 12/14/2015 07:21 AM, Jan Cholasta wrote: On 11.12.2015 19:01, Tomas Babej wrote: On 12/11/2015 09:36 AM, Martin Kosek wrote: On 12/10/2015 05:09 PM, Martin Basti wrote: On 10.12.2015 15:49, Tomas Babej wrote: On 12/10/2015 11:23 AM, Martin

[Freeipa-devel] [PATCH 0088] Don't error when find_base() fails if a base is not required

We always have to call find_base() in order to force libldap to open the socket. However, if no base is actually required then there is no reason to error out if find_base() fails. This condition can arise when anonymous binds are disabled.From 7cb7a7da4271101b7ad089d90716a27dd2041c0d Mon Sep 17

Re: [Freeipa-devel] [PATCH 0058, 0064] dns: do not add (forward)zone if it is already resolvable.

On 14/12/15 15:25, David Kupka wrote: On 14/12/15 14:52, David Kupka wrote: On 11/12/15 15:00, Petr Spacek wrote: On 11.12.2015 12:35, David Kupka wrote: On 10/12/15 18:10, Petr Spacek wrote: On 10.12.2015 17:31, David Kupka wrote: On 09/12/15 18:55, Petr Spacek wrote: On 9.12.2015 13:37,

Re: [Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

On Mon, 14 Dec 2015, David Kupka wrote: On 14/12/15 15:05, Alexander Bokovoy wrote: On Mon, 14 Dec 2015, David Kupka wrote: On 30/11/15 16:31, Martin Basti wrote: First instance of KRA should be installed only by ipa-kra-install Patch attached. Hi, patch works, but I don't like the

Re: [Freeipa-devel] [PATCH 0058, 0064] dns: do not add (forward)zone if it is already resolvable.

On 14.12.2015 16:31, David Kupka wrote: > On 14/12/15 15:25, David Kupka wrote: >> On 14/12/15 14:52, David Kupka wrote: >>> On 11/12/15 15:00, Petr Spacek wrote: On 11.12.2015 12:35, David Kupka wrote: > On 10/12/15 18:10, Petr Spacek wrote: >> On 10.12.2015 17:31, David Kupka wrote:

[Freeipa-devel] certmonger everywhere

Hi, recently I and David discussed the direction of installers with regard to requesting certificates. Currently there are four (!) different ways of requesting certificates in the installer [1][2][3][4]. We would like to reduce it to one. Since all the certificates are tracked by

Re: [Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

On 14.12.2015 16:54, Alexander Bokovoy wrote: On Mon, 14 Dec 2015, David Kupka wrote: On 14/12/15 15:05, Alexander Bokovoy wrote: On Mon, 14 Dec 2015, David Kupka wrote: On 30/11/15 16:31, Martin Basti wrote: First instance of KRA should be installed only by ipa-kra-install Patch attached.

Re: [Freeipa-devel] [PATCH 0117] ipa-client-install: create a temporary directory for ccache files

On 12/15/2015 07:19 AM, Jan Cholasta wrote: On 14.12.2015 18:51, Tomas Babej wrote: On 12/14/2015 05:31 PM, Martin Babinsky wrote: fixes https://fedorahosted.org/freeipa/ticket/5528 Works as expected, code-wise looks good. Thanks for looking into this, ACK! Pushed to master:

Re: [Freeipa-devel] Testing FreeIPA 4.3 for GA

On (15/12/15 01:05), Petr Vobornik wrote: >Blocking patches for FreeIPA 4.3 were pushed, ipa-4-3 branch was created. >Master branch is ready for 4.4 development. > >A build is available for testing in my pvoborni/freeipa-4-3 COPR repo [1] >until the official 4.3 repo is created. The repo contains

Re: [Freeipa-devel] Testing FreeIPA 4.3 for GA

On (15/12/15 01:05), Petr Vobornik wrote: >Blocking patches for FreeIPA 4.3 were pushed, ipa-4-3 branch was created. >Master branch is ready for 4.4 development. > >A build is available for testing in my pvoborni/freeipa-4-3 COPR repo [1] >until the official 4.3 repo is created. The repo contains

Re: [Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

On 30/11/15 16:31, Martin Basti wrote: First instance of KRA should be installed only by ipa-kra-install Patch attached. Hi, patch works, but I don't like the approach. Do we really want to remove '--setup-kra' option from ipa-server-install? Why do we remove '--setup-kra' while keeping

Re: [Freeipa-devel] [PATCH 0018] Fixed install_ca and install_kra failures at domain level 0

Hi Martin, On 12/11/2015 05:58 PM, Martin Basti wrote: > > > On 11.12.2015 17:28, Oleg Fayans wrote: >> +myre = re.compile(".*Backed up to (?P.*?)\n.*") > > IMO this regexp is not good. > > 1) > please name it better than "myre" Done > > 2) > initial '.*' is not needed because regexp

Re: [Freeipa-devel] [PATCH] 0047 dogtaginstance: remove unused function 'check_inst'

On 12/14/2015 06:56 AM, Fraser Tweedale wrote: > Just some drive-by cleanup of an unused function. > > Cheers, > Fraser > ACK, thanks for the cleanup! Pushed to master: 38861428e76c19107a03f07530e3724aee60a270 -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 0058, 0064] dns: do not add (forward)zone if it is already resolvable.

On 11/12/15 15:00, Petr Spacek wrote: On 11.12.2015 12:35, David Kupka wrote: On 10/12/15 18:10, Petr Spacek wrote: On 10.12.2015 17:31, David Kupka wrote: On 09/12/15 18:55, Petr Spacek wrote: On 9.12.2015 13:37, David Kupka wrote: On 08/12/15 15:24, Petr Spacek wrote: On 8.12.2015 12:19,

Re: [Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

On Mon, 14 Dec 2015, David Kupka wrote: On 30/11/15 16:31, Martin Basti wrote: First instance of KRA should be installed only by ipa-kra-install Patch attached. Hi, patch works, but I don't like the approach. Do we really want to remove '--setup-kra' option from ipa-server-install? Why

Re: [Freeipa-devel] [PATCH 0058, 0064] dns: do not add (forward)zone if it is already resolvable.

On 14/12/15 14:52, David Kupka wrote: On 11/12/15 15:00, Petr Spacek wrote: On 11.12.2015 12:35, David Kupka wrote: On 10/12/15 18:10, Petr Spacek wrote: On 10.12.2015 17:31, David Kupka wrote: On 09/12/15 18:55, Petr Spacek wrote: On 9.12.2015 13:37, David Kupka wrote: On 08/12/15 15:24,

Re: [Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

On 14/12/15 15:05, Alexander Bokovoy wrote: On Mon, 14 Dec 2015, David Kupka wrote: On 30/11/15 16:31, Martin Basti wrote: First instance of KRA should be installed only by ipa-kra-install Patch attached. Hi, patch works, but I don't like the approach. Do we really want to remove

Re: [Freeipa-devel] [PATCH 534] replica promotion: let ipa-client-install validate enrollment options

On 12/14/2015 03:37 PM, Jan Cholasta wrote: > Hi, > > the attached patch fixes . > > Honza > > > ACK, Pushed to master: 110e3dfc5401899ae0a54cc979ca0820e53cfa02 -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 0116] CI tests: remove '-p' option from ipa-dns-install calls

On 12/10/2015 04:35 PM, Martin Babinsky wrote: See commit message. Works for me. ACK. -- Milan Kubik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCHES 531-532] server install: redirect ipa-client-install output to standard output

On 12/14/2015 12:57 PM, Jan Cholasta wrote: > On 14.12.2015 12:54, Tomas Babej wrote: >> >> >> On 12/14/2015 12:52 PM, Jan Cholasta wrote: >>> Hi, >>> >>> the attached patches fix . >>> >>> Honza >>> >>> >>> >> >> Shouldn't skip_output be also marked

Re: [Freeipa-devel] [PATCH 533] replica promotion: notify user about ignoring client enrollment options

On 12/14/2015 02:02 PM, Jan Cholasta wrote: > On 14.12.2015 13:41, Jan Cholasta wrote: >> Hi, >> >> the attached patch fixes . > > Self-NACK, updated patch attached. > > > ACK, works fine. -- Manage your subscription for the Freeipa-devel

Re: [Freeipa-devel] [PATCHES 529-530] ca install: use host credentials in domain level 1

On 14.12.2015 10:15, Martin Basti wrote: On 14.12.2015 07:53, Jan Cholasta wrote: On 11.12.2015 17:24, Martin Basti wrote: On 11.12.2015 15:00, Jan Cholasta wrote: On 10.12.2015 09:51, Jan Cholasta wrote: Hi, the attached patches fix .

Re: [Freeipa-devel] [PATCH 0373] Upgrade: Fix IPA version comparison

On 12/14/2015 10:21 AM, Martin Basti wrote: > > > On 14.12.2015 09:24, Martin Kosek wrote: >> On 12/14/2015 07:21 AM, Jan Cholasta wrote: >>> On 11.12.2015 19:01, Tomas Babej wrote: On 12/11/2015 09:36 AM, Martin Kosek wrote: > On 12/10/2015 05:09 PM, Martin Basti wrote: >>

Re: [Freeipa-devel] [PATCH 0116] CI tests: remove '-p' option from ipa-dns-install calls

On 14.12.2015 15:40, Milan Kubík wrote: On 12/10/2015 04:35 PM, Martin Babinsky wrote: See commit message. Works for me. ACK. Pushed to master: c4b9b295d8184694c50c0d56051e0273445c98ec -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 0378] Tests: fix always true assertion

On 12/14/2015 12:24 PM, Martin Basti wrote: > Fixes: > /usr/lib/python2.7/site-packages/ipatests/test_cmdline/test_ipagetkeytab.py:116: > SyntaxWarning: assertion is always true, perhaps remove parentheses? > > Patch attached. > > Nice catch. ACK. Pushed to master:

Re: [Freeipa-devel] [PATCHES 531-532] server install: redirect ipa-client-install output to standard output

On 14.12.2015 14:20, Tomas Babej wrote: On 12/14/2015 12:57 PM, Jan Cholasta wrote: On 14.12.2015 12:54, Tomas Babej wrote: On 12/14/2015 12:52 PM, Jan Cholasta wrote: Hi, the attached patches fix . Honza Shouldn't skip_output be also

Re: [Freeipa-devel] [PATCHES 531-532] server install: redirect ipa-client-install output to standard output

On 12/14/2015 02:41 PM, Jan Cholasta wrote: > On 14.12.2015 14:20, Tomas Babej wrote: >> >> >> On 12/14/2015 12:57 PM, Jan Cholasta wrote: >>> On 14.12.2015 12:54, Tomas Babej wrote: On 12/14/2015 12:52 PM, Jan Cholasta wrote: > Hi, > > the attached patches fix >

Re: [Freeipa-devel] [PATCH 0374-0375] Fix permissions on newly created directories

On 12/11/2015 07:19 PM, Martin Basti wrote: > > > On 10.12.2015 15:18, Martin Basti wrote: >> Hello, >> >> patch 0374 fixes the ticket, but I found more issues with directory >> permission, I fixed them in 0375 >> >> https://fedorahosted.org/freeipa/ticket/5520 >> >> Patches attached. > >

[Freeipa-devel] [PATCH 534] replica promotion: let ipa-client-install validate enrollment options

Hi, the attached patch fixes . Honza -- Jan Cholasta From 9981523cb21abba358f54ff6b801211c9e41b16c Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Mon, 14 Dec 2015 15:15:44 +0100 Subject: [PATCH] replica promotion: let

Re: [Freeipa-devel] [PATCH 533] replica promotion: notify user about ignoring client enrollment options

On 14.12.2015 13:41, Jan Cholasta wrote: Hi, the attached patch fixes . Self-NACK, updated patch attached. -- Jan Cholasta From fdbe15a0fe488177184b740ab65a57f9166799f7 Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Mon,

Re: [Freeipa-devel] [PATCH 533] replica promotion: notify user about ignoring client enrollment options

On 12/14/2015 02:19 PM, Tomas Babej wrote: > > > On 12/14/2015 02:02 PM, Jan Cholasta wrote: >> On 14.12.2015 13:41, Jan Cholasta wrote: >>> Hi, >>> >>> the attached patch fixes . >> >> Self-NACK, updated patch attached. >> >> >> > > ACK, works

[Freeipa-devel] [PATCH 0117] ipa-client-install: create a temporary directory for ccache files

fixes https://fedorahosted.org/freeipa/ticket/5528 -- Martin^3 Babinsky From 1e6dcfe235b1c9e563dd0fd3408ef93008010a89 Mon Sep 17 00:00:00 2001 From: Martin Babinsky Date: Mon, 14 Dec 2015 14:28:41 +0100 Subject: [PATCH] ipa-client-install: create a temporary directory for

Re: [Freeipa-devel] [PATCH 0376] KRA: add RA cert during replica promotion

On 14/12/15 11:00, David Kupka wrote: On 10/12/15 19:40, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5512 patch attached. Hi, thanks for the patch. It works but only when WAIT_AFTER_ARCHIVE is raised. Patch attached. IOW, your patch works for me, ACK. To let tests pass (and

Re: [Freeipa-devel] [PATCH 0070] Makefile: disable parallel build

On 12/11/2015 09:35 AM, Petr Spacek wrote: > Hello, > > Makefile: disable parallel build > > IPA build system cannot cope with parallel build anyway, so this patch > disables parallel build explicitly so it does not blow up when user > has -j specified in default MAKEOPTS. > > > ACK.

Re: [Freeipa-devel] [PATCH 0117] ipa-client-install: create a temporary directory for ccache files

On 12/14/2015 05:31 PM, Martin Babinsky wrote: > fixes https://fedorahosted.org/freeipa/ticket/5528 Works as expected, code-wise looks good. Thanks for looking into this, ACK! Pushed to master: 5886f87f974fa508047a21350c2e6e75a3001da6 -- Manage your subscription for the Freeipa-devel

Re: [Freeipa-devel] [PATCH 0373] Upgrade: Fix IPA version comparison

On 12/14/2015 07:21 AM, Jan Cholasta wrote: > On 11.12.2015 19:01, Tomas Babej wrote: >> >> >> On 12/11/2015 09:36 AM, Martin Kosek wrote: >>> On 12/10/2015 05:09 PM, Martin Basti wrote: On 10.12.2015 15:49, Tomas Babej wrote: > > On 12/10/2015 11:23 AM, Martin Basti wrote:

Re: [Freeipa-devel] [PATCH 0373] Upgrade: Fix IPA version comparison

On 14.12.2015 09:24, Martin Kosek wrote: > On 12/14/2015 07:21 AM, Jan Cholasta wrote: >> On 11.12.2015 19:01, Tomas Babej wrote: >>> >>> >>> On 12/11/2015 09:36 AM, Martin Kosek wrote: On 12/10/2015 05:09 PM, Martin Basti wrote: > > > On 10.12.2015 15:49, Tomas Babej wrote:

Re: [Freeipa-devel] [PATCH 0114] harden domain level 1 topology connectivity checks

On 12/08/2015 05:35 PM, Martin Babinsky wrote: A sort of auxilliary patch which makes topology checks more resistant to https://fedorahosted.org/freeipa/ticket/5526 If required I will open a separate ticket for it though. Bump for review. -- Martin^3 Babinsky -- Manage your subscription