[Freeipa-devel] [freeipa PR#619][synchronized] pytest 3.x compatibility

2017-03-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/619 Author: tiran Title: #619: pytest 3.x compatibility Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/619/head:pr619 git checkout pr619 From 481060359a287f0623

[Freeipa-devel] [freeipa PR#620][synchronized] [WIP] Fixing 6549

2017-03-17 Thread felipevolpone
URL: https://github.com/freeipa/freeipa/pull/620 Author: felipevolpone Title: #620: [WIP] Fixing 6549 Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/620/head:pr620 git checkout pr620 From 86510b8f703a10432

[Freeipa-devel] [freeipa PR#619][comment] pytest 3.x compatibility

2017-03-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/619 Title: #619: pytest 3.x compatibility MartinBasti commented: """ ``` * Module ipatests.util ipatests/util.py:73: [E1123(unexpected-keyword-arg), check_ipaclient_unittests] Unexpected keyword argument 'allow_module_level' in constructo

[Freeipa-devel] [freeipa PR#620][opened] [WIP] Fixing 6549

2017-03-17 Thread felipevolpone
URL: https://github.com/freeipa/freeipa/pull/620 Author: felipevolpone Title: #620: [WIP] Fixing 6549 Action: opened PR body: """ In order to fix https://pagure.io/freeipa/issue/6549. First of all, I tried at `ipaserver/server/install/replicainstall.py:1393`: ```python try: domain_level

[Freeipa-devel] [freeipa PR#618][synchronized] [WIP] Tox testing support for client wheel packages

2017-03-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/618 Author: tiran Title: #618: [WIP] Tox testing support for client wheel packages Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/618/head:pr618 git checkout pr

[Freeipa-devel] [freeipa PR#618][synchronized] [WIP] Tox testing support for client wheel packages

2017-03-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/618 Author: tiran Title: #618: [WIP] Tox testing support for client wheel packages Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/618/head:pr618 git checkout pr

[Freeipa-devel] [freeipa PR#619][opened] pytest 3.x compatibility

2017-03-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/619 Author: tiran Title: #619: pytest 3.x compatibility Action: opened PR body: """ pytest 3.x does no longer support plain pytest.skip() on module level. Signed-off-by: Christian Heimes """ To pull the PR as Git branch: git remote add ghfreeipa

[Freeipa-devel] [freeipa PR#618][opened] [WIP] Tox testing support for client wheel packages

2017-03-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/618 Author: tiran Title: #618: [WIP] Tox testing support for client wheel packages Action: opened PR body: """ Depends on PR #613 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull

Re: [Freeipa-devel] [TESTING] Please test and add karma to pki-core-10.4.0-1

2017-03-17 Thread Matthew Harmsen
On 03/17/2017 10:02 AM, Lukas Slebodnik wrote: On (17/03/17 12:14), Martin Babinsky wrote: A new update for Dogtag PKI (pki-core-10.4.0-1.fc25) landed it Fedora 25 updates-testing yesterday.[1] It was also pushed to fedora26 https://bodhi.fedoraproject.org/updates/FEDORA-2017-9cc27242c1 I ha

[Freeipa-devel] [freeipa PR#613][synchronized] Constrain wheel package versions

2017-03-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/613 Author: tiran Title: #613: Constrain wheel package versions Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/613/head:pr613 git checkout pr613 From 8d976a4c9f

Re: [Freeipa-devel] [TESTING] Please test and add karma to pki-core-10.4.0-1

2017-03-17 Thread Lukas Slebodnik
On (17/03/17 12:14), Martin Babinsky wrote: >A new update for Dogtag PKI (pki-core-10.4.0-1.fc25) landed it Fedora 25 >updates-testing yesterday.[1] > It was also pushed to fedora26 https://bodhi.fedoraproject.org/updates/FEDORA-2017-9cc27242c1 >I have already provided negative karma as the update

[Freeipa-devel] [freeipa PR#593][comment] Add make patchcheck for developers

2017-03-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/593 Title: #593: Add make patchcheck for developers tiran commented: """ All dependencies have been merged. PR is ready for review. """ See the full comment at https://github.com/freeipa/freeipa/pull/593#issuecomment-287372325 -- Manage your subsc

[Freeipa-devel] [freeipa PR#593][synchronized] Add make patchcheck for developers

2017-03-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/593 Author: tiran Title: #593: Add make patchcheck for developers Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/593/head:pr593 git checkout pr593 From 3c67b43

[Freeipa-devel] [freeipa PR#470][synchronized] WebUI: Size limit warning on details pages fixed

2017-03-17 Thread pvomacka
URL: https://github.com/freeipa/freeipa/pull/470 Author: pvomacka Title: #470: WebUI: Size limit warning on details pages fixed Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/470/head:pr470 git checkout pr

[Freeipa-devel] [freeipa PR#475][+pushed] Add options to run only ipaclient unittests

2017-03-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/475 Title: #475: Add options to run only ipaclient unittests Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contr

[Freeipa-devel] [freeipa PR#475][comment] Add options to run only ipaclient unittests

2017-03-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/475 Title: #475: Add options to run only ipaclient unittests martbab commented: """ master: * fd1b4f6ec9a349196d5df510008c4745f0b1fb84 Add options to run only ipaclient unittests ipa-4-5: * 29b885a8fac82e963f5ab98d178e81854056930e Add options to ru

[Freeipa-devel] [freeipa PR#475][closed] Add options to run only ipaclient unittests

2017-03-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/475 Author: tiran Title: #475: Add options to run only ipaclient unittests Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/475/head:pr475 git checkout pr475 -- Manage

[Freeipa-devel] [freeipa PR#617][comment] Allow renaming of sudo rules

2017-03-17 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/617 Title: #617: Allow renaming of sudo rules abbra commented: """ I don't like it is done on the client side. This will not work for Web UI, for example. Additionally, no validation of cn={newname} is here to be a single value RDN. If we add this a

[Freeipa-devel] [freeipa PR#475][+ack] Add options to run only ipaclient unittests

2017-03-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/475 Title: #475: Add options to run only ipaclient unittests Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribu

[Freeipa-devel] [freeipa PR#617][opened] Allow renaming of sudo rules

2017-03-17 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/617 Author: stlaz Title: #617: Allow renaming of sudo rules Action: opened PR body: """ This simple hack adds a rename option to client side sudorule-mod command. https://pagure.io/freeipa/issue/2466 """ To pull the PR as Git branch: git remote ad

[Freeipa-devel] [freeipa PR#616][synchronized] Simplify KRA transport cert cache

2017-03-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/616 Author: tiran Title: #616: Simplify KRA transport cert cache Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/616/head:pr616 git checkout pr616 From 3aa2cf9ea

[Freeipa-devel] [freeipa PR#608][comment] tasks: run `systemctl daemon-reload` after httpd.service.d updates

2017-03-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/608 Title: #608: tasks: run `systemctl daemon-reload` after httpd.service.d updates martbab commented: """ Hmmm I just caught a following error during FreeIPA replica uninstall: ```console[root@replica1 ~]# ipa-server-install --uninstall -U Updating

[Freeipa-devel] [freeipa PR#608][-ack] tasks: run `systemctl daemon-reload` after httpd.service.d updates

2017-03-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/608 Title: #608: tasks: run `systemctl daemon-reload` after httpd.service.d updates Label: -ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.fr

[Freeipa-devel] [TESTING] Please test and add karma to pki-core-10.4.0-1

2017-03-17 Thread Martin Babinsky
A new update for Dogtag PKI (pki-core-10.4.0-1.fc25) landed it Fedora 25 updates-testing yesterday.[1] I have already provided negative karma as the update broke CA clone deployment on FreeIPA replica install. It would be nice if you could test it and provide +1/-1 ASAP so that we can push it out

[Freeipa-devel] [freeipa PR#616][synchronized] Simplify KRA transport cert cache

2017-03-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/616 Author: tiran Title: #616: Simplify KRA transport cert cache Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/616/head:pr616 git checkout pr616 From 44d2c8334

[Freeipa-devel] [freeipa PR#616][comment] Simplify KRA transport cert cache

2017-03-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/616 Title: #616: Simplify KRA transport cert cache tiran commented: """ @HonzaCholasta I don't agree with you. Mutable mapping is too complex for a simple cache. My approach is KISS. """ See the full comment at https://github.com/freeipa/freeipa/pu

[Freeipa-devel] [freeipa PR#517][comment] [WIP] Use Custodia 0.3 features

2017-03-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/517 Title: #517: [WIP] Use Custodia 0.3 features tiran commented: """ I had some issues with build system yesterday. For some reason ```python2-python-etcd``` dependency was missing dependency on ```etcd```. I'm glad time heals all wounds (or some d

[Freeipa-devel] [freeipa PR#616][comment] Simplify KRA transport cert cache

2017-03-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/616 Title: #616: Simplify KRA transport cert cache MartinBasti commented: """ Please open backport ticket and put it into commit messsage """ See the full comment at https://github.com/freeipa/freeipa/pull/616#issuecomment-287312239 -- Manage your

[Freeipa-devel] [freeipa PR#616][comment] Simplify KRA transport cert cache

2017-03-17 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/616 Title: #616: Simplify KRA transport cert cache HonzaCholasta commented: """ NACK on the completely unnecessary changes in `_TransportCertCache` interface, variable names and formatting. Otherwise LGTM. """ See the full comment at https://github

[Freeipa-devel] [freeipa PR#616][comment] Simplify KRA transport cert cache

2017-03-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/616 Title: #616: Simplify KRA transport cert cache MartinBasti commented: """ Please open backport ticket and put it into commit messsage """ See the full comment at https://github.com/freeipa/freeipa/pull/616#issuecomment-287312239 -- Manage your

[Freeipa-devel] [freeipa PR#614][edited] [4.5] Constrain wheel package versions

2017-03-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/614 Author: tiran Title: #614: [4.5] Constrain wheel package versions Action: edited Changed field: title Original value: """ Constrain wheel package versions """ -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.

[Freeipa-devel] [freeipa PR#616][comment] Simplify KRA transport cert cache

2017-03-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/616 Title: #616: Simplify KRA transport cert cache tiran commented: """ Needs to be merged into ipa-4.5 branch, too. """ See the full comment at https://github.com/freeipa/freeipa/pull/616#issuecomment-287311164 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#616][opened] Simplify KRA transport cert cache

2017-03-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/616 Author: tiran Title: #616: Simplify KRA transport cert cache Action: opened PR body: """ In-memory cache causes problem in forking servers. A file based cache is good enough. It's easier to understand and avoids performance regression and synchr

[Freeipa-devel] [freeipa PR#614][opened] Constrain wheel package versions

2017-03-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/614 Author: tiran Title: #614: Constrain wheel package versions Action: opened PR body: """ The presence of IPA packages on PyPI revealed an interesting issue with make wheel_bundle. pip gives final releases a higher precedence than our development

[Freeipa-devel] [freeipa PR#608][+ack] tasks: run `systemctl daemon-reload` after httpd.service.d updates

2017-03-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/608 Title: #608: tasks: run `systemctl daemon-reload` after httpd.service.d updates Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.fr

[Freeipa-devel] [freeipa PR#615][opened] httpinstance: clean up /etc/httpd/alias on uninstall

2017-03-17 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/615 Author: HonzaCholasta Title: #615: httpinstance: clean up /etc/httpd/alias on uninstall Action: opened PR body: """ **certs: do not implicitly create DS pin.txt** Do not implicitly create DS pin.txt in `CertDB.init_from_pkcs12()`, create it exp

[Freeipa-devel] [freeipa PR#613][opened] Constrain wheel package versions

2017-03-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/613 Author: tiran Title: #613: Constrain wheel package versions Action: opened PR body: """ The presence of IPA packages on PyPI revealed an interesting issue with make wheel_bundle. pip gives final releases a higher precedence than our development

[Freeipa-devel] [freeipa PR#606][comment] [ipa-4-4] ipa-kdb: support KDB DAL version 6.1

2017-03-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/606 Title: #606: [ipa-4-4] ipa-kdb: support KDB DAL version 6.1 tomaskrizek commented: """ Created the ticket and linked it in the commit message. """ See the full comment at https://github.com/freeipa/freeipa/pull/606#issuecomment-287302249 -- Man

[Freeipa-devel] [freeipa PR#606][synchronized] [ipa-4-4] ipa-kdb: support KDB DAL version 6.1

2017-03-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/606 Author: tomaskrizek Title: #606: [ipa-4-4] ipa-kdb: support KDB DAL version 6.1 Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/606/head:pr606 git checkout p

[Freeipa-devel] [freeipa PR#517][comment] [WIP] Use Custodia 0.3 features

2017-03-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/517 Title: #517: [WIP] Use Custodia 0.3 features martbab commented: """ @MartinBasti ok there should be no problems with that (built it on F25 VM but threw it away afterwards, oh well) """ See the full comment at https://github.com/freeipa/freeipa/

[Freeipa-devel] [freeipa PR#517][comment] [WIP] Use Custodia 0.3 features

2017-03-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/517 Title: #517: [WIP] Use Custodia 0.3 features MartinBasti commented: """ @martbab I will test it manually (when I receive f25/F26 rpms), if works then I will update master copr """ See the full comment at https://github.com/freeipa/freeipa/pull/

[Freeipa-devel] [freeipa PR#612][opened] [4.5] Add debug log in case cookie retrieval went wrong

2017-03-17 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/612 Author: stlaz Title: #612: [4.5] Add debug log in case cookie retrieval went wrong Action: opened PR body: """ https://pagure.io/freeipa/issue/6774 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa gi

[Freeipa-devel] [freeipa PR#609][synchronized] [4.4] Fix cookie with Max-Age processing

2017-03-17 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/609 Author: stlaz Title: #609: [4.4] Fix cookie with Max-Age processing Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/609/head:pr609 git checkout pr609 From 17

[Freeipa-devel] [freeipa PR#610][comment] [4.3] Fix cookie with Max-Age processing

2017-03-17 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/610 Title: #610: [4.3] Fix cookie with Max-Age processing stlaz commented: """ The ticket's already there, I just recycled the old commit message and forgot to replace it. """ See the full comment at https://github.com/freeipa/freeipa/pull/610#issu

[Freeipa-devel] [freeipa PR#610][synchronized] [4.3] Fix cookie with Max-Age processing

2017-03-17 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/610 Author: stlaz Title: #610: [4.3] Fix cookie with Max-Age processing Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/610/head:pr610 git checkout pr610 From e7

[Freeipa-devel] [freeipa PR#611][opened] Add debug log in case cookie retrieval went wrong

2017-03-17 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/611 Author: stlaz Title: #611: Add debug log in case cookie retrieval went wrong Action: opened PR body: """ When backporting the fix, @MartinBasti pointed out we could use a debug log. https://pagure.io/freeipa/issue/6774 """ To pull the PR as Gi

[Freeipa-devel] [freeipa PR#475][comment] Add options to run only ipaclient unittests

2017-03-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/475 Title: #475: Add options to run only ipaclient unittests martbab commented: """ I have one small question and am going to try out some integration tests to see if we did not break something in them as Travis won't catch that. """ See the full c

[Freeipa-devel] [freeipa PR#606][comment] [ipa-4-4] ipa-kdb: support KDB DAL version 6.1

2017-03-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/606 Title: #606: [ipa-4-4] ipa-kdb: support KDB DAL version 6.1 martbab commented: """ Since the original ticket is in already closed milestone open a separate one for backport to 4-4 branch please. """ See the full comment at https://github.com/fr

[Freeipa-devel] [freeipa PR#517][comment] [WIP] Use Custodia 0.3 features

2017-03-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/517 Title: #517: [WIP] Use Custodia 0.3 features martbab commented: """ @tiran we first need a copr build on F25 to unblock Travis CI. Can you provide a copr repo and modify test runner config to add it during builddep phase? """ See the full commen