[Freeipa-devel] [freeipa PR#361][-ack] This PR implements a number of improvements for our Travis CI:

2017-01-05 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/361 Title: #361: This PR implements a number of improvements for our Travis CI: Label: -ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#361][comment] This PR implements a number of improvements for our Travis CI:

2017-01-05 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/361 Title: #361: This PR implements a number of improvements for our Travis CI: stlaz commented: """ The change LGTM, ACK, we'll see how it works :) """ See the full comment at https://github.com/freeipa/freeipa/p

[Freeipa-devel] [freeipa PR#361][+ack] This PR implements a number of improvements for our Travis CI:

2017-01-05 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/361 Title: #361: This PR implements a number of improvements for our Travis CI: Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#370][comment] [EXPERIMENT] ci: send build log to paste.fedoraproject.org

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/370 Title: #370: [EXPERIMENT] ci: send build log to paste.fedoraproject.org stlaz commented: """ Um, sorry, but I fail to see the real upside here, perhaps I am missing something. If I see here on github that a build of my PR faile

[Freeipa-devel] [freeipa PR#367][comment] Remove nsslib from IPA

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Title: #367: Remove nsslib from IPA stlaz commented: """ @rcritten I spoke to the NSS people who assured me it's the intended behavior. But thanks for the remainder, I will open a Bugzilla for that as well, I was considering it b

[Freeipa-devel] [freeipa PR#370][comment] [EXPERIMENT] ci: send build log to paste.fedoraproject.org

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/370 Title: #370: [EXPERIMENT] ci: send build log to paste.fedoraproject.org stlaz commented: """ Um, sorry, but I fail to see the real upside here, perhaps I am missing something. If I see here on github that a build of my PR faile

[Freeipa-devel] [freeipa PR#367][comment] Remove nsslib from IPA

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Title: #367: Remove nsslib from IPA stlaz commented: """ @rcritten I spoke to the NSS people who assured me it's the intended behavior. But thanks for the remainder, I will open a Bugzilla for that as well, I was considering it b

[Freeipa-devel] [freeipa PR#352][comment] Clarify meaning of --domain and --realm in installers

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/352 Title: #352: Clarify meaning of --domain and --realm in installers stlaz commented: """ The fixes to raised issues are fixed in https://github.com/freeipa/freeipa/issues/362 """ See the full comment at https://g

[Freeipa-devel] [freeipa PR#352][+rejected] Clarify meaning of --domain and --realm in installers

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/352 Title: #352: Clarify meaning of --domain and --realm in installers Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#352][closed] Clarify meaning of --domain and --realm in installers

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/352 Author: pspacek Title: #352: Clarify meaning of --domain and --realm in installers Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/352/head:pr352 git checkout

[Freeipa-devel] [freeipa PR#361][comment] This PR implements a number of improvements for our Travis CI:

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/361 Title: #361: This PR implements a number of improvements for our Travis CI: stlaz commented: """ @martbab My naive solution is to do something like ```bash LINE=`grep -n -m 1 $CI_TRAVIS_LOG -e "=== FAILURES ===" |

[Freeipa-devel] [freeipa PR#367][comment] Remove nsslib from IPA

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Title: #367: Remove nsslib from IPA stlaz commented: """ You're right, I should probably write some design. The current implementation does not check CRL or OSCP, so we're "fine" with this change. There is a

[Freeipa-devel] [freeipa PR#367][synchronized] Remove nsslib from IPA

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Author: stlaz Title: #367: Remove nsslib from IPA Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/367/head:pr367 git checkout pr367 From

[Freeipa-devel] [freeipa PR#361][comment] This PR implements a number of improvements for our Travis CI:

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/361 Title: #361: This PR implements a number of improvements for our Travis CI: stlaz commented: """ I assume the licence headers did not break the automember tests so this could be pushed. Just a brief question: would it be re

[Freeipa-devel] [freeipa PR#359][comment] dogtag: search past the first 100 certificates

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/359 Title: #359: dogtag: search past the first 100 certificates stlaz commented: """ @frasertweedale if `_ldap_search` is performed with correct filters, `sizelimit=0` is not the correct solution at least for CLI which should

[Freeipa-devel] [freeipa PR#367][edited] Remove nsslib from IPA

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Author: stlaz Title: #367: Remove nsslib from IPA Action: edited Changed field: body Original value: """ This batch of patches removes NSSConnection along with the whole ipapython.nsslib from IPA and replaces it wit

[Freeipa-devel] [freeipa PR#367][opened] Remove nsslib from IPA

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Author: stlaz Title: #367: Remove nsslib from IPA Action: opened PR body: """ This batch of patches removes NSSConnection along with the whole ipapython.nsslib from IPA and replaces it with more standard httplib.

[Freeipa-devel] [freeipa PR#362][+ack] Clarify meaning of --domain and --realm in installers

2017-01-03 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/362 Title: #362: Clarify meaning of --domain and --realm in installers Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#362][synchronized] Clarify meaning of --domain and --realm in installers

2017-01-02 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/362 Author: stlaz Title: #362: Clarify meaning of --domain and --realm in installers Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/362/head:pr362 git checkout

[Freeipa-devel] [freeipa PR#362][opened] Clarify meaning of --domain and --realm in installers

2017-01-02 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/362 Author: stlaz Title: #362: Clarify meaning of --domain and --realm in installers Action: opened PR body: """ This is my take on original https://github.com/freeipa/freeipa/pull/352. I hope I fixed all the mentioned issues

[Freeipa-devel] [freeipa PR#350][+ack] spec file: revert to the previous Release tag

2017-01-02 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/350 Title: #350: spec file: revert to the previous Release tag Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#350][comment] spec file: revert to the previous Release tag

2017-01-02 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/350 Title: #350: spec file: revert to the previous Release tag stlaz commented: """ I also appreciate the dist information, ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/350#issuecom

[Freeipa-devel] [freeipa PR#298][+rejected] ipaldap: handle binary encoding option transparently

2017-01-02 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/298 Title: #298: ipaldap: handle binary encoding option transparently Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#317][synchronized] Unify password generation across FreeIPA

2016-12-21 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Author: stlaz Title: #317: Unify password generation across FreeIPA Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/317/head:pr317 git checkout pr317 From

[Freeipa-devel] [freeipa PR#317][synchronized] Unify password generation across FreeIPA

2016-12-21 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Author: stlaz Title: #317: Unify password generation across FreeIPA Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/317/head:pr317 git checkout pr317 From

[Freeipa-devel] [freeipa PR#317][synchronized] Unify password generation across FreeIPA

2016-12-21 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Author: stlaz Title: #317: Unify password generation across FreeIPA Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/317/head:pr317 git checkout pr317 From

[Freeipa-devel] [freeipa PR#356][+ack] server install: fix KRA agent PEM file not being created

2016-12-20 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/356 Title: #356: server install: fix KRA agent PEM file not being created Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#356][comment] server install: fix KRA agent PEM file not being created

2016-12-20 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/356 Title: #356: server install: fix KRA agent PEM file not being created stlaz commented: """ Works as expected. """ See the full comment at https://github.com/freeipa/freeipa/pull/356#issuecomment-26827111

[Freeipa-devel] [freeipa PR#279][+ack] installer: Stop adding distro-specific NTP servers into ntp.conf

2016-12-19 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/279 Title: #279: installer: Stop adding distro-specific NTP servers into ntp.conf Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#210][comment] Tests: Stage User Tracker implementation

2016-12-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/210 Title: #210: Tests: Stage User Tracker implementation stlaz commented: """ I just wanted to remove the ACK till @martbab's comment is worked in so nobody pushes it but I found some minor issues that I would like to see fixed

[Freeipa-devel] [freeipa PR#210][-ack] Tests: Stage User Tracker implementation

2016-12-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/210 Title: #210: Tests: Stage User Tracker implementation Label: -ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#117][comment] Make ipa-replica-install run in interactive mode

2016-12-15 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/117 Title: #117: Make ipa-replica-install run in interactive mode stlaz commented: """ Rebase done. I wanted to wait until some more changes to api bootstrapping to be able to call client installation from module using the latest in

[Freeipa-devel] [freeipa PR#117][synchronized] Make ipa-replica-install run in interactive mode

2016-12-15 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/117 Author: stlaz Title: #117: Make ipa-replica-install run in interactive mode Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/117/head:pr117 git checkout

[Freeipa-devel] [freeipa PR#301][comment] scripts, tests: explicitly set confdir in the rest of server code

2016-12-13 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/301 Title: #301: scripts, tests: explicitly set confdir in the rest of server code stlaz commented: """ @tiran I find all the changes actually required. I think ACK is in order unless you spell out those which you think are not nece

[Freeipa-devel] [freeipa PR#323][+ack] ipactl: pass api as argument to services

2016-12-12 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/323 Title: #323: ipactl: pass api as argument to services Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#323][comment] ipactl: pass api as argument to services

2016-12-12 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/323 Title: #323: ipactl: pass api as argument to services stlaz commented: """ Works as expected. ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/323#issuecomment-266427247 -- Manage your subs

[Freeipa-devel] [freeipa PR#323][comment] ipactl: pass api as argument to services

2016-12-12 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/323 Title: #323: ipactl: pass api as argument to services stlaz commented: """ Do we need a ticket for this? I notice the original commit did not have it either. """ See the full comment at https://github.com/freeipa

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-11 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA stlaz commented: """ Correct me if I'm wrong here but I believe we're going for the scenario where the attacker has to guess the `xxx` bits of entropy and they know that t

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-11 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA stlaz commented: """ Correct me if I'm wrong here but I believe we're going for the scenario where the attacker has to guess the `xxx` bits of entropy and they know that t

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-11 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA stlaz commented: """ Correct me if I'm wrong here but I believe we're going for the scenario where the attacker has to guess the `xxx` bits of entropy and they know that t

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-08 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA stlaz commented: """ @simo5 I was actually trying to get rid of SHA-1 and I am aware that entropy will not be raised, that part of the code draw a smile on some of our face

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-08 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA stlaz commented: """ Apparently, spaces are ok even in HTTP password.conf so I guess we can leave it there. """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-08 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA stlaz commented: """ NSS does support spaces in its passwords it seems. My hopes are that HTTP will be able to understand spaces in its password.conf file. """

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-08 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA stlaz commented: """ The passwords should have around the same entropy now. SHA-1 actually produces 160bit outputs (hence 40-characters long hexadecimal digests), so I recou

[Freeipa-devel] [freeipa PR#317][synchronized] Unify password generation across FreeIPA

2016-12-08 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Author: stlaz Title: #317: Unify password generation across FreeIPA Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/317/head:pr317 git checkout pr317 From

[Freeipa-devel] [freeipa PR#317][opened] Unify password generation across FreeIPA

2016-12-07 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Author: stlaz Title: #317: Unify password generation across FreeIPA Action: opened PR body: """ When installing FreeIPA in FIPS mode I noticed that there were often different ways of generating passwords in different spots r

[Freeipa-devel] [freeipa PR#316][opened] Fix error in permission-find post_callback search

2016-12-07 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/316 Author: stlaz Title: #316: Fix error in permission-find post_callback search Action: opened PR body: """ This pull requests fixes a bug introduced when fixing a different issue in https://github.com/freeipa

[Freeipa-devel] [freeipa PR#293][+ack] Run out-of-tree tests in Travis CI

2016-12-07 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/293 Title: #293: Run out-of-tree tests in Travis CI Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#293][comment] Run out-of-tree tests in Travis CI

2016-12-07 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/293 Title: #293: Run out-of-tree tests in Travis CI stlaz commented: """ Good. I see the tests pass now and both @tiran's nitpicks and @mbasti-rh's comment have been resolved, so an ACK is in order. """ See the full

[Freeipa-devel] [freeipa PR#293][comment] Run out-of-tree tests in Travis CI

2016-12-05 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/293 Title: #293: Run out-of-tree tests in Travis CI stlaz commented: """ Since I recently run into issues with ipa-server-install and low entropy somewhere around creation of kdb proxy which drastically increased install time, woul

[Freeipa-devel] [freeipa PR#276][+ack] replica-conncheck: improve error msg + logging

2016-12-05 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/276 Title: #276: replica-conncheck: improve error msg + logging Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#276][comment] replica-conncheck: improve error msg + logging

2016-12-05 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/276 Title: #276: replica-conncheck: improve error msg + logging stlaz commented: """ Seems to work fine, ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/276#issuecomment-26479382

[Freeipa-devel] [freeipa PR#276][comment] replica-conncheck: improve error msg + logging

2016-12-02 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/276 Title: #276: replica-conncheck: improve error msg + logging stlaz commented: """ Needs rebase. """ See the full comment at https://github.com/freeipa/freeipa/pull/276#issuecomment-264432666 -- Manage your subs

[Freeipa-devel] [freeipa PR#278][+ack] Restore the original functionality of `env` and `plugins` commands

2016-12-02 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/278 Title: #278: Restore the original functionality of `env` and `plugins` commands Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#278][comment] Restore the original functionality of `env` and `plugins` commands

2016-12-02 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/278 Title: #278: Restore the original functionality of `env` and `plugins` commands stlaz commented: """ `env` works as expected, `plugins` seems to fail as expected. ACK. """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#295][comment] Issue6474 fixups

2016-12-01 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/295 Title: #295: Issue6474 fixups stlaz commented: """ Good :) The tests seem to pass, the changes are trivial, ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/295#issuecomment-26420726

[Freeipa-devel] [freeipa PR#295][+ack] Issue6474 fixups

2016-12-01 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/295 Title: #295: Issue6474 fixups Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#295][comment] Issue6474 fixups

2016-12-01 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/295 Title: #295: Issue6474 fixups stlaz commented: """ There are some more ipaplatform imports left, some in test_xmlrpc, test_webui, test_install and test_cmdline (of which I think may interest you). Is it ok these are left

[Freeipa-devel] [freeipa PR#271][comment] Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient

2016-11-30 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/271 Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient stlaz commented: """ The patch's already been pushed, could you, @mbasti-rh, supply the automated message? """ See the full

[Freeipa-devel] [freeipa PR#271][+pushed] Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient

2016-11-30 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/271 Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#271][comment] Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient

2016-11-29 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/271 Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient stlaz commented: """ Last I checked the ticket was still open. The ticket was trying to solve the same issue as this PR although its a

[Freeipa-devel] [freeipa PR#282][opened] replicainstall: give correct error message on DL mismatch

2016-11-29 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/282 Author: stlaz Title: #282: replicainstall: give correct error message on DL mismatch Action: opened PR body: """ https://fedorahosted.org/freeipa/ticket/6510 """ To pull the PR as Git branch: git remote add ghfree

[Freeipa-devel] [freeipa PR#271][+ack] Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient

2016-11-29 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/271 Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#271][comment] Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient

2016-11-29 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/271 Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient stlaz commented: """ I checked the rebase again as well as ran the tests. The changes in the PR clean the code nicely aside from doing

[Freeipa-devel] [freeipa PR#266][comment] ipapython: simplify Env object initialization

2016-11-29 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/266 Title: #266: ipapython: simplify Env object initialization stlaz commented: """ This PR breaks almost all tests in test_ipalib/test_crud.py with `AttributeError: 'API' object has no attribute 'env'`. This error can be observe

[Freeipa-devel] [freeipa PR#266][comment] ipapython: simplify Env object initialization

2016-11-29 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/266 Title: #266: ipapython: simplify Env object initialization stlaz commented: """ From offline discussion I got that the PR should actually work in the end. I'll make the review. """ See the full comment at http

[Freeipa-devel] [freeipa PR#101][comment] Improved vault-show error message

2016-11-28 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/101 Title: #101: Improved vault-show error message stlaz commented: """ WONTFIX then. There's no winning here. """ See the full comment at https://github.com/freeipa/freeipa/pull/101#issuecomment-26326507

[Freeipa-devel] [freeipa PR#101][synchronized] Improved vault-show error message

2016-11-28 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/101 Author: stlaz Title: #101: Improved vault-show error message Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/101/head:pr101 git checkout pr101 From

[Freeipa-devel] [freeipa PR#101][synchronized] Improved vault-show error message

2016-11-25 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/101 Author: stlaz Title: #101: Improved vault-show error message Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/101/head:pr101 git checkout pr101 From

[Freeipa-devel] [freeipa PR#101][comment] Improved vault-show error message

2016-11-25 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/101 Title: #101: Improved vault-show error message stlaz commented: """ Seems like nobody objected so far. """ See the full comment at https://github.com/freeipa/freeipa/pull/101#issuecomment-262971504 -- Manage you

[Freeipa-devel] [freeipa PR#252][comment] Use namespace-aware meta importer for ipaplatform

2016-11-25 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/252 Title: #252: Use namespace-aware meta importer for ipaplatform stlaz commented: """ It is not AFAIK. I noted that in https://fedorahosted.org/freeipa/ticket/6474 comment and there's also discussion about this in https://git

[Freeipa-devel] [freeipa PR#271][comment] Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient

2016-11-25 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/271 Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient stlaz commented: """ @jcholast Thanks, I'll add it as a comment to that ticket so that it's more visible to a potential community :) @tira

[Freeipa-devel] [freeipa PR#271][comment] Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient

2016-11-25 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/271 Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient stlaz commented: """ @jcholast Thanks, I'll add it as a comment to that ticket so that it's more visible to a potential community :) + LGTM @

[Freeipa-devel] [freeipa PR#231][synchronized] Do not log DM password in ca/kra installation logs

2016-11-22 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/231 Author: stlaz Title: #231: Do not log DM password in ca/kra installation logs Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/231/head:pr231 git checkout

[Freeipa-devel] [freeipa PR#231][comment] Do not log DM password in ca/kra installation logs

2016-11-22 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/231 Title: #231: Do not log DM password in ca/kra installation logs stlaz commented: """ @martbab Oh, I thought you wanted me to re-add `dm_password` to DogtagInstance as @tomaskrizek which does not seem right as DogtagInstance is

[Freeipa-devel] [freeipa PR#212][+ack] KRA: don't add KRA container when KRA replica

2016-11-21 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/212 Title: #212: KRA: don't add KRA container when KRA replica Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#212][comment] KRA: don't add KRA container when KRA replica

2016-11-21 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/212 Title: #212: KRA: don't add KRA container when KRA replica stlaz commented: """ ACK, works on both DLs. """ See the full comment at https://github.com/freeipa/freeipa/pull/212#issuecomment-261890178 -- Manage you

[Freeipa-devel] [freeipa PR#231][comment] Do not log DM password in ca/kra installation logs

2016-11-18 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/231 Title: #231: Do not log DM password in ca/kra installation logs stlaz commented: """ I must have misclicked "close" when viewing this PR on my phone. I believe we may rather add admin and DM passwords to the nolo

[Freeipa-devel] [freeipa PR#231][reopened] Do not log DM password in ca/kra installation logs

2016-11-18 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/231 Author: stlaz Title: #231: Do not log DM password in ca/kra installation logs Action: reopened To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/231/head:pr231 git checkout pr231

[Freeipa-devel] [freeipa PR#231][closed] Do not log DM password in ca/kra installation logs

2016-11-14 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/231 Author: stlaz Title: #231: Do not log DM password in ca/kra installation logs Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/231/head:pr231 git checkout pr231

[Freeipa-devel] [freeipa PR#235][comment] Remove unused Knob function

2016-11-13 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/235 Title: #235: Remove unused Knob function stlaz commented: """ From our offline discussion I got the impression the Knob function was still used somewhere, therefore the ACK. I'm not sure what was the reason of keeping Knob there

[Freeipa-devel] [freeipa PR#235][+ack] Make Knob function deprecated

2016-11-11 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/235 Title: #235: Make Knob function deprecated Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#235][comment] Make Knob function deprecated

2016-11-11 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/235 Title: #235: Make Knob function deprecated stlaz commented: """ ACK, there should be note about this deprecation somewhere. Deleting Knob might be worth a ticket as well. """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#212][comment] KRA: don't add KRA container when KRA replica

2016-11-11 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/212 Title: #212: KRA: don't add KRA container when KRA replica stlaz commented: """ configure_instance and configure_replica codes were merged, you'll need to check for self.clone value instead. """ See the full

[Freeipa-devel] [freeipa PR#231][opened] Do not log DM password in ca/kra installation logs

2016-11-10 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/231 Author: stlaz Title: #231: Do not log DM password in ca/kra installation logs Action: opened PR body: """ We can merge this after refactoring merges not to mess the rebases. https://fedorahosted.org/freeipa/ticket/6461 &quo

[Freeipa-devel] [freeipa PR#201][+ack] spec file: bump minimal required version of 389-ds-base

2016-11-01 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/201 Title: #201: spec file: bump minimal required version of 389-ds-base Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#201][comment] spec file: bump minimal required version of 389-ds-base

2016-11-01 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/201 Title: #201: spec file: bump minimal required version of 389-ds-base stlaz commented: """ ACK """ See the full comment at https://github.com/freeipa/freeipa/pull/201#issuecomment-257535867 -- Manage your subs

[Freeipa-devel] [freeipa PR#199][opened] [ipa-4-4] Fix missing file that fails DL1 replica installation

2016-11-01 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/199 Author: stlaz Title: #199: [ipa-4-4] Fix missing file that fails DL1 replica installation Action: opened PR body: """ Replica installation on DL1 would fail to create a httpd instance due to missing '/etc/httpd/alias/cace

[Freeipa-devel] [freeipa PR#198][synchronized] Fix missing file that fails DL1 replica installation

2016-10-31 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/198 Author: stlaz Title: #198: Fix missing file that fails DL1 replica installation Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/198/head:pr198 git checkout

[Freeipa-devel] [freeipa PR#198][edited] Fix missing file that fails DL1 replica installation

2016-10-31 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/198 Author: stlaz Title: #198: Fix missing file that fails DL1 replica installation Action: edited Changed field: body Original value: """ Replica installation on DL1 would fail to create a httpd instance due to missing '/

[Freeipa-devel] [freeipa PR#198][opened] Fix missing file that fails DL1 replica installation

2016-10-31 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/198 Author: stlaz Title: #198: Fix missing file that fails DL1 replica installation Action: opened PR body: """ Replica installation on DL1 would fail to create a httpd instance due to missing '/etc/httpd/alias/cacert.asc'. C

[Freeipa-devel] [freeipa PR#188][comment] Move Python build artefacts to top level directory

2016-10-27 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/188 Title: #188: Move Python build artefacts to top level directory stlaz commented: """ +1 with @pspacek, build artefacts should be in the same directory as is their source. I would like to have them removed on `make clea

[Freeipa-devel] [freeipa PR#193][opened] [ipa-4-4] Make httpd publish its CA certificate on DL1

2016-10-26 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/193 Author: stlaz Title: #193: [ipa-4-4] Make httpd publish its CA certificate on DL1 Action: opened PR body: """ httpd did not publish its certificate on DL1 which could cause issues during client installation in a rare co

[Freeipa-devel] [freeipa PR#151][synchronized] Make httpd publish its CA certificate on DL1

2016-10-26 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/151 Author: stlaz Title: #151: Make httpd publish its CA certificate on DL1 Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/151/head:pr151 git checkout pr151

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-19 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires stlaz commented: """ @martbab Thanks, that worked. However, first set of patches was not yet ACKed in https://github.com/freeipa/freeipa/pull/171. """ See the full

[Freeipa-devel] [freeipa PR#159][-ack] spec file: clean up BuildRequires

2016-10-19 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires Label: -ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-19 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires stlaz commented: """ @martbab Thanks, that worked. ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/159#issuecomment-254843561 -- Manage you

[Freeipa-devel] [freeipa PR#159][+ack] spec file: clean up BuildRequires

2016-10-19 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-19 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 stlaz commented: """ +1 to push, the comments were added to outdated diffs so I thought them resolved. They are now. """ See the full comment at https://github.com/freeipa

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-19 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires stlaz commented: """ For some reason, after running `sudo dnf builddep freeipa.spec`, which is successful, if I run the same command again, if fails: ``` [login@vm freeipa-git]$ su

<    1   2   3   4   5   6   7   >