URL: https://github.com/freeipa/freeipa/pull/271
Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and
ipaclient
stlaz commented:
"""
@jcholast Thanks, I'll add it as a comment to that ticket so that it's more
visible to a potential communit
URL: https://github.com/freeipa/freeipa/pull/271
Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and
ipaclient
stlaz commented:
"""
@jcholast Thanks, I'll add it as a comment to that ticket so that it's more
visible to a potential community :
URL: https://github.com/freeipa/freeipa/pull/271
Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and
ipaclient
stlaz commented:
"""
The changes seem fine, I especially dig moving parts only used in
ipaserver/ipaclient to their respective submodules
URL: https://github.com/freeipa/freeipa/pull/271
Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and
ipaclient
stlaz commented:
"""
I do not have much trouble reviewing the whole PR, also it does not do that
much and does not break tests (did not try
URL: https://github.com/freeipa/freeipa/pull/231
Author: stlaz
Title: #231: Do not log DM password in ca/kra installation logs
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/231/head:pr231
git checkout
URL: https://github.com/freeipa/freeipa/pull/231
Title: #231: Do not log DM password in ca/kra installation logs
stlaz commented:
"""
@martbab Oh, I thought you wanted me to re-add `dm_password` to DogtagInstance
as @tomaskrizek which does not seem right as DogtagInstance is in
URL: https://github.com/freeipa/freeipa/pull/212
Title: #212: KRA: don't add KRA container when KRA replica
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contri
URL: https://github.com/freeipa/freeipa/pull/212
Title: #212: KRA: don't add KRA container when KRA replica
stlaz commented:
"""
ACK, works on both DLs.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/212#issuecomment-261890178
--
Manag
URL: https://github.com/freeipa/freeipa/pull/231
Title: #231: Do not log DM password in ca/kra installation logs
stlaz commented:
"""
I must have misclicked "close" when viewing this PR on my phone. I believe we
may rather add admin and DM passwords to the nolog_li
URL: https://github.com/freeipa/freeipa/pull/231
Author: stlaz
Title: #231: Do not log DM password in ca/kra installation logs
Action: reopened
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/231/head:pr231
git checkout pr231
URL: https://github.com/freeipa/freeipa/pull/231
Author: stlaz
Title: #231: Do not log DM password in ca/kra installation logs
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/231/head:pr231
git checkout pr231
URL: https://github.com/freeipa/freeipa/pull/235
Title: #235: Remove unused Knob function
stlaz commented:
"""
From our offline discussion I got the impression the Knob function was still
used somewhere, therefore the ACK. I'm not sure what was the reason of keeping
Knob
URL: https://github.com/freeipa/freeipa/pull/235
Title: #235: Make Knob function deprecated
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/235
Title: #235: Make Knob function deprecated
stlaz commented:
"""
ACK, there should be note about this deprecation somewhere. Deleting Knob might
be worth a ticket as well.
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/212
Title: #212: KRA: don't add KRA container when KRA replica
stlaz commented:
"""
configure_instance and configure_replica codes were merged, you'll need to
check for self.clone value instead.
"""
See
URL: https://github.com/freeipa/freeipa/pull/231
Author: stlaz
Title: #231: Do not log DM password in ca/kra installation logs
Action: opened
PR body:
"""
We can merge this after refactoring merges not to mess the rebases.
https://fedorahosted.org/freeipa/ticket/6461
"&
URL: https://github.com/freeipa/freeipa/pull/201
Title: #201: spec file: bump minimal required version of 389-ds-base
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/p
URL: https://github.com/freeipa/freeipa/pull/201
Title: #201: spec file: bump minimal required version of 389-ds-base
stlaz commented:
"""
ACK
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/201#issuecomment-257535867
--
Manage your subs
URL: https://github.com/freeipa/freeipa/pull/199
Author: stlaz
Title: #199: [ipa-4-4] Fix missing file that fails DL1 replica installation
Action: opened
PR body:
"""
Replica installation on DL1 would fail to create a httpd instance
due to missing '/etc/httpd/alias/cace
URL: https://github.com/freeipa/freeipa/pull/198
Author: stlaz
Title: #198: Fix missing file that fails DL1 replica installation
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/198/head:pr198
git checkout
URL: https://github.com/freeipa/freeipa/pull/198
Author: stlaz
Title: #198: Fix missing file that fails DL1 replica installation
Action: edited
Changed field: body
Original value:
"""
Replica installation on DL1 would fail to create a httpd instance
due to missing &#
URL: https://github.com/freeipa/freeipa/pull/198
Author: stlaz
Title: #198: Fix missing file that fails DL1 replica installation
Action: opened
PR body:
"""
Replica installation on DL1 would fail to create a httpd instance
due to missing '/etc/httpd/alias/cacert.asc'
URL: https://github.com/freeipa/freeipa/pull/188
Title: #188: Move Python build artefacts to top level directory
stlaz commented:
"""
+1 with @pspacek, build artefacts should be in the same directory as is their
source. I would like to have them removed on `make clean` i
URL: https://github.com/freeipa/freeipa/pull/193
Author: stlaz
Title: #193: [ipa-4-4] Make httpd publish its CA certificate on DL1
Action: opened
PR body:
"""
httpd did not publish its certificate on DL1 which could
cause issues during client installation in a rare corner
c
URL: https://github.com/freeipa/freeipa/pull/151
Author: stlaz
Title: #151: Make httpd publish its CA certificate on DL1
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/151/head:pr151
git checkout pr151
URL: https://github.com/freeipa/freeipa/pull/159
Title: #159: spec file: clean up BuildRequires
stlaz commented:
"""
@martbab Thanks, that worked. However, first set of patches was not yet ACKed
in https://github.com/freeipa/freeipa/pull/171.
"""
See the full
URL: https://github.com/freeipa/freeipa/pull/159
Title: #159: spec file: clean up BuildRequires
Label: -ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/159
Title: #159: spec file: clean up BuildRequires
stlaz commented:
"""
@martbab Thanks, that worked. ACK.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/159#issuecomment-254843561
--
Manage you
URL: https://github.com/freeipa/freeipa/pull/159
Title: #159: spec file: clean up BuildRequires
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
stlaz commented:
"""
+1 to push, the comments were added to outdated diffs so I thought them
resolved. They are now.
"""
See the full comment at
https://github.com/freeipa
URL: https://github.com/freeipa/freeipa/pull/159
Title: #159: spec file: clean up BuildRequires
stlaz commented:
"""
For some reason, after running `sudo dnf builddep freeipa.spec`, which is
successful, if I run the same command again, if fails:
```
[login@vm freeipa-git]$ su
URL: https://github.com/freeipa/freeipa/pull/159
Title: #159: spec file: clean up BuildRequires
stlaz commented:
"""
For some reason, after running `sudo dnf builddep freeipa.spec`, which is
successful, if I run the same command again, if fails:
```
[login@vm freeipa-git]$ su
URL: https://github.com/freeipa/freeipa/pull/159
Title: #159: spec file: clean up BuildRequires
stlaz commented:
"""
For some reason, after running `sudo dnf builddep freeipa.spec`, which is
successful, if I run the same command again, if fails:
```
[login@vm freeipa-git]$ su
URL: https://github.com/freeipa/freeipa/pull/159
Title: #159: spec file: clean up BuildRequires
stlaz commented:
"""
For some reason, after running `sudo dnf builddep freeipa.spec`, which is
successful, if I run the same command again, if fails:
```
[login@vm freeipa-git]$ su
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
stlaz commented:
"""
ACK, works for me.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/171#issuecomment-254788258
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode
stlaz commented:
"""
@simo5: There is a LOT of checking of various combinations of options in
ipa-client-install, not even mentioning IPADiscovery in interactive mod
URL: https://github.com/freeipa/freeipa/pull/151
Author: stlaz
Title: #151: Make httpd publish its CA certificate on DL1
Action: opened
PR body:
"""
httpd did not publish its certificate on DL1 which could
cause issues during client installation in a rare corner
case where th
URL: https://github.com/freeipa/freeipa/pull/117
Author: stlaz
Title: #117: Make ipa-replica-install run in interactive mode
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/117/head:pr117
git checkout
URL: https://github.com/freeipa/freeipa/pull/148
Author: gkaihorodova
Title: #148: Unaccessible variable self.attrs in Tracker
Action: reopened
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/148/head:pr148
git checkout pr148
-
URL: https://github.com/freeipa/freeipa/pull/149
Title: #149: Tests: Unaccessible variable self.attrs in Tracker
stlaz commented:
"""
Please fix this in the original PR, it will be a nice training for you ;)
"""
See the full comment at
https://github.com/freeipa
URL: https://github.com/freeipa/freeipa/pull/149
Author: gkaihorodova
Title: #149: Tests: Unaccessible variable self.attrs in Tracker
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/149/head:pr149
git checkout pr
URL: https://github.com/freeipa/freeipa/pull/149
Title: #149: Tests: Unaccessible variable self.attrs in Tracker
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/p
URL: https://github.com/freeipa/freeipa/pull/148
Title: #148: Unaccessible variable self.attrs in Tracker
stlaz commented:
"""
That's not how pull requests work. You should change the commit and force push
it to the branch instead.
"""
See the full com
URL: https://github.com/freeipa/freeipa/pull/135
Title: #135: Pylint: remove unused variables
stlaz commented:
"""
A refactoring ticket needs opening for the issues with find_entries mentioned
here. Tests seem to pass, so ACK.
"""
See the full comment at
http
URL: https://github.com/freeipa/freeipa/pull/135
Title: #135: Pylint: remove unused variables
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/113
Title: #113: ipalib.constants: Remove default domain, realm, basedn,
xmlrpc_uri, ldap_uri
stlaz commented:
"""
NACK, please see the review comment.
"""
See the full comment at
https://github.com/freeipa/freeipa/p
URL: https://github.com/freeipa/freeipa/pull/117
Author: stlaz
Title: #117: Make ipa-replica-install run in interactive mode
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/117/head:pr117
git checkout
URL: https://github.com/freeipa/freeipa/pull/129
Author: stlaz
Title: #129: Fix test_util.test_assert_deepequal test
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/129/head:pr129
git checkout pr129
From
URL: https://github.com/freeipa/freeipa/pull/129
Author: stlaz
Title: #129: Fix test_util.test_assert_deepequal test
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/129/head:pr129
git checkout pr129
From
URL: https://github.com/freeipa/freeipa/pull/129
Author: stlaz
Title: #129: Fix test_util.test_assert_deepequal test
Action: opened
PR body:
"""
The test would be failing because recent pretty-print changes
that caused the inner members of a dictionary to be printed
in a
URL: https://github.com/freeipa/freeipa/pull/117
Author: stlaz
Title: #117: Make ipa-replica-install run in interactive mode
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/117/head:pr117
git checkout
URL: https://github.com/freeipa/freeipa/pull/121
Title: #121: Pylint: enable unused-variable check
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/121
Title: #121: Pylint: enable unused-variable check
stlaz commented:
"""
The latest changes fixed the nitpicks mentioned, ACK. Thanks :+1:
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/121#iss
URL: https://github.com/freeipa/freeipa/pull/121
Title: #121: Pylint: enable unused-variable check
stlaz commented:
"""
The changes seem fine except for the two small nitpicks.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/121#issuecom
URL: https://github.com/freeipa/freeipa/pull/120
Author: stlaz
Title: #120: Pretty-print structures in assert_deepequal
Action: opened
PR body:
"""
By default, ipa-run-tests will now pretty-print structures
compared in the assert_deepequal function. This behaviour
can be tu
URL: https://github.com/freeipa/freeipa/pull/117
Author: stlaz
Title: #117: Make ipa-replica-install run in interactive mode
Action: opened
PR body:
"""
ipa-replica-install would not run in interactive mode which confused some
users. Make it run ipa-client-install in attend
URL: https://github.com/freeipa/freeipa/pull/84
Title: #84: Fix update_from_dict function testing
stlaz commented:
"""
Removed the method and its respective test again.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/84#issuecomment-24883203
URL: https://github.com/freeipa/freeipa/pull/84
Author: stlaz
Title: #84: Fix update_from_dict function testing
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/84/head:pr84
git checkout pr84
From
URL: https://github.com/freeipa/freeipa/pull/102
Author: stlaz
Title: #102: Updated ipa-client-install info about hostname
Action: opened
PR body:
"""
The man page and help of ipa-client-install had an outdated
information about what is used as a hostname.
https://fedorahos
URL: https://github.com/freeipa/freeipa/pull/101
Author: stlaz
Title: #101: Improved vault-show error message
Action: opened
PR body:
"""
Added more information to the NotFound error that may occur during
execution of vault-show. It was not clear whether the vault
really does
URL: https://github.com/freeipa/freeipa/pull/82
Title: #82: Fix regexp in user/group name
stlaz commented:
"""
The tests seem to pass as well.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/82#issuecomment-248306443
--
Manage your subs
URL: https://github.com/freeipa/freeipa/pull/92
Title: #92: Add log messages for IP checks during client install
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/C
URL: https://github.com/freeipa/freeipa/pull/85
Title: #85: WebUI: Change group name from 'normal' to 'Non-POSIX'
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/
URL: https://github.com/freeipa/freeipa/pull/85
Title: #85: WebUI: Change group name from 'normal' to 'Non-POSIX'
stlaz commented:
"""
Works fine.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/85#issuecomment-248236255
URL: https://github.com/freeipa/freeipa/pull/91
Title: #91: Add help info about certificate revocation reasons
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Con
URL: https://github.com/freeipa/freeipa/pull/91
Title: #91: Add help info about certificate revocation reasons
stlaz commented:
"""
Please, don't forget to add the ACK labels if you think the code should be
pushed into FreeIPA.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/90
Title: #90: Update ipa-server-install man page for hostname
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contri
URL: https://github.com/freeipa/freeipa/pull/89
Title: #89: client: remove hard dependency on pam_krb5
stlaz commented:
"""
Works as expected.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/89#issuecomment-247579650
--
Manage your subs
URL: https://github.com/freeipa/freeipa/pull/89
Title: #89: client: remove hard dependency on pam_krb5
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/
URL: https://github.com/freeipa/freeipa/pull/82
Title: #82: Fix regexp in user/group name
stlaz commented:
"""
Sure. But from what I see, this patch may possibly break idviews plugin for
users of username of about 255 characters (see idoverrideuser - 'uid'), same
stlaz commented on a pull request
"""
Would the gist of this patch also apply to any of idviews, servicedelegation or
topology plugins where a similar or slightly different regexp is used? Could we
rather have the regexp as a constant somewhere so it does not have to be
change
Akasurde's pull request #83: "Added a fix for setting Priority as required
field " label *ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/83
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-de
stlaz commented on a pull request
"""
Looks OK to me, thanks.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/83#issuecomment-247310347
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listin
Akasurde's pull request #83: "Added a fix for setting Priority as required
field " label *ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/83
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-de
stlaz commented on a pull request
"""
Well, I did fix the test, then. I can imagine the function being pretty handy
as a library function although it'd better be used in the future.
What infuriates me is the fact that the test might have never worked (well, at
least yea
stlaz's pull request #84: "Removed update_from_dict function from ldapupdate"
was synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/84
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/84/head:pr84
pvomacka's pull request #72: "WebUI: Add handling for HTTP error 404" label
*ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/72
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribut
stlaz's pull request #84: "Removed update_from_dict function from ldapupdate"
was opened
PR body:
"""
update_from_dict was basically dead code as it's used nowhere in
the project.
https://fedorahosted.org/freeipa/ticket/6311
"""
See the full pull-request at https://github.com/freeipa/freeipa/pu
martbab's pull request #68: "netgroup: avoid extraneous LDAP search when
retrieving primary key from DN" label *ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/68
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailm
stlaz commented on a pull request
"""
Please add ```assert isinstance(dn, DN)``` as in the parent method.
Also, I think maybe it's safer to check for rdns emptiness before you try to
assign from it.
"""
See the full comment at
https://github.com/freeipa/fre
stlaz commented on a pull request
"""
LGTM, just please add ```assert isinstance(dn, DN)``` as in the parent method.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/68#issuecomment-245878203
--
Manage your subscription for the Fre
stlaz commented on a pull request
"""
Sure.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/67#issuecomment-245529296
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-dev
martbab's pull request #67: "advise: Use `name` instead of `__name__` to get
plugin names" label *ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/67
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/fr
stlaz commented on a pull request
"""
Seems to be doing more or less the same but in cleaner manner => LGTM. Do we
need a ticket for this?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/67#issuecomment-245525153
--
Manage your subscript
stlaz commented on a pull request
"""
Works as expected, the code looks fine as well.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/19#issuecomment-245509559
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redha
pvomacka's pull request #19: "WebUI: Add 'Restore' option to action dropdown
menu" label *ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/19
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-de
pvoborni's pull request #65: "#6216 - webui: cert_revoke should use --cacn to
set correct CA when revoking certificate" label *ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/65
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.r
stlaz commented on a pull request
"""
Seems to be working as expected.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/65#issuecomment-245210985
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/lis
stlaz commented on a pull request
"""
I pushed the latest changes of the time rules to this pull request. These
changes were made according to the discussion on freeipa-devel mailing list,
the main change is cutting off some attributes from the ipaHBACRuleV2
objectclass.
P
stlaz's pull request #23: "Time-Based HBAC Policies" was synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/23
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/23/head:pr23
git checkout pr23
From 50
pspacek's pull request #36: "Fix tests for forward zones" label *ack* has been
added
See the full pull-request at https://github.com/freeipa/freeipa/pull/36
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA
stlaz commented on a pull request
"""
This seems to have fixed the test issue, ACK.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/36#issuecomment-243370278
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redha
stlaz's pull request #23: "Time-Based HBAC Policies" was synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/23
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/23/head:pr23
git checkout pr23
freei
stlaz's pull request #23: "Time-Based HBAC Policies" was synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/23
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/23/head:pr23
git checkout pr23
freei
stlaz's pull request #26: "Don't ignore --ignore-last-of-role for last CA" was
opened
PR body:
"""
Use a handler created for the purpose of deciding whether
to raise exception or not.
https://fedorahosted.org/freeipa/ticket/6259
"""
See the full pull-request at https://github.com/freeipa/freeip
stlaz's pull request #23: "Time-Based HBAC Policies" was edited
See the full pull-request at https://github.com/freeipa/freeipa/pull/23
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/23/head:pr23
git checkout pr23
--
Manage y
stlaz's pull request #23: "Prototype of timerules as LDAP objects" was opened
PR body:
"""
Hello,
My branch adds the basic capabilities for adding time policies to HBAC rules.
The policies are represented as separate objects that I call "time rules" which
can be added to each HBAC rule. The pol
601 - 698 of 698 matches
Mail list logo
