[Freeipa-devel] [freeipa PR#252][+rejected] Use namespace-aware meta importer for ipaplatform

2016-11-25 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/252 Title: #252: Use namespace-aware meta importer for ipaplatform Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/pa

[Freeipa-devel] [freeipa PR#101][comment] Improved vault-show error message

2016-11-25 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/101 Title: #101: Improved vault-show error message stlaz commented: """ Seems like nobody objected so far. """ See the full comment at https://github.com/freeipa/freeipa/pull/101#issuecomment-262971504 -- Manage you

[Freeipa-devel] [freeipa PR#101][synchronized] Improved vault-show error message

2016-11-25 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/101 Author: stlaz Title: #101: Improved vault-show error message Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/101/head:pr101 git checkout pr101 From

[Freeipa-devel] [freeipa PR#101][synchronized] Improved vault-show error message

2016-11-28 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/101 Author: stlaz Title: #101: Improved vault-show error message Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/101/head:pr101 git checkout pr101 From

[Freeipa-devel] [freeipa PR#101][comment] Improved vault-show error message

2016-11-28 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/101 Title: #101: Improved vault-show error message stlaz commented: """ WONTFIX then. There's no winning here. """ See the full comment at https://github.com/freeipa/freeipa/pull/101#issuecomment-263265074 -

[Freeipa-devel] [freeipa PR#266][comment] ipapython: simplify Env object initialization

2016-11-29 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/266 Title: #266: ipapython: simplify Env object initialization stlaz commented: """ From offline discussion I got that the PR should actually work in the end. I'll make the review. """ See the full comment at

[Freeipa-devel] [freeipa PR#266][comment] ipapython: simplify Env object initialization

2016-11-29 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/266 Title: #266: ipapython: simplify Env object initialization stlaz commented: """ This PR breaks almost all tests in test_ipalib/test_crud.py with `AttributeError: 'API' object has no attribute 'env'`. This e

[Freeipa-devel] [freeipa PR#271][comment] Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient

2016-11-29 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/271 Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient stlaz commented: """ I checked the rebase again as well as ran the tests. The changes in the PR clean the code nicely aside from doing wha

[Freeipa-devel] [freeipa PR#271][+ack] Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient

2016-11-29 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/271 Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http

[Freeipa-devel] [freeipa PR#282][opened] replicainstall: give correct error message on DL mismatch

2016-11-29 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/282 Author: stlaz Title: #282: replicainstall: give correct error message on DL mismatch Action: opened PR body: """ https://fedorahosted.org/freeipa/ticket/6510 """ To pull the PR as Git branch: git remote add ghfree

[Freeipa-devel] [freeipa PR#271][comment] Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient

2016-11-29 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/271 Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient stlaz commented: """ Last I checked the ticket was still open. The ticket was trying to solve the same issue as this PR although its aim s

[Freeipa-devel] [freeipa PR#271][+pushed] Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient

2016-11-30 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/271 Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: h

[Freeipa-devel] [freeipa PR#271][comment] Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient

2016-11-30 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/271 Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient stlaz commented: """ The patch's already been pushed, could you, @mbasti-rh, supply the automated message? """ See the

[Freeipa-devel] [freeipa PR#295][comment] Issue6474 fixups

2016-12-01 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/295 Title: #295: Issue6474 fixups stlaz commented: """ There are some more ipaplatform imports left, some in test_xmlrpc, test_webui, test_install and test_cmdline (of which I think may interest you). Is it ok these are left ther

[Freeipa-devel] [freeipa PR#295][+ack] Issue6474 fixups

2016-12-01 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/295 Title: #295: Issue6474 fixups Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#295][comment] Issue6474 fixups

2016-12-01 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/295 Title: #295: Issue6474 fixups stlaz commented: """ Good :) The tests seem to pass, the changes are trivial, ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/295#issuecomment-264207266 -- Ma

[Freeipa-devel] [freeipa PR#278][+ack] Restore the original functionality of `env` and `plugins` commands

2016-12-02 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/278 Title: #278: Restore the original functionality of `env` and `plugins` commands Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.fr

[Freeipa-devel] [freeipa PR#278][comment] Restore the original functionality of `env` and `plugins` commands

2016-12-02 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/278 Title: #278: Restore the original functionality of `env` and `plugins` commands stlaz commented: """ `env` works as expected, `plugins` seems to fail as expected. ACK. """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#276][comment] replica-conncheck: improve error msg + logging

2016-12-02 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/276 Title: #276: replica-conncheck: improve error msg + logging stlaz commented: """ Needs rebase. """ See the full comment at https://github.com/freeipa/freeipa/pull/276#issuecomment-264432666 -- Manage your subs

[Freeipa-devel] [freeipa PR#276][comment] replica-conncheck: improve error msg + logging

2016-12-05 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/276 Title: #276: replica-conncheck: improve error msg + logging stlaz commented: """ Seems to work fine, ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/276#issuecomment-264793827 -- Ma

[Freeipa-devel] [freeipa PR#276][+ack] replica-conncheck: improve error msg + logging

2016-12-05 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/276 Title: #276: replica-conncheck: improve error msg + logging Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contr

[Freeipa-devel] [freeipa PR#293][comment] Run out-of-tree tests in Travis CI

2016-12-05 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/293 Title: #293: Run out-of-tree tests in Travis CI stlaz commented: """ Since I recently run into issues with ipa-server-install and low entropy somewhere around creation of kdb proxy which drastically increased install time, woul

[Freeipa-devel] [freeipa PR#293][comment] Run out-of-tree tests in Travis CI

2016-12-07 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/293 Title: #293: Run out-of-tree tests in Travis CI stlaz commented: """ Good. I see the tests pass now and both @tiran's nitpicks and @mbasti-rh's comment have been resolved, so an ACK is in order. """ See

[Freeipa-devel] [freeipa PR#293][+ack] Run out-of-tree tests in Travis CI

2016-12-07 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/293 Title: #293: Run out-of-tree tests in Travis CI Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#316][opened] Fix error in permission-find post_callback search

2016-12-07 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/316 Author: stlaz Title: #316: Fix error in permission-find post_callback search Action: opened PR body: """ This pull requests fixes a bug introduced when fixing a different issue in https://github.com/freeipa

[Freeipa-devel] [freeipa PR#317][opened] Unify password generation across FreeIPA

2016-12-07 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Author: stlaz Title: #317: Unify password generation across FreeIPA Action: opened PR body: """ When installing FreeIPA in FIPS mode I noticed that there were often different ways of generating passwords in different spots r

[Freeipa-devel] [freeipa PR#317][synchronized] Unify password generation across FreeIPA

2016-12-08 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Author: stlaz Title: #317: Unify password generation across FreeIPA Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/317/head:pr317 git checkout pr317 From

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-08 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA stlaz commented: """ The passwords should have around the same entropy now. SHA-1 actually produces 160bit outputs (hence 40-characters long hexadecimal digests), so I recou

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-08 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA stlaz commented: """ NSS does support spaces in its passwords it seems. My hopes are that HTTP will be able to understand spaces in its password.conf file. """

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-08 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA stlaz commented: """ Apparently, spaces are ok even in HTTP password.conf so I guess we can leave it there. """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-08 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA stlaz commented: """ @simo5 I was actually trying to get rid of SHA-1 and I am aware that entropy will not be raised, that part of the code draw a smile on some of our face

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-11 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA stlaz commented: """ Correct me if I'm wrong here but I believe we're going for the scenario where the attacker has to guess the `xxx` bits of entropy and they know

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-11 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA stlaz commented: """ Correct me if I'm wrong here but I believe we're going for the scenario where the attacker has to guess the `xxx` bits of entropy and they know

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-11 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA stlaz commented: """ Correct me if I'm wrong here but I believe we're going for the scenario where the attacker has to guess the `xxx` bits of entropy and they know

[Freeipa-devel] [freeipa PR#323][comment] ipactl: pass api as argument to services

2016-12-12 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/323 Title: #323: ipactl: pass api as argument to services stlaz commented: """ Do we need a ticket for this? I notice the original commit did not have it either. """ See the full comment at https://github.com/freeipa

[Freeipa-devel] [freeipa PR#323][comment] ipactl: pass api as argument to services

2016-12-12 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/323 Title: #323: ipactl: pass api as argument to services stlaz commented: """ Works as expected. ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/323#issuecomment-266427247 -- Manage your subs

[Freeipa-devel] [freeipa PR#323][+ack] ipactl: pass api as argument to services

2016-12-12 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/323 Title: #323: ipactl: pass api as argument to services Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/

[Freeipa-devel] [freeipa PR#301][comment] scripts, tests: explicitly set confdir in the rest of server code

2016-12-13 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/301 Title: #301: scripts, tests: explicitly set confdir in the rest of server code stlaz commented: """ @tiran I find all the changes actually required. I think ACK is in order unless you spell out those which you think are not nece

[Freeipa-devel] [freeipa PR#117][synchronized] Make ipa-replica-install run in interactive mode

2016-12-15 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/117 Author: stlaz Title: #117: Make ipa-replica-install run in interactive mode Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/117/head:pr117 git checkout

[Freeipa-devel] [freeipa PR#117][comment] Make ipa-replica-install run in interactive mode

2016-12-15 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/117 Title: #117: Make ipa-replica-install run in interactive mode stlaz commented: """ Rebase done. I wanted to wait until some more changes to api bootstrapping to be able to call client installation from module using the latest in

[Freeipa-devel] [freeipa PR#117][comment] Make ipa-replica-install run in interactive mode

2016-12-15 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/117 Title: #117: Make ipa-replica-install run in interactive mode stlaz commented: """ Rebase done. I wanted to wait until some more changes to api bootstrapping to be able to call client installation from module using the latest in

[Freeipa-devel] [freeipa PR#210][-ack] Tests: Stage User Tracker implementation

2016-12-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/210 Title: #210: Tests: Stage User Tracker implementation Label: -ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/

[Freeipa-devel] [freeipa PR#210][comment] Tests: Stage User Tracker implementation

2016-12-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/210 Title: #210: Tests: Stage User Tracker implementation stlaz commented: """ I just wanted to remove the ACK till @martbab's comment is worked in so nobody pushes it but I found some minor issues that I would like to see fix

[Freeipa-devel] [freeipa PR#279][+ack] installer: Stop adding distro-specific NTP servers into ntp.conf

2016-12-19 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/279 Title: #279: installer: Stop adding distro-specific NTP servers into ntp.conf Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.free

[Freeipa-devel] [freeipa PR#356][+ack] server install: fix KRA agent PEM file not being created

2016-12-20 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/356 Title: #356: server install: fix KRA agent PEM file not being created Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/

[Freeipa-devel] [freeipa PR#356][comment] server install: fix KRA agent PEM file not being created

2016-12-20 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/356 Title: #356: server install: fix KRA agent PEM file not being created stlaz commented: """ Works as expected. """ See the full comment at https://github.com/freeipa/freeipa/pull/356#issuecomment-26827 -- Ma

[Freeipa-devel] [freeipa PR#317][synchronized] Unify password generation across FreeIPA

2016-12-21 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Author: stlaz Title: #317: Unify password generation across FreeIPA Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/317/head:pr317 git checkout pr317 From

[Freeipa-devel] [freeipa PR#317][synchronized] Unify password generation across FreeIPA

2016-12-21 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Author: stlaz Title: #317: Unify password generation across FreeIPA Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/317/head:pr317 git checkout pr317 From

[Freeipa-devel] [freeipa PR#317][synchronized] Unify password generation across FreeIPA

2016-12-21 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Author: stlaz Title: #317: Unify password generation across FreeIPA Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/317/head:pr317 git checkout pr317 From

[Freeipa-devel] [freeipa PR#298][+rejected] ipaldap: handle binary encoding option transparently

2017-01-02 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/298 Title: #298: ipaldap: handle binary encoding option transparently Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org

[Freeipa-devel] [freeipa PR#350][comment] spec file: revert to the previous Release tag

2017-01-02 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/350 Title: #350: spec file: revert to the previous Release tag stlaz commented: """ I also appreciate the dist information, ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/350#issuecom

[Freeipa-devel] [freeipa PR#350][+ack] spec file: revert to the previous Release tag

2017-01-02 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/350 Title: #350: spec file: revert to the previous Release tag Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contri

[Freeipa-devel] [freeipa PR#362][opened] Clarify meaning of --domain and --realm in installers

2017-01-02 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/362 Author: stlaz Title: #362: Clarify meaning of --domain and --realm in installers Action: opened PR body: """ This is my take on original https://github.com/freeipa/freeipa/pull/352. I hope I fixed all the mentioned issues

[Freeipa-devel] [freeipa PR#362][synchronized] Clarify meaning of --domain and --realm in installers

2017-01-02 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/362 Author: stlaz Title: #362: Clarify meaning of --domain and --realm in installers Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/362/head:pr362 git checkout

[Freeipa-devel] [freeipa PR#362][+ack] Clarify meaning of --domain and --realm in installers

2017-01-03 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/362 Title: #362: Clarify meaning of --domain and --realm in installers Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/pag

[Freeipa-devel] [freeipa PR#367][opened] Remove nsslib from IPA

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Author: stlaz Title: #367: Remove nsslib from IPA Action: opened PR body: """ This batch of patches removes NSSConnection along with the whole ipapython.nsslib from IPA and replaces it with more standard httplib.

[Freeipa-devel] [freeipa PR#367][edited] Remove nsslib from IPA

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Author: stlaz Title: #367: Remove nsslib from IPA Action: edited Changed field: body Original value: """ This batch of patches removes NSSConnection along with the whole ipapython.nsslib from IPA and replaces it wit

[Freeipa-devel] [freeipa PR#359][comment] dogtag: search past the first 100 certificates

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/359 Title: #359: dogtag: search past the first 100 certificates stlaz commented: """ @frasertweedale if `_ldap_search` is performed with correct filters, `sizelimit=0` is not the correct solution at least for CLI which should eit

[Freeipa-devel] [freeipa PR#361][comment] This PR implements a number of improvements for our Travis CI:

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/361 Title: #361: This PR implements a number of improvements for our Travis CI: stlaz commented: """ I assume the licence headers did not break the automember tests so this could be pushed. Just a brief question: would it be reason

[Freeipa-devel] [freeipa PR#367][synchronized] Remove nsslib from IPA

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Author: stlaz Title: #367: Remove nsslib from IPA Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/367/head:pr367 git checkout pr367 From

[Freeipa-devel] [freeipa PR#367][comment] Remove nsslib from IPA

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Title: #367: Remove nsslib from IPA stlaz commented: """ You're right, I should probably write some design. The current implementation does not check CRL or OSCP, so we're "fine" with this change. The

[Freeipa-devel] [freeipa PR#361][comment] This PR implements a number of improvements for our Travis CI:

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/361 Title: #361: This PR implements a number of improvements for our Travis CI: stlaz commented: """ @martbab My naive solution is to do something like ```bash LINE=`grep -n -m 1 $CI_TRAVIS_LOG -e "=== FAILURES ===" |

[Freeipa-devel] [freeipa PR#352][+rejected] Clarify meaning of --domain and --realm in installers

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/352 Title: #352: Clarify meaning of --domain and --realm in installers Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.or

[Freeipa-devel] [freeipa PR#352][closed] Clarify meaning of --domain and --realm in installers

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/352 Author: pspacek Title: #352: Clarify meaning of --domain and --realm in installers Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/352/head:pr352 git checkout pr35

[Freeipa-devel] [freeipa PR#352][comment] Clarify meaning of --domain and --realm in installers

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/352 Title: #352: Clarify meaning of --domain and --realm in installers stlaz commented: """ The fixes to raised issues are fixed in https://github.com/freeipa/freeipa/issues/362 """ See the full comment at https://g

[Freeipa-devel] [freeipa PR#367][comment] Remove nsslib from IPA

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Title: #367: Remove nsslib from IPA stlaz commented: """ @rcritten I spoke to the NSS people who assured me it's the intended behavior. But thanks for the remainder, I will open a Bugzilla for that as well, I was considering

[Freeipa-devel] [freeipa PR#370][comment] [EXPERIMENT] ci: send build log to paste.fedoraproject.org

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/370 Title: #370: [EXPERIMENT] ci: send build log to paste.fedoraproject.org stlaz commented: """ Um, sorry, but I fail to see the real upside here, perhaps I am missing something. If I see here on github that a build of my PR faile

[Freeipa-devel] [freeipa PR#367][comment] Remove nsslib from IPA

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Title: #367: Remove nsslib from IPA stlaz commented: """ @rcritten I spoke to the NSS people who assured me it's the intended behavior. But thanks for the remainder, I will open a Bugzilla for that as well, I was considering

[Freeipa-devel] [freeipa PR#370][comment] [EXPERIMENT] ci: send build log to paste.fedoraproject.org

2017-01-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/370 Title: #370: [EXPERIMENT] ci: send build log to paste.fedoraproject.org stlaz commented: """ Um, sorry, but I fail to see the real upside here, perhaps I am missing something. If I see here on github that a build of my PR faile

[Freeipa-devel] [freeipa PR#361][comment] This PR implements a number of improvements for our Travis CI:

2017-01-05 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/361 Title: #361: This PR implements a number of improvements for our Travis CI: stlaz commented: """ The change LGTM, ACK, we'll see how it works :) """ See the full comment at https://github.com/freeipa/free

[Freeipa-devel] [freeipa PR#361][+ack] This PR implements a number of improvements for our Travis CI:

2017-01-05 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/361 Title: #361: This PR implements a number of improvements for our Travis CI: Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeip

[Freeipa-devel] [freeipa PR#361][-ack] This PR implements a number of improvements for our Travis CI:

2017-01-05 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/361 Title: #361: This PR implements a number of improvements for our Travis CI: Label: -ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeip

[Freeipa-devel] [freeipa PR#372][comment] Restore IPA 3.0 compatibility of copy-schema-to-ca.py

2017-01-05 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/372 Title: #372: Restore IPA 3.0 compatibility of copy-schema-to-ca.py stlaz commented: """ Is there a reason not to stick with the original `ipautil.SHARE_DIR` and without setting `confdir`? This script won't be run on serv

[Freeipa-devel] [freeipa PR#361][+ack] This PR implements a number of improvements for our Travis CI:

2017-01-05 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/361 Title: #361: This PR implements a number of improvements for our Travis CI: Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeip

[Freeipa-devel] [freeipa PR#361][comment] This PR implements a number of improvements for our Travis CI:

2017-01-05 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/361 Title: #361: This PR implements a number of improvements for our Travis CI: stlaz commented: """ I have no more remarks on this, hopefully final ACK. """ See the full comment at https://github.com/freeipa/freeipa/p

[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values

2017-01-05 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values stlaz commented: """ Seems fine + Travis is satisfied as well, ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/181#iss

[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values

2017-01-05 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values stlaz commented: """ Seems fine + Travis is satisfied as well, ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/181#iss

[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values

2017-01-05 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values stlaz commented: """ The changes introduce different behavior than in the previous change where repr() of the given strings would have been printed. To hav

[Freeipa-devel] [freeipa PR#317][synchronized] Unify password generation across FreeIPA

2017-01-06 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Author: stlaz Title: #317: Unify password generation across FreeIPA Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/317/head:pr317 git checkout pr317 From

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2017-01-06 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA stlaz commented: """ I don't see any merge conflicts and the rebase was automatic so I don't see why, but ok. Just note that ipatool may be confused with me commiting

[Freeipa-devel] [freeipa PR#367][synchronized] Remove nsslib from IPA

2017-01-06 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Author: stlaz Title: #367: Remove nsslib from IPA Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/367/head:pr367 git checkout pr367 From

[Freeipa-devel] [freeipa PR#367][edited] Remove nsslib from IPA

2017-01-06 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Author: stlaz Title: #367: Remove nsslib from IPA Action: edited Changed field: body Original value: """ This batch of patches removes NSSConnection along with the whole ipapython.nsslib from IPA and replaces it wit

[Freeipa-devel] [freeipa PR#367][synchronized] Remove nsslib from IPA

2017-01-06 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Author: stlaz Title: #367: Remove nsslib from IPA Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/367/head:pr367 git checkout pr367 From

[Freeipa-devel] [freeipa PR#210][+ack] Tests: Stage User Tracker implementation

2017-01-08 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/210 Title: #210: Tests: Stage User Tracker implementation Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/

[Freeipa-devel] [freeipa PR#181][+ack] Tests : User Tracker creation of user with minimal values

2017-01-08 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org

[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values

2017-01-08 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values stlaz commented: """ Thank you for the changes! """ See the full comment at https://github.com/freeipa/freeipa/pull/181#issuecomment-27122275

[Freeipa-devel] [freeipa PR#380][comment] Travis CI: actually return non-zero exit status when the test job fails

2017-01-09 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/380 Title: #380: Travis CI: actually return non-zero exit status when the test job fails stlaz commented: """ It works but for some reason there are many extra newlines in the failure log """ See the full comment

[Freeipa-devel] [freeipa PR#380][+ack] Travis CI: actually return non-zero exit status when the test job fails

2017-01-09 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/380 Title: #380: Travis CI: actually return non-zero exit status when the test job fails Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://

[Freeipa-devel] [freeipa PR#380][comment] Travis CI: actually return non-zero exit status when the test job fails

2017-01-09 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/380 Title: #380: Travis CI: actually return non-zero exit status when the test job fails stlaz commented: """ It works but for some reason there are many extra newlines in the failure log """ See the full comment

[Freeipa-devel] [freeipa PR#380][comment] Travis CI: actually return non-zero exit status when the test job fails

2017-01-09 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/380 Title: #380: Travis CI: actually return non-zero exit status when the test job fails stlaz commented: """ It works but for some reason there are many extra newlines in the failure log **edit:** nvm, displayes correctly now, ap

[Freeipa-devel] [freeipa PR#367][synchronized] Remove nsslib from IPA

2017-01-10 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Author: stlaz Title: #367: Remove nsslib from IPA Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/367/head:pr367 git checkout pr367 From

[Freeipa-devel] [freeipa PR#367][comment] Remove nsslib from IPA

2017-01-10 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Title: #367: Remove nsslib from IPA stlaz commented: """ In the last update I added SSLv2 support in IPAHTTPSConnection for backward compatibility (https://goo.gl/images/gqh2D9). I also removed the Fedora crypto policies cipher

[Freeipa-devel] [freeipa PR#367][synchronized] Remove nsslib from IPA

2017-01-10 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Author: stlaz Title: #367: Remove nsslib from IPA Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/367/head:pr367 git checkout pr367 From

[Freeipa-devel] [freeipa PR#385][opened] Generate sha256 ssh pubkey fingerprints for hosts

2017-01-10 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/385 Author: stlaz Title: #385: Generate sha256 ssh pubkey fingerprints for hosts Action: opened PR body: """ Replace md5 with sha256 for host ssh pubkey fingerprints. MD5 is disabled in FIPS mode, newer versions of OpenSSH print SH

[Freeipa-devel] [freeipa PR#383][+ack] Remove duplicated step from DS install

2017-01-10 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/383 Title: #383: Remove duplicated step from DS install Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Co

[Freeipa-devel] [freeipa PR#383][comment] Remove duplicated step from DS install

2017-01-10 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/383 Title: #383: Remove duplicated step from DS install stlaz commented: """ The tests passed, ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/383#issuecomment-271622092 -- Manage your subs

[Freeipa-devel] [freeipa PR#385][synchronized] Generate sha256 ssh pubkey fingerprints for hosts

2017-01-10 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/385 Author: stlaz Title: #385: Generate sha256 ssh pubkey fingerprints for hosts Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/385/head:pr385 git checkout

[Freeipa-devel] [freeipa PR#385][comment] Generate sha256 ssh pubkey fingerprints for hosts

2017-01-11 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/385 Title: #385: Generate sha256 ssh pubkey fingerprints for hosts stlaz commented: """ @tiran Which SSHFP records do you mean? """ See the full comment at https://github.com/freeipa/freeipa/pull/385#issuecom

[Freeipa-devel] [freeipa PR#367][edited] Remove nsslib from IPA

2017-01-11 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Author: stlaz Title: #367: Remove nsslib from IPA Action: edited Changed field: body Original value: """ This batch of patches removes NSSConnection along with the whole ipapython.nsslib from IPA and replaces it wit

[Freeipa-devel] [freeipa PR#385][comment] Generate sha256 ssh pubkey fingerprints for hosts

2017-01-11 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/385 Title: #385: Generate sha256 ssh pubkey fingerprints for hosts stlaz commented: """ @tiran Yes, exactly, this is only a UI thing. """ See the full comment at https://github.com/freeipa/freeipa/pull/385#issuecom

<    1   2   3   4   5   6   7   >