Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-09 Thread Jan Cholasta
On 10.8.2016 08:34, Pavel Vomacka wrote: On 08/10/2016 07:55 AM, Jan Cholasta wrote: On 9.8.2016 13:00, Martin Basti wrote: On 05.08.2016 16:44, Martin Basti wrote: On 02.08.2016 18:08, Pavel Vomacka wrote: On 08/02/2016 05:31 PM, Pavel Vomacka wrote: On 08/02/2016 05:27 PM, Martin

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-09 Thread Pavel Vomacka
On 08/10/2016 07:55 AM, Jan Cholasta wrote: On 9.8.2016 13:00, Martin Basti wrote: On 05.08.2016 16:44, Martin Basti wrote: On 02.08.2016 18:08, Pavel Vomacka wrote: On 08/02/2016 05:31 PM, Pavel Vomacka wrote: On 08/02/2016 05:27 PM, Martin Basti wrote: On 02.08.2016 17:12, Rob

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-09 Thread Jan Cholasta
On 9.8.2016 13:00, Martin Basti wrote: On 05.08.2016 16:44, Martin Basti wrote: On 02.08.2016 18:08, Pavel Vomacka wrote: On 08/02/2016 05:31 PM, Pavel Vomacka wrote: On 08/02/2016 05:27 PM, Martin Basti wrote: On 02.08.2016 17:12, Rob Crittenden wrote: Pavel Vomacka wrote: Hello,

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-09 Thread Martin Basti
On 05.08.2016 16:44, Martin Basti wrote: On 02.08.2016 18:08, Pavel Vomacka wrote: On 08/02/2016 05:31 PM, Pavel Vomacka wrote: On 08/02/2016 05:27 PM, Martin Basti wrote: On 02.08.2016 17:12, Rob Crittenden wrote: Pavel Vomacka wrote: Hello, please review attached patches which S

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-05 Thread Martin Basti
On 02.08.2016 18:08, Pavel Vomacka wrote: On 08/02/2016 05:31 PM, Pavel Vomacka wrote: On 08/02/2016 05:27 PM, Martin Basti wrote: On 02.08.2016 17:12, Rob Crittenden wrote: Pavel Vomacka wrote: Hello, please review attached patches which Split make lint to more targets and add jsli

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-02 Thread Pavel Vomacka
On 08/02/2016 05:31 PM, Pavel Vomacka wrote: On 08/02/2016 05:27 PM, Martin Basti wrote: On 02.08.2016 17:12, Rob Crittenden wrote: Pavel Vomacka wrote: Hello, please review attached patches which Split make lint to more targets and add jslint What's the driver to split the checks ou

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-02 Thread Rob Crittenden
Petr Spacek wrote: On 2.8.2016 17:12, Rob Crittenden wrote: Pavel Vomacka wrote: Hello, please review attached patches which Split make lint to more targets and add jslint What's the driver to split the checks out into separate targets? Most importantly, makeapi and makeaci do not need to

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-02 Thread Pavel Vomacka
On 08/02/2016 05:27 PM, Martin Basti wrote: On 02.08.2016 17:12, Rob Crittenden wrote: Pavel Vomacka wrote: Hello, please review attached patches which Split make lint to more targets and add jslint What's the driver to split the checks out into separate targets? It is called several

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-02 Thread Petr Spacek
On 2.8.2016 17:12, Rob Crittenden wrote: > Pavel Vomacka wrote: >> Hello, >> >> please review attached patches which Split make lint to more targets and >> add jslint > > What's the driver to split the checks out into separate targets? > > You are moving the makeapi and makeaci from version-updat

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-02 Thread Petr Spacek
On 2.8.2016 17:12, Rob Crittenden wrote: > Pavel Vomacka wrote: >> Hello, >> >> please review attached patches which Split make lint to more targets and >> add jslint > > What's the driver to split the checks out into separate targets? Most importantly, makeapi and makeaci do not need to be calle

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-02 Thread Martin Basti
On 02.08.2016 17:12, Rob Crittenden wrote: Pavel Vomacka wrote: Hello, please review attached patches which Split make lint to more targets and add jslint What's the driver to split the checks out into separate targets? It is called several times during build (makes build slower), and you

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-02 Thread Rob Crittenden
Pavel Vomacka wrote: Hello, please review attached patches which Split make lint to more targets and add jslint What's the driver to split the checks out into separate targets? You are moving the makeapi and makeaci from version-update to lint. They were in version-update for a reason: downs

[Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-02 Thread Pavel Vomacka
Hello, please review attached patches which Split make lint to more targets and add jslint -- Pavel^3 Vomacka From f32919a910dc98301b373a47cc72f68b1310c0ee Mon Sep 17 00:00:00 2001 From: Pavel Vomacka Date: Tue, 2 Aug 2016 16:44:10 +0200 Subject: [PATCH 1/2] Split targets in Makefile Separa