Re: [Freeipa-devel] [PATCH] 0003 Honor the default home directory in user_add

2012-02-13 Thread Simo Sorce
On Mon, 2012-02-13 at 17:11 +0100, Martin Kosek wrote: > > That was just a patch fixing default shell and home directory. What > Rob > acked was my proposal to fix params in config object to be required so > that user cannot remove the LDAP attribute. Most often we don't expect > that and crash ba

Re: [Freeipa-devel] [PATCH] 0003 Honor the default home directory in user_add

2012-02-13 Thread Martin Kosek
On Mon, 2012-02-13 at 11:01 -0500, Simo Sorce wrote: > On Mon, 2012-02-13 at 10:42 -0500, Rob Crittenden wrote: > > Martin Kosek wrote: > > > On Wed, 2012-02-08 at 08:22 -0500, Rob Crittenden wrote: > > >> Martin Kosek wrote: > > >>> On Tue, 2012-02-07 at 16:31 -0500, Rob Crittenden wrote: > >

Re: [Freeipa-devel] [PATCH] 0003 Honor the default home directory in user_add

2012-02-13 Thread Simo Sorce
On Mon, 2012-02-13 at 10:42 -0500, Rob Crittenden wrote: > Martin Kosek wrote: > > On Wed, 2012-02-08 at 08:22 -0500, Rob Crittenden wrote: > >> Martin Kosek wrote: > >>> On Tue, 2012-02-07 at 16:31 -0500, Rob Crittenden wrote: > Petr Viktorin wrote: > > On 02/07/2012 01:52 PM, Petr Viktor

Re: [Freeipa-devel] [PATCH] 0003 Honor the default home directory in user_add

2012-02-13 Thread Rob Crittenden
Martin Kosek wrote: On Wed, 2012-02-08 at 08:22 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Tue, 2012-02-07 at 16:31 -0500, Rob Crittenden wrote: Petr Viktorin wrote: On 02/07/2012 01:52 PM, Petr Viktorin wrote: Honor the default home directory base when creating a new user. Test inc

Re: [Freeipa-devel] [PATCH] 0003 Honor the default home directory in user_add

2012-02-09 Thread Martin Kosek
On Wed, 2012-02-08 at 10:11 +0100, Petr Viktorin wrote: > On 02/07/2012 10:31 PM, Rob Crittenden wrote: > > Petr Viktorin wrote: > >> On 02/07/2012 01:52 PM, Petr Viktorin wrote: > >>> Honor the default home directory base when creating a new user. Test > >>> included. I also cleaned up the way hom

Re: [Freeipa-devel] [PATCH] 0003 Honor the default home directory in user_add

2012-02-08 Thread Martin Kosek
On Wed, 2012-02-08 at 08:22 -0500, Rob Crittenden wrote: > Martin Kosek wrote: > > On Tue, 2012-02-07 at 16:31 -0500, Rob Crittenden wrote: > >> Petr Viktorin wrote: > >>> On 02/07/2012 01:52 PM, Petr Viktorin wrote: > Honor the default home directory base when creating a new user. Test >

Re: [Freeipa-devel] [PATCH] 0003 Honor the default home directory in user_add

2012-02-08 Thread Rob Crittenden
Martin Kosek wrote: On Tue, 2012-02-07 at 16:31 -0500, Rob Crittenden wrote: Petr Viktorin wrote: On 02/07/2012 01:52 PM, Petr Viktorin wrote: Honor the default home directory base when creating a new user. Test included. I also cleaned up the way home directory was created. This patch remove

Re: [Freeipa-devel] [PATCH] 0003 Honor the default home directory in user_add

2012-02-08 Thread Martin Kosek
On Tue, 2012-02-07 at 16:31 -0500, Rob Crittenden wrote: > Petr Viktorin wrote: > > On 02/07/2012 01:52 PM, Petr Viktorin wrote: > >> Honor the default home directory base when creating a new user. Test > >> included. I also cleaned up the way home directory was created. > >> > >> This patch remove

Re: [Freeipa-devel] [PATCH] 0003 Honor the default home directory in user_add

2012-02-08 Thread Petr Viktorin
On 02/07/2012 10:31 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/07/2012 01:52 PM, Petr Viktorin wrote: Honor the default home directory base when creating a new user. Test included. I also cleaned up the way home directory was created. This patch removes the default from the --homedir

Re: [Freeipa-devel] [PATCH] 0003 Honor the default home directory in user_add

2012-02-07 Thread Rob Crittenden
Petr Viktorin wrote: On 02/07/2012 01:52 PM, Petr Viktorin wrote: Honor the default home directory base when creating a new user. Test included. I also cleaned up the way home directory was created. This patch removes the default from the --homedirectory option, letting the server fill it in pr

Re: [Freeipa-devel] [PATCH] 0003 Honor the default home directory in user_add

2012-02-07 Thread Petr Viktorin
On 02/07/2012 01:52 PM, Petr Viktorin wrote: Honor the default home directory base when creating a new user. Test included. I also cleaned up the way home directory was created. This patch removes the default from the --homedirectory option, letting the server fill it in pre_callback. If I'm rea

[Freeipa-devel] [PATCH] 0003 Honor the default home directory in user_add

2012-02-07 Thread Petr Viktorin
Honor the default home directory base when creating a new user. Test included. I also cleaned up the way home directory was created. This patch removes the default from the --homedirectory option, letting the server fill it in pre_callback. If I'm reading this correctly, default_from and creat