Re: [Freeipa-devel] [PATCH 0056] Enable nsaccountlock in user.py cli

2015-10-14 Thread Gabe Alford
Alright. Let's postpone it to 4.4. Gabe On Wed, Oct 14, 2015 at 2:52 AM, Martin Basti wrote: > Sorry, we cannot push this patch because I realize that it breaks API > compatibility. > > The proper fix is add this code to find method (not tested) > > def get_options(self): > for opti

Re: [Freeipa-devel] [PATCH 0056] Enable nsaccountlock in user.py cli

2015-10-14 Thread Martin Basti
Sorry, we cannot push this patch because I realize that it breaks API compatibility. The proper fix is add this code to find method (not tested) def get_options(self): for option in super(user_find, self).get_options(): if option.name == "nsaccountlock":

Re: [Freeipa-devel] [PATCH 0056] Enable nsaccountlock in user.py cli

2015-10-13 Thread Gabe Alford
Updated patch attached. On Tue, Oct 13, 2015 at 10:59 AM, Martin Basti wrote: > > > On 13.10.2015 18:53, Gabe Alford wrote: > > Thanks Martin, > > What about adding no_create and no_update flags? > > Gabe > > Yes, that may work, also please increment minor version of API and add > ticket into co

Re: [Freeipa-devel] [PATCH 0056] Enable nsaccountlock in user.py cli

2015-10-13 Thread Martin Basti
On 13.10.2015 18:53, Gabe Alford wrote: Thanks Martin, What about adding no_create and no_update flags? Gabe Yes, that may work, also please increment minor version of API and add ticket into commit message (https://fedorahosted.org/freeipa/ticket/5366)

Re: [Freeipa-devel] [PATCH 0056] Enable nsaccountlock in user.py cli

2015-10-13 Thread Gabe Alford
Thanks Martin, What about adding no_create and no_update flags? Gabe On Tue, Oct 13, 2015 at 9:54 AM, Martin Basti wrote: > > > On 09.10.2015 19:17, Gabe Alford wrote: > > Hello, > > This patch enables nsaccountlock in user.py cli. It is very handy to be > able to search and find users with di

Re: [Freeipa-devel] [PATCH 0056] Enable nsaccountlock in user.py cli

2015-10-13 Thread Martin Basti
On 09.10.2015 19:17, Gabe Alford wrote: Hello, This patch enables nsaccountlock in user.py cli. It is very handy to be able to search and find users with disabled/enabled accounts, etc. That said, I couldn't find why it was no_option in the first place, so I am not 100% sure if it breaks so

[Freeipa-devel] [PATCH 0056] Enable nsaccountlock in user.py cli

2015-10-09 Thread Gabe Alford
Hello, This patch enables nsaccountlock in user.py cli. It is very handy to be able to search and find users with disabled/enabled accounts, etc. That said, I couldn't find why it was no_option in the first place, so I am not 100% sure if it breaks something or the reasoning behind no_option. Tha