Re: [Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

2015-12-22 Thread Martin Basti
On 15.12.2015 16:43, David Kupka wrote: On 15/12/15 16:20, Martin Kosek wrote: On 12/15/2015 07:42 AM, Jan Cholasta wrote: On 14.12.2015 16:54, Alexander Bokovoy wrote: On Mon, 14 Dec 2015, David Kupka wrote: ... We can always have both. With the new installer framework it is trivial to fo

Re: [Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

2015-12-15 Thread David Kupka
On 15/12/15 16:20, Martin Kosek wrote: On 12/15/2015 07:42 AM, Jan Cholasta wrote: On 14.12.2015 16:54, Alexander Bokovoy wrote: On Mon, 14 Dec 2015, David Kupka wrote: ... We can always have both. With the new installer framework it is trivial to fold installers like this without code duplic

Re: [Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

2015-12-15 Thread Martin Kosek
On 12/15/2015 07:42 AM, Jan Cholasta wrote: > On 14.12.2015 16:54, Alexander Bokovoy wrote: >> On Mon, 14 Dec 2015, David Kupka wrote: ... > We can always have both. With the new installer framework it is trivial to > fold > installers like this without code duplication. It is still work in progre

Re: [Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

2015-12-15 Thread Alexander Bokovoy
On Tue, 15 Dec 2015, David Kupka wrote: On 14/12/15 16:54, Alexander Bokovoy wrote: On Mon, 14 Dec 2015, David Kupka wrote: On 14/12/15 15:05, Alexander Bokovoy wrote: On Mon, 14 Dec 2015, David Kupka wrote: On 30/11/15 16:31, Martin Basti wrote: First instance of KRA should be installed onl

Re: [Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

2015-12-15 Thread Alexander Bokovoy
On Tue, 15 Dec 2015, Jan Cholasta wrote: On 14.12.2015 16:54, Alexander Bokovoy wrote: On Mon, 14 Dec 2015, David Kupka wrote: On 14/12/15 15:05, Alexander Bokovoy wrote: On Mon, 14 Dec 2015, David Kupka wrote: On 30/11/15 16:31, Martin Basti wrote: First instance of KRA should be installed

Re: [Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

2015-12-14 Thread David Kupka
On 14/12/15 16:54, Alexander Bokovoy wrote: On Mon, 14 Dec 2015, David Kupka wrote: On 14/12/15 15:05, Alexander Bokovoy wrote: On Mon, 14 Dec 2015, David Kupka wrote: On 30/11/15 16:31, Martin Basti wrote: First instance of KRA should be installed only by ipa-kra-install Patch attached.

Re: [Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

2015-12-14 Thread Jan Cholasta
On 14.12.2015 16:54, Alexander Bokovoy wrote: On Mon, 14 Dec 2015, David Kupka wrote: On 14/12/15 15:05, Alexander Bokovoy wrote: On Mon, 14 Dec 2015, David Kupka wrote: On 30/11/15 16:31, Martin Basti wrote: First instance of KRA should be installed only by ipa-kra-install Patch attached.

Re: [Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

2015-12-14 Thread Alexander Bokovoy
On Mon, 14 Dec 2015, David Kupka wrote: On 14/12/15 15:05, Alexander Bokovoy wrote: On Mon, 14 Dec 2015, David Kupka wrote: On 30/11/15 16:31, Martin Basti wrote: First instance of KRA should be installed only by ipa-kra-install Patch attached. Hi, patch works, but I don't like the appro

Re: [Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

2015-12-14 Thread David Kupka
On 14/12/15 15:05, Alexander Bokovoy wrote: On Mon, 14 Dec 2015, David Kupka wrote: On 30/11/15 16:31, Martin Basti wrote: First instance of KRA should be installed only by ipa-kra-install Patch attached. Hi, patch works, but I don't like the approach. Do we really want to remove '--setu

Re: [Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

2015-12-14 Thread Alexander Bokovoy
On Mon, 14 Dec 2015, David Kupka wrote: On 30/11/15 16:31, Martin Basti wrote: First instance of KRA should be installed only by ipa-kra-install Patch attached. Hi, patch works, but I don't like the approach. Do we really want to remove '--setup-kra' option from ipa-server-install? Why do

Re: [Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

2015-12-14 Thread David Kupka
On 30/11/15 16:31, Martin Basti wrote: First instance of KRA should be installed only by ipa-kra-install Patch attached. Hi, patch works, but I don't like the approach. Do we really want to remove '--setup-kra' option from ipa-server-install? Why do we remove '--setup-kra' while keeping '-

[Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

2015-11-30 Thread Martin Basti
First instance of KRA should be installed only by ipa-kra-install Patch attached. From 7e097902dd107e5bd1d8dbb78e17e34806da53c2 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Mon, 30 Nov 2015 15:34:31 +0100 Subject: [PATCH] Remove unused code in server installer related to KRA The first in