Re: [Freeipa-devel] Should we split up ipa-client?
On 14.1.2016 10:48, Petr Viktorin wrote: On 01/14/2016 07:55 AM, Jan Cholasta wrote: Hi, On 13.1.2016 13:03, Martin Babinsky wrote: On 01/13/2016 11:34 AM, Petr Viktorin wrote: Hello, I'm planning to port the ipa-client to Python 3, and I'm likely to end up shaking out some dusty corners of the codebase, rather than doing the minimal amount of work :) So I'd like to get your opinions before I commit significant time to this. [...] client-tools/ - man/* - *.c - *.h - all the automake stuff - current contents of ipa-install (Python scripts that go in /usr/sbin) I would rather s/client-tools/client/, as this stuff goes into the freeipa-*client* subpackage. OK. It's just that there's no admintools/ or server/ either. Putting the scripts into install/tools/ (or install/client/) is another possibility. Right. I guess we have to decide whether we want a directory layout based on the component/subpackage or not. install/tools/ works for me equally well. I'm not sure if this is what you are suggesting or not, but I would like the man page files to be in the same directory as the corresponding source code files. Do you mean not having the man/ subdirectory? Yes. (I don't insist though.) -- Jan Cholasta -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] Should we split up ipa-client?
On 01/14/2016 07:55 AM, Jan Cholasta wrote: > Hi, > > On 13.1.2016 13:03, Martin Babinsky wrote: >> On 01/13/2016 11:34 AM, Petr Viktorin wrote: >>> Hello, >>> I'm planning to port the ipa-client to Python 3, and I'm likely to end >>> up shaking out some dusty corners of the codebase, rather than doing the >>> minimal amount of work :) >>> So I'd like to get your opinions before I commit significant time to >>> this. [...] >>> client-tools/ >>> - man/* >>> - *.c >>> - *.h >>> - all the automake stuff >>> - current contents of ipa-install (Python scripts that go in /usr/sbin) > > I would rather s/client-tools/client/, as this stuff goes into the > freeipa-*client* subpackage. OK. It's just that there's no admintools/ or server/ either. Putting the scripts into install/tools/ (or install/client/) is another possibility. > I'm not sure if this is what you are suggesting or not, but I would like > the man page files to be in the same directory as the corresponding > source code files. Do you mean not having the man/ subdirectory? -- Petr Viktorin -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] Should we split up ipa-client?
Hi, On 13.1.2016 13:03, Martin Babinsky wrote: On 01/13/2016 11:34 AM, Petr Viktorin wrote: Hello, I'm planning to port the ipa-client to Python 3, and I'm likely to end up shaking out some dusty corners of the codebase, rather than doing the minimal amount of work :) So I'd like to get your opinions before I commit significant time to this. I think it would be beneficial to split ipa-client to better match both how it's put in the RPMs these days, and how the rest of IPA is organized. (And, to stop using autotools to "build" Python libraries...) The resulting structure could look like this: ipaclient/ - *.py - setup.py +1 client-tools/ - man/* - *.c - *.h - all the automake stuff - current contents of ipa-install (Python scripts that go in /usr/sbin) I would rather s/client-tools/client/, as this stuff goes into the freeipa-*client* subpackage. I'm not sure if this is what you are suggesting or not, but I would like the man page files to be in the same directory as the corresponding source code files. Removed: - ipa-client.spec.in (included in freeipa.spec.in) - NEWS (empty) - README (entirely outdated) +1 Does this look like a reasonable direction to explore? Makes sense to me, this kind of work would be needed during client installer refactoring anyway (also, using autotools for python module installation hurts my brain a lot). Honza -- Jan Cholasta -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] Should we split up ipa-client?
On 01/13/2016 11:34 AM, Petr Viktorin wrote: Hello, I'm planning to port the ipa-client to Python 3, and I'm likely to end up shaking out some dusty corners of the codebase, rather than doing the minimal amount of work :) So I'd like to get your opinions before I commit significant time to this. I think it would be beneficial to split ipa-client to better match both how it's put in the RPMs these days, and how the rest of IPA is organized. (And, to stop using autotools to "build" Python libraries...) The resulting structure could look like this: ipaclient/ - *.py - setup.py client-tools/ - man/* - *.c - *.h - all the automake stuff - current contents of ipa-install (Python scripts that go in /usr/sbin) Removed: - ipa-client.spec.in (included in freeipa.spec.in) - NEWS (empty) - README (entirely outdated) Does this look like a reasonable direction to explore? Makes sense to me, this kind of work would be needed during client installer refactoring anyway (also, using autotools for python module installation hurts my brain a lot). -- Martin^3 Babinsky -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] Should we split up ipa-client?
Hello, I'm planning to port the ipa-client to Python 3, and I'm likely to end up shaking out some dusty corners of the codebase, rather than doing the minimal amount of work :) So I'd like to get your opinions before I commit significant time to this. I think it would be beneficial to split ipa-client to better match both how it's put in the RPMs these days, and how the rest of IPA is organized. (And, to stop using autotools to "build" Python libraries...) The resulting structure could look like this: ipaclient/ - *.py - setup.py client-tools/ - man/* - *.c - *.h - all the automake stuff - current contents of ipa-install (Python scripts that go in /usr/sbin) Removed: - ipa-client.spec.in (included in freeipa.spec.in) - NEWS (empty) - README (entirely outdated) Does this look like a reasonable direction to explore? -- Petr Viktorin -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
