[Freeipa-devel] [PATCH] 297 Fixed "enroll" labels.

2011-10-25 Thread Endi Sukma Dewata
Labels using the word "enroll" (except for host enrollment) have been modified to use more relevant words. The IPA.add_dialog has been renamed into IPA.entity_adder_dialog for clarity. Ticket #1642 -- Endi S. Dewata From ae1a5d9d7c1ed811848453c080b316aa3710975c Mon Sep 17 00:00:00 2001 From: En

Re: [Freeipa-devel] [PATCH] 028 Code cleanup of HBAC, Sudo rules

2011-10-25 Thread Petr Vobornik
Comments in text. New patch not supplied yet - some topics may require further discussion. Most of the comments should be part of the 'Nesting widgets' thread. On 10/24/2011 06:29 PM, Endi Sukma Dewata wrote: On 10/24/2011 3:29 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/

Re: [Freeipa-devel] Keytab for talking to PKI CA from IPA

2011-10-25 Thread Rob Crittenden
Adam Young wrote: When setting up replication, it should not be necessary to cache any passwords, anywhere, until the replication agreemsnts are set up, and then, all caching should be using known secure mechanisms. The two main repositories we care about are the Directory Server instances manag

[Freeipa-devel] [PATCH] 1 Do lazy initializiation ipalib

2011-10-25 Thread Ondrej Hamada
https://fedorahosted.org/freeipa/ticket/1336 Lazy initialization of ipalib plugins is used under all contexts, not only when context = cli. Every loaded plugin is pre-finalized - a flag is set, which means, that the plugin needs to be finalized. Then every call of plugin's __gettattr__ checks

Re: [Freeipa-devel] [PATCH] 1 Do lazy initializiation ipalib

2011-10-25 Thread Martin Kosek
On Tue, 2011-10-25 at 15:29 +0200, Ondrej Hamada wrote: > https://fedorahosted.org/freeipa/ticket/1336 > > Lazy initialization of ipalib plugins is used under all contexts, not > only when context = cli. Every loaded plugin is pre-finalized - a flag > is set, which means, that the plugin needs t

[Freeipa-devel] [PATCH] 155 Fix ipa-managed-entries bind procedure

2011-10-25 Thread Martin Kosek
Make sure that when Directory Manager password is entered, we directly do a simple bind instead of trying binding via GSSAPI. Also capture ldap.INVALID_CREDENTIALS exception and provide nice error message than crash. https://fedorahosted.org/freeipa/ticket/1927 >From 332f96ea1e4c77d429adaad858a45

Re: [Freeipa-devel] [PATCH] 295 Fixed inconsistent required/optional attributes.

2011-10-25 Thread Petr Vobornik
On 10/24/2011 10:43 PM, Endi Sukma Dewata wrote: On 10/21/2011 6:40 AM, Petr Vobornik wrote: 1) Wouldn't be better if the asterisk has different color than the label? Visually I don't like it that much and I think it can be overlook. Attaching a proposition. I used green IPAish color because red

Re: [Freeipa-devel] [PATCH] 1 Do lazy initializiation ipalib

2011-10-25 Thread Ondrej Hamada
On 10/25/2011 04:01 PM, Martin Kosek wrote: On Tue, 2011-10-25 at 15:29 +0200, Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/1336 Lazy initialization of ipalib plugins is used under all contexts, not only when context = cli. Every loaded plugin is pre-finalized - a flag is set, w

Re: [Freeipa-devel] [PATCH] 295 Fixed inconsistent required/optional attributes.

2011-10-25 Thread Endi Sukma Dewata
On 10/25/2011 9:20 AM, Petr Vobornik wrote: ACK Pushed to master. Also proposing minor visual enhancement (see attached patch). ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redha

Re: [Freeipa-devel] [PATCH] 296 Removed HBAC deny rule warning.

2011-10-25 Thread Petr Vobornik
On 10/25/2011 02:01 AM, Endi Sukma Dewata wrote: The HBAC deny rule is no longer supported so it's no longer necessary to show the warning. Ticket #1444 Just a minor things: 1) Some references remained in testing data: hbacrule_find.json, hbacrule_show.json. Anyway these don't do any harm.

[Freeipa-devel] [PATCH] 0030 Quote worker option

2011-10-25 Thread Alexander Bokovoy
https://fedorahosted.org/freeipa/ticket/2023 -- / Alexander Bokovoy >From 29eb102e9319eff837d71e4da6ad45796f3e7868 Mon Sep 17 00:00:00 2001 From: Alexander Bokovoy Date: Tue, 25 Oct 2011 18:41:32 +0300 Subject: [PATCH] Quote multiple workers option https://fedorahosted.org/freeipa/ticket/2023 -

Re: [Freeipa-devel] [PATCH] 0030 Quote worker option

2011-10-25 Thread Martin Kosek
On Tue, 2011-10-25 at 18:44 +0300, Alexander Bokovoy wrote: > https://fedorahosted.org/freeipa/ticket/2023 > ACK. Pushed to master, ipa-2-1. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa

Re: [Freeipa-devel] [PATCH] 028 Code cleanup of HBAC, Sudo rules

2011-10-25 Thread Endi Sukma Dewata
On 10/25/2011 7:49 AM, Petr Vobornik wrote: 2. The set_facet() is added to widget. I don't think we want to make widget dependent on facet. The facet so far is only used by IPA.sudo.enable_widget. In IPA.sudo.options_section the facet object is passed as a parameter in spec. Are you saying tha

Re: [Freeipa-devel] [PATCH] 136 Fix ipa-managed-entries password option long form

2011-10-25 Thread Rob Crittenden
Martin Kosek wrote: https://fedorahosted.org/freeipa/ticket/1913 ACK ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 151 Add --zonemgr validator

2011-10-25 Thread Rob Crittenden
Martin Kosek wrote: On Mon, 2011-10-24 at 17:08 +0200, Martin Kosek wrote: On Mon, 2011-10-24 at 09:02 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Fri, 2011-10-21 at 11:31 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Fri, 2011-10-14 at 14:11 -0400, Rob Crittenden wrote: Marti

Re: [Freeipa-devel] [PATCH] 296 Removed HBAC deny rule warning.

2011-10-25 Thread Endi Sukma Dewata
On 10/25/2011 10:40 AM, Petr Vobornik wrote: 1) Some references remained in testing data: hbacrule_find.json, hbacrule_show.json. Anyway these don't do any harm. Fixed. 2) Remaining string in internal.py: hbacrule.deny (couldn't find any usage). The hbacrule.allow isn't used either. Fixed i

[Freeipa-devel] [PATCH] 298 Fixed host Enrolled column.

2011-10-25 Thread Endi Sukma Dewata
The Enrolled column in the host search page has been added back to show the host enrollment status based on has_keytab attribute. Ticket #2020 -- Endi S. Dewata From 05c85f889e1f58716fd6368451bdc8c9a22afb33 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Tue, 25 Oct 2011 14:25:31 -0500 Subj

Re: [Freeipa-devel] [PATCH] 1 Do lazy initializiation ipalib

2011-10-25 Thread Rob Crittenden
Ondrej Hamada wrote: On 10/25/2011 04:01 PM, Martin Kosek wrote: On Tue, 2011-10-25 at 15:29 +0200, Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/1336 Lazy initialization of ipalib plugins is used under all contexts, not only when context = cli. Every loaded plugin is pre-finali

[Freeipa-devel] ipalib vs. ipapython?

2011-10-25 Thread John Dennis
Usually when I look at a source code directory layout it's fairly obvious what belongs in each directory. I'll be honest, I've never quite understood the role of ipapython vs. ipalib. From time to time I have to do some code refactoring, especially in the context of introducing common code mean

Re: [Freeipa-devel] ipalib vs. ipapython?

2011-10-25 Thread Martin Kosek
On Tue, 2011-10-25 at 17:24 -0400, John Dennis wrote: > Usually when I look at a source code directory layout it's fairly > obvious what belongs in each directory. I'll be honest, I've never quite > understood the role of ipapython vs. ipalib. From time to time I have to > do some code refactori

Re: [Freeipa-devel] [PATCH] 151 Add --zonemgr validator

2011-10-25 Thread Martin Kosek
On Tue, 2011-10-25 at 15:57 -0400, Rob Crittenden wrote: > Martin Kosek wrote: > > On Mon, 2011-10-24 at 17:08 +0200, Martin Kosek wrote: > >> On Mon, 2011-10-24 at 09:02 -0400, Rob Crittenden wrote: > >>> Martin Kosek wrote: > On Fri, 2011-10-21 at 11:31 -0400, Rob Crittenden wrote: > > M

Re: [Freeipa-devel] [PATCH] 136 Fix ipa-managed-entries password option long form

2011-10-25 Thread Martin Kosek
On Tue, 2011-10-25 at 15:58 -0400, Rob Crittenden wrote: > Martin Kosek wrote: > > https://fedorahosted.org/freeipa/ticket/1913 > > ACK > Pushed to master, ipa-2-1. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com