Re: [Freeipa-devel] [PATCH] 0021 Add CLI tests

2012-03-28 Thread Martin Kosek
On Tue, 2012-03-27 at 19:02 +0200, Petr Viktorin wrote: > Updated with a regression test for > https://fedorahosted.org/freeipa/ticket/2581 (Unable to delete all sshfp > records interactively) which Martin fixed recently. > > Thank's for adding a specific test for this I see 2 issues with this

Re: [Freeipa-devel] [PATCH] 0021 Add CLI tests

2012-03-28 Thread Petr Viktorin
On 03/28/2012 09:11 AM, Martin Kosek wrote: On Tue, 2012-03-27 at 19:02 +0200, Petr Viktorin wrote: Updated with a regression test for https://fedorahosted.org/freeipa/ticket/2581 (Unable to delete all sshfp records interactively) which Martin fixed recently. Thank's for adding a specific te

Re: [Freeipa-devel] [PATCHES] Improve framework parameter validation

2012-03-28 Thread Jan Cholasta
On 27.3.2012 17:41, Martin Kosek wrote: On Tue, 2012-03-27 at 16:42 +0200, Martin Kosek wrote: On Tue, 2012-03-27 at 16:30 +0200, Jan Cholasta wrote: On 27.3.2012 16:00, Martin Kosek wrote: On Thu, 2012-03-15 at 14:57 +0100, Jan Cholasta wrote: On 15.3.2012 14:20, Petr Viktorin wrote: On 03/

Re: [Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-03-28 Thread Petr Viktorin
On 03/27/2012 10:31 PM, John Dennis wrote: On 03/27/2012 01:57 PM, Petr Viktorin wrote: Seeing this, I definitely recommend putting po_file_iterate in an importable package. Of course I considered that. Clearly not any existing top level directory in the tree, those are reserved for what we in

[Freeipa-devel] [PATCH] 0032 Move DNS test skipping to class setup

2012-03-28 Thread Petr Viktorin
Currently, each DNS test case first checks if DNS is configured by creating and deleting a test zone. This takes quite a lot of time. This patch moves the check to the setUpClass method, so the check is only done once for all the tests. On my VM, this makes the DNS plugin tests 50% faster, sa

Re: [Freeipa-devel] [PATCH] 490 Fix s4u2proxy handling when a MS-PAC is available

2012-03-28 Thread Sumit Bose
On Tue, Mar 27, 2012 at 03:17:06PM -0400, Simo Sorce wrote: > This patch fixes #2504, the logic to choose the client principal to use > was basically reversed, and we ended up using the wrong principal to > verify the PAC owner. > > This patch fixes it. Tested and s4u2proxy keeps working both with

Re: [Freeipa-devel] [PATCHES] Improve framework parameter validation

2012-03-28 Thread Martin Kosek
On Wed, 2012-03-28 at 10:39 +0200, Jan Cholasta wrote: > On 27.3.2012 17:41, Martin Kosek wrote: > > On Tue, 2012-03-27 at 16:42 +0200, Martin Kosek wrote: > >> On Tue, 2012-03-27 at 16:30 +0200, Jan Cholasta wrote: > >>> On 27.3.2012 16:00, Martin Kosek wrote: > On Thu, 2012-03-15 at 14:57 +0

Re: [Freeipa-devel] [PATCH] 0021 Add CLI tests

2012-03-28 Thread Martin Kosek
On Wed, 2012-03-28 at 10:19 +0200, Petr Viktorin wrote: > On 03/28/2012 09:11 AM, Martin Kosek wrote: > > On Tue, 2012-03-27 at 19:02 +0200, Petr Viktorin wrote: > >> Updated with a regression test for > >> https://fedorahosted.org/freeipa/ticket/2581 (Unable to delete all sshfp > >> records intera

Re: [Freeipa-devel] [PATCH] 239 Tolerate UDP port failures in conncheck

2012-03-28 Thread Rob Crittenden
Martin Kosek wrote: UDP port checks in ipa-replica-conncheck are too strict. The entire conncheck fails when UDP ports cannot be verified as open. However, UDP protocol is unrealiable by its nature and the port can also not be checked if there is an application already bound to it. This can happe

Re: [Freeipa-devel] [PATCH] 16 Netgroup nisdomain and hosts validation

2012-03-28 Thread Martin Kosek
On Tue, 2012-03-27 at 17:56 +0200, Ondrej Hamada wrote: > On 03/27/2012 01:57 PM, Martin Kosek wrote: > > On Fri, 2012-03-23 at 23:10 +0100, Ondrej Hamada wrote: > >> On 03/15/2012 08:13 AM, Martin Kosek wrote: > >>> On Wed, 2012-03-14 at 16:54 +0100, Ondrej Hamada wrote: > On 03/09/2012 04:34

Re: [Freeipa-devel] [PATCH] 0022 Use ipauniqueid for the RDN of sudo commands (rebased)

2012-03-28 Thread Petr Viktorin
Earlier, someone (I think Alexander?) mentioned off-list that since the sudocmd attribute is case-sensitive, it should be compared as case-sensitive when used in the DN, so this is a directory server bug. I found now that ipalib.dn.AVA.__eq__'s docstring says: The value comparison is also c

[Freeipa-devel] web ui error

2012-03-28 Thread Michael Gregg
I am trying to use the webui on a ipa machine I have here and I seem to be unable to make it work properly. I load a browser on the machine and head to the webui, in this case https://ipaqavmc.testrelm.com/ipa/ui I've kinited as admin, and I have run through the browser setup as per the in

Re: [Freeipa-devel] web ui error

2012-03-28 Thread Rob Crittenden
Michael Gregg wrote: I am trying to use the webui on a ipa machine I have here and I seem to be unable to make it work properly. I load a browser on the machine and head to the webui, in this case https://ipaqavmc.testrelm.com/ipa/ui I've kinited as admin, and I have run through the browser se

Re: [Freeipa-devel] web ui error

2012-03-28 Thread John Dennis
On 03/28/2012 03:12 PM, Michael Gregg wrote: I am trying to use the webui on a ipa machine I have here and I seem to be unable to make it work properly. I load a browser on the machine and head to the webui, in this case https://ipaqavmc.testrelm.com/ipa/ui I've kinited as admin, and I have ru

Re: [Freeipa-devel] web ui error

2012-03-28 Thread Michael Gregg
On 03/28/2012 12:19 PM, John Dennis wrote: On 03/28/2012 03:12 PM, Michael Gregg wrote: I am trying to use the webui on a ipa machine I have here and I seem to be unable to make it work properly. I load a browser on the machine and head to the webui, in this case https://ipaqavmc.testrelm.com/

Re: [Freeipa-devel] [PATCH] 993 disable UPG for migration

2012-03-28 Thread Rob Crittenden
Martin Kosek wrote: On Thu, 2012-03-22 at 15:21 -0400, Rob Crittenden wrote: We don't want to create private groups automatically for migrated users, there could be namespace overlap (and race conditions prevent us from trying to check in advance). Check the sanity of groups in general, warn if

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-03-28 Thread Rob Crittenden
Jan Cholasta wrote: On 29.2.2012 15:45, Rob Crittenden wrote: Jan Cholasta wrote: On 28.2.2012 18:58, Rob Crittenden wrote: Jan Cholasta wrote: On 28.2.2012 18:02, Petr Viktorin wrote: On 02/28/2012 04:45 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/28/2012 04:02 AM, Rob Crittenden