Re: [Freeipa-devel] [PATCH] 248 Raise proper exception when LDAP limits are exceeded

2012-04-17 Thread Martin Kosek
On Mon, 2012-04-16 at 13:51 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Jan Cholasta wrote: On 10.4.2012 10:57, Martin Kosek wrote: Few test hints are attached to the ticket. --- ldap2 plugin returns NotFound error for find_entries/get_entry queries when the server did not

[Freeipa-devel] [PATCH] 251 Fix DNS and permissions unit tests

2012-04-17 Thread Martin Kosek
Amend unit tests to match the latest changes in DNS (tickets 2627, 2628) and hardened exception error message checks. From 29f0420f5a1c57ffe88ca92548736bd6ce0b1215 Mon Sep 17 00:00:00 2001 From: Martin Kosek mko...@redhat.com Date: Tue, 17 Apr 2012 10:26:20 +0200 Subject: [PATCH] Fix DNS and

[Freeipa-devel] [PATCH] 121 User is notified that password needs to be reset in, forms-based login

2012-04-17 Thread Petr Vobornik
This solution depends on Rob's patch #1006-2 Forms-based login procedure detects if 401 unauthorized message contains 'Expired Password' message. If so it displays an error message that user needs to reset his password. https://fedorahosted.org/freeipa/ticket/2608 -- Petr Vobornik From

Re: [Freeipa-devel] [PATCH] 1007 remove all state when uninstalling

2012-04-17 Thread Martin Kosek
On Mon, 2012-04-16 at 17:28 -0400, Rob Crittenden wrote: We no longer use the running state when uninstalling DS instances but we need to pull it in case it is there in an upgraded instance. rob ACK. Pushed to master, ipa-2-2. I added a clear reproduction steps to the linked Bugzilla.

Re: [Freeipa-devel] [PATCH] 251 Fix DNS and permissions unit tests

2012-04-17 Thread Petr Viktorin
On 04/17/2012 10:36 AM, Martin Kosek wrote: Amend unit tests to match the latest changes in DNS (tickets 2627, 2628) and hardened exception error message checks. ACK -- PetrĀ³ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 251 Fix DNS and permissions unit tests

2012-04-17 Thread Martin Kosek
On Tue, 2012-04-17 at 14:02 +0200, Petr Viktorin wrote: On 04/17/2012 10:36 AM, Martin Kosek wrote: Amend unit tests to match the latest changes in DNS (tickets 2627, 2628) and hardened exception error message checks. ACK Pushed to master, ipa-2-2. Martin

Re: [Freeipa-devel] More types of replica in FreeIPA

2012-04-17 Thread Simo Sorce
On Tue, 2012-04-17 at 01:13 +0200, Ondrej Hamada wrote: Sorry for inactivity, I was struggling with a lot of school stuff. I've summed up the main goals, do you agree on them or should I add/remove any? GOALS === Create Hub and Consumer

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-17 Thread Petr Viktorin
On 04/17/2012 12:12 AM, Rob Crittenden wrote: John Dennis wrote: On 04/16/2012 04:15 PM, Rob Crittenden wrote: John Dennis wrote: On 04/16/2012 01:31 PM, Rob Crittenden wrote: John Dennis wrote: On 04/13/2012 06:25 AM, Petr Viktorin wrote: When the utility sets logging to console, the

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-17 Thread John Dennis
There have been so many versions of the patch and various comments attached to it I'm afraid I'm still trying to wrap my head around what the actual problem is we're trying to solve, until I have that understanding I can't evaluate the proposed solution. Could you please state simply what the

Re: [Freeipa-devel] [PATCH] 1006 detect expired passwords in forms login

2012-04-17 Thread Rob Crittenden
Martin Kosek wrote: On Mon, 2012-04-16 at 09:34 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Petr Vobornik wrote: On 04/13/2012 09:28 PM, Rob Crittenden wrote: When doing a forms-based login there is no notification that a password needs to be reset. We don't currently provide a

Re: [Freeipa-devel] [PATCH] 20 Fix empty external member processing

2012-04-17 Thread Martin Kosek
On Tue, 2012-04-03 at 15:22 +0200, Ondrej Hamada wrote: On 04/03/2012 12:22 PM, Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2447 Validation of external member was failing for empty strings because of wrong condition.

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-17 Thread Petr Viktorin
On 04/17/2012 04:12 PM, John Dennis wrote: There have been so many versions of the patch and various comments attached to it I'm afraid I'm still trying to wrap my head around what the actual problem is we're trying to solve, until I have that understanding I can't evaluate the proposed

Re: [Freeipa-devel] [PATCH] 121 User is notified that password needs to be reset in, forms-based login

2012-04-17 Thread Petr Vobornik
Updated patch attached. It's modified according to Rob's patch #1006-3 which uses 'X-rejection-reason' to notify expired password. On 04/17/2012 11:17 AM, Petr Vobornik wrote: This solution depends on Rob's patch #1006-2 Forms-based login procedure detects if 401 unauthorized message contains

Re: [Freeipa-devel] [PATCH] 1006 detect expired passwords in forms login

2012-04-17 Thread Martin Kosek
On Tue, 2012-04-17 at 10:13 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2012-04-16 at 09:34 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Petr Vobornik wrote: On 04/13/2012 09:28 PM, Rob Crittenden wrote: When doing a forms-based login there is no notification that a

[Freeipa-devel] DNS zone serial number updates [#2554]

2012-04-17 Thread Petr Spacek
Hello, there is IPA ticket #2554 DNS zone serial number is not updated [1], which is required by RFE Support zone transfers in bind-dyndb-ldap [2]. I think we need to discuss next steps with this issue: Basic support for zone transfers is already done in bind-dyndb-ldap. We need second part

Re: [Freeipa-devel] DNS zone serial number updates [#2554]

2012-04-17 Thread Simo Sorce
On Tue, 2012-04-17 at 17:49 +0200, Petr Spacek wrote: Hello, there is IPA ticket #2554 DNS zone serial number is not updated [1], which is required by RFE Support zone transfers in bind-dyndb-ldap [2]. I think we need to discuss next steps with this issue: Basic support for zone

[Freeipa-devel] [PATCH] 122 Added permission field to delegation

2012-04-17 Thread Petr Vobornik
Permission field is missing in delegation so it can't be set/modified. It was added to delegation details facet and adder dialog. The field is using checkboxes instead of multivalued textbox because it can have only two effective values: 'read' and 'write'.

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-17 Thread John Dennis
Thank you for the explanation Petr, it's very much appreciated. I do have a problem with this patch and I'm inclined to NAK it, but I'm open to discussion. Here's my thoughts, if I've made mistakes in my reasoning please point them out. The fundamental problem is many of our command line

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-17 Thread Petr Viktorin
On 04/17/2012 06:46 PM, John Dennis wrote: Thank you for the explanation Petr, it's very much appreciated. I do have a problem with this patch and I'm inclined to NAK it, but I'm open to discussion. Here's my thoughts, if I've made mistakes in my reasoning please point them out. The

[Freeipa-devel] [PATCH] 252 Do not fail migration because of duplicate groups

2012-04-17 Thread Martin Kosek
When 2 groups in a remote LDAP server share the same GID number, the migration may fail entirely with incomprehensible message. This should not be taken as unrecoverable error - GID number check is just a sanity check, a warning is enough. This patch also makes sure that GID check warnings include

Re: [Freeipa-devel] [PATCH] 1006 detect expired passwords in forms login

2012-04-17 Thread Rob Crittenden
Martin Kosek wrote: On Tue, 2012-04-17 at 10:13 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2012-04-16 at 09:34 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Petr Vobornik wrote: On 04/13/2012 09:28 PM, Rob Crittenden wrote: When doing a forms-based login there is no

Re: [Freeipa-devel] [PATCH] 121 User is notified that password needs to be reset in, forms-based login

2012-04-17 Thread Rob Crittenden
Petr Vobornik wrote: Updated patch attached. It's modified according to Rob's patch #1006-3 which uses 'X-rejection-reason' to notify expired password. ACK In patch 1006 it was suggested to use X-IPA-Rejection-Reason instead. Updated this patch and pushed to master and ipa-2-2 rob On

Re: [Freeipa-devel] [PATCH 73] don't append basedn to container if it is included

2012-04-17 Thread Rob Crittenden
ACK, pushed to master and ipa-2-2 rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] Pushed one-liner to silence coverity

2012-04-17 Thread Simo Sorce
http://git.fedorahosted.org/git/?p=freeipa.git;a=commit;h=adf16a9b1c52ea8ee1e9989b99ab7da32adddf38 Was ticket #2634 Simo. -- Simo Sorce * Red Hat, Inc * New York ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 248 Raise proper exception when LDAP limits are exceeded

2012-04-17 Thread Rob Crittenden
Martin Kosek wrote: On Mon, 2012-04-16 at 13:51 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Jan Cholasta wrote: On 10.4.2012 10:57, Martin Kosek wrote: Few test hints are attached to the ticket. --- ldap2 plugin returns NotFound error for find_entries/get_entry queries when the

Re: [Freeipa-devel] [PATCH] 252 Do not fail migration because of duplicate groups

2012-04-17 Thread Rob Crittenden
Martin Kosek wrote: When 2 groups in a remote LDAP server share the same GID number, the migration may fail entirely with incomprehensible message. This should not be taken as unrecoverable error - GID number check is just a sanity check, a warning is enough. This patch also makes sure that GID

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-17 Thread Dmitri Pal
On 04/17/2012 01:13 PM, Petr Viktorin wrote: On 04/17/2012 06:46 PM, John Dennis wrote: Thank you for the explanation Petr, it's very much appreciated. I do have a problem with this patch and I'm inclined to NAK it, but I'm open to discussion. Here's my thoughts, if I've made mistakes in my

Re: [Freeipa-devel] DNS zone serial number updates [#2554]

2012-04-17 Thread Dmitri Pal
On 04/17/2012 12:13 PM, Simo Sorce wrote: On Tue, 2012-04-17 at 17:49 +0200, Petr Spacek wrote: Hello, there is IPA ticket #2554 DNS zone serial number is not updated [1], which is required by RFE Support zone transfers in bind-dyndb-ldap [2]. I think we need to discuss next steps with