Re: [Freeipa-devel] [PATCH] 309 Fix addattr internal error

2012-09-14 Thread Martin Kosek
On 09/13/2012 09:19 PM, Rob Crittenden wrote: Martin Kosek wrote: When ADD command is being executed and a single-value object attribute is being set with both option and addattr IPA ends up in an internal error. Make better value sanitizing job in this case and let IPA throw a

Re: [Freeipa-devel] [PATCH] 0077 Check direct/reverse hostname/address resolution in ipa-replica-install

2012-09-14 Thread Martin Kosek
On 09/13/2012 10:35 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 09/11/2012 11:05 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 09/04/2012 07:44 PM, Rob Crittenden wrote: Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2845 Shouldn't this also call verify_fqdn() on

Re: [Freeipa-devel] [PATCH] 305-308 Expand Referential Integrity checks

2012-09-14 Thread Martin Kosek
On 09/13/2012 06:40 PM, Rob Crittenden wrote: Martin Kosek wrote: To test, add sudo commands, hosts or users to a sudo rule or hbac rule and then rename or delete the linked object. After the update, the links should be amended. - Many attributes in IPA (e.g. manager, memberuser,

[Freeipa-devel] [PATCH 0062] Prevent memory read outside allocated space in str_alloc()

2012-09-14 Thread Petr Spacek
Hello, Prevent memory read outside allocated space in str_alloc(). Found by Valgrind during nsupdate stress test. -- Petr^2 Spacek From c53ec9cf2cc22e29630767b6b2259d145192ff62 Mon Sep 17 00:00:00 2001 From: Petr Spacek pspa...@redhat.com Date: Fri, 14 Sep 2012 10:48:04 +0200 Subject: [PATCH]

Re: [Freeipa-devel] [PATCH] 0079 Update the pot file (translation source)

2012-09-14 Thread Petr Viktorin
On 09/13/2012 09:21 PM, Rob Crittenden wrote: Petr Viktorin wrote: Transifex is watching our repository, so pushing this patch will update the translations on the site. Okay, I lied. Some time ago (before I joined), Transifex changed its watching mechanism from VCS pulls to URL polling. I

Re: [Freeipa-devel] [PATCH] 1050 prevent replica orphans

2012-09-14 Thread Martin Kosek
On 09/10/2012 08:34 PM, Rob Crittenden wrote: Martin Kosek wrote: On Thu, 2012-09-06 at 17:22 -0400, Rob Crittenden wrote: Martin Kosek wrote: On 08/31/2012 07:40 PM, Rob Crittenden wrote: Rob Crittenden wrote: It was possible use ipa-replica-manage connect/disconnect/del to end up

Re: [Freeipa-devel] [PATCH] 1031 run cleanallruv task

2012-09-14 Thread Martin Kosek
On 09/06/2012 11:17 PM, Rob Crittenden wrote: Martin Kosek wrote: On 09/06/2012 05:55 PM, Rob Crittenden wrote: Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek wrote: On 09/05/2012 08:06 PM, Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek wrote: On 07/05/2012 08:39 PM,

[Freeipa-devel] [PATCH] 0081 Only stop the main DS instance when upgrading it

2012-09-14 Thread Petr Viktorin
This fixes a 2.2→3.0 upgrade bug found while testing the Dogtag 10 work. See commit or ticket for details. https://fedorahosted.org/freeipa/ticket/3083 I also suspect that waiting for ports is not a good way to check if the CMS is fully initialized, but I don't know of a better way. If you

Re: [Freeipa-devel] [PATCH] Patch to allow IPA to work with dogtag 10 on f18

2012-09-14 Thread Petr Viktorin
On 09/11/2012 09:20 PM, Rob Crittenden wrote: Rob Crittenden wrote: Petr Viktorin wrote: On 09/11/2012 04:38 PM, Rob Crittenden wrote: Ade Lee wrote: On Tue, 2012-09-11 at 08:59 -0400, Rob Crittenden wrote: Petr Viktorin wrote: On 09/11/2012 04:04 AM, Ade Lee wrote: On Mon, 2012-09-10 at

Re: [Freeipa-devel] [PATCH 0055] Fix race condition in addrdataset() during SOA serial update

2012-09-14 Thread Adam Tkac
On Fri, Sep 07, 2012 at 01:05:37PM +0200, Petr Spacek wrote: Hello, Fix race condition in addrdataset() during SOA serial update. https://fedorahosted.org/bind-dyndb-ldap/ticket/89 Good catch, thanks. Ack A From 5e8bc8f943345d8d92900474905288939958dcd8 Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH 0056] Fix crash caused by zone deletion vs. SOA serial increment race condition

2012-09-14 Thread Adam Tkac
On Wed, Sep 12, 2012 at 12:33:47PM +0200, Petr Spacek wrote: Hello, The patch fixes crash caused by stupid bug in logging code. Ack. From 01aa00f9ba4feac9f97b34b81c3697b2b7f8122f Mon Sep 17 00:00:00 2001 From: Petr Spacek pspa...@redhat.com Date: Fri, 7 Sep 2012 16:21:27 +0200 Subject:

Re: [Freeipa-devel] [PATCH] 0081 Only stop the main DS instance when upgrading it

2012-09-14 Thread Simo Sorce
On Fri, 2012-09-14 at 14:53 +0200, Petr Viktorin wrote: This fixes a 2.2→3.0 upgrade bug found while testing the Dogtag 10 work. See commit or ticket for details. https://fedorahosted.org/freeipa/ticket/3083 I also suspect that waiting for ports is not a good way to check if the CMS

Re: [Freeipa-devel] [PATCH] 309 Fix addattr internal error

2012-09-14 Thread Jan Cholasta
Dne 14.9.2012 08:40, Martin Kosek napsal(a): On 09/13/2012 09:19 PM, Rob Crittenden wrote: Martin Kosek wrote: When ADD command is being executed and a single-value object attribute is being set with both option and addattr IPA ends up in an internal error. Make better value sanitizing job in

Re: [Freeipa-devel] [PATCH 0056] Fix crash caused by zone deletion vs. SOA serial increment race condition

2012-09-14 Thread Petr Spacek
On 09/14/2012 03:10 PM, Adam Tkac wrote: On Wed, Sep 12, 2012 at 12:33:47PM +0200, Petr Spacek wrote: Hello, The patch fixes crash caused by stupid bug in logging code. Ack. Pushed to master: https://fedorahosted.org/bind-dyndb-ldap/changeset/da558d15329f6e2308ad69118545363b9adbd0d1

Re: [Freeipa-devel] [PATCH 0055] Fix race condition in addrdataset() during SOA serial update

2012-09-14 Thread Petr Spacek
On 09/14/2012 03:07 PM, Adam Tkac wrote: On Fri, Sep 07, 2012 at 01:05:37PM +0200, Petr Spacek wrote: Hello, Fix race condition in addrdataset() during SOA serial update. https://fedorahosted.org/bind-dyndb-ldap/ticket/89 Good catch, thanks. Ack A Pushed to master:

Re: [Freeipa-devel] [PATCH 0057] Fix LDAP operation selection logic in ldap_modify_do()

2012-09-14 Thread Adam Tkac
On Wed, Sep 12, 2012 at 12:35:25PM +0200, Petr Spacek wrote: Hello, There is a fix for LDAP operation selection logic in ldap_modify_do(). Each operation code in LDAPMod structure can be ORed with LDAP_MOD_BVALUES. Ack From ab11e62ec2496f2c7245c4d8d80c2fd189b68aa9 Mon Sep 17

Re: [Freeipa-devel] [PATCH 0058] Improve persistent search logging

2012-09-14 Thread Adam Tkac
On Wed, Sep 12, 2012 at 12:36:38PM +0200, Petr Spacek wrote: Hello, this patch adds result codes to error messages in persistent search code. Ack. From f6cb53278d8f39ac6da4fb8e26820f6ee02ae6e3 Mon Sep 17 00:00:00 2001 From: Petr Spacek pspa...@redhat.com Date: Wed, 12 Sep 2012 12:27:51

Re: [Freeipa-devel] [PATCH 0059] Fix potential crash after free(uninitialized variable)

2012-09-14 Thread Adam Tkac
On Wed, Sep 12, 2012 at 01:07:56PM +0200, Petr Spacek wrote: Hello, This patch fixes potential crash after free(uninitialized variable) in persistent search code. Coverity CID 13088. Ack From 3197b4ace3e852495bf4f9fdc32192459160027c Mon Sep 17 00:00:00 2001 From: Petr Spacek

Re: [Freeipa-devel] [PATCH 0057] Fix LDAP operation selection logic in ldap_modify_do()

2012-09-14 Thread Petr Spacek
On 09/14/2012 03:23 PM, Adam Tkac wrote: On Wed, Sep 12, 2012 at 12:35:25PM +0200, Petr Spacek wrote: Hello, There is a fix for LDAP operation selection logic in ldap_modify_do(). Each operation code in LDAPMod structure can be ORed with LDAP_MOD_BVALUES. Ack Pushed to

Re: [Freeipa-devel] [PATCH 0058] Improve persistent search logging

2012-09-14 Thread Petr Spacek
On 09/14/2012 03:24 PM, Adam Tkac wrote: On Wed, Sep 12, 2012 at 12:36:38PM +0200, Petr Spacek wrote: Hello, this patch adds result codes to error messages in persistent search code. Ack. Pushed to master:

Re: [Freeipa-devel] [PATCH 0059] Fix potential crash after free(uninitialized variable)

2012-09-14 Thread Petr Spacek
On 09/14/2012 03:34 PM, Adam Tkac wrote: On Wed, Sep 12, 2012 at 01:07:56PM +0200, Petr Spacek wrote: Hello, This patch fixes potential crash after free(uninitialized variable) in persistent search code. Coverity CID 13088. Ack Pushed to master:

Re: [Freeipa-devel] [PATCH] 0081 Only stop the main DS instance when upgrading it

2012-09-14 Thread Petr Viktorin
On 09/14/2012 03:12 PM, Simo Sorce wrote: On Fri, 2012-09-14 at 14:53 +0200, Petr Viktorin wrote: This fixes a 2.2→3.0 upgrade bug found while testing the Dogtag 10 work. See commit or ticket for details. https://fedorahosted.org/freeipa/ticket/3083 I also suspect that waiting for ports is

[Freeipa-devel] [PATCH] ipasam: Fixes build with samba4 rc1

2012-09-14 Thread Sumit Bose
Hi, in samba4 rc1 there is an API change which we have to adopt in ipasam. This patch updates ipasam and unbreaks the build with samba4 rc1. bye, Sumit From 4e39eb306da08b29f694b9ff44ccb53865e33d92 Mon Sep 17 00:00:00 2001 From: Sumit Bose sb...@redhat.com Date: Fri, 14 Sep 2012 14:14:23 +0200

Re: [Freeipa-devel] [PATCH] ipasam: Fixes build with samba4 rc1

2012-09-14 Thread Simo Sorce
On Fri, 2012-09-14 at 16:43 +0200, Sumit Bose wrote: Hi, in samba4 rc1 there is an API change which we have to adopt in ipasam. This patch updates ipasam and unbreaks the build with samba4 rc1. Ack. Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [Freeipa-devel] [PATCH] ipasam: Fixes build with samba4 rc1

2012-09-14 Thread Martin Kosek
On 09/14/2012 04:49 PM, Simo Sorce wrote: On Fri, 2012-09-14 at 16:43 +0200, Sumit Bose wrote: Hi, in samba4 rc1 there is an API change which we have to adopt in ipasam. This patch updates ipasam and unbreaks the build with samba4 rc1. Ack. Simo. Pushed to master, ipa-3-0. Martin

Re: [Freeipa-devel] [PATCH] 0081 Only stop the main DS instance when upgrading it

2012-09-14 Thread Petr Viktorin
On 09/14/2012 04:12 PM, Petr Viktorin wrote: On 09/14/2012 03:12 PM, Simo Sorce wrote: On Fri, 2012-09-14 at 14:53 +0200, Petr Viktorin wrote: This fixes a 2.2→3.0 upgrade bug found while testing the Dogtag 10 work. See commit or ticket for details.

Re: [Freeipa-devel] [PATCH] 1056 sudorule cn uniqueness

2012-09-14 Thread Rob Crittenden
Rob Crittenden wrote: A sudorule dn uses ipaUniqueId as the cn so we have to do a search to ensure uniqueness. This leaves us vulnerable to a race. Configure the uniqueness plugin to ensure no dups. rob Add missing attribute to the fresh install ldif. I had already fixed this in the update,

Re: [Freeipa-devel] [PATCH] 0081 Only stop the main DS instance when upgrading it

2012-09-14 Thread Martin Kosek
On 09/14/2012 04:53 PM, Petr Viktorin wrote: On 09/14/2012 04:12 PM, Petr Viktorin wrote: On 09/14/2012 03:12 PM, Simo Sorce wrote: On Fri, 2012-09-14 at 14:53 +0200, Petr Viktorin wrote: This fixes a 2.2→3.0 upgrade bug found while testing the Dogtag 10 work. See commit or ticket for

Re: [Freeipa-devel] [PATCH] 1050 prevent replica orphans

2012-09-14 Thread Rob Crittenden
Martin Kosek wrote: On 09/10/2012 08:34 PM, Rob Crittenden wrote: Martin Kosek wrote: On Thu, 2012-09-06 at 17:22 -0400, Rob Crittenden wrote: Martin Kosek wrote: On 08/31/2012 07:40 PM, Rob Crittenden wrote: Rob Crittenden wrote: It was possible use ipa-replica-manage

Re: [Freeipa-devel] [PATCH] 1031 run cleanallruv task

2012-09-14 Thread Rob Crittenden
Martin Kosek wrote: On 09/06/2012 11:17 PM, Rob Crittenden wrote: Martin Kosek wrote: On 09/06/2012 05:55 PM, Rob Crittenden wrote: Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek wrote: On 09/05/2012 08:06 PM, Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek wrote: On

Re: [Freeipa-devel] [PATCH] 0079 Update the pot file (translation source)

2012-09-14 Thread Jérôme Fenal
2012/9/14 Petr Viktorin pvikt...@redhat.com On 09/13/2012 09:21 PM, Rob Crittenden wrote: Petr Viktorin wrote: Transifex is watching our repository, so pushing this patch will update the translations on the site. Okay, I lied. Some time ago (before I joined), Transifex changed its

Re: [Freeipa-devel] [PATCH] Patch to allow IPA to work with dogtag 10 on f18

2012-09-14 Thread Rob Crittenden
Petr Viktorin wrote: On 09/12/2012 06:40 PM, Petr Viktorin wrote: A new Dogtag build with changed pkispawn/pkidestroy locations should be out later today. The attached patch should work with that build. Fresh install is failing in F-18.

Re: [Freeipa-devel] [PATCH] Set master_kdc and dns_lookup_kdc to true

2012-09-14 Thread Rob Crittenden
Sumit Bose wrote: Hi, those two patches should fix https://fedorahosted.org/freeipa/ticket/2515 . The first makes the needed change for fresh installations. The second adds the changes during ipa-adtrust-install if needed. I prefer to do the changes here instead of during updates, because