[Freeipa-devel] [PATCH 0356] trusts: Detect missing Samba instance

2015-08-06 Thread Tomas Babej
Hi, In the event of invocation of trust related commands, IPA server needs to contact local Samba instance. This is not possible on servers that merely act as AD trust agents, since they do not have Samba instance running. Properly detect the absence of the Samba instance and output user-friendly

Re: [Freeipa-devel] [PATCH 0355] Fix incorrect type comparison in trust-fetch-domains

2015-08-06 Thread Tomas Babej
On 08/05/2015 08:24 PM, Alexander Bokovoy wrote: > On Wed, 05 Aug 2015, Tomas Babej wrote: >> Hi, >> >> Value needs to be unpacked from the list and converted before comparison. >> >> https://fedorahosted.org/freeipa/ticket/5182 > One more -- this is bug > https://bugzilla.redhat.com/show_bug.cgi

Re: [Freeipa-devel] [PATCH] 0194 Fix selector of protocol for LSA RPC binding string

2015-08-06 Thread Tomas Babej
On 08/05/2015 08:40 PM, Alexander Bokovoy wrote: > Hi, > > attached patch fixes a bug > https://bugzilla.redhat.com/show_bug.cgi?id=1249455 > > details are in the commit message. > > > Looks good to me, generates bindings strings as described in the BZ. Just a readability nitpick, can we g

[Freeipa-devel] [PATCH 0357] trusts: Detect domain clash with IPA domain when adding a AD

2015-08-06 Thread Tomas Babej
Hi, When IPA is deployed in the same domain as AD, trust-add fails since the names of the local domain and trusted domain ranges is the same - it's always DOMAIN.NAME_id_range. When adding a trusted domain, we look for previous ranges for this domain (which may have been left behind by previous t

Re: [Freeipa-devel] Time-Based Account Policies

2015-08-06 Thread Stanislav Laznicka
On 08/03/2015 04:30 PM, Alexander Bokovoy wrote: On Mon, 03 Aug 2015, Stanislav Laznicka wrote: dragons may appear, although with a tiny tiny possibility of a golden treasure in the end. Yes, I think intervals are required. Alright. I gave it a little thought considering the current state of

Re: [Freeipa-devel] [PATCH 0051] IPA server and replica installers can accept options from config file

2015-08-06 Thread Martin Babinsky
On 08/03/2015 01:56 PM, Martin Babinsky wrote: On 07/30/2015 08:55 AM, Jan Cholasta wrote: Dne 29.7.2015 v 17:43 Petr Vobornik napsal(a): On 07/29/2015 05:13 PM, Martin Babinsky wrote: On 07/29/2015 01:25 PM, Jan Cholasta wrote: Dne 29.7.2015 v 12:20 Martin Babinsky napsal(a): Initial attemp

Re: [Freeipa-devel] [PATCH] 0194 Fix selector of protocol for LSA RPC binding string

2015-08-06 Thread Alexander Bokovoy
- Original Message - > > > On 08/05/2015 08:40 PM, Alexander Bokovoy wrote: > > Hi, > > > > attached patch fixes a bug > > https://bugzilla.redhat.com/show_bug.cgi?id=1249455 > > > > details are in the commit message. > > > > > > > > Looks good to me, generates bindings strings as

Re: [Freeipa-devel] [PATCH] 0194 Fix selector of protocol for LSA RPC binding string

2015-08-06 Thread Martin Kosek
On 08/06/2015 10:37 AM, Tomas Babej wrote: > > > On 08/05/2015 08:40 PM, Alexander Bokovoy wrote: >> Hi, >> >> attached patch fixes a bug >> https://bugzilla.redhat.com/show_bug.cgi?id=1249455 >> >> details are in the commit message. >> >> >> > > Looks good to me, generates bindings strings as d

[Freeipa-devel] [PATCH 0053] fix crash when installer with no positional arguments handles invalid options

2015-08-06 Thread Martin Babinsky
This bug was discovered when writing tests for functionality introduced in my PATCH 0051. This patch should apply on top of PATCH 0051. -- Martin^3 Babinsky From 7b281ba47e4fec7da7eab4a861a7cbaceb2bd859 Mon Sep 17 00:00:00 2001 From: Martin Babinsky Date: Thu, 6 Aug 2015 14:19:52 +0200 Subject

Re: [Freeipa-devel] [PATCH 0053] fix crash when installer with no positional arguments handles invalid options

2015-08-06 Thread Jan Cholasta
Hi, Dne 6.8.2015 v 14:29 Martin Babinsky napsal(a): This bug was discovered when writing tests for functionality introduced in my PATCH 0051. This patch should apply on top of PATCH 0051. This whole patch can be reduced to: except core.KnobValueError as e: knob_cls = ge

Re: [Freeipa-devel] [PATCH 0053] fix crash when installer with no positional arguments handles invalid options

2015-08-06 Thread Martin Babinsky
On 08/06/2015 02:35 PM, Jan Cholasta wrote: Hi, Dne 6.8.2015 v 14:29 Martin Babinsky napsal(a): This bug was discovered when writing tests for functionality introduced in my PATCH 0051. This patch should apply on top of PATCH 0051. This whole patch can be reduced to: except core.K

[Freeipa-devel] [PATCH 0054] test suite for functionality implemented #4517

2015-08-06 Thread Martin Babinsky
I have slapped together a small test suite for the functionality implemented in PATCH 0051. Obviously it requires this patch to work. It also requires PATCH 0052 to pass all tests. https://fedorahosted.org/freeipa/ticket/4517 -- Martin^3 Babinsky From d09a4f1134a0e0535b1cab6989b41929f793d33c M

Re: [Freeipa-devel] [PATCHES] changes in preparation of replica promotion work

2015-08-06 Thread Simo Sorce
On Thu, 2015-08-06 at 07:21 +0200, Jan Cholasta wrote: > Dne 5.8.2015 v 17:24 Simo Sorce napsal(a): > > On Wed, 2015-08-05 at 08:20 +0200, Jan Cholasta wrote: > >> Hi, > >> > >> Dne 31.7.2015 v 12:46 Simo Sorce napsal(a): > >>> I've been carrying these patches in my tree for a while, I think it is

Re: [Freeipa-devel] Update of User Certificates design page

2015-08-06 Thread Martin Babinsky
On 08/04/2015 06:47 PM, Jan Pazdziora wrote: On Tue, Aug 04, 2015 at 05:39:01PM +0200, Martin Babinsky wrote: I am working on the update of http://www.freeipa.org/page/V4/User_Certificates design page. For now I have edited the "Feature Management" and "Howto Test" sections. Since this is my

[Freeipa-devel] Unable to install bits from ipa-4-2 branch

2015-08-06 Thread Milan Kubík
Hi list, I just noticed that the bits built from ipa-4-2 branch cannot be installed. The freeipa packages built have version such as freeipa-server-dns-4.2.0-0.20150806083844Zjenkins9git2812242.fc22.x86_64 The version check in the spec file makes the server-dns package obsolete the server packa

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-08-06 Thread Gabe Alford
Hello, Updated patch attached. - Time limit is -1 for unlimited. I found this https://www.redhat.com/archives/freeipa-devel/2011-January/msg00330.html in reference to keeping the time limit as -1 for unlimited. Sure enough, testing time limit at 0 did not work for unlimited as well as appeared to

Re: [Freeipa-devel] Unable to install bits from ipa-4-2 branch

2015-08-06 Thread Martin Kosek
On 08/06/2015 05:26 PM, Milan Kubík wrote: Hi list, I just noticed that the bits built from ipa-4-2 branch cannot be installed. The freeipa packages built have version such as freeipa-server-dns-4.2.0-0.20150806083844Zjenkins9git2812242.fc22.x86_64 The version check in the spec file makes the se

Re: [Freeipa-devel] Unable to install bits from ipa-4-2 branch

2015-08-06 Thread Jan Cholasta
Dne 7.8.2015 v 08:44 Martin Kosek napsal(a): On 08/06/2015 05:26 PM, Milan Kubík wrote: Hi list, I just noticed that the bits built from ipa-4-2 branch cannot be installed. The freeipa packages built have version such as freeipa-server-dns-4.2.0-0.20150806083844Zjenkins9git2812242.fc22.x86_64 T