Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

2015-11-02 Thread Martin Basti
On 29.10.2015 18:32, Martin Basti wrote: On 29.10.2015 18:31, Martin Basti wrote: NACK 1) DO NOT use tabs in code to indent 2) Replica uninstallation does not work, uninstallation works different with domain level 0 and 1 (currently uninstallation with domain 1 level will not work, it is

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

2015-11-02 Thread Oleg Fayans
Hi Martin, On 11/02/2015 10:39 AM, Martin Basti wrote: On 29.10.2015 18:32, Martin Basti wrote: On 29.10.2015 18:31, Martin Basti wrote: NACK 1) DO NOT use tabs in code to indent Fixed 2) Replica uninstallation does not work, uninstallation works different with domain level 0 and 1 (cu

Re: [Freeipa-devel] [PATCH 0090] show optionally configured components in server-find/show command output

2015-11-02 Thread Martin Kosek
On 11/02/2015 06:10 AM, Jan Cholasta wrote: > Hi, > > On 22.10.2015 10:44, Martin Babinsky wrote: >> https://fedorahosted.org/freeipa/ticket/5181 > > This should be handled by a separate object plugin: > > $ ipa servercomponent-find master.ipa.test > --- > 6 server compon

Re: [Freeipa-devel] [PATCH 0011, 0012, 0015] Replica promotion related changes in integration tests

2015-11-02 Thread Martin Basti
On 02.11.2015 11:54, Oleg Fayans wrote: Hi Martin, On 11/02/2015 10:39 AM, Martin Basti wrote: On 29.10.2015 18:32, Martin Basti wrote: On 29.10.2015 18:31, Martin Basti wrote: NACK 1) DO NOT use tabs in code to indent Fixed 2) Replica uninstallation does not work, uninstallation wo

Re: [Freeipa-devel] [PATCH 0090] show optionally configured components in server-find/show command output

2015-11-02 Thread Martin Babinsky
On 10/30/2015 11:53 AM, Martin Babinsky wrote: On 10/26/2015 01:41 PM, Martin Babinsky wrote: On 10/22/2015 04:13 PM, Martin Basti wrote: On 22.10.2015 10:44, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5181 Thank you for the patch. 1) +OPTIONAL_SERVICES = { +'DN

Re: [Freeipa-devel] [PATCH 0339] ipa-csreplica-manage: disable connect/disconnect/del subcommands

2015-11-02 Thread Martin Basti
On 30.10.2015 15:49, Martin Babinsky wrote: On 10/30/2015 03:47 PM, Martin Basti wrote: On 30.10.2015 14:49, Martin Babinsky wrote: On 10/30/2015 02:09 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5405 Patch attached Hi Martin, NACK since I'm not a big fan of havin

Re: [Freeipa-devel] [PATCH] 375 Added mechanism to copy vault secrets.

2015-11-02 Thread Martin Basti
On 05.10.2015 09:21, Jan Cholasta wrote: On 2.10.2015 15:23, Martin Basti wrote: On 08/27/2015 01:47 AM, Endi Sukma Dewata wrote: On 8/20/2015 2:08 AM, Endi Sukma Dewata wrote: On 8/19/2015 4:20 AM, Martin Basti wrote: On 08/16/2015 05:29 PM, Endi Sukma Dewata wrote: The vault-add and va

Re: [Freeipa-devel] [PATCH] 925 Update .po files

2015-11-02 Thread Alexander Bokovoy
On Mon, 02 Nov 2015, Petr Vobornik wrote: For 4.2.3 release https://fedorahosted.org/freeipa/ticket/5427 target branches: master, ipa-4-2 -- Petr Vobornik From 07e0ceff02932f1c8db1591be560a2b1745335d8 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Mon, 2 Nov 2015 12:24:58 +0100 Subject:

Re: [Freeipa-devel] [PATCH 0011, 0012, 0015] Replica promotion related changes in integration tests

2015-11-02 Thread Oleg Fayans
Hi Martin, On 11/02/2015 12:52 PM, Martin Basti wrote: On 02.11.2015 11:54, Oleg Fayans wrote: Hi Martin, On 11/02/2015 10:39 AM, Martin Basti wrote: On 29.10.2015 18:32, Martin Basti wrote: On 29.10.2015 18:31, Martin Basti wrote: NACK 1) DO NOT use tabs in code to indent Fixed 2

Re: [Freeipa-devel] [PATCH] 375 Added mechanism to copy vault secrets.

2015-11-02 Thread Endi Sukma Dewata
On 11/2/2015 6:38 AM, Martin Basti wrote: The vault-add and vault-archive commands have been modified to optionally retrieve a secret from a source vault, then re-archive the secret into the new/existing target vault. https://fedorahosted.org/freeipa/ticket/5223 I cannot apply this patch.

Re: [Freeipa-devel] [PATCH 0011, 0012, 0015] Replica promotion related changes in integration tests

2015-11-02 Thread Martin Basti
On 02.11.2015 14:45, Oleg Fayans wrote: Hi Martin, On 11/02/2015 12:52 PM, Martin Basti wrote: On 02.11.2015 11:54, Oleg Fayans wrote: Hi Martin, On 11/02/2015 10:39 AM, Martin Basti wrote: On 29.10.2015 18:32, Martin Basti wrote: On 29.10.2015 18:31, Martin Basti wrote: NACK 1) D

Re: [Freeipa-devel] [PATCH] 375 Added mechanism to copy vault secrets.

2015-11-02 Thread Alexander Bokovoy
On Mon, 02 Nov 2015, Endi Sukma Dewata wrote: On 11/2/2015 6:38 AM, Martin Basti wrote: The vault-add and vault-archive commands have been modified to optionally retrieve a secret from a source vault, then re-archive the secret into the new/existing target vault. https://fedorahosted.org/freeip

Re: [Freeipa-devel] [PATCH 0011, 0012, 0015] Replica promotion related changes in integration tests

2015-11-02 Thread Oleg Fayans
On 11/02/2015 03:45 PM, Martin Basti wrote: On 02.11.2015 14:45, Oleg Fayans wrote: Hi Martin, On 11/02/2015 12:52 PM, Martin Basti wrote: On 02.11.2015 11:54, Oleg Fayans wrote: Hi Martin, On 11/02/2015 10:39 AM, Martin Basti wrote: On 29.10.2015 18:32, Martin Basti wrote: On 29

[Freeipa-devel] [PATCH] 0198 depend on dogtag 10.2.6-12 for tomcat 8 upgrades

2015-11-02 Thread Alexander Bokovoy
See details in the patch. -- / Alexander Bokovoy From ee434967dfc1613bf7575a92ed66881aab663da3 Mon Sep 17 00:00:00 2001 From: Alexander Bokovoy Date: Mon, 2 Nov 2015 19:06:24 +0200 Subject: [PATCH] spec file: depend on Dogtag 10.2.6-12 for tomcat 8 upgrade Dogtag 10.2.6-12 includes automatic up

Re: [Freeipa-devel] [PATCH] 925 Update .po files

2015-11-02 Thread Alexander Bokovoy
On Mon, 02 Nov 2015, Alexander Bokovoy wrote: On Mon, 02 Nov 2015, Petr Vobornik wrote: For 4.2.3 release https://fedorahosted.org/freeipa/ticket/5427 target branches: master, ipa-4-2 -- Petr Vobornik From 07e0ceff02932f1c8db1591be560a2b1745335d8 Mon Sep 17 00:00:00 2001 From: Petr Vobornik

Re: [Freeipa-devel] [PATCH] 925 Update .po files

2015-11-02 Thread Petr Vobornik
On 11/02/2015 06:49 PM, Alexander Bokovoy wrote: On Mon, 02 Nov 2015, Alexander Bokovoy wrote: On Mon, 02 Nov 2015, Petr Vobornik wrote: For 4.2.3 release https://fedorahosted.org/freeipa/ticket/5427 target branches: master, ipa-4-2 -- Petr Vobornik From 07e0ceff02932f1c8db1591be560a2b1745

Re: [Freeipa-devel] [PATCH] 925 Update .po files

2015-11-02 Thread Martin Basti
On 02.11.2015 19:02, Petr Vobornik wrote: On 11/02/2015 06:49 PM, Alexander Bokovoy wrote: On Mon, 02 Nov 2015, Alexander Bokovoy wrote: On Mon, 02 Nov 2015, Petr Vobornik wrote: For 4.2.3 release https://fedorahosted.org/freeipa/ticket/5427 target branches: master, ipa-4-2 -- Petr Voborni

Re: [Freeipa-devel] [PATCH] 0198 depend on dogtag 10.2.6-12 for tomcat 8 upgrades

2015-11-02 Thread Petr Vobornik
On 11/02/2015 06:09 PM, Alexander Bokovoy wrote: See details in the patch. ACK Pushed to master: abf34d99d9300417a7c067926250d7fd2e0e8a4 Pushed to ipa-4-2: 0c4342ce385ddcb57fceddbfef2dd2106e587f85 -- Petr Vobornik -- Manage your subscription for the Freeipa-devel mailing list: https://www.

Re: [Freeipa-devel] [PATCH] 925 Update .po files

2015-11-02 Thread Petr Vobornik
On 11/02/2015 07:17 PM, Martin Basti wrote: On 02.11.2015 19:02, Petr Vobornik wrote: On 11/02/2015 06:49 PM, Alexander Bokovoy wrote: On Mon, 02 Nov 2015, Alexander Bokovoy wrote: On Mon, 02 Nov 2015, Petr Vobornik wrote: For 4.2.3 release https://fedorahosted.org/freeipa/ticket/5427 tar

[Freeipa-devel] [PATCH 0340 - 0341] DNSSEC restore state fixes in uninstall

2015-11-02 Thread Martin Basti
Attached patches removes the sysrestore states that has been left in sysrestore.state file after uninstall From e812fae82ad6cf0771af614c64f3266a596e6e9b Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Mon, 2 Nov 2015 18:33:05 +0100 Subject: [PATCH 1/2] Fix typo in ods-exporter uninstall to rest

[Freeipa-devel] Announcing FreeIPA 4.2.3

2015-11-02 Thread Petr Vobornik
The FreeIPA team would like to announce FreeIPA v4.2.3 bug fixing release! It can be downloaded from http://www.freeipa.org/page/Downloads. The builds are available for Fedora 23 and rawhide. Builds for Fedora 22 are available in the official COPR repository

[Freeipa-devel] [PATCH] SPEC: Drop sssd from BuildRequires

2015-11-02 Thread Lukas Slebodnik
ehlo, it happened many times that freeipa rpms could not be build in mock because there was build requirement for very new sssd. Even though it was not necessary to have new sssd among build dependencies. I've manged to build FreeIPA rpms on rawhide without sssd in build root. So it means it is n